From: Tom Hughes <tom@compton.nu>
Date: Wed, 5 Sep 2018 18:06:16 +0000 (+0100)
Subject: Merge remote-tracking branch 'upstream/pull/1974'
X-Git-Tag: live~3919
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/983e21db2e3ccc5f645f40a5f076d35e2b7897c2?hp=-c

Merge remote-tracking branch 'upstream/pull/1974'
---

983e21db2e3ccc5f645f40a5f076d35e2b7897c2
diff --combined app/views/changeset/history.html.erb
index ec3adcb02,bd8c24703..ba745cb03
--- a/app/views/changeset/history.html.erb
+++ b/app/views/changeset/history.html.erb
@@@ -5,9 -5,9 +5,9 @@@
  <% end -%>
  
  <%
-    set_title(changeset_list_title(params, current_user))
+    set_title(changeset_index_title(params, current_user))
     if params[:display_name]
-      @heading = t('changeset.list.title_user', :user => link_to(params[:display_name], user_path(:display_name => params[:display_name]))).html_safe
 -     @heading = t('changeset.index.title_user', :user => link_to(params[:display_name], :controller => "user", :action => "view", :display_name => params[:display_name])).html_safe
++     @heading = t('changeset.index.title_user', :user => link_to(params[:display_name], user_path(:display_name => params[:display_name]))).html_safe
     else
       @heading = @title
     end
diff --combined app/views/changeset/index.atom.builder
index 33b284417,b21d77728..801b9cd39
--- a/app/views/changeset/index.atom.builder
+++ b/app/views/changeset/index.atom.builder
@@@ -1,8 -1,8 +1,8 @@@
  atom_feed(:language => I18n.locale, :schema_date => 2009,
            :id => url_for(@params.merge(:only_path => false)),
-           :root_url => url_for(@params.merge(:action => :list, :format => nil, :only_path => false)),
+           :root_url => url_for(@params.merge(:action => :index, :format => nil, :only_path => false)),
            "xmlns:georss" => "http://www.georss.org/georss") do |feed|
-   feed.title changeset_list_title(params, current_user)
+   feed.title changeset_index_title(params, current_user)
  
    feed.updated @edits.map { |e| [e.created_at, e.closed_at].max }.max
    feed.icon image_url("favicon.ico")
@@@ -32,7 -32,7 +32,7 @@@
        if changeset.user.data_public?
          entry.author do |author|
            author.name changeset.user.display_name
 -          author.uri url_for(:controller => "user", :action => "view", :display_name => changeset.user.display_name, :only_path => false)
 +          author.uri user_url(changeset.user, :only_path => false)
          end
        end
  
@@@ -51,7 -51,7 +51,7 @@@
              table.tr do |tr|
                tr.th t("browse.changeset.belongs_to")
                tr.td do |td|
 -                td.a h(changeset.user.display_name), :href => url_for(:controller => "user", :action => "view", :display_name => changeset.user.display_name, :only_path => false)
 +                td.a h(changeset.user.display_name), :href => user_url(changeset.user, :only_path => false)
                end
              end
            end
diff --combined app/views/user/show.html.erb
index 0e99a2861,0b48d28d2..0b48d28d2
--- a/app/views/user/show.html.erb
+++ b/app/views/user/show.html.erb
@@@ -7,7 -7,7 +7,7 @@@
          <!-- Displaying user's own profile page to themself -->
          <ul class='secondary-actions clearfix'>
            <li>
-             <%= link_to t('.my edits'), :controller => 'changeset', :action => 'list', :display_name => current_user.display_name %>
+             <%= link_to t('.my edits'), :controller => 'changeset', :action => 'index', :display_name => current_user.display_name %>
              <span class='count-number'><%= number_with_delimiter(current_user.changesets.size) %></span>
            </li>
            <li>
@@@ -49,7 -49,7 +49,7 @@@
          <ul class='secondary-actions clearfix'>
  
            <li>
-             <%= link_to t('.edits'), :controller => 'changeset', :action => 'list', :display_name => @user.display_name %>
+             <%= link_to t('.edits'), :controller => 'changeset', :action => 'index', :display_name => @user.display_name %>
              <span class='count-number'><%= number_with_delimiter(@user.changesets.size) %></span>
            </li>
            <li>
diff --combined config/locales/en.yml
index 872a31f6d,92de08483..7682204d5
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@@ -228,7 -228,7 +228,7 @@@ en
        user: "User"
        comment: "Comment"
        area: "Area"
-     list:
+     index:
        title: "Changesets"
        title_user: "Changesets by %{user}"
        title_friend: "Changesets by my friends"
@@@ -276,7 -276,7 +276,7 @@@
        use_map_link: "use map"
        save_button: "Save"
        marker_text: Diary entry location
 -    view:
 +    show:
        title: "%{user}'s diary | %{title}"
        user_title: "%{user}'s diary"
        leave_a_comment: "Leave a comment"
@@@ -2006,7 -2006,7 +2006,7 @@@
        heading: "The user %{user} does not exist"
        body: "Sorry, there is no user with the name %{user}. Please check your spelling, or maybe the link you clicked is wrong."
        deleted: "deleted"
 -    view:
 +    show:
        my diary: My Diary
        new diary entry: new diary entry
        my edits: My Edits
diff --combined config/routes.rb
index 579dced16,c0b004455..da7e0de71
--- a/config/routes.rb
+++ b/config/routes.rb
@@@ -119,11 -119,11 +119,11 @@@ OpenStreetMap::Application.routes.draw 
    get "/changeset/:id/comments/feed" => "changeset#comments_feed", :as => :changeset_comments_feed, :id => /\d*/, :defaults => { :format => "rss" }
    get "/note/:id" => "browse#note", :id => /\d+/, :as => "browse_note"
    get "/note/new" => "browse#new_note"
-   get "/user/:display_name/history" => "changeset#list"
+   get "/user/:display_name/history" => "changeset#index"
    get "/user/:display_name/history/feed" => "changeset#feed", :defaults => { :format => :atom }
    get "/user/:display_name/notes" => "notes#mine"
-   get "/history/friends" => "changeset#list", :friends => true, :as => "friend_changesets", :defaults => { :format => :html }
-   get "/history/nearby" => "changeset#list", :nearby => true, :as => "nearby_changesets", :defaults => { :format => :html }
+   get "/history/friends" => "changeset#index", :friends => true, :as => "friend_changesets", :defaults => { :format => :html }
+   get "/history/nearby" => "changeset#index", :nearby => true, :as => "nearby_changesets", :defaults => { :format => :html }
  
    get "/browse/way/:id",                :to => redirect(:path => "/way/%{id}")
    get "/browse/way/:id/history",        :to => redirect(:path => "/way/%{id}/history")
@@@ -150,7 -150,7 +150,7 @@@
    get "/fixthemap" => "site#fixthemap"
    get "/help" => "site#help"
    get "/about" => "site#about"
-   get "/history" => "changeset#list"
+   get "/history" => "changeset#index"
    get "/history/feed" => "changeset#feed", :defaults => { :format => :atom }
    get "/history/comments/feed" => "changeset#comments_feed", :as => :changesets_comments_feed, :defaults => { :format => "rss" }
    get "/export" => "site#export"
@@@ -208,8 -208,10 +208,8 @@@
    get "/traces/mine/tag/:tag" => "traces#mine"
    get "/traces/mine/page/:page" => "traces#mine"
    get "/traces/mine" => "traces#mine"
 -  post "/trace/create" => "traces#create" # remove after deployment
    get "/trace/create", :to => redirect(:path => "/traces/new")
    get "/trace/:id/data" => "traces#data", :id => /\d+/, :as => "trace_data"
 -  post "trace/:id/edit" => "traces#update" # remove after deployment
    get "/trace/:id/edit", :to => redirect(:path => "/traces/%{id}/edit")
    post "/trace/:id/delete" => "traces#delete", :id => /\d+/
  
@@@ -225,7 -227,7 +225,7 @@@
    get "/user/:display_name/diary" => "diary_entry#list"
    get "/diary/:language" => "diary_entry#list"
    get "/diary" => "diary_entry#list"
 -  get "/user/:display_name/diary/:id" => "diary_entry#view", :id => /\d+/, :as => :diary_entry
 +  get "/user/:display_name/diary/:id" => "diary_entry#show", :id => /\d+/, :as => :diary_entry
    post "/user/:display_name/diary/:id/newcomment" => "diary_entry#comment", :id => /\d+/
    match "/user/:display_name/diary/:id/edit" => "diary_entry#edit", :via => [:get, :post], :id => /\d+/
    post "/user/:display_name/diary/:id/hide" => "diary_entry#hide", :id => /\d+/, :as => :hide_diary_entry
@@@ -234,7 -236,7 +234,7 @@@
    post "/user/:display_name/diary/:id/unsubscribe" => "diary_entry#unsubscribe", :as => :diary_entry_unsubscribe, :id => /\d+/
  
    # user pages
 -  get "/user/:display_name" => "user#view", :as => "user"
 +  get "/user/:display_name" => "user#show", :as => "user"
    match "/user/:display_name/make_friend" => "user#make_friend", :via => [:get, :post], :as => "make_friend"
    match "/user/:display_name/remove_friend" => "user#remove_friend", :via => [:get, :post], :as => "remove_friend"
    match "/user/:display_name/account" => "user#account", :via => [:get, :post]