From: Anton Khorev <tony29@yandex.ru>
Date: Wed, 10 Jul 2024 10:18:32 +0000 (+0300)
Subject: Remove alt text of OpenID logo inside input label
X-Git-Tag: live~409^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/9a9cf59adc0cd94a65ed4c3de0190cbef06afe44?ds=sidebyside

Remove alt text of OpenID logo inside input label

This keeps the input focusing when the logo is clicked but the alt text is not read by screen readers.
---

diff --git a/app/views/application/_auth_providers.html.erb b/app/views/application/_auth_providers.html.erb
index 4b487cc5d..1455a46c5 100644
--- a/app/views/application/_auth_providers.html.erb
+++ b/app/views/application/_auth_providers.html.erb
@@ -47,7 +47,7 @@
   <%= form_tag(auth_path(:provider => "openid"), :id => "openid_login_form") do %>
     <div id="login_openid_url" class="mb-3">
       <label for="openid_url" class="form-label">
-        <%= image_tag "openid.svg", :size => "36", :alt => t(".openid_logo_alt"), :class => "align-text-bottom" %>
+        <%= image_tag "openid.svg", :size => "36", :alt => "", :class => "align-text-bottom" %>
         <%= t ".openid_url" %>
       </label>
       <%= hidden_field_tag("referer", params[:referer], :autocomplete => "off") %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 2eaee052e..c5978b5d7 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2583,7 +2583,6 @@ en:
       oauth2_authorizations: OAuth 2 authorizations
       muted_users: Muted Users
     auth_providers:
-      openid_logo_alt: "Log in with an OpenID"
       openid_url: "OpenID URL"
       openid_login_button: "Continue"
       openid: