From: Tom Hughes <tom@compton.nu>
Date: Fri, 25 Jul 2014 15:40:53 +0000 (+0100)
Subject: Modernise statistics script to work with rails 4.1
X-Git-Tag: live~4892
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/ace29736c7df752c5a0ee2dd82f29b233d9a9e9c?ds=sidebyside

Modernise statistics script to work with rails 4.1
---

diff --git a/script/statistics b/script/statistics
index c201f6c57..315c6cd18 100755
--- a/script/statistics
+++ b/script/statistics
@@ -33,7 +33,7 @@ begin
     puts "<table>"
     puts "<tr><th>User</th><th>Number of Points</th></tr>"
 
-    Trace.sum(:size, :conditions => { :inserted => true }, :group => :user_id, :order => "sum_size DESC", :limit => 50).each do |user, count|
+    Trace.where(:inserted => true).group(:user_id).order("sum_size DESC").limit(50).sum(:size).each do |user, count|
       display_name = User.find(user).display_name.gsub('@', ' at ').gsub('.', ' dot ')
       puts "<tr><td><a href=\"/user/#{display_name}\">#{display_name}</a></td><td>#{count}</td></tr>"
     end
@@ -44,21 +44,15 @@ begin
     puts "<table>"
     puts "<tr><th>Data Type</th><th>Day</th><th>Week</th><th>Month</th></tr>"
 
-    day_count = Trace.count(:user_id, :distinct => true, 
-                            :conditions => "timestamp > NOW() - '1 DAY'::INTERVAL")
-    week_count = Trace.count(:user_id, :distinct => true, 
-                             :conditions => "timestamp > NOW() - '7 DAYS'::INTERVAL")
-    month_count = Trace.count(:user_id, :distinct => true, 
-                              :conditions => "timestamp > NOW() - '28 DAYS'::INTERVAL")
+    day_count = Trace.where("timestamp > NOW() - '1 DAY'::INTERVAL").distinct.count(:user_id)
+    week_count = Trace.where("timestamp > NOW() - '7 DAYS'::INTERVAL").distinct.count(:user_id)
+    month_count = Trace.where("timestamp > NOW() - '28 DAYS'::INTERVAL").distinct.count(:user_id)
 
     puts "<tr><th>GPX Files</th><td>#{day_count}</td><td>#{week_count}</td><td>#{month_count}</td></tr>"
 
-    day_count = OldNode.count(:user_id, :distinct => true, :joins => :changeset,
-                              :conditions => "timestamp > NOW() - '1 DAY'::INTERVAL")
-    week_count = OldNode.count(:user_id, :distinct => true,  :joins => :changeset,
-                               :conditions => "timestamp > NOW() - '7 DAYS'::INTERVAL")
-    month_count = OldNode.count(:user_id, :distinct => true, :joins => :changeset,
-                                :conditions => "timestamp > NOW() - '28 DAYS'::INTERVAL")
+    day_count = OldNode.where("timestamp > NOW() - '1 DAY'::INTERVAL").joins(:changeset).distinct.count(:user_id)
+    week_count = OldNode.where("timestamp > NOW() - '7 DAYS'::INTERVAL").joins(:changeset).distinct.count(:user_id)
+    month_count = OldNode.where("timestamp > NOW() - '28 DAYS'::INTERVAL").joins(:changeset).distinct.count(:user_id)
 
     puts "<tr><th>Nodes</th><td>#{day_count}</td><td>#{week_count}</td><td>#{month_count}</td></tr>"
 
@@ -68,15 +62,9 @@ begin
     puts "<table>"
     puts "<tr><th>Day</th><th>Week</th><th>Month</th></tr>"
 
-    day_users = OldNode.count(:conditions => "timestamp > NOW() - '1 DAY'::INTERVAL",
-                              :joins => :changeset, :group => :user_id,
-                              :order => "count_all DESC")
-    week_users = OldNode.count(:conditions => "timestamp > NOW() - '7 DAYS'::INTERVAL",
-                               :joins => :changeset, :group => :user_id,
-                               :order => "count_all DESC", :limit => 60)
-    month_users = OldNode.count(:conditions => "timestamp > NOW() - '28 DAYS'::INTERVAL",
-                                :joins => :changeset, :group => :user_id,
-                                :order => "count_all DESC", :limit => 60)
+    day_users = OldNode.where("timestamp > NOW() - '1 DAY'::INTERVAL").joins(:changeset).order("count_all DESC").limit(50).group(:user_id).count
+    week_users = OldNode.where("timestamp > NOW() - '7 DAYS'::INTERVAL").joins(:changeset).order("count_all DESC").limit(50).group(:user_id).count
+    month_users = OldNode.where("timestamp > NOW() - '28 DAYS'::INTERVAL").joins(:changeset).order("count_all DESC").limit(50).group(:user_id).count
 
     day_users.zip(week_users, month_users).each do |row|
       puts "<tr>"