From: Anton Khorev <tony29@yandex.ru>
Date: Sat, 1 Feb 2025 17:19:00 +0000 (+0300)
Subject: Use filter instead of loop in visible node/way collections
X-Git-Tag: live~66^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/b9f1e311229e89a6cc2718a87cc9cbe3db2ca9e5

Use filter instead of loop in visible node/way collections
---

diff --git a/app/controllers/api/maps_controller.rb b/app/controllers/api/maps_controller.rb
index c37ba2a3e..9ba95c255 100644
--- a/app/controllers/api/maps_controller.rb
+++ b/app/controllers/api/maps_controller.rb
@@ -57,15 +57,9 @@ module Api
 
       nodes += Node.includes(:node_tags).find(nodes_to_fetch) unless nodes_to_fetch.empty?
 
-      @nodes = []
-      nodes.each do |node|
-        @nodes << node if node.visible?
-      end
+      @nodes = nodes.filter(&:visible?)
 
-      @ways = []
-      ways.each do |way|
-        @ways << way if way.visible?
-      end
+      @ways = ways.filter(&:visible?)
 
       @relations = Relation.nodes(@nodes).visible +
                    Relation.ways(@ways).visible