From: Tom Hughes <tom@compton.nu>
Date: Wed, 6 Jun 2018 13:51:30 +0000 (+0100)
Subject: Merge remote-tracking branch 'upstream/pull/1892'
X-Git-Tag: live~4023
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/ba9a00b10cc8a075a5a4090a1601e3d3b72b2ec1?ds=sidebyside;hp=-c

Merge remote-tracking branch 'upstream/pull/1892'
---

ba9a00b10cc8a075a5a4090a1601e3d3b72b2ec1
diff --combined .rubocop_todo.yml
index 83f60d4f8,2f6ea0087..362cfcb32
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@@ -67,7 -67,7 +67,7 @@@ Metrics/AbcSize
  # Offense count: 41
  # Configuration parameters: CountComments, ExcludedMethods.
  Metrics/BlockLength:
-   Max: 245
 -  Max: 241
++  Max: 247
  
  # Offense count: 12
  # Configuration parameters: CountBlocks.
diff --combined config/routes.rb
index c57668920,9ab3f57da..741268e46
--- a/config/routes.rb
+++ b/config/routes.rb
@@@ -207,7 -207,9 +207,9 @@@ OpenStreetMap::Application.routes.draw 
    get "/traces/mine/tag/:tag" => "traces#mine"
    get "/traces/mine/page/:page" => "traces#mine"
    get "/traces/mine" => "traces#mine"
-   match "/trace/create" => "traces#create", :via => [:get, :post]
+   resources :traces, :only => [:new, :create]
+   post "/trace/create" => "traces#create" # remove after deployment
+   get "/trace/create", :to => redirect(:path => "/traces/new")
    get "/trace/:id/data" => "traces#data", :id => /\d+/, :as => "trace_data"
    match "/trace/:id/edit" => "traces#edit", :via => [:get, :post], :id => /\d+/, :as => "trace_edit"
    post "/trace/:id/delete" => "traces#delete", :id => /\d+/
@@@ -261,16 -263,10 +263,16 @@@
    get "/export/embed" => "export#embed"
  
    # messages
 -  get "/user/:display_name/inbox" => "messages#inbox", :as => "inbox"
 -  get "/user/:display_name/outbox" => "messages#outbox", :as => "outbox"
 +  resources :messages, :only => [:show] do
 +    collection do
 +      get :inbox
 +      get :outbox
 +    end
 +  end
 +  get "/user/:display_name/inbox", :to => redirect(:path => "/messages/inbox")
 +  get "/user/:display_name/outbox", :to => redirect(:path => "/messages/outbox")
    match "/message/new/:display_name" => "messages#new", :via => [:get, :post], :as => "new_message"
 -  get "/message/read/:message_id" => "messages#show", :as => "message"
 +  get "/message/read/:message_id", :to => redirect(:path => "/messages/%{message_id}")
    post "/message/mark/:message_id" => "messages#mark", :as => "mark_message"
    match "/message/reply/:message_id" => "messages#reply", :via => [:get, :post], :as => "reply_message"
    post "/message/delete/:message_id" => "messages#destroy", :as => "destroy_message"