From: Tom Hughes Date: Wed, 5 Aug 2020 20:50:08 +0000 (+0100) Subject: Merge remote-tracking branch 'upstream/pull/2667' X-Git-Tag: live~2633 X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/c24c2e481cc6d27e76274ed4e32668a4690a7788?hp=-c Merge remote-tracking branch 'upstream/pull/2667' --- c24c2e481cc6d27e76274ed4e32668a4690a7788 diff --combined Gemfile index 540f61634,9df88f8fa..cfe734b94 --- a/Gemfile +++ b/Gemfile @@@ -1,7 -1,7 +1,7 @@@ source "https://rubygems.org" # Require rails -gem "rails", "6.0.3.1" +gem "rails", "6.0.3.2" # Require things which have moved to gems in ruby 1.9 gem "bigdecimal", "~> 1.1.0", :platforms => :ruby_19 @@@ -43,18 -43,19 +43,19 @@@ gem "image_optim_rails gem "actionpack-page_caching", ">= 1.2.0" gem "active_record_union" gem "activerecord-import" -gem "bootstrap", "~> 4.3.1" +gem "bootstrap", "~> 4.5.0" + gem "bootstrap_form", "~> 4.0" gem "cancancan" gem "composite_primary_keys", "~> 12.0.0" gem "config" gem "delayed_job_active_record" gem "dynamic_form" -gem "http_accept_language", "~> 2.0.0" +gem "http_accept_language", "~> 2.1.1" gem "i18n-js", ">= 3.0.0" gem "oauth-plugin", ">= 0.5.1" gem "openstreetmap-deadlock_retry", ">= 1.3.0", :require => "deadlock_retry" gem "rack-cors" -gem "rails-i18n", "~> 4.0.0" +gem "rails-i18n", "~> 6.0.0" gem "rinku", ">= 2.0.6", :require => "rails_rinku" gem "strong_migrations" gem "validates_email_format_of", ">= 1.5.1" @@@ -138,13 -139,12 +139,13 @@@ en # Gems needed for running tests group :test do + gem "brakeman" gem "capybara", ">= 2.15" gem "coveralls", :require => false gem "erb_lint", :require => false gem "factory_bot_rails" gem "minitest", "~> 5.1" - gem "puma", "~> 3.11" + gem "puma", "~> 4.3" gem "rails-controller-testing" gem "rubocop" gem "rubocop-minitest" diff --combined Gemfile.lock index 379bab307,0aa9545a2..3b3ffaf06 --- a/Gemfile.lock +++ b/Gemfile.lock @@@ -2,64 -2,64 +2,64 @@@ GE remote: https://rubygems.org/ specs: SystemTimer (1.2.3) - aasm (5.0.8) + aasm (5.1.0) concurrent-ruby (~> 1.0) - actioncable (6.0.3.1) - actionpack (= 6.0.3.1) + actioncable (6.0.3.2) + actionpack (= 6.0.3.2) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailbox (6.0.3.1) - actionpack (= 6.0.3.1) - activejob (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + actionmailbox (6.0.3.2) + actionpack (= 6.0.3.2) + activejob (= 6.0.3.2) + activerecord (= 6.0.3.2) + activestorage (= 6.0.3.2) + activesupport (= 6.0.3.2) mail (>= 2.7.1) - actionmailer (6.0.3.1) - actionpack (= 6.0.3.1) - actionview (= 6.0.3.1) - activejob (= 6.0.3.1) + actionmailer (6.0.3.2) + actionpack (= 6.0.3.2) + actionview (= 6.0.3.2) + activejob (= 6.0.3.2) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (6.0.3.1) - actionview (= 6.0.3.1) - activesupport (= 6.0.3.1) + actionpack (6.0.3.2) + actionview (= 6.0.3.2) + activesupport (= 6.0.3.2) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.2.0) - actionpack-page_caching (1.2.2) + actionpack-page_caching (1.2.3) actionpack (>= 5.0.0) - actiontext (6.0.3.1) - actionpack (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + actiontext (6.0.3.2) + actionpack (= 6.0.3.2) + activerecord (= 6.0.3.2) + activestorage (= 6.0.3.2) + activesupport (= 6.0.3.2) nokogiri (>= 1.8.5) - actionview (6.0.3.1) - activesupport (= 6.0.3.1) + actionview (6.0.3.2) + activesupport (= 6.0.3.2) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.1, >= 1.2.0) active_record_union (1.3.0) activerecord (>= 4.0) - activejob (6.0.3.1) - activesupport (= 6.0.3.1) + activejob (6.0.3.2) + activesupport (= 6.0.3.2) globalid (>= 0.3.6) - activemodel (6.0.3.1) - activesupport (= 6.0.3.1) - activerecord (6.0.3.1) - activemodel (= 6.0.3.1) - activesupport (= 6.0.3.1) - activerecord-import (1.0.5) + activemodel (6.0.3.2) + activesupport (= 6.0.3.2) + activerecord (6.0.3.2) + activemodel (= 6.0.3.2) + activesupport (= 6.0.3.2) + activerecord-import (1.0.6) activerecord (>= 3.2) - activestorage (6.0.3.1) - actionpack (= 6.0.3.1) - activejob (= 6.0.3.1) - activerecord (= 6.0.3.1) + activestorage (6.0.3.2) + actionpack (= 6.0.3.2) + activejob (= 6.0.3.2) + activerecord (= 6.0.3.2) marcel (~> 0.3.1) - activesupport (6.0.3.1) + activesupport (6.0.3.2) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@@ -70,25 -70,25 +70,25 @@@ annotate (3.1.1) activerecord (>= 3.2, < 7.0) rake (>= 10.4, < 14.0) - ast (2.4.0) - autoprefixer-rails (9.7.6) + ast (2.4.1) + autoprefixer-rails (9.8.6.1) execjs aws-eventstream (1.1.0) - aws-partitions (1.326.0) - aws-sdk-core (3.98.0) + aws-partitions (1.343.0) + aws-sdk-core (3.104.1) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.239.0) aws-sigv4 (~> 1.1) jmespath (~> 1.0) - aws-sdk-kms (1.33.0) - aws-sdk-core (~> 3, >= 3.71.0) + aws-sdk-kms (1.36.0) + aws-sdk-core (~> 3, >= 3.99.0) aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.67.1) - aws-sdk-core (~> 3, >= 3.96.1) + aws-sdk-s3 (1.75.0) + aws-sdk-core (~> 3, >= 3.104.1) aws-sdk-kms (~> 1) aws-sigv4 (~> 1.1) - aws-sigv4 (1.1.4) - aws-eventstream (~> 1.0, >= 1.0.2) + aws-sigv4 (1.2.1) + aws-eventstream (~> 1, >= 1.0.2) better_errors (2.7.1) coderay (>= 1.0.0) erubi (>= 1.0.0) @@@ -104,13 -104,15 +104,16 @@@ bigdecimal (1.1.0) binding_of_caller (0.8.0) debug_inspector (>= 0.0.1) - bootsnap (1.4.6) + bootsnap (1.4.7) msgpack (~> 1.0) - bootstrap (4.3.1) + bootstrap (4.5.0) autoprefixer-rails (>= 9.1.0) popper_js (>= 1.14.3, < 2) sassc-rails (>= 2.0.0) + bootstrap_form (4.5.0) + actionpack (>= 5.2) + activemodel (>= 5.2) + brakeman (4.9.0) browser (4.2.0) builder (3.2.4) bzip2-ffi (1.0.0) @@@ -118,7 -120,7 +121,7 @@@ cancancan (3.1.0) canonical-rails (0.2.8) rails (>= 4.1, < 6.1) - capybara (3.32.2) + capybara (3.33.0) addressable mini_mime (>= 0.1.3) nokogiri (~> 1.8) @@@ -152,7 -154,7 +155,7 @@@ activerecord (>= 3.0, < 6.1) delayed_job (>= 3.0, < 5) docile (1.3.2) - dry-configurable (0.11.5) + dry-configurable (0.11.6) concurrent-ruby (~> 1.0) dry-core (~> 0.4, >= 0.4.7) dry-equalizer (~> 0.2) @@@ -168,7 -170,7 +171,7 @@@ concurrent-ruby (~> 1.0) dry-core (~> 0.2) dry-equalizer (~> 0.2) - dry-schema (1.5.1) + dry-schema (1.5.2) concurrent-ruby (~> 1.0) dry-configurable (~> 0.8, >= 0.8.3) dry-core (~> 0.4) @@@ -183,7 -185,7 +186,7 @@@ dry-equalizer (~> 0.3) dry-inflector (~> 0.1, >= 0.1.2) dry-logic (~> 1.0, >= 1.0.2) - dry-validation (1.5.0) + dry-validation (1.5.1) concurrent-ruby (~> 1.0) dry-container (~> 0.7, >= 0.7.1) dry-core (~> 0.4) @@@ -191,7 -193,7 +194,7 @@@ dry-initializer (~> 3.0) dry-schema (~> 1.5) dynamic_form (1.1.4) - erb_lint (0.0.33) + erb_lint (0.0.34) activesupport better_html (~> 1.0.7) html_tokenizer @@@ -201,15 -203,15 +204,15 @@@ erubi (1.9.0) execjs (2.7.0) exifr (1.3.6) - factory_bot (5.2.0) - activesupport (>= 4.2.0) - factory_bot_rails (5.2.0) - factory_bot (~> 5.2.0) - railties (>= 4.2.0) + factory_bot (6.1.0) + activesupport (>= 5.0.0) + factory_bot_rails (6.1.0) + factory_bot (~> 6.1.0) + railties (>= 5.0.0) faraday (1.0.1) multipart-post (>= 1.2, < 3) - ffi (1.13.0) - ffi-libarchive (1.0.0) + ffi (1.13.1) + ffi-libarchive (1.0.3) ffi (~> 1.0) fspath (3.1.2) gd2-ffij (0.4.0) @@@ -220,10 -222,10 +223,10 @@@ hashie (4.1.0) html_tokenizer (0.0.7) htmlentities (4.3.4) - http_accept_language (2.0.5) - i18n (0.9.5) + http_accept_language (2.1.1) + i18n (1.8.5) concurrent-ruby (~> 1.0) - i18n-js (3.7.0) + i18n-js (3.7.1) i18n (>= 0.6.6) image_optim (0.26.5) exifr (~> 1.2, >= 1.2.2) @@@ -244,10 -246,10 +247,10 @@@ rails-dom-testing (>= 1, < 3) railties (>= 4.2.0) thor (>= 0.14, < 2.0) - json (2.3.0) + json (2.3.1) jwt (2.2.1) kgio (2.11.3) - kramdown (2.2.1) + kramdown (2.3.0) rexml libxml-ruby (3.2.0) listen (3.2.1) @@@ -258,7 -260,7 +261,7 @@@ activesupport (>= 4.0) logstash-event (~> 1.2.0) request_store - loofah (2.5.0) + loofah (2.6.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) mail (2.7.1) @@@ -277,7 -279,7 +280,7 @@@ multi_xml (0.6.0) multipart-post (2.1.1) nio4r (2.5.2) - nokogiri (1.10.9) + nokogiri (1.10.10) mini_portile2 (~> 2.4.0) nokogumbo (2.0.2) nokogiri (~> 1.8, >= 1.8.4) @@@ -321,19 -323,18 +324,19 @@@ multi_json (~> 1.12) omniauth-oauth2 (~> 1.4) openstreetmap-deadlock_retry (1.3.0) - parallel (1.19.1) - parser (2.7.1.3) - ast (~> 2.4.0) + parallel (1.19.2) + parser (2.7.1.4) + ast (~> 2.4.1) pg (1.2.3) popper_js (1.16.0) progress (3.5.2) psych (3.1.0) public_suffix (4.0.5) - puma (3.12.6) + puma (4.3.5) + nio4r (~> 2.0) quad_tile (1.0.1) r2 (0.2.7) - rack (2.2.2) + rack (2.2.3) rack-cors (1.1.1) rack (>= 2.0.0) rack-openid (1.3.1) @@@ -342,36 -343,36 +345,36 @@@ rack-test (1.1.0) rack (>= 1.0, < 3) rack-uri_sanitizer (0.0.2) - rails (6.0.3.1) - actioncable (= 6.0.3.1) - actionmailbox (= 6.0.3.1) - actionmailer (= 6.0.3.1) - actionpack (= 6.0.3.1) - actiontext (= 6.0.3.1) - actionview (= 6.0.3.1) - activejob (= 6.0.3.1) - activemodel (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + rails (6.0.3.2) + actioncable (= 6.0.3.2) + actionmailbox (= 6.0.3.2) + actionmailer (= 6.0.3.2) + actionpack (= 6.0.3.2) + actiontext (= 6.0.3.2) + actionview (= 6.0.3.2) + activejob (= 6.0.3.2) + activemodel (= 6.0.3.2) + activerecord (= 6.0.3.2) + activestorage (= 6.0.3.2) + activesupport (= 6.0.3.2) bundler (>= 1.3.0) - railties (= 6.0.3.1) + railties (= 6.0.3.2) sprockets-rails (>= 2.0.0) - rails-controller-testing (1.0.4) - actionpack (>= 5.0.1.x) - actionview (>= 5.0.1.x) - activesupport (>= 5.0.1.x) + rails-controller-testing (1.0.5) + actionpack (>= 5.0.1.rc1) + actionview (>= 5.0.1.rc1) + activesupport (>= 5.0.1.rc1) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) rails-html-sanitizer (1.3.0) loofah (~> 2.3) - rails-i18n (4.0.2) - i18n (~> 0.6) - rails (>= 4.0) - railties (6.0.3.1) - actionpack (= 6.0.3.1) - activesupport (= 6.0.3.1) + rails-i18n (6.0.0) + i18n (>= 0.7, < 2) + railties (>= 6.0.0, < 7) + railties (6.0.3.2) + actionpack (= 6.0.3.2) + activesupport (= 6.0.3.2) method_source rake (>= 0.8.7) thor (>= 0.20.3, < 2.0) @@@ -385,31 -386,32 +388,31 @@@ rack (>= 1.4) rexml (3.2.4) rinku (2.0.6) - rotp (6.0.0) - addressable (~> 2.7) - rubocop (0.85.1) + rotp (6.1.0) + rubocop (0.86.0) parallel (~> 1.10) parser (>= 2.7.0.1) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.7) rexml - rubocop-ast (>= 0.0.3) + rubocop-ast (>= 0.0.3, < 1.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 2.0) - rubocop-ast (0.0.3) + rubocop-ast (0.2.0) parser (>= 2.7.0.1) rubocop-minitest (0.9.0) rubocop (>= 0.74) - rubocop-performance (1.6.1) - rubocop (>= 0.71.0) - rubocop-rails (2.5.2) - activesupport + rubocop-performance (1.7.1) + rubocop (>= 0.82.0) + rubocop-rails (2.6.0) + activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 0.72.0) + rubocop (>= 0.82.0) ruby-openid (2.9.2) ruby-progressbar (1.10.1) rubyzip (2.3.0) safe_yaml (1.0.5) - sanitize (5.2.0) + sanitize (5.2.1) crass (~> 1.0.2) nokogiri (>= 1.8.0) nokogumbo (~> 2.0) @@@ -421,7 -423,7 +424,7 @@@ sprockets (> 3.0) sprockets-rails tilt - secure_headers (6.3.0) + secure_headers (6.3.1) selenium-webdriver (3.142.7) childprocess (>= 0.5, < 4.0) rubyzip (>= 1.2.2) @@@ -438,7 -440,7 +441,7 @@@ actionpack (>= 4.0) activesupport (>= 4.0) sprockets (>= 3.0.0) - strong_migrations (0.6.8) + strong_migrations (0.7.1) activerecord (>= 5) sync (0.5.0) term-ansicolor (1.7.1) @@@ -465,7 -467,7 +468,7 @@@ websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) - zeitwerk (2.3.0) + zeitwerk (2.4.0) PLATFORMS ruby @@@ -483,8 -485,8 +486,9 @@@ DEPENDENCIE bigdecimal (~> 1.1.0) binding_of_caller bootsnap (>= 1.4.2) - bootstrap (~> 4.3.1) + bootstrap (~> 4.5.0) + bootstrap_form (~> 4.0) + brakeman browser bzip2-ffi cancancan @@@ -502,7 -504,7 +506,7 @@@ ffi-libarchive gd2-ffij (>= 0.4.0) htmlentities - http_accept_language (~> 2.0.0) + http_accept_language (~> 2.1.1) i18n-js (>= 3.0.0) image_optim_rails jbuilder (~> 2.7) @@@ -528,14 -530,14 +532,14 @@@ openstreetmap-deadlock_retry (>= 1.3.0) pg psych - puma (~> 3.11) + puma (~> 4.3) quad_tile (~> 1.0.1) r2 (~> 0.2.7) rack-cors rack-uri_sanitizer - rails (= 6.0.3.1) + rails (= 6.0.3.2) rails-controller-testing - rails-i18n (~> 4.0.0) + rails-i18n (~> 6.0.0) rinku (>= 2.0.6) rotp rubocop @@@ -553,4 -555,4 +557,4 @@@ webmock BUNDLED WITH - 1.17.2 + 2.1.4 diff --combined app/assets/javascripts/application.js index 36b560fde,d861cbb33..205ad8161 --- a/app/assets/javascripts/application.js +++ b/app/assets/javascripts/application.js @@@ -16,6 -16,8 +16,8 @@@ //= require piwik //= require richtext //= require querystring + //= require bs-custom-file-input + //= require bs-custom-file-input-init /* * Called as the user scrolls/zooms around to manipulate hrefs of the @@@ -81,11 -83,11 +83,11 @@@ $(document).ready(function () var windowWidth = $(window).width(); if (windowWidth < compactWidth) { - $("body").removeClass("compact").addClass("small"); + $("body").removeClass("compact-nav").addClass("small-nav"); } else if (windowWidth < headerWidth) { - $("body").addClass("compact").removeClass("small"); + $("body").addClass("compact-nav").removeClass("small-nav"); } else { - $("body").removeClass("compact").removeClass("small"); + $("body").removeClass("compact-nav").removeClass("small-nav"); } } @@@ -100,13 -102,13 +102,13 @@@ headerWidth = headerWidth + $(e).outerWidth(); }); - $("body").addClass("compact"); + $("body").addClass("compact-nav"); $("header").children(":visible").each(function (i, e) { compactWidth = compactWidth + $(e).outerWidth(); }); - $("body").removeClass("compact"); + $("body").removeClass("compact-nav"); updateHeader(); diff --combined app/assets/javascripts/leaflet.layers.js index ddcce195d,102b02460..f375dc08f --- a/app/assets/javascripts/leaflet.layers.js +++ b/app/assets/javascripts/leaflet.layers.js @@@ -116,10 -116,10 +116,10 @@@ L.OSM.layers = function (options) $("

") .text(I18n.t("javascripts.map.layers.overlays")) - .attr("class", "deemphasize") + .attr("class", "text-muted") .appendTo(overlaySection); - var overlays = $("