From: Tom Hughes <tom@compton.nu>
Date: Thu, 6 Feb 2025 17:08:44 +0000 (+0000)
Subject: Correct test for notes opened by inactive users
X-Git-Tag: live~146^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/cb51f46a4ff913985d535afed0fd8d7d1d955126?ds=sidebyside

Correct test for notes opened by inactive users
---

diff --git a/app/controllers/notes_controller.rb b/app/controllers/notes_controller.rb
index 574c9b8b7..5d817c9c6 100644
--- a/app/controllers/notes_controller.rb
+++ b/app/controllers/notes_controller.rb
@@ -43,7 +43,7 @@ class NotesController < ApplicationController
 
     @note_includes_anonymous = @note.author.nil? || @note_comments.find { |comment| comment.author.nil? }
 
-    @note_comments = @note_comments.drop(1) unless !@note.author.nil? && @note.author.status == "deleted"
+    @note_comments = @note_comments.drop(1) if @note.author.nil? || @note.author.active?
   rescue ActiveRecord::RecordNotFound
     render :template => "browse/not_found", :status => :not_found
   end