From: Tom Hughes <tom@compton.nu>
Date: Wed, 29 Aug 2012 13:08:18 +0000 (+0100)
Subject: Improve handling of sidebar close link
X-Git-Tag: live~5946
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/ce054eed227c9f01d8278b80fcbd7e8fcca04355?ds=sidebyside

Improve handling of sidebar close link
---

diff --git a/app/views/site/_sidebar.html.erb b/app/views/site/_sidebar.html.erb
index 3b1b547b6..481f89795 100644
--- a/app/views/site/_sidebar.html.erb
+++ b/app/views/site/_sidebar.html.erb
@@ -2,7 +2,7 @@
   <table class="sidebar_title" width="100%">
     <tr>
       <td id="sidebar_title"><% t 'site.sidebar.search_results' %></td>
-      <td id="sidebar_close"><a href="javascript:closeSidebar()"><%= t 'site.sidebar.close' %></a></td>
+      <td id="sidebar_close"><a class="sidebar_close" href="#"><%= t 'site.sidebar.close' %></a></td>
     </tr>
   </table>
   <div id="sidebar_content">
@@ -33,7 +33,7 @@
     onclose = options.onclose;
   }
 
-  function closeSidebar() {
+  $(".sidebar_close").click(function (e) {
     $("#sidebar").css("display", "none");
 
     <%= onclose %>
@@ -42,7 +42,9 @@
        onclose();
        onclose = null;
     }
-  }
+
+    e.preventDefault();
+  });
 
   function updateSidebar(title, content) {
     $("#sidebar_title").html(title);