From: Tom Hughes <tom@compton.nu>
Date: Wed, 6 Sep 2023 23:32:11 +0000 (+0100)
Subject: Handle timeouts inside a view for API calls
X-Git-Tag: live~1332
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/d1d3c2597e81f64d908c5e0c797ccb1600722e88?ds=inline;hp=-c

Handle timeouts inside a view for API calls
---

d1d3c2597e81f64d908c5e0c797ccb1600722e88
diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb
index a2d016c8c..89388c0bb 100644
--- a/app/controllers/api_controller.rb
+++ b/app/controllers/api_controller.rb
@@ -178,6 +178,16 @@ class ApiController < ApplicationController
   # wrap an api call in a timeout
   def api_call_timeout(&block)
     Timeout.timeout(Settings.api_timeout, Timeout::Error, &block)
+  rescue ActionView::Template::Error => e
+    e = e.cause
+
+    if e.is_a?(Timeout::Error) ||
+       (e.is_a?(ActiveRecord::StatementInvalid) && e.message.include?("execution expired"))
+      ActiveRecord::Base.connection.raw_connection.cancel
+      raise OSM::APITimeoutError
+    else
+      raise
+    end
   rescue Timeout::Error
     ActiveRecord::Base.connection.raw_connection.cancel
     raise OSM::APITimeoutError