From: Tom Hughes <tom@compton.nu>
Date: Fri, 15 Dec 2023 17:34:07 +0000 (+0000)
Subject: Merge remote-tracking branch 'upstream/pull/4408'
X-Git-Tag: live~1332
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/d2c103b9c54d0fc90e8dddd70861a4689ac4c83a?hp=a2e76f2400d3730d27b248e4a4a4f5adfa68dbb9

Merge remote-tracking branch 'upstream/pull/4408'
---

diff --git a/app/assets/images/key/mapnik/apron.png b/app/assets/images/key/mapnik/apron.png
deleted file mode 100644
index bcea5e3fb..000000000
Binary files a/app/assets/images/key/mapnik/apron.png and /dev/null differ
diff --git a/app/helpers/browse_tags_helper.rb b/app/helpers/browse_tags_helper.rb
index 014b8262d..1bda7dcb7 100644
--- a/app/helpers/browse_tags_helper.rb
+++ b/app/helpers/browse_tags_helper.rb
@@ -36,7 +36,7 @@ module BrowseTagsHelper
     elsif colour_value = colour_preview(key, value)
       tag.span("", :class => "colour-preview-box float-end m-1 border border-dark border-opacity-10", :"data-colour" => colour_value, :title => t("browse.tag_details.colour_preview", :colour_value => colour_value)) + colour_value
     else
-      safe_join(value.split(";").map { |x| linkify(h(x)) }, ";")
+      safe_join(value.split(";", -1).map { |x| linkify(h(x)) }, ";")
     end
   end
 
diff --git a/config/key.yml b/config/key.yml
index 114a623df..c524a9098 100644
--- a/config/key.yml
+++ b/config/key.yml
@@ -21,7 +21,7 @@ mapnik:
   - { min_zoom: 17, name: tram_only, width: 52, height: 2, fill: "#6e6e6e" }
   - { min_zoom: 12, max_zoom: 19, name: cable, image: cable.png }
   - { min_zoom: 11, max_zoom: 19, name: runway, image: runway.png }
-  - { min_zoom: 12, max_zoom: 19, name: apron, image: apron.png }
+  - { min_zoom: 11, name: apron_only, width: 26, height: 10, fill: "#dadae0" } # landcover.mss
   # administrative boundaries: admin.mss
   - { name: admin, width: 52, height: 2, fill: "#8d618b88" }
   # landcover z5: landcover.mss, water.mss
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 31563243a..c06ff3ceb 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2303,9 +2303,7 @@ en:
           runway:
             - Airport Runway
             - taxiway
-          apron:
-            - Airport apron
-            - terminal
+          apron_only: "Airport apron"
           admin: "Administrative boundary"
           orchard:
             - Orchard
diff --git a/test/helpers/browse_tags_helper_test.rb b/test/helpers/browse_tags_helper_test.rb
index 0af0d9310..0786af61d 100644
--- a/test/helpers/browse_tags_helper_test.rb
+++ b/test/helpers/browse_tags_helper_test.rb
@@ -22,6 +22,12 @@ class BrowseTagsHelperTest < ActionView::TestCase
     html = format_value("unknown", "unknown")
     assert_dom_equal "unknown", html
 
+    html = format_value("unknown", "abc;def")
+    assert_dom_equal "abc;def", html
+
+    html = format_value("unknown", "foo;")
+    assert_dom_equal "foo;", html
+
     html = format_value("addr:street", "Rue de l'Amigo")
     assert_dom_equal "Rue de l&#39;Amigo", html