From: Tom Hughes <tom@compton.nu>
Date: Mon, 25 Mar 2013 21:49:25 +0000 (+0000)
Subject: Mark CORS responses as uncacheable
X-Git-Tag: live~5616^2~13^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/d53bbe53f48d3f235ebc93af665ac912c057a51b?ds=sidebyside

Mark CORS responses as uncacheable
---

diff --git a/config/initializers/cors.rb b/config/initializers/cors.rb
index 9bbf937cf..1a8ce106d 100644
--- a/config/initializers/cors.rb
+++ b/config/initializers/cors.rb
@@ -1,11 +1,26 @@
 require "rack/cors"
 
+# Mark CORS responses as uncacheable as we don't want a browser to
+# try and reuse a response that had a different origin, even with
+# revalidation, as the origin check will fail.
+module OpenStreetMap
+  class Cors < Rack::Cors
+    def call(env)
+      status, headers, body = super env
+      if headers['Access-Control-Allow-Origin']
+        headers['Cache-Control'] = 'no-cache'
+      end
+      [status, headers, body]
+    end
+  end
+end
+
 # Allow any and all cross-origin requests to the API. Allow any origin, and
 # any headers. Non-browser requests do not have origin or header restrictions,
 # so browser-requests should be similarly permitted. (Though the API does not
 # require any custom headers, Ajax frameworks may automatically add headers
 # such as X-Requested-By to requests.)
-Rails.configuration.middleware.use Rack::Cors do
+Rails.configuration.middleware.use OpenStreetMap::Cors do
   allow do
     origins "*"
     resource "/oauth/*", :headers => :any, :methods => [:get, :post]