From: Tom Hughes <tom@compton.nu>
Date: Thu, 7 Jan 2010 16:09:44 +0000 (+0000)
Subject: Add a 30 second timeout to all data browser requests to avoid attempts
X-Git-Tag: live~6903
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/e0e849c91c66232c986a54da4a848d77f29bcb5b?hp=1374a7ef10f71331a08c7f5d4e78610a1ef3e0f7

Add a 30 second timeout to all data browser requests to avoid attempts
to browse very large and/or complicated objects blocking other requests.
---

diff --git a/app/controllers/browse_controller.rb b/app/controllers/browse_controller.rb
index 91d8eb84f..96cec3943 100644
--- a/app/controllers/browse_controller.rb
+++ b/app/controllers/browse_controller.rb
@@ -4,29 +4,29 @@ class BrowseController < ApplicationController
   before_filter :authorize_web  
   before_filter :set_locale 
   before_filter { |c| c.check_database_readable(true) }
+  around_filter :timeout, :except => [:start]
 
   def start 
   end
   
-  
-  
   def relation
+    @type = "relation"
     @relation = Relation.find(params[:id])
     @next = Relation.find(:first, :order => "id ASC", :conditions => [ "visible = true AND id > :id", { :id => @relation.id }] )
     @prev = Relation.find(:first, :order => "id DESC", :conditions => [ "visible = true AND id < :id", { :id => @relation.id }] )
   rescue ActiveRecord::RecordNotFound
-    @type = "relation"
     render :action => "not_found", :status => :not_found
   end
   
   def relation_history
+    @type = "relation"
     @relation = Relation.find(params[:id])
   rescue ActiveRecord::RecordNotFound
-    @type = "relation"
     render :action => "not_found", :status => :not_found
   end
   
   def way
+    @type = "way"
     @way = Way.find(params[:id], :include => [:way_tags, {:changeset => :user}, {:nodes => [:node_tags, {:ways => :way_tags}]}, :containing_relation_members])
     @next = Way.find(:first, :order => "id ASC", :conditions => [ "visible = true AND id > :id", { :id => @way.id }] )
     @prev = Way.find(:first, :order => "id DESC", :conditions => [ "visible = true AND id < :id", { :id => @way.id }] )
@@ -34,34 +34,35 @@ class BrowseController < ApplicationController
     # Used for edit link, takes approx middle node of way
     @midnode = @way.nodes[@way.nodes.length/2]
   rescue ActiveRecord::RecordNotFound
-    @type = "way"
     render :action => "not_found", :status => :not_found
   end
   
   def way_history
+    @type = "way"
     @way = Way.find(params[:id], :include => [:way_tags, {:old_ways => {:changeset => :user}}])
   rescue ActiveRecord::RecordNotFound
-    @type = "way"
     render :action => "not_found", :status => :not_found
   end
 
   def node
+    @type = "node"
     @node = Node.find(params[:id])
     @next = Node.find(:first, :order => "id ASC", :conditions => [ "visible = true AND id > :id", { :id => @node.id }] )
     @prev = Node.find(:first, :order => "id DESC", :conditions => [ "visible = true AND id < :id", { :id => @node.id }] )
   rescue ActiveRecord::RecordNotFound
-    @type = "node"
     render :action => "not_found", :status => :not_found
   end
   
   def node_history
+    @type = "node"
     @node = Node.find(params[:id])
   rescue ActiveRecord::RecordNotFound
-    @type = "way"
     render :action => "not_found", :status => :not_found
   end
   
   def changeset
+    @type = "changeset"
+
     @changeset = Changeset.find(params[:id])
     @node_pages, @nodes = paginate(:old_nodes, :conditions => {:changeset_id => @changeset.id}, :per_page => 20, :parameter => 'node_page')
     @way_pages, @ways = paginate(:old_ways, :conditions => {:changeset_id => @changeset.id}, :per_page => 20, :parameter => 'way_page')
@@ -74,7 +75,16 @@ class BrowseController < ApplicationController
     @next_by_user = Changeset.find(:first, :order => "id ASC", :conditions => [ "id > :id AND user_id = :user_id", {:id => @changeset.id, :user_id => @changeset.user_id }] )
     @prev_by_user = Changeset.find(:first, :order => "id DESC", :conditions => [ "id < :id AND user_id = :user_id", {:id => @changeset.id, :user_id => @changeset.user_id }] )
   rescue ActiveRecord::RecordNotFound
-    @type = "changeset"
     render :action => "not_found", :status => :not_found
   end
+
+private
+
+  def timeout
+    Timeout::timeout(30) do
+      yield
+    end
+  rescue Timeout::Error
+    render :action => "timeout", :status => :request_timeout
+  end
 end
diff --git a/app/views/browse/timeout.html.erb b/app/views/browse/timeout.html.erb
new file mode 100644
index 000000000..8b5076902
--- /dev/null
+++ b/app/views/browse/timeout.html.erb
@@ -0,0 +1,9 @@
+<%
+  browse_timeout_type = {
+    'node' => I18n.t('browse.timeout.type.node'),
+    'way' => I18n.t('browse.timeout.type.way'),
+    'relation' => I18n.t('browse.timeout.type.relation'),
+    'changeset' => I18n.t('browse.timeout.type.changeset'),
+  };
+%>
+<p><%= t'browse.timeout.sorry', :type=> browse_timeout_type[@type] , :id => params[:id] %></p>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index adaa7e662..6231f0dbe 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -162,6 +162,13 @@ en:
         way: way
         relation: relation
         changeset: changeset
+    timeout:
+      sorry: "Sorry, the data for the {{type}} with the id {{id}}, took too long to retrieve."
+      type:
+        node: node
+        way: way
+        relation: relation
+        changeset: changeset
     paging_nav:
       showing_page: "Showing page"
       of: "of"