From: Tom Hughes Date: Tue, 16 Nov 2021 08:21:17 +0000 (+0000) Subject: Merge remote-tracking branch 'upstream/pull/3353' X-Git-Tag: live~1986 X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/e342314d8b513dd1b7693a40885fd61d439a3557?hp=aad81eb74c9e6d70971f938da542271b8a70b638 Merge remote-tracking branch 'upstream/pull/3353' --- diff --git a/Gemfile b/Gemfile index 15348a989..3df9bc7eb 100644 --- a/Gemfile +++ b/Gemfile @@ -149,7 +149,7 @@ group :test do gem "rubocop" gem "rubocop-minitest" gem "rubocop-performance" - gem "rubocop-rails", "~> 2.11.3" # Bug in 2.12.0, fixed in master after 2.12.2 + gem "rubocop-rails" gem "rubocop-rake" gem "selenium-webdriver", "~> 3.142.7" gem "simplecov", :require => false diff --git a/Gemfile.lock b/Gemfile.lock index 9c46a8653..7d510c09c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -80,17 +80,17 @@ GEM autoprefixer-rails (10.3.3.0) execjs (~> 2) aws-eventstream (1.2.0) - aws-partitions (1.522.0) - aws-sdk-core (3.121.5) + aws-partitions (1.525.0) + aws-sdk-core (3.122.0) aws-eventstream (~> 1, >= 1.0.2) - aws-partitions (~> 1, >= 1.520.1) + aws-partitions (~> 1, >= 1.525.0) aws-sigv4 (~> 1.1) jmespath (~> 1.0) - aws-sdk-kms (1.50.0) - aws-sdk-core (~> 3, >= 3.121.2) + aws-sdk-kms (1.51.0) + aws-sdk-core (~> 3, >= 3.122.0) aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.104.0) - aws-sdk-core (~> 3, >= 3.121.2) + aws-sdk-s3 (1.105.1) + aws-sdk-core (~> 3, >= 3.122.0) aws-sdk-kms (~> 1) aws-sigv4 (~> 1.4) aws-sigv4 (1.4.0) @@ -124,8 +124,8 @@ GEM bzip2-ffi (1.1.0) ffi (~> 1.0) cancancan (3.3.0) - canonical-rails (0.2.12) - rails (>= 4.1, < 6.2) + canonical-rails (0.2.13) + rails (>= 4.1, <= 7.0) capybara (3.36.0) addressable matrix @@ -239,11 +239,11 @@ GEM globalid (0.5.2) activesupport (>= 5.0) hashdiff (1.0.1) - hashie (4.1.0) + hashie (5.0.0) html_tokenizer (0.0.7) htmlentities (4.3.4) http_accept_language (2.1.1) - i18n (1.8.10) + i18n (1.8.11) concurrent-ruby (~> 1.0) i18n-js (3.9.0) i18n (>= 0.6.6) @@ -334,7 +334,7 @@ GEM omniauth-oauth (1.2.0) oauth omniauth (>= 1.0, < 3) - omniauth-oauth2 (1.7.1) + omniauth-oauth2 (1.7.2) oauth2 (~> 1.4) omniauth (>= 1.9, < 3) omniauth-openid (2.0.1) @@ -423,14 +423,14 @@ GEM rubocop-ast (>= 1.12.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.12.0) + rubocop-ast (1.13.0) parser (>= 3.0.1.1) rubocop-minitest (0.15.2) rubocop (>= 0.90, < 2.0) rubocop-performance (1.12.0) rubocop (>= 1.7.0, < 2.0) rubocop-ast (>= 0.4.0) - rubocop-rails (2.11.3) + rubocop-rails (2.12.4) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.7.0, < 2.0) @@ -571,7 +571,7 @@ DEPENDENCIES rubocop rubocop-minitest rubocop-performance - rubocop-rails (~> 2.11.3) + rubocop-rails rubocop-rake sanitize sassc-rails diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index ccb0d7493..f2afdcf7a 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -370,8 +370,6 @@ body.compact-nav { } h3, h4 { - margin-top: $lineheight; - margin-bottom: $lineheight/2; font-size: 1.25rem; } @@ -813,7 +811,6 @@ tr.turn:hover { border-bottom: 1px solid $grey; h4:first-child { - margin-top: 0; word-wrap: break-word; } } @@ -858,6 +855,7 @@ tr.turn:hover { border-collapse: separate; border-spacing: 0; width: 100%; + margin-bottom: $spacer; th, td { border-bottom: 1px solid $grey; @@ -910,7 +908,7 @@ tr.turn:hover { .subscribe-buttons { float: left; - margin: 18px 10px 10px; + margin: 0 10px; min-width: 80px; } @@ -966,7 +964,7 @@ tr.turn:hover { } .export_area_inputs { - margin-bottom: $lineheight/2; + margin-bottom: $spacer; input[type="text"] { width: 100px; text-align: center; @@ -1094,13 +1092,6 @@ tr.turn:hover { } } -/* Rules for the user profile page */ - -.contact-activity { - margin-top: $lineheight; - width: 100%; -} - /* Rules for the user map */ .content_map .leaflet-popup-content { @@ -1117,30 +1108,12 @@ tr.turn:hover { margin-top: 0 0 0 60px; font-size: 12px; } - img.user_thumbnail { - float: left; - margin: 0 $lineheight/2 0 0; - } } /* Rules for the user list */ #user_list { width: 100%; - - tr { - vertical-align: middle; - } - - p { - margin-top: 0px; - margin-bottom: 0px; - } -} - -#user_list_actions { - float: right; - margin-top: $lineheight/2; } /* Rules for the diary list page */ @@ -1425,28 +1398,12 @@ img.user_image { max-width: 100px; max-height: 100px; border: 1px solid $grey; - margin-bottom: $lineheight; - float: left; - margin-right: $lineheight; -} - -img.user_image_no_margins { - max-width: 100px; - max-height: 100px; - border: 1px solid $grey; } img.user_thumbnail { max-width: 50px; max-height: 50px; border: 1px solid $grey; - margin-right: $lineheight; -} - -img.user_thumbnail_no_margins { - max-width: 50px; - max-height: 50px; - border: 1px solid $grey; } img.user_thumbnail_tiny { @@ -1612,10 +1569,6 @@ dl.dl-inline { } } -.comments .richtext { - margin-left: 70px; -} - /* Rules for the user notes list */ .note_list { diff --git a/app/assets/stylesheets/leaflet-all.scss b/app/assets/stylesheets/leaflet-all.scss index 34e3d094e..d12c61f77 100644 --- a/app/assets/stylesheets/leaflet-all.scss +++ b/app/assets/stylesheets/leaflet-all.scss @@ -15,9 +15,6 @@ div.leaflet-marker-icon.location-filter.move-marker { /* Override some conflicting styles. https://github.com/openstreetmap/openstreetmap-website/pull/121#issuecomment-10206946 */ -.leaflet-popup-content img.user_thumbnail { - max-width: 50px !important; -} .user_popup p { margin: 0 !important; diff --git a/app/views/browse/_common_details.html.erb b/app/views/browse/_common_details.html.erb index 356207754..5505ee4a9 100644 --- a/app/views/browse/_common_details.html.erb +++ b/app/views/browse/_common_details.html.erb @@ -11,7 +11,7 @@ <% end %>

-
+

<%= t "browse.#{common_details.visible? ? :edited : :deleted}_by_html", :time => time_ago_in_words(common_details.timestamp, :scope => :"datetime.distance_in_words_ago"), :user => changeset_user_link(common_details.changeset), @@ -19,7 +19,7 @@ · <%= t "browse.in_changeset" %> #<%= link_to common_details.changeset_id, :action => :changeset, :id => common_details.changeset_id %> -

+

<% if @type == "node" and common_details.visible? %>
diff --git a/app/views/browse/changeset.html.erb b/app/views/browse/changeset.html.erb index 079915fcf..496589a08 100644 --- a/app/views/browse/changeset.html.erb +++ b/app/views/browse/changeset.html.erb @@ -6,7 +6,7 @@

<%= linkify(@changeset.tags["comment"].to_s.presence || t("browse.no_comment")) %>

-
<%= changeset_details(@changeset) %>
+

<%= changeset_details(@changeset) %>

<%= render :partial => "tag_details", :object => @changeset.tags.except("comment") %> @@ -63,14 +63,14 @@ <% end %> <% unless current_user %> -
+

<%= link_to(t(".join_discussion"), login_path(:referer => request.fullpath)) %> -

+

<% end %> <% if current_user %> <% unless @changeset.is_open? %> -
+
@@ -79,9 +79,9 @@
<% else %> -
- <%= t(".still_open") %> -
+

+ <%= t(".still_open") %> +

<% end %> <% end %> diff --git a/app/views/dashboards/_contact.html.erb b/app/views/dashboards/_contact.html.erb index 7614c0c4d..77363dbdb 100644 --- a/app/views/dashboards/_contact.html.erb +++ b/app/views/dashboards/_contact.html.erb @@ -4,9 +4,9 @@ :icon => image_path(type == "friend" ? "marker-blue.png" : "marker-green.png"), :description => render(:partial => "popup", :object => contact, :locals => { :type => type }) } %> -<%= tag.div :class => "contact-activity clearfix row", :data => { :user => user_data } do %> +<%= tag.div :class => "clearfix row", :data => { :user => user_data } do %>
- <%= user_thumbnail contact, :class => "user_thumbnail_no_margins" %> + <%= user_thumbnail contact %>

diff --git a/app/views/dashboards/_popup.html.erb b/app/views/dashboards/_popup.html.erb index a643b5c90..ef86f042d 100644 --- a/app/views/dashboards/_popup.html.erb +++ b/app/views/dashboards/_popup.html.erb @@ -1,5 +1,9 @@ -

- <%= user_thumbnail popup %> -

<%= t(".#{type}") %>

-

<%= link_to popup.display_name, user_path(popup) %>

+
+
+ <%= user_thumbnail popup %> +
+
+

<%= t(".#{type}") %>

+

<%= link_to popup.display_name, user_path(popup) %>

+
diff --git a/app/views/dashboards/show.html.erb b/app/views/dashboards/show.html.erb index 9aa4abed4..0f04dafb9 100644 --- a/app/views/dashboards/show.html.erb +++ b/app/views/dashboards/show.html.erb @@ -32,7 +32,7 @@ <% if friends.empty? %> <%= t ".no friends" %> <% else %> -