From: Anton Khorev <tony29@yandex.ru>
Date: Tue, 13 Sep 2022 01:20:57 +0000 (+0300)
Subject: Fix zoom level related tooltips for layer checkboxes
X-Git-Tag: live~1462^2~4
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/e8f2af833ac73f953cb65d06b8861c0f9844e852

Fix zoom level related tooltips for layer checkboxes
---

diff --git a/app/assets/javascripts/leaflet.layers.js b/app/assets/javascripts/leaflet.layers.js
index d762696a1..f372b86cf 100644
--- a/app/assets/javascripts/leaflet.layers.js
+++ b/app/assets/javascripts/leaflet.layers.js
@@ -98,11 +98,15 @@ L.OSM.layers = function (options) {
 
       var addOverlay = function (layer, name, maxArea) {
         var item = $("<li>")
-          .tooltip({
-            placement: "top"
-          })
           .appendTo(overlays);
 
+        var tooltip;
+        if (name === "notes" || name === "data") {
+          item.attr("title", I18n.t("javascripts.site.map_" + name + "_zoom_in_tooltip"));
+          tooltip = new bootstrap.Tooltip(item[0]);
+          tooltip.disable();
+        }
+
         var label = $("<label>")
           .attr("class", "form-check-label")
           .appendTo(item);
@@ -145,8 +149,13 @@ L.OSM.layers = function (options) {
           }
 
           $(item).attr("class", disabled ? "disabled" : "");
-          item.attr("data-bs-original-title", disabled ? // has additional bug when zooming out from enabled state
-            I18n.t("javascripts.site.map_" + name + "_zoom_in_tooltip") : "");
+          if (tooltip) {
+            if (disabled) {
+              tooltip.enable();
+            } else {
+              tooltip.disable();
+            }
+          }
         });
       };
 
diff --git a/test/system/site_test.rb b/test/system/site_test.rb
index 2809feb93..f918b897a 100644
--- a/test/system/site_test.rb
+++ b/test/system/site_test.rb
@@ -62,4 +62,18 @@ class SiteTest < ApplicationSystemTestCase
       assert_selector ".tooltip", :text => "Zoom in"
     end
   end
+
+  test "notes layer tooltip appears on zoom out" do
+    visit "/#map=9/40/-4" # depends on zoom levels where notes are allowed
+    find(".control-layers .control-button").click
+    li = find(".layers-ui .overlay-layers li:first-child")
+    li.not_matches_css? ".disabled"
+    li.hover # try to trigger disabled tooltip
+    zoomout = find(".control-button.zoomout")
+    zoomout.hover # un-hover the tooltip that's being tested
+    zoomout.click
+    li.matches_css? ".disabled"
+    li.hover
+    assert_selector ".tooltip", :text => "Zoom in"
+  end
 end