From: Tom Hughes Date: Tue, 22 Feb 2022 19:06:43 +0000 (+0000) Subject: Merge remote-tracking branch 'upstream/pull/3462' X-Git-Tag: live~2222 X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/fe7996586927f46f048625fe38ccebc43415d5dd?hp=be878df0978d5b51f7fbb72fca16f74c5708c818 Merge remote-tracking branch 'upstream/pull/3462' --- diff --git a/Gemfile.lock b/Gemfile.lock index 0c8b03bda..6b90fce50 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -86,8 +86,8 @@ GEM autoprefixer-rails (10.4.2.0) execjs (~> 2) aws-eventstream (1.2.0) - aws-partitions (1.554.0) - aws-sdk-core (3.126.1) + aws-partitions (1.556.0) + aws-sdk-core (3.126.2) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.525.0) aws-sigv4 (~> 1.1) @@ -180,7 +180,7 @@ GEM dry-logic (1.2.0) concurrent-ruby (~> 1.0) dry-core (~> 0.5, >= 0.5) - dry-schema (1.9.0) + dry-schema (1.9.1) concurrent-ruby (~> 1.0) dry-configurable (~> 0.13, >= 0.13.0) dry-core (~> 0.5, >= 0.5) @@ -193,12 +193,12 @@ GEM dry-core (~> 0.5, >= 0.5) dry-inflector (~> 0.1, >= 0.1.2) dry-logic (~> 1.0, >= 1.0.2) - dry-validation (1.7.0) + dry-validation (1.8.0) concurrent-ruby (~> 1.0) dry-container (~> 0.7, >= 0.7.1) dry-core (~> 0.5, >= 0.5) dry-initializer (~> 3.0) - dry-schema (~> 1.8, >= 1.8.0) + dry-schema (~> 1.9, >= 1.9.1) erb_lint (0.1.1) activesupport better_html (~> 1.0.7) @@ -215,29 +215,10 @@ GEM factory_bot_rails (6.2.0) factory_bot (~> 6.2.0) railties (>= 5.0.0) - faraday (1.9.3) - faraday-em_http (~> 1.0) - faraday-em_synchrony (~> 1.0) - faraday-excon (~> 1.1) - faraday-httpclient (~> 1.0) - faraday-multipart (~> 1.0) - faraday-net_http (~> 1.0) - faraday-net_http_persistent (~> 1.0) - faraday-patron (~> 1.0) - faraday-rack (~> 1.0) - faraday-retry (~> 1.0) + faraday (2.2.0) + faraday-net_http (~> 2.0) ruby2_keywords (>= 0.0.4) - faraday-em_http (1.0.0) - faraday-em_synchrony (1.0.0) - faraday-excon (1.1.0) - faraday-httpclient (1.0.1) - faraday-multipart (1.0.3) - multipart-post (>= 1.2, < 3) - faraday-net_http (1.0.1) - faraday-net_http_persistent (1.2.0) - faraday-patron (1.0.0) - faraday-rack (1.0.0) - faraday-retry (1.0.3) + faraday-net_http (2.0.1) ffi (1.15.5) ffi-compiler (1.0.1) ffi (>= 1.0.0) @@ -305,12 +286,11 @@ GEM method_source (1.0.0) mini_magick (4.11.0) mini_mime (1.1.2) - mini_portile2 (2.7.1) + mini_portile2 (2.8.0) minitest (5.15.0) msgpack (1.4.5) multi_json (1.15.0) multi_xml (0.6.0) - multipart-post (2.1.1) net-imap (0.2.3) digest net-protocol @@ -327,8 +307,8 @@ GEM net-protocol timeout nio4r (2.5.8) - nokogiri (1.13.1) - mini_portile2 (~> 2.7.0) + nokogiri (1.13.3) + mini_portile2 (~> 2.8.0) racc (~> 1.4) oauth (0.4.7) oauth-plugin (0.5.1) @@ -336,8 +316,8 @@ GEM oauth (~> 0.4.4) oauth2 (>= 0.5.0) rack - oauth2 (1.4.7) - faraday (>= 0.8, < 2.0) + oauth2 (1.4.9) + faraday (>= 0.17.3, < 3.0) jwt (>= 1.0, < 3.0) multi_json (~> 1.3) multi_xml (~> 0.5) @@ -376,7 +356,7 @@ GEM omniauth-oauth2 (~> 1.4) openstreetmap-deadlock_retry (1.3.1) parallel (1.21.0) - parser (3.1.0.0) + parser (3.1.1.0) ast (~> 2.4.1) pg (1.3.2) popper_js (1.16.0) @@ -451,8 +431,8 @@ GEM rubocop-ast (>= 1.15.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.15.2) - parser (>= 3.0.1.1) + rubocop-ast (1.16.0) + parser (>= 3.1.1.0) rubocop-minitest (0.17.2) rubocop (>= 0.90, < 2.0) rubocop-performance (1.13.2) diff --git a/app/assets/javascripts/index/browse.js b/app/assets/javascripts/index/browse.js index b6a388d81..1140515f5 100644 --- a/app/assets/javascripts/index/browse.js +++ b/app/assets/javascripts/index/browse.js @@ -1,6 +1,5 @@ OSM.initializeBrowse = function (map) { var browseBounds; - var selectedLayer; var dataLayer = map.dataLayer; dataLayer.setStyle({ @@ -92,7 +91,6 @@ OSM.initializeBrowse = function (map) { url: url, success: function (xml) { dataLayer.clearLayers(); - selectedLayer = null; var features = dataLayer.buildFeatures(xml); @@ -112,24 +110,16 @@ OSM.initializeBrowse = function (map) { displayFeatureWarning(features.length, maxFeatures, addFeatures, cancelAddFeatures); } + if (map._objectLayer) { + map._objectLayer.bringToFront(); + } + dataLoader = null; } }); } function onSelect(layer) { - // Unselect previously selected feature - if (selectedLayer) { - selectedLayer.setStyle(selectedLayer.originalStyle); - } - - // Redraw in selected style - layer.originalStyle = layer.options; - layer.setStyle({ color: "#0000ff", weight: 8 }); - OSM.router.route("/" + layer.feature.type + "/" + layer.feature.id); - - // Stash the currently drawn feature - selectedLayer = layer; } }; diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index d9fa276ba..d63317812 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -1182,8 +1182,9 @@ tr.turn:hover { /* Rules for messages pages */ .messages { - input[type="submit"] { + button[type="submit"] { margin: auto; + white-space: nowrap; } .inbox-row { diff --git a/app/views/accounts/edit.html.erb b/app/views/accounts/edit.html.erb index eb977d094..2017bee0a 100644 --- a/app/views/accounts/edit.html.erb +++ b/app/views/accounts/edit.html.erb @@ -68,5 +68,5 @@

<%= t ".public editing note.heading" %>

<%= t ".public editing note.html" %> - <%= button_to t(".make edits public button"), user_go_public_path %> +<%= button_to t(".make edits public button"), user_go_public_path, :class => "btn btn-primary" %> <% end %> diff --git a/config/initializers/new_framework_defaults_7_0.rb b/config/initializers/new_framework_defaults_7_0.rb index ccf2fcd11..6196fd438 100644 --- a/config/initializers/new_framework_defaults_7_0.rb +++ b/config/initializers/new_framework_defaults_7_0.rb @@ -11,10 +11,10 @@ # `button_to` view helper will render `