From 1b977454f7f993ebf6d64c30921a4f62accbc640 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Sun, 9 Feb 2025 18:38:22 +0300 Subject: [PATCH] Add show_redactions checks to api old element show tests --- test/controllers/api/old_nodes_controller_test.rb | 8 ++++++++ test/controllers/api/old_relations_controller_test.rb | 8 ++++++++ test/controllers/api/old_ways_controller_test.rb | 8 ++++++++ 3 files changed, 24 insertions(+) diff --git a/test/controllers/api/old_nodes_controller_test.rb b/test/controllers/api/old_nodes_controller_test.rb index e24693a41..e80d14608 100644 --- a/test/controllers/api/old_nodes_controller_test.rb +++ b/test/controllers/api/old_nodes_controller_test.rb @@ -151,6 +151,10 @@ module Api get api_node_version_path(node, 1) assert_response :forbidden, "Redacted node shouldn't be visible via the version API." + + get api_node_version_path(node, 1, :show_redactions => "true") + + assert_response :forbidden, "Redacted node shouldn't be visible via the version API when passing flag." end def test_show_redacted_normal_user @@ -160,6 +164,10 @@ module Api get api_node_version_path(node, 1), :headers => bearer_authorization_header assert_response :forbidden, "Redacted node shouldn't be visible via the version API, even when logged in." + + get api_node_version_path(node, 1, :show_redactions => "true"), :headers => bearer_authorization_header + + assert_response :forbidden, "Redacted node shouldn't be visible via the version API, even when logged in and passing flag." end # Ensure the lat/lon is formatted as a decimal e.g. not 4.0e-05 diff --git a/test/controllers/api/old_relations_controller_test.rb b/test/controllers/api/old_relations_controller_test.rb index aac46ad65..4225083ba 100644 --- a/test/controllers/api/old_relations_controller_test.rb +++ b/test/controllers/api/old_relations_controller_test.rb @@ -151,6 +151,10 @@ module Api get api_relation_version_path(relation, 1) assert_response :forbidden, "Redacted relation shouldn't be visible via the version API." + + get api_relation_version_path(relation, 1, :show_redactions => "true") + + assert_response :forbidden, "Redacted relation shouldn't be visible via the version API when passing flag." end def test_show_redacted_normal_user @@ -160,6 +164,10 @@ module Api get api_relation_version_path(relation, 1), :headers => bearer_authorization_header assert_response :forbidden, "Redacted relation shouldn't be visible via the version API, even when logged in." + + get api_relation_version_path(relation, 1, :show_redactions => "true"), :headers => bearer_authorization_header + + assert_response :forbidden, "Redacted relation shouldn't be visible via the version API, even when logged in and passing flag." end ## diff --git a/test/controllers/api/old_ways_controller_test.rb b/test/controllers/api/old_ways_controller_test.rb index c365f3297..bd818c377 100644 --- a/test/controllers/api/old_ways_controller_test.rb +++ b/test/controllers/api/old_ways_controller_test.rb @@ -148,6 +148,10 @@ module Api get api_way_version_path(way, 1) assert_response :forbidden, "Redacted way shouldn't be visible via the version API." + + get api_way_version_path(way, 1, :show_redactions => "true") + + assert_response :forbidden, "Redacted way shouldn't be visible via the version API when passing flag." end def test_show_redacted_normal_user @@ -157,6 +161,10 @@ module Api get api_way_version_path(way, 1), :headers => bearer_authorization_header assert_response :forbidden, "Redacted way shouldn't be visible via the version API, even when logged in." + + get api_way_version_path(way, 1, :show_redactions => "true"), :headers => bearer_authorization_header + + assert_response :forbidden, "Redacted way shouldn't be visible via the version API, even when logged in and passing flag." end ## -- 2.39.5