From 22408c3e5bbce14b70b56be3a02122e2db3de896 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Thu, 14 Nov 2013 12:22:20 -0800 Subject: [PATCH] Simplify --- app/assets/javascripts/index.js | 14 +-------- app/assets/javascripts/leaflet.map.js.erb | 38 ++++++++++++++--------- 2 files changed, 24 insertions(+), 28 deletions(-) diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js index d612b2778..6fc870a4c 100644 --- a/app/assets/javascripts/index.js +++ b/app/assets/javascripts/index.js @@ -230,19 +230,7 @@ $(document).ready(function () { }; page.load = function(path, type, id) { - if (OSM.STATUS === 'api_offline' || OSM.STATUS === 'database_offline') return; - - map.addObject({type: type, id: parseInt(id)}, - { - zoom: window.location.hash == "", - style: { - color: "#FF6200", - weight: 4, - opacity: 1, - fillOpacity: 0.5 - } - } - ); + map.addObject({type: type, id: parseInt(id)}); }; page.unload = function() { diff --git a/app/assets/javascripts/leaflet.map.js.erb b/app/assets/javascripts/leaflet.map.js.erb index 75700913f..f598a4839 100644 --- a/app/assets/javascripts/leaflet.map.js.erb +++ b/app/assets/javascripts/leaflet.map.js.erb @@ -169,7 +169,21 @@ L.OSM.Map = L.Map.extend({ return str; }, - addObject: function(object, options) { + addObject: function(object) { + var objectStyle = { + color: "#FF6200", + weight: 4, + opacity: 1, + fillOpacity: 0.5 + }; + + var changesetStyle = { + weight: 1, + color: '#FF9500', + opacity: 1, + fillOpacity: 0 + }; + this._object = object; if (this._objectLoader) this._objectLoader.abort(); @@ -182,15 +196,10 @@ L.OSM.Map = L.Map.extend({ success: function (xml) { map._objectLayer = new L.OSM.DataLayer(null, { styles: { - node: options.style, - way: options.style, - area: options.style, - changeset: { - weight: 1, - color: '#FF9500', - opacity: 1, - fillOpacity: 0 - } + node: objectStyle, + way: objectStyle, + area: objectStyle, + changeset: changesetStyle } }); @@ -207,13 +216,12 @@ L.OSM.Map = L.Map.extend({ }; map._objectLayer.addData(xml); + map._objectLayer.addTo(map); var bounds = map._objectLayer.getBounds(); - - if (options.zoom && bounds.isValid()) map.fitBounds(bounds); - if (options.callback) options.callback(bounds); - - map._objectLayer.addTo(map); + if (bounds.isValid()) { + map.fitBounds(bounds); + } } }); }, -- 2.39.5