From 24c138ac8d5952117611146cec78379eb12e315f Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Thu, 6 Jun 2024 18:01:23 +0300 Subject: [PATCH] Ensure that Open Graph image url is absolute --- app/helpers/open_graph_helper.rb | 2 +- test/controllers/diary_entries_controller_test.rb | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb index 89aeee6b9..0ce4d6267 100644 --- a/app/helpers/open_graph_helper.rb +++ b/app/helpers/open_graph_helper.rb @@ -4,7 +4,7 @@ module OpenGraphHelper "og:site_name" => t("layouts.project_name.title"), "og:title" => [title, t("layouts.project_name.title")].compact.join(" | "), "og:type" => "website", - "og:image" => og_image || image_url("osm_logo_256.png"), + "og:image" => og_image ? URI.join(root_url, og_image) : image_url("osm_logo_256.png"), "og:url" => url_for(:only_path => false), "og:description" => t("layouts.intro_text") } diff --git a/test/controllers/diary_entries_controller_test.rb b/test/controllers/diary_entries_controller_test.rb index 765391d24..b6d11c62a 100644 --- a/test/controllers/diary_entries_controller_test.rb +++ b/test/controllers/diary_entries_controller_test.rb @@ -763,6 +763,17 @@ class DiaryEntriesControllerTest < ActionDispatch::IntegrationTest end end + def test_show_og_image_with_relative_uri + user = create(:user) + diary_entry = create(:diary_entry, :user => user, :body => "![some local picture](/picture.jpg)") + + get diary_entry_path(user, diary_entry) + assert_response :success + assert_dom "head meta[property='og:image']" do + assert_dom "> @content", "#{root_url}picture.jpg" + end + end + def test_hide user = create(:user) diary_entry = create(:diary_entry, :user => user) -- 2.39.5