From 31dae1bac102bdf30d62aacd24e6821a2fbbc542 Mon Sep 17 00:00:00 2001 From: John Firebaugh Date: Sun, 21 Oct 2012 20:31:29 -0700 Subject: [PATCH] Avoid unnecessary array allocations --- app/models/relation.rb | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/app/models/relation.rb b/app/models/relation.rb index ce19f7b98..e402d0d08 100644 --- a/app/models/relation.rb +++ b/app/models/relation.rb @@ -167,13 +167,9 @@ class Relation < ActiveRecord::Base # FIXME is this really needed? def members - unless @members - @members = Array.new - self.relation_members.each do |member| - @members += [[member.member_type,member.member_id,member.member_role]] - end + @members ||= self.relation_members.map do |member| + [member.member_type, member.member_id, member.member_role] end - @members end def tags @@ -194,9 +190,9 @@ class Relation < ActiveRecord::Base @tags = t end - def add_member(type,id,role) - @members = Array.new unless @members - @members += [[type,id.to_i,role]] + def add_member(type, id, role) + @members ||= [] + @members << [type, id.to_i, role] end def add_tag_keyval(k, v) -- 2.39.5