From 4073e0fc4784794eefa9922964cba1f807515e63 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Wed, 12 Feb 2025 18:56:09 +0300 Subject: [PATCH] Split api changeset comment create fail tests --- .../api/changeset_comments_controller_test.rb | 41 ++++++++++--------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/test/controllers/api/changeset_comments_controller_test.rb b/test/controllers/api/changeset_comments_controller_test.rb index cc257eb9d..b3b3d9c75 100644 --- a/test/controllers/api/changeset_comments_controller_test.rb +++ b/test/controllers/api/changeset_comments_controller_test.rb @@ -98,38 +98,39 @@ module Api ActionMailer::Base.deliveries.clear end - ## - # create comment fail - def test_create_fail - # unauthorized - post changeset_comment_path(create(:changeset, :closed), :text => "This is a comment") - assert_response :unauthorized - - auth_header = bearer_authorization_header + def test_create_by_unauthorized + assert_no_difference "ChangesetComment.count" do + post changeset_comment_path(create(:changeset, :closed), :text => "This is a comment") + assert_response :unauthorized + end + end - # bad changeset id + def test_create_on_missing_changeset assert_no_difference "ChangesetComment.count" do - post changeset_comment_path(999111, :text => "This is a comment"), :headers => auth_header + post changeset_comment_path(999111, :text => "This is a comment"), :headers => bearer_authorization_header + assert_response :not_found end - assert_response :not_found + end - # not closed changeset + def test_create_on_open_changeset assert_no_difference "ChangesetComment.count" do - post changeset_comment_path(create(:changeset), :text => "This is a comment"), :headers => auth_header + post changeset_comment_path(create(:changeset), :text => "This is a comment"), :headers => bearer_authorization_header + assert_response :conflict end - assert_response :conflict + end - # no text + def test_create_without_text assert_no_difference "ChangesetComment.count" do - post changeset_comment_path(create(:changeset, :closed)), :headers => auth_header + post changeset_comment_path(create(:changeset, :closed)), :headers => bearer_authorization_header + assert_response :bad_request end - assert_response :bad_request + end - # empty text + def test_create_with_empty_text assert_no_difference "ChangesetComment.count" do - post changeset_comment_path(create(:changeset, :closed), :text => ""), :headers => auth_header + post changeset_comment_path(create(:changeset, :closed), :text => ""), :headers => bearer_authorization_header + assert_response :bad_request end - assert_response :bad_request end ## -- 2.39.5