From 5e8fd6e6cbf974999395f6199a3862823e1ca357 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 5 Jun 2019 09:10:03 +0100 Subject: [PATCH] Update rubocop todo --- .rubocop_todo.yml | 80 +++++++++++++++++++++++++---------------------- 1 file changed, 42 insertions(+), 38 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d63584223..342275040 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,40 +1,40 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-09-19 14:24:02 +0100 using RuboCop version 0.58.2. +# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 32 +# Offense count: 33 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - - 'app/controllers/api/traces_controller.rb' - 'app/controllers/traces_controller.rb' - 'app/controllers/users_controller.rb' - - 'app/controllers/api/user_preferences_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/browse_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/models/client_application.rb' - 'app/mailers/notifier.rb' + - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' # Offense count: 4 +# Configuration parameters: AllowComments. Lint/HandleExceptions: Exclude: - 'app/controllers/api/amf_controller.rb' - 'app/controllers/users_controller.rb' -# Offense count: 692 +# Offense count: 703 Metrics/AbcSize: - Max: 283 + Max: 279 # Offense count: 40 # Configuration parameters: CountComments, ExcludedMethods. @@ -42,36 +42,36 @@ Metrics/AbcSize: Metrics/BlockLength: Max: 263 -# Offense count: 11 +# Offense count: 15 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 63 +# Offense count: 68 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1627 + Max: 1397 -# Offense count: 72 +# Offense count: 73 Metrics/CyclomaticComplexity: - Max: 23 + Max: 22 -# Offense count: 691 -# Configuration parameters: CountComments. +# Offense count: 714 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 179 -# Offense count: 2 +# Offense count: 1 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 135 + Max: 107 # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 72 +# Offense count: 71 Metrics/PerceivedComplexity: Max: 25 @@ -100,10 +100,12 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' -# Disabled pending merge of fix for: -# https://github.com/rubocop-hq/rubocop/issues/6943 +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/models/**/*.rb Rails/ActiveRecordOverride: - Enabled: false + Exclude: + - 'app/models/trace.rb' # Offense count: 6 # Configuration parameters: Database, Include. @@ -116,14 +118,6 @@ Rails/BulkChangeTable: - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: - Exclude: - - 'lib/**/*.rake' - - 'lib/daemons/gpx_import.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -132,6 +126,15 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' +# Offense count: 11 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/title_helper.rb' + - 'app/helpers/trace_helper.rb' + # Offense count: 5 # Configuration parameters: Include. # Include: db/migrate/*.rb @@ -143,7 +146,7 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 20 +# Offense count: 18 Rails/OutputSafety: Exclude: - 'app/controllers/users_controller.rb' @@ -153,11 +156,11 @@ Rails/OutputSafety: - 'app/helpers/note_helper.rb' - 'app/helpers/open_graph_helper.rb' - 'app/helpers/user_blocks_helper.rb' - - 'app/helpers/user_roles_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 86 +# Offense count: 94 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: @@ -169,14 +172,14 @@ Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 230 +# Offense count: 255 Style/Documentation: Enabled: false -# Offense count: 462 +# Offense count: 503 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: when_needed, always, never +# SupportedStyles: always, never Style/FrozenStringLiteralComment: Enabled: false @@ -186,14 +189,15 @@ Style/IfUnlessModifier: Exclude: - 'app/controllers/api/ways_controller.rb' -# Offense count: 70 +# Offense count: 74 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 -# Offense count: 3080 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 3320 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: Max: 1073 -- 2.39.5