From 64f3a1a947e92436bf3a40d2e9e4a280a4f319f2 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Mon, 30 Apr 2018 23:01:08 +0100 Subject: [PATCH 1/1] Fix translation lookups for roundabout exits --- app/assets/javascripts/index/directions/osrm.js | 10 +++++++++- config/locales/en.yml | 6 +----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/index/directions/osrm.js b/app/assets/javascripts/index/directions/osrm.js index 4ce2d005f..81c62e183 100644 --- a/app/assets/javascripts/index/directions/osrm.js +++ b/app/assets/javascripts/index/directions/osrm.js @@ -32,6 +32,8 @@ function OSRMEngine() { 'turn slight left': 'javascripts.directions.instructions.slight_left', 'roundabout': 'javascripts.directions.instructions.roundabout', 'rotary': 'javascripts.directions.instructions.roundabout', + 'exit roundabout': 'javascripts.directions.instructions.exit_roundabout', + 'exit rotary': 'javascripts.directions.instructions.exit_roundabout', 'depart': 'javascripts.directions.instructions.start', 'arrive': 'javascripts.directions.instructions.destination', }; @@ -57,6 +59,8 @@ function OSRMEngine() { 'turn sharp left': 7, 'roundabout': 10, 'rotary': 10, + 'exit roundabout': 10, + 'exit rotary': 10, 'depart': 8, 'arrive': 14 }; @@ -79,6 +83,8 @@ function OSRMEngine() { case 'arrive': case 'roundabout': case 'rotary': + case 'exit roundabout': + case 'exit rotary': maneuver_id = step.maneuver.type; break; case 'roundabout turn': @@ -113,7 +119,9 @@ function OSRMEngine() { namedRoad = false; } - if (step.maneuver.type.match(/rotary|roundabout/)) { + if (step.maneuver.type.match(/exit (rotary|roundabout)/)) { + instText += I18n.t(template, { name: name }); + } else if (step.maneuver.type.match(/rotary|roundabout/)) { if (step.maneuver.exit) { if (step.maneuver.exit <= 10) { instText += I18n.t(template + '_with_exit_ordinal', { exit: I18n.t('javascripts.directions.instructions.exit_counts.' + numToWord(step.maneuver.exit)), name: name }); diff --git a/config/locales/en.yml b/config/locales/en.yml index 15cc2dbf6..7cb67e0c8 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -2378,11 +2378,7 @@ en: end_oneway_without_exit: End of one-way on %{name} roundabout_with_exit: At roundabout take exit %{exit} onto %{name} roundabout_with_exit_ordinal: At roundabout take %{exit} exit onto %{name} - turn_left_with_exit: Exit onto %{name} - slight_left_with_exit: Exit onto %{name} - turn_right_with_exit: Exit onto %{name} - slight_right_with_exit: Exit onto %{name} - continue_with_exit: Exit onto %{name} + exit_roundabout: Exit roundabout onto %{name} unnamed: "unnamed road" courtesy: "Directions courtesy of %{link}" exit_counts: -- 2.39.5