From 9e99fa05c9e7d849a95d6faf6fa7a5d9988fc308 Mon Sep 17 00:00:00 2001
From: Emin Kocan <kocanmn.dev@gmail.com>
Date: Thu, 27 Jun 2024 17:22:41 +0200
Subject: [PATCH] add _section_divider component utilizing hr tags

---
 app/views/sessions/new.html.erb            | 14 +++-----------
 app/views/shared/_section_divider.html.erb |  5 +++++
 app/views/users/new.html.erb               | 14 +++-----------
 3 files changed, 11 insertions(+), 22 deletions(-)
 create mode 100644 app/views/shared/_section_divider.html.erb

diff --git a/app/views/sessions/new.html.erb b/app/views/sessions/new.html.erb
index 70839d160..57e6d014a 100644
--- a/app/views/sessions/new.html.erb
+++ b/app/views/sessions/new.html.erb
@@ -25,12 +25,8 @@
 <div id="login_login" class="auth-container mx-auto my-0">
   <% if @preferred_auth_provider %>
     <%= render :partial => "auth_providers" %>
-    <div class="d-flex justify-content-center align-items-center mb-2">
-      <div class="border-bottom border-1 flex-grow-1"></div>
-      <div class="text-secondary mx-3"><%= t ".or" %></div>
-      <div class="border-bottom border-1 flex-grow-1"></div>
-    </div>
-  <% end %>
+    <%= render :partial => "shared/section_divider", :locals => { :text => t(".or") } %>
+<% end %>
 
   <%= bootstrap_form_tag(:action => "login", :html => { :id => "login_form" }) do |f| %>
     <%= hidden_field_tag("referer", h(params[:referer]), :autocomplete => "off") %>
@@ -57,11 +53,7 @@
   <% end %>
 
   <% unless @preferred_auth_provider %>
-    <div class="d-flex justify-content-center align-items-center">
-      <div class="border-bottom border-1 flex-grow-1"></div>
-      <div class="text-secondary mx-3"><%= t ".with external" %></div>
-      <div class="border-bottom border-1 flex-grow-1"></div>
-    </div>
+    <%= render :partial => "shared/section_divider", :locals => { :text => t(".with external") } %>
     <%= render :partial => "auth_providers" %>
   <% end %>
 </div>
diff --git a/app/views/shared/_section_divider.html.erb b/app/views/shared/_section_divider.html.erb
new file mode 100644
index 000000000..ad6bffd9d
--- /dev/null
+++ b/app/views/shared/_section_divider.html.erb
@@ -0,0 +1,5 @@
+<div class="d-flex align-items-center my-1">
+  <hr class="flex-grow-1 border-secondary" role="separator">
+  <span class="mx-3 text-secondary"><%= text %></span>
+  <hr class="flex-grow-1 border-secondary" role="separator">
+</div>
diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb
index b618f3811..c0cef51d9 100644
--- a/app/views/users/new.html.erb
+++ b/app/views/users/new.html.erb
@@ -31,12 +31,8 @@
 
     <% unless @preferred_auth_provider.nil? %>
       <%= render :partial => "auth_providers" %>
-      <div class="d-flex justify-content-center align-items-center mb-2">
-        <div class="border-bottom border-1 flex-grow-1"></div>
-        <div class="text-secondary mx-3"><%= t ".or" %></div>
-        <div class="border-bottom border-1 flex-grow-1"></div>
-      </div>
-    <% end %>
+      <%= render :partial => "shared/section_divider", :locals => { :text => t(".or") } %>
+<% end %>
   <% else %>
     <h4><%= t ".about.welcome" %></h4>
   <% end %>
@@ -98,11 +94,7 @@
   <% end %>
 
   <% if current_user.auth_uid.nil? and @preferred_auth_provider.nil? %>
-    <div class="d-flex justify-content-center align-items-center">
-      <div class="border-bottom border-1 flex-grow-1"></div>
-      <div class="text-secondary mx-3"><%= t ".use external auth" %></div>
-      <div class="border-bottom border-1 flex-grow-1"></div>
-    </div>
+    <%= render :partial => "shared/section_divider", :locals => { :text => t(".use external auth") } %>
     <%= render :partial => "auth_providers" %>
   <% end %>
 </div>
-- 
2.39.5