From 9ed6a9d779829757714f70313d29367db3821d85 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Sat, 31 Aug 2024 19:13:27 +0300 Subject: [PATCH] Fix page title for failed trace updates --- app/controllers/traces_controller.rb | 2 +- test/controllers/traces_controller_test.rb | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/app/controllers/traces_controller.rb b/app/controllers/traces_controller.rb index 02b553d0a..d723bac5b 100644 --- a/app/controllers/traces_controller.rb +++ b/app/controllers/traces_controller.rb @@ -143,7 +143,7 @@ class TracesController < ApplicationController flash[:notice] = t ".updated" redirect_to :action => "show", :display_name => current_user.display_name else - @title = t ".title", :name => @trace.name + @title = t "traces.edit.title", :name => @trace.name render :action => "edit" end rescue ActiveRecord::RecordNotFound diff --git a/test/controllers/traces_controller_test.rb b/test/controllers/traces_controller_test.rb index 972cbb3c3..c5f503d62 100644 --- a/test/controllers/traces_controller_test.rb +++ b/test/controllers/traces_controller_test.rb @@ -667,6 +667,17 @@ class TracesControllerTest < ActionDispatch::IntegrationTest assert_equal new_details[:visibility], trace.visibility end + # Test invalid updates + def test_update_invalid + trace = create(:trace) + + # Invalid visibility + session_for(trace.user) + put trace_path(trace, :trace => { :description => "Changed description", :tagstring => "new_tag", :visibility => "wrong" }) + assert_response :success + assert_select "title", :text => /^Editing Trace/ + end + # Test destroying a trace def test_destroy public_trace_file = create(:trace, :visibility => "public") -- 2.39.5