From aebac722c2e4cbd47dbdc6fc274f17bde1c9f320 Mon Sep 17 00:00:00 2001
From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 29 Mar 2023 16:43:58 +0100
Subject: [PATCH] Rework geocoder titles to avoid raw html in translations

---
 app/views/geocoder/search.html.erb |  5 ++++-
 config/locales/en.yml              | 10 +++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/app/views/geocoder/search.html.erb b/app/views/geocoder/search.html.erb
index ceb099421..86048b0ad 100644
--- a/app/views/geocoder/search.html.erb
+++ b/app/views/geocoder/search.html.erb
@@ -3,7 +3,10 @@
 <%= render "sidebar_header", :title => t("site.sidebar.search_results") %>
 
 <% @sources.each do |source| %>
-  <h4><%= t(".title.#{source}_html") %></h4>
+  <h4>
+    <%= t(".title.results_from_html", :results_link => link_to(t(".title.#{source}"),
+                                                               t(".title.#{source}_url"))) %>
+  </h4>
   <div class="search_results_entry mx-n3" data-href="<%= url_for @params.merge(:action => "search_#{source}") %>">
     <div class="text-center loader">
       <div class="spinner-border" role="status">
diff --git a/config/locales/en.yml b/config/locales/en.yml
index d64c11782..afc578b69 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -590,9 +590,13 @@ en:
   geocoder:
     search:
       title:
-        latlon_html: 'Results from <a href="https://openstreetmap.org/">Internal</a>'
-        osm_nominatim_html: 'Results from <a href="https://nominatim.openstreetmap.org/">OpenStreetMap Nominatim</a>'
-        osm_nominatim_reverse_html: 'Results from <a href="https://nominatim.openstreetmap.org/">OpenStreetMap Nominatim</a>'
+        results_from_html: 'Results from %{results_link}'
+        latlon: Internal
+        latlon_url: https://openstreetmap.org/
+        osm_nominatim: OpenStreetMap Nominatim
+        osm_nominatim_url: https://nominatim.openstreetmap.org/
+        osm_nominatim_reverse: OpenStreetMap Nominatim
+        osm_nominatim_reverse_url: https://nominatim.openstreetmap.org/
     search_osm_nominatim:
       prefix_format: "%{name}"
       prefix:
-- 
2.39.5