From bb5bad9115a014730575083a2bbc1be13e3bb49a Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Thu, 13 Feb 2025 03:03:36 +0300 Subject: [PATCH] Split api changeset comment unhide fail tests --- .../api/changeset_comments_controller_test.rb | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/test/controllers/api/changeset_comments_controller_test.rb b/test/controllers/api/changeset_comments_controller_test.rb index 8a1a286df..91b8ad683 100644 --- a/test/controllers/api/changeset_comments_controller_test.rb +++ b/test/controllers/api/changeset_comments_controller_test.rb @@ -321,30 +321,31 @@ module Api assert_not comment.reload.visible end - ## - # test unhide comment fail - def test_unhide_fail - # unauthorized + def test_unhide_by_unauthorized comment = create(:changeset_comment, :visible => false) - assert_not comment.visible post changeset_comment_unhide_path(comment) + assert_response :unauthorized assert_not comment.reload.visible + end + def test_unhide_by_normal_user + comment = create(:changeset_comment, :visible => false) auth_header = bearer_authorization_header - # not a moderator post changeset_comment_unhide_path(comment), :headers => auth_header + assert_response :forbidden assert_not comment.reload.visible + end + def test_unhide_missing_comment auth_header = bearer_authorization_header create(:moderator_user) - # bad comment id post changeset_comment_unhide_path(999111), :headers => auth_header + assert_response :not_found - assert_not comment.reload.visible end ## -- 2.39.5