From e22d19f004ee5c2db473717cc5bd57059a6203f5 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 10 Sep 2024 18:50:38 +0100 Subject: [PATCH 1/1] Limit the number of users counted for users#index This view uses cursor based pagination but then undermines that by counting the total number of users so limit the effect of that but counting a maximum of ten pages of users. --- app/controllers/users_controller.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 4ebeb1ec3..bc1baf8a5 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -38,7 +38,9 @@ class UsersController < ApplicationController users = users.where(:status => @params[:status]) if @params[:status] users = users.where(:creation_ip => @params[:ip]) if @params[:ip] - @users_count = users.count + @users_count = users.limit(501).count + @users_count = I18n.t("count.at_least_pattern", :count => 500) if @users_count > 500 + @users, @newer_users_id, @older_users_id = get_page_items(users, :limit => 50) render :partial => "page" if turbo_frame_request_id == "pagination" -- 2.39.5