From f6f23ed0ee63d1199e1aa2e0260b6c0c0fc0c21f Mon Sep 17 00:00:00 2001 From: Andreas Geyer-Schulz Date: Sat, 25 Jan 2020 20:10:23 +0100 Subject: [PATCH] Fix typo: change 'noreferer' to 'noreferrer' as the correct rel attribute in external links. --- config/initializers/sanitize.rb | 2 +- lib/rich_text.rb | 4 ++-- test/lib/rich_text_test.rb | 16 ++++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/config/initializers/sanitize.rb b/config/initializers/sanitize.rb index c7b7b3326..30fe37820 100644 --- a/config/initializers/sanitize.rb +++ b/config/initializers/sanitize.rb @@ -1,5 +1,5 @@ Sanitize::Config::OSM = Sanitize::Config::RELAXED.dup Sanitize::Config::OSM[:elements] -= %w[div style] -Sanitize::Config::OSM[:add_attributes] = { "a" => { "rel" => "nofollow noopener noreferer" } } +Sanitize::Config::OSM[:add_attributes] = { "a" => { "rel" => "nofollow noopener noreferrer" } } Sanitize::Config::OSM[:remove_contents] = %w[script style] diff --git a/lib/rich_text.rb b/lib/rich_text.rb index 1de7b882b..8950c6888 100644 --- a/lib/rich_text.rb +++ b/lib/rich_text.rb @@ -61,9 +61,9 @@ module RichText def linkify(text, mode = :urls) if text.html_safe? - Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferer")).html_safe + Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer")).html_safe else - Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferer")) + Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow noopener noreferrer")) end end end diff --git a/test/lib/rich_text_test.rb b/test/lib/rich_text_test.rb index e1603fb09..80cf0ae37 100644 --- a/test/lib/rich_text_test.rb +++ b/test/lib/rich_text_test.rb @@ -8,14 +8,14 @@ class RichTextTest < ActiveSupport::TestCase assert_html r do assert_select "a", 1 assert_select "a[href='http://example.com/']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("html", "foo bar baz") assert_html r do assert_select "a", 1 assert_select "a[href='http://example.com/']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("html", "foo example@example.com bar") @@ -27,7 +27,7 @@ class RichTextTest < ActiveSupport::TestCase assert_html r do assert_select "a", 1 assert_select "a[href='mailto:example@example.com']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("html", "foo
bar
baz") @@ -64,28 +64,28 @@ class RichTextTest < ActiveSupport::TestCase assert_html r do assert_select "a", 1 assert_select "a[href='http://example.com/']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("markdown", "foo [bar](http://example.com/) baz") assert_html r do assert_select "a", 1 assert_select "a[href='http://example.com/']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("markdown", "foo example@example.com bar") assert_html r do assert_select "a", 1 assert_select "a[href='mailto:example@example.com']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("markdown", "foo [bar](mailto:example@example.com) bar") assert_html r do assert_select "a", 1 assert_select "a[href='mailto:example@example.com']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("markdown", "foo ![bar](http://example.com/example.png) bar") @@ -162,7 +162,7 @@ class RichTextTest < ActiveSupport::TestCase assert_html r do assert_select "a", 1 assert_select "a[href='http://example.com/']", 1 - assert_select "a[rel='nofollow noopener noreferer']", 1 + assert_select "a[rel='nofollow noopener noreferrer']", 1 end r = RichText.new("text", "foo example@example.com bar") -- 2.39.5