Update rubocop

diff --git a/Gemfile b/Gemfile
index 31e34a999989e34291a85be93550734b43996c2b..b701698701ae715aba9cfc4226332e28f89741e3 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
 source "https://rubygems.org"
 

-gem "rubocop"

 gem "foodcritic"
 gem "foodcritic"

-gem "test-kitchen"

 gem "kitchen-vagrant"
 gem "kitchen-vagrant"

+gem "rubocop"

 gem "serverspec"
 gem "serverspec"

+gem "test-kitchen"

diff --git a/Gemfile.lock b/Gemfile.lock
index 94acd759210a0e68513b7ccc0661b0c67b4c5a5f..54dd6453205a267bf00777aa665e5f822b20a975 100644 (file)
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -37,11 +37,11 @@ GEM
     net-telnet (0.1.1)
     nokogiri (1.6.8.1)
       mini_portile2 (~> 2.1.0)
     net-telnet (0.1.1)
     nokogiri (1.6.8.1)
       mini_portile2 (~> 2.1.0)

-    parser (2.3.1.4)
+    parser (2.3.3.1)

       ast (~> 2.2)
     polyglot (0.3.5)
     powerpack (0.1.1)
       ast (~> 2.2)
     polyglot (0.3.5)
     powerpack (0.1.1)

-    rainbow (2.1.0)
+    rainbow (2.2.1)

     rake (11.3.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
     rake (11.3.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)


@@ -59,8 +59,8 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)

-    rubocop (0.45.0)
-      parser (>= 2.3.1.1, < 3.0)
+    rubocop (0.47.1)
+      parser (>= 2.3.3.1, < 3.0)

       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)


@@ -90,7 +90,7 @@ GEM
     thor (0.19.1)
     treetop (1.6.8)
       polyglot (~> 0.3)
     thor (0.19.1)
     treetop (1.6.8)
       polyglot (~> 0.3)

-    unicode-display_width (1.1.1)
+    unicode-display_width (1.1.3)

     yajl-ruby (1.3.0)
 
 PLATFORMS
     yajl-ruby (1.3.0)
 
 PLATFORMS

diff --git a/cookbooks/imagery/resources/site.rb b/cookbooks/imagery/resources/site.rb
index d0f51a0a6b3430bde89d06232e88bbbbe5a3018f..2bebd0c75c5242012f8118977fe93efdd049e077 100644 (file)
--- a/cookbooks/imagery/resources/site.rb
+++ b/cookbooks/imagery/resources/site.rb
@@ -77,7 +77,7 @@ action :create do
   end
 
   layers = Dir.glob("/srv/imagery/layers/#{name}/*.yml").collect do |path|
   end
 
   layers = Dir.glob("/srv/imagery/layers/#{name}/*.yml").collect do |path|

-    YAML.load(::File.read(path))
+    YAML.safe_load(::File.read(path))

   end
 
   template "/srv/#{name}/imagery.js" do
   end
 
   template "/srv/#{name}/imagery.js" do

diff --git a/cookbooks/kibana/recipes/default.rb b/cookbooks/kibana/recipes/default.rb
index e4dd05c9fee5c98977fc8c660cecb3a98a3a64e0..160d3233c610b1abeed110ba304484785ebebb58 100644 (file)
--- a/cookbooks/kibana/recipes/default.rb
+++ b/cookbooks/kibana/recipes/default.rb
@@ -73,7 +73,7 @@ end
 
 node[:kibana][:sites].each do |name, details|
   file "/etc/kibana/#{name}.yml" do
 
 node[:kibana][:sites].each do |name, details|
   file "/etc/kibana/#{name}.yml" do

-    content YAML.dump(YAML.load(File.read("/opt/kibana-#{version}/config/kibana.yml")).merge(
+    content YAML.dump(YAML.safe_load(File.read("/opt/kibana-#{version}/config/kibana.yml")).merge(

                         "port" => details[:port],
                         "host" => "127.0.0.1",
                         "elasticsearch_url" => details[:elasticsearch_url],
                         "port" => details[:port],
                         "host" => "127.0.0.1",
                         "elasticsearch_url" => details[:elasticsearch_url],

diff --git a/cookbooks/planet/files/default/replication-bin/replicate-changesets b/cookbooks/planet/files/default/replication-bin/replicate-changesets
index 9e16151471b5a695f5d3cd858d6056268e9f6b06..8c943902a8e91ad7d2869e9e8eb8182b429f7949 100644 (file)
--- a/cookbooks/planet/files/default/replication-bin/replicate-changesets
+++ b/cookbooks/planet/files/default/replication-bin/replicate-changesets
@@ -141,8 +141,8 @@ end
 # replicated to a file.
 class Replicator
   def initialize(config)
 # replicated to a file.
 class Replicator
   def initialize(config)

-    @config = YAML.load(File.read(config))
-    @state = YAML.load(File.read(@config["state_file"]))
+    @config = YAML.safe_load(File.read(config))
+    @state = YAML.safe_load(File.read(@config["state_file"]))

     @conn = PGconn.connect(@config["db"])
     # get current time from the database rather than the current system
     @now = @conn.exec("select now() as now").map { |row| Time.parse(row["now"]) }[0]
     @conn = PGconn.connect(@config["db"])
     # get current time from the database rather than the current system
     @now = @conn.exec("select now() as now").map { |row| Time.parse(row["now"]) }[0]