Try to make mediawiki installation and update more robust

diff --git a/cookbooks/mediawiki/resources/extension.rb b/cookbooks/mediawiki/resources/extension.rb
index 4e44f18c2ad426fd8d81c810d137e58bebcc7701..6240f6e87d008c1624d5497c6f2da6595499af61 100644 (file)
--- a/cookbooks/mediawiki/resources/extension.rb
+++ b/cookbooks/mediawiki/resources/extension.rb
@@ -84,17 +84,6 @@ action :create do
       mode "664"
     end
   end
       mode "664"
     end
   end

-
-  execute "#{extension_directory}/composer.json" do
-    action :nothing
-    command "composer update --no-dev"
-    cwd mediawiki_directory
-    user node[:mediawiki][:user]
-    group node[:mediawiki][:group]
-    environment "COMPOSER_HOME" => site_directory
-    only_if { ::File.exist?("#{extension_directory}/composer.json") }
-    subscribes :run, "git[#{extension_directory}]"
-  end

 end
 
 action :delete do
 end
 
 action :delete do


@@ -131,12 +120,5 @@ action_class do
 end
 
 def after_created
 end
 
 def after_created

-  if update_site
-    notifies :update, "mediawiki_site[#{site}]"
-  else
-    site_directory = node[:mediawiki][:sites][site][:directory]
-
-    notifies :create, "template[#{site_directory}/w/LocalSettings.php]"
-    notifies :run, "execute[#{site_directory}/w/maintenance/update.php]"
-  end
+  notifies :update, "mediawiki_site[#{site}]" if update_site

 end
 end

diff --git a/cookbooks/mediawiki/resources/site.rb b/cookbooks/mediawiki/resources/site.rb
index 8be994ee3b1ae9af81f3791698b4755f06c1c4ba..f27c150f574aab13d403ac47ce35c85ce37371ef 100644 (file)
--- a/cookbooks/mediawiki/resources/site.rb
+++ b/cookbooks/mediawiki/resources/site.rb
@@ -59,8 +59,6 @@ action :create do
     :version => new_resource.version
   }
 
     :version => new_resource.version
   }
 

-  secret_key = persistent_token("mediawiki", new_resource.site, "wgSecretKey")
-

   mysql_user "#{new_resource.database_user}@localhost" do
     password new_resource.database_password
   end
   mysql_user "#{new_resource.database_user}@localhost" do
     password new_resource.database_password
   end


@@ -71,13 +69,6 @@ action :create do
 
   mediawiki_directory = "#{site_directory}/w"
 
 
   mediawiki_directory = "#{site_directory}/w"
 

-  ruby_block "rename-installer-localsettings" do
-    action :nothing
-    block do
-      ::File.rename("#{mediawiki_directory}/LocalSettings.php", "#{mediawiki_directory}/LocalSettings-install.php")
-    end
-  end
-

   declare_resource :directory, site_directory do
     owner node[:mediawiki][:user]
     group node[:mediawiki][:group]
   declare_resource :directory, site_directory do
     owner node[:mediawiki][:user]
     group node[:mediawiki][:group]


@@ -97,9 +88,6 @@ action :create do
     depth 1
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]
     depth 1
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]

-    notifies :run, "execute[#{mediawiki_directory}/composer.json]", :immediately
-    notifies :run, "execute[#{mediawiki_directory}/maintenance/install.php]", :immediately
-    notifies :run, "execute[#{mediawiki_directory}/maintenance/update.php]"

   end
 
   template "#{mediawiki_directory}/composer.local.json" do
   end
 
   template "#{mediawiki_directory}/composer.local.json" do


@@ -111,44 +99,21 @@ action :create do
   end
 
   execute "#{mediawiki_directory}/composer.json" do
   end
 
   execute "#{mediawiki_directory}/composer.json" do

-    action :nothing

     command "composer update --no-dev"
     cwd mediawiki_directory
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]
     environment "COMPOSER_HOME" => site_directory
     command "composer update --no-dev"
     cwd mediawiki_directory
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]
     environment "COMPOSER_HOME" => site_directory

+    not_if { ::File.exist?("#{mediawiki_directory}/composer.lock") }

   end
 
   execute "#{mediawiki_directory}/maintenance/install.php" do
   end
 
   execute "#{mediawiki_directory}/maintenance/install.php" do

-    action :nothing

     # Use metanamespace as Site Name to ensure correct set namespace
     command "php maintenance/install.php --server '#{name}' --dbtype 'mysql' --dbname '#{new_resource.database_name}' --dbuser '#{new_resource.database_user}' --dbpass '#{new_resource.database_password}' --dbserver 'localhost' --scriptpath /w --pass '#{new_resource.admin_password}' '#{new_resource.metanamespace}' '#{new_resource.admin_user}'"
     cwd mediawiki_directory
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]
     # Use metanamespace as Site Name to ensure correct set namespace
     command "php maintenance/install.php --server '#{name}' --dbtype 'mysql' --dbname '#{new_resource.database_name}' --dbuser '#{new_resource.database_user}' --dbpass '#{new_resource.database_password}' --dbserver 'localhost' --scriptpath /w --pass '#{new_resource.admin_password}' '#{new_resource.metanamespace}' '#{new_resource.admin_user}'"
     cwd mediawiki_directory
     user node[:mediawiki][:user]
     group node[:mediawiki][:group]

-    not_if do
-      ::File.exist?("#{mediawiki_directory}/LocalSettings-install.php")
-    end
-    notifies :run, "ruby_block[rename-installer-localsettings]", :immediately
-  end
-
-  execute "#{mediawiki_directory}/maintenance/update.php" do
-    action :nothing
-    command "php maintenance/update.php --quick"
-    cwd mediawiki_directory
-    user node[:mediawiki][:user]
-    group node[:mediawiki][:group]
-  end
-
-  # Safety catch if git doesn't update but install.php hasn't run
-  ruby_block "catch-installer-localsettings-run" do
-    action :run
-    block do
-    end
-    not_if do
-      ::File.exist?("#{mediawiki_directory}/LocalSettings-install.php")
-    end
-    notifies :run, "execute[#{mediawiki_directory}/maintenance/install.php]", :immediately
+    not_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   declare_resource :directory, "#{mediawiki_directory}/images" do
   end
 
   declare_resource :directory, "#{mediawiki_directory}/images" do


@@ -180,23 +145,26 @@ action :create do
               :database_params => database_params,
               :mediawiki => mediawiki_params,
               :secret_key => secret_key
               :database_params => database_params,
               :mediawiki => mediawiki_params,
               :secret_key => secret_key

-    notifies :run, "execute[#{mediawiki_directory}/maintenance/update.php]"

   end
 
   service "mediawiki-sitemap@#{new_resource.site}.timer" do
     action [:enable, :start]
   end
 
   service "mediawiki-sitemap@#{new_resource.site}.timer" do
     action [:enable, :start]

+    only_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   service "mediawiki-jobs@#{new_resource.site}.timer" do
     action [:enable, :start]
   end
 
   service "mediawiki-jobs@#{new_resource.site}.timer" do
     action [:enable, :start]

+    only_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   service "mediawiki-email-jobs@#{new_resource.site}.timer" do
     action [:enable, :start]
   end
 
   service "mediawiki-email-jobs@#{new_resource.site}.timer" do
     action [:enable, :start]

+    only_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   service "mediawiki-refresh-links@#{new_resource.site}.timer" do
     action [:enable, :start]
   end
 
   service "mediawiki-refresh-links@#{new_resource.site}.timer" do
     action [:enable, :start]

+    only_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   template "/etc/cron.daily/mediawiki-#{cron_name}-backup" do
   end
 
   template "/etc/cron.daily/mediawiki-#{cron_name}-backup" do


@@ -208,12 +176,14 @@ action :create do
     variables :name => new_resource.site,
               :directory => site_directory,
               :database_params => database_params
     variables :name => new_resource.site,
               :directory => site_directory,
               :database_params => database_params

+    only_if { ::File.exist?("#{mediawiki_directory}/LocalSettings.php") }

   end
 
   # MobileFrontend extension is required by MinervaNeue skin
   mediawiki_extension "MobileFrontend" do
     site new_resource.site
     template "mw-ext-MobileFrontend.inc.php.erb"
   end
 
   # MobileFrontend extension is required by MinervaNeue skin
   mediawiki_extension "MobileFrontend" do
     site new_resource.site
     template "mw-ext-MobileFrontend.inc.php.erb"

+    update_site false

   end
 
   # MobileFrontend extension is required by MinervaNeue skin
   end
 
   # MobileFrontend extension is required by MinervaNeue skin


@@ -534,6 +504,14 @@ end
 action :update do
   mediawiki_directory = "#{site_directory}/w"
 
 action :update do
   mediawiki_directory = "#{site_directory}/w"
 

+  execute "#{mediawiki_directory}/composer.json" do
+    command "composer update --no-dev"
+    cwd mediawiki_directory
+    user node[:mediawiki][:user]
+    group node[:mediawiki][:group]
+    environment "COMPOSER_HOME" => site_directory
+  end
+

   template "#{mediawiki_directory}/LocalSettings.php" do
     cookbook "mediawiki"
     source "LocalSettings.php.erb"
   template "#{mediawiki_directory}/LocalSettings.php" do
     cookbook "mediawiki"
     source "LocalSettings.php.erb"


@@ -543,8 +521,8 @@ action :update do
     variables :name => new_resource.site,
               :directory => mediawiki_directory,
               :database_params => database_params,
     variables :name => new_resource.site,
               :directory => mediawiki_directory,
               :database_params => database_params,

-              :mediawiki => mediawiki_params
-    notifies :run, "execute[#{mediawiki_directory}/maintenance/update.php]"
+              :mediawiki => mediawiki_params,
+              :secret_key => secret_key

   end
 
   execute "#{mediawiki_directory}/maintenance/update.php" do
   end
 
   execute "#{mediawiki_directory}/maintenance/update.php" do


@@ -624,8 +602,13 @@ action_class do
       :private_site => new_resource.private_site
     }
   end
       :private_site => new_resource.private_site
     }
   end

+
+  def secret_key
+    persistent_token("mediawiki", new_resource.site, "wgSecretKey")
+  end

 end
 
 def after_created
 end
 
 def after_created

+  notifies :update, "mediawiki_site[#{site}]"

   notifies :reload, "service[apache2]" if reload_apache
 end
   notifies :reload, "service[apache2]" if reload_apache
 end

diff --git a/cookbooks/mediawiki/resources/skin.rb b/cookbooks/mediawiki/resources/skin.rb
index 3153fa91a772b37b4e15b682015e782f89f81be6..15ab639464f815380fe87e69be06e4e848d4bfea 100644 (file)
--- a/cookbooks/mediawiki/resources/skin.rb
+++ b/cookbooks/mediawiki/resources/skin.rb
@@ -121,12 +121,5 @@ action_class do
 end
 
 def after_created
 end
 
 def after_created

-  if update_site
-    notifies :update, "mediawiki_site[#{site}]"
-  else
-    site_directory = node[:mediawiki][:sites][site][:directory]
-
-    notifies :create, "template[#{site_directory}/w/LocalSettings.php]"
-    notifies :run, "execute[#{site_directory}/w/maintenance/update.php]"
-  end
+  notifies :update, "mediawiki_site[#{site}]" if update_site

 end
 end