cleanup API request URL from unset parameters

diff --git a/TODO.md b/TODO.md
index 22d3fd448346f230e3c9e3421c6f4b21eaf6694a..346e664fe2e866e92e8358919eadd14b1e42fba6 100644 (file)
--- a/TODO.md
+++ b/TODO.md
@@ -34,7 +34,6 @@ http://localhost:8000/reverse.html?format=html&lat=52.3755991766591&lon=7.646484
 
 ## Nice-to-have
 
 
 ## Nice-to-have
 

-* don't show unset parameters in URL, e.g. `&a=&b=&c=1` => '&c='

 * different content for official OSM, e.g. github urls
 * set HTML title
 * cache `update_data_date` result
 * different content for official OSM, e.g. github urls
 * set HTML title
 * cache `update_data_date` result

diff --git a/src/assets/js/base.js b/src/assets/js/base.js
index 02c228ace139c9d402b9f56ce1162df528d04e07..2aed93b998bfbcd7cf9e141ceab732e4b984a683 100644 (file)
--- a/src/assets/js/base.js
+++ b/src/assets/js/base.js
@@ -46,6 +46,12 @@ function map_viewbox_as_string() {
 *********************************************************/
 
 function fetch_from_api(endpoint_name, params, callback) {
 *********************************************************/
 
 function fetch_from_api(endpoint_name, params, callback) {

+
+    // `&a=&b=&c=1` => '&c='
+    for(var k in params) {
+        if (typeof(params[k]) === 'undefined' || params[k] === '' || params[k] === null ) delete params[k];
+    }
+

     var api_url = get_config_value('Nominatim_API_Endpoint') + endpoint_name + '.php?' + $.param(params);
     if (endpoint_name !== 'status') {
         $('#api-request-link').attr('href', api_url);
     var api_url = get_config_value('Nominatim_API_Endpoint') + endpoint_name + '.php?' + $.param(params);
     if (endpoint_name !== 'status') {
         $('#api-request-link').attr('href', api_url);