]> git.openstreetmap.org Git - nominatim.git/blob - test/python/test_tools_postcodes.py
add and extend tests for new postcode handling
[nominatim.git] / test / python / test_tools_postcodes.py
1 """
2 Tests for functions to maintain the artificial postcode table.
3 """
4 import subprocess
5
6 import pytest
7
8 from nominatim.tools import postcodes
9 import dummy_tokenizer
10
11 class MockPostcodeTable:
12     """ A location_postcode table for testing.
13     """
14     def __init__(self, conn):
15         self.conn = conn
16         with conn.cursor() as cur:
17             cur.execute("""CREATE TABLE location_postcode (
18                                place_id BIGINT,
19                                parent_place_id BIGINT,
20                                rank_search SMALLINT,
21                                rank_address SMALLINT,
22                                indexed_status SMALLINT,
23                                indexed_date TIMESTAMP,
24                                country_code varchar(2),
25                                postcode TEXT,
26                                geometry GEOMETRY(Geometry, 4326))""")
27             cur.execute("""CREATE OR REPLACE FUNCTION token_normalized_postcode(postcode TEXT)
28                            RETURNS TEXT AS $$ BEGIN RETURN postcode; END; $$ LANGUAGE plpgsql;
29                         """)
30         conn.commit()
31
32     def add(self, country, postcode, x, y):
33         with self.conn.cursor() as cur:
34             cur.execute("""INSERT INTO location_postcode (place_id, indexed_status,
35                                                           country_code, postcode,
36                                                           geometry)
37                            VALUES (nextval('seq_place'), 1, %s, %s,
38                                    'SRID=4326;POINT(%s %s)')""",
39                         (country, postcode, x, y))
40         self.conn.commit()
41
42
43     @property
44     def row_set(self):
45         with self.conn.cursor() as cur:
46             cur.execute("""SELECT country_code, postcode,
47                                   ST_X(geometry), ST_Y(geometry)
48                            FROM location_postcode""")
49             return set((tuple(row) for row in cur))
50
51
52 @pytest.fixture
53 def tokenizer():
54     return dummy_tokenizer.DummyTokenizer(None, None)
55
56 @pytest.fixture
57 def postcode_table(temp_db_conn, placex_table, word_table):
58     return MockPostcodeTable(temp_db_conn)
59
60
61 def test_import_postcodes_empty(dsn, postcode_table, tmp_path, tokenizer):
62     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
63
64     assert not postcode_table.row_set
65
66
67 def test_import_postcodes_add_new(dsn, placex_table, postcode_table, tmp_path, tokenizer):
68     placex_table.add(country='xx', geom='POINT(10 12)',
69                      address=dict(postcode='9486'))
70     postcode_table.add('yy', '9486', 99, 34)
71
72     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
73
74     assert postcode_table.row_set == {('xx', '9486', 10, 12),
75                                       ('yy', '9486', 99, 34)}
76
77
78 def test_import_postcodes_replace_coordinates(dsn, placex_table, postcode_table, tmp_path, tokenizer):
79     placex_table.add(country='xx', geom='POINT(10 12)',
80                      address=dict(postcode='AB 4511'))
81     postcode_table.add('xx', 'AB 4511', 99, 34)
82
83     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
84
85     assert postcode_table.row_set == {('xx', 'AB 4511', 10, 12)}
86
87
88 def test_import_postcodes_replace_coordinates_close(dsn, placex_table, postcode_table, tmp_path, tokenizer):
89     placex_table.add(country='xx', geom='POINT(10 12)',
90                      address=dict(postcode='AB 4511'))
91     postcode_table.add('xx', 'AB 4511', 10, 11.99999)
92
93     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
94
95     assert postcode_table.row_set == {('xx', 'AB 4511', 10, 11.99999)}
96
97
98 def test_import_postcodes_remove(dsn, placex_table, postcode_table, tmp_path, tokenizer):
99     placex_table.add(country='xx', geom='POINT(10 12)',
100                      address=dict(postcode='AB 4511'))
101     postcode_table.add('xx', 'badname', 10, 12)
102
103     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
104
105     assert postcode_table.row_set == {('xx', 'AB 4511', 10, 12)}
106
107
108 def test_import_postcodes_multi_country(dsn, placex_table, postcode_table, tmp_path, tokenizer):
109     placex_table.add(country='de', geom='POINT(10 12)',
110                      address=dict(postcode='54451'))
111     placex_table.add(country='cc', geom='POINT(100 56)',
112                      address=dict(postcode='DD23 T'))
113     placex_table.add(country='de', geom='POINT(10.3 11.0)',
114                      address=dict(postcode='54452'))
115     placex_table.add(country='cc', geom='POINT(10.3 11.0)',
116                      address=dict(postcode='54452'))
117
118     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
119
120     assert postcode_table.row_set == {('de', '54451', 10, 12),
121                                       ('de', '54452', 10.3, 11.0),
122                                       ('cc', '54452', 10.3, 11.0),
123                                       ('cc', 'DD23 T', 100, 56)}
124
125
126 @pytest.mark.parametrize("gzipped", [True, False])
127 def test_import_postcodes_extern(dsn, placex_table, postcode_table, tmp_path,
128                                  tokenizer, gzipped):
129     placex_table.add(country='xx', geom='POINT(10 12)',
130                      address=dict(postcode='AB 4511'))
131
132     extfile = tmp_path / 'xx_postcodes.csv'
133     extfile.write_text("postcode,lat,lon\nAB 4511,-4,-1\nCD 4511,-5, -10")
134
135     if gzipped:
136         subprocess.run(['gzip', str(extfile)])
137         assert not extfile.is_file()
138
139     postcodes.update_postcodes(dsn, tmp_path, tokenizer)
140
141     assert postcode_table.row_set == {('xx', 'AB 4511', 10, 12),
142                                       ('xx', 'CD 4511', -10, -5)}
143