]> git.openstreetmap.org Git - nominatim.git/commitdiff
Merge remote-tracking branch 'upstream/master'
authorSarah Hoffmann <lonvia@denofr.de>
Tue, 24 Oct 2017 21:33:35 +0000 (23:33 +0200)
committerSarah Hoffmann <lonvia@denofr.de>
Tue, 24 Oct 2017 21:33:35 +0000 (23:33 +0200)
1  2 
lib/Geocode.php
lib/lib.php
lib/template/includes/introduction.php
website/reverse.php

diff --combined lib/Geocode.php
index 306255b59079968104e5665d5f4b255f2527a609,496a3c6be48274154b796d2da99a251aac77acd2..97fc6371a0faec22eadb00a53dcbd646c4bbaa21
@@@ -12,22 -12,14 +12,14 @@@ class Geocod
  {
      protected $oDB;
  
+     protected $oPlaceLookup;
      protected $aLangPrefOrder = array();
  
      protected $bIncludeAddressDetails = false;
-     protected $bIncludeExtraTags = false;
-     protected $bIncludeNameDetails = false;
-     protected $bIncludePolygonAsPoints = false;
-     protected $bIncludePolygonAsText = false;
-     protected $bIncludePolygonAsGeoJSON = false;
-     protected $bIncludePolygonAsKML = false;
-     protected $bIncludePolygonAsSVG = false;
-     protected $fPolygonSimplificationThreshold = 0.0;
  
      protected $aExcludePlaceIDs = array();
-     protected $bDeDupe = true;
 -    protected $bReverseInPlan = false;
 +    protected $bReverseInPlan = true;
  
      protected $iLimit = 20;
      protected $iFinalLimit = 10;
@@@ -45,7 -37,6 +37,6 @@@
      protected $iMinAddressRank = 0;
      protected $iMaxAddressRank = 30;
      protected $aAddressRankList = array();
-     protected $exactMatchCache = array();
  
      protected $sAllowedTypesSQLList = false;
  
@@@ -58,6 -49,7 +49,7 @@@
      public function __construct(&$oDB)
      {
          $this->oDB =& $oDB;
+         $this->oPlaceLookup = new PlaceLookup($this->oDB);
          $this->oNormalizer = \Transliterator::createFromRules(CONST_Term_Normalization_Rules);
      }
  
              $aParams = array('q' => $this->sQuery);
          }
  
+         $aParams = array_merge($aParams, $this->oPlaceLookup->getMoreUrlParams());
          if ($this->aExcludePlaceIDs) {
              $aParams['exclude_place_ids'] = implode(',', $this->aExcludePlaceIDs);
          }
  
          if ($this->bIncludeAddressDetails) $aParams['addressdetails'] = '1';
-         if ($this->bIncludeExtraTags) $aParams['extratags'] = '1';
-         if ($this->bIncludeNameDetails) $aParams['namedetails'] = '1';
-         if ($this->bIncludePolygonAsPoints) $aParams['polygon'] = '1';
-         if ($this->bIncludePolygonAsText) $aParams['polygon_text'] = '1';
-         if ($this->bIncludePolygonAsGeoJSON) $aParams['polygon_geojson'] = '1';
-         if ($this->bIncludePolygonAsKML) $aParams['polygon_kml'] = '1';
-         if ($this->bIncludePolygonAsSVG) $aParams['polygon_svg'] = '1';
-         if ($this->fPolygonSimplificationThreshold > 0.0) {
-             $aParams['polygon_threshold'] = $this->fPolygonSimplificationThreshold;
-         }
          if ($this->bBoundedSearch) $aParams['bounded'] = '1';
-         if (!$this->bDeDupe) $aParams['dedupe'] = '0';
  
          if ($this->aCountryCodes) {
              $aParams['countrycodes'] = implode(',', $this->aCountryCodes);
          }
  
          if ($this->aViewBox) {
-             $aParams['viewbox'] = $this->aViewBox[0].','.$this->aViewBox[3]
-                                   .','.$this->aViewBox[2].','.$this->aViewBox[1];
+             $aParams['viewbox'] = join(',', $this->aViewBox);
          }
  
          return $aParams;
      }
  
-     public function setIncludePolygonAsPoints($b = true)
-     {
-         $this->bIncludePolygonAsPoints = $b;
-     }
-     public function setIncludePolygonAsText($b = true)
-     {
-         $this->bIncludePolygonAsText = $b;
-     }
-     public function setIncludePolygonAsGeoJSON($b = true)
-     {
-         $this->bIncludePolygonAsGeoJSON = $b;
-     }
-     public function setIncludePolygonAsKML($b = true)
-     {
-         $this->bIncludePolygonAsKML = $b;
-     }
-     public function setIncludePolygonAsSVG($b = true)
-     {
-         $this->bIncludePolygonAsSVG = $b;
-     }
-     public function setPolygonSimplificationThreshold($f)
-     {
-         $this->fPolygonSimplificationThreshold = $f;
-     }
      public function setLimit($iLimit = 10)
      {
          if ($iLimit > 50) $iLimit = 50;
  
      public function setViewbox($aViewbox)
      {
-         $this->aViewBox = array_map('floatval', $aViewbox);
+         $aBox = array_map('floatval', $aViewbox);
  
-         $this->aViewBox[0] = max(-180.0, min(180, $this->aViewBox[0]));
-         $this->aViewBox[1] = max(-90.0, min(90, $this->aViewBox[1]));
-         $this->aViewBox[2] = max(-180.0, min(180, $this->aViewBox[2]));
-         $this->aViewBox[3] = max(-90.0, min(90, $this->aViewBox[3]));
+         $this->aViewBox[0] = max(-180.0, min($aBox[0], $aBox[2]));
+         $this->aViewBox[1] = max(-90.0, min($aBox[1], $aBox[3]));
+         $this->aViewBox[2] = min(180.0, max($aBox[0], $aBox[2]));
+         $this->aViewBox[3] = min(90.0, max($aBox[1], $aBox[3]));
  
-         if (abs($this->aViewBox[0] - $this->aViewBox[2]) < 0.000000001
-             || abs($this->aViewBox[1] - $this->aViewBox[3]) < 0.000000001
+         if ($this->aViewBox[2] - $this->aViewBox[0] < 0.000000001
+             || $this->aViewBox[3] - $this->aViewBox[1] < 0.000000001
          ) {
              userError("Bad parameter 'viewbox'. Not a box.");
          }
      }
  
+     private function viewboxImportanceFactor($fX, $fY)
+     {
+         $fWidth = ($this->aViewBox[2] - $this->aViewBox[0])/2;
+         $fHeight = ($this->aViewBox[3] - $this->aViewBox[1])/2;
+         $fXDist = abs($fX - ($this->aViewBox[0] + $this->aViewBox[2])/2);
+         $fYDist = abs($fY - ($this->aViewBox[1] + $this->aViewBox[3])/2);
+         if ($fXDist <= $fWidth && $fYDist <= $fHeight) {
+             return 1;
+         }
+         if ($fXDist <= $fWidth * 3 && $fYDist <= 3 * $fHeight) {
+             return 0.5;
+         }
+         return 0.25;
+     }
      public function setQuery($sQueryString)
      {
          $this->sQuery = $sQueryString;
      }
  
  
-     public function loadParamArray($oParams)
+     public function loadParamArray($oParams, $sForceGeometryType = null)
      {
          $this->bIncludeAddressDetails
           = $oParams->getBool('addressdetails', $this->bIncludeAddressDetails);
-         $this->bIncludeExtraTags
-          = $oParams->getBool('extratags', $this->bIncludeExtraTags);
-         $this->bIncludeNameDetails
-          = $oParams->getBool('namedetails', $this->bIncludeNameDetails);
  
          $this->bBoundedSearch = $oParams->getBool('bounded', $this->bBoundedSearch);
-         $this->bDeDupe = $oParams->getBool('dedupe', $this->bDeDupe);
  
          $this->setLimit($oParams->getInt('limit', $this->iFinalLimit));
          $this->iOffset = $oParams->getInt('offset', $this->iOffset);
                  }
              }
          }
+         $this->oPlaceLookup->loadParamArray($oParams, $sForceGeometryType);
+         $this->oPlaceLookup->setIncludeAddressDetails(false);
+         $this->oPlaceLookup->setIncludePolygonAsPoints($oParams->getBool('polygon'));
      }
  
      public function setQueryFromParams($oParams)
          return false;
      }
  
-     public function getDetails($aPlaceIDs, $oCtx)
-     {
-         //$aPlaceIDs is an array with key: placeID and value: tiger-housenumber, if found, else -1
-         if (sizeof($aPlaceIDs) == 0) return array();
-         $sLanguagePrefArraySQL = getArraySQL(
-             array_map("getDBQuoted", $this->aLangPrefOrder)
-         );
-         // Get the details for display (is this a redundant extra step?)
-         $sPlaceIDs = join(',', array_keys($aPlaceIDs));
-         $sImportanceSQL = $oCtx->viewboxImportanceSQL('ST_Collect(centroid)');
-         $sImportanceSQLGeom = $oCtx->viewboxImportanceSQL('geometry');
-         $sSQL  = "SELECT ";
-         $sSQL .= "    osm_type,";
-         $sSQL .= "    osm_id,";
-         $sSQL .= "    class,";
-         $sSQL .= "    type,";
-         $sSQL .= "    admin_level,";
-         $sSQL .= "    rank_search,";
-         $sSQL .= "    rank_address,";
-         $sSQL .= "    min(place_id) AS place_id, ";
-         $sSQL .= "    min(parent_place_id) AS parent_place_id, ";
-         $sSQL .= "    country_code, ";
-         $sSQL .= "    get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) AS langaddress,";
-         $sSQL .= "    get_name_by_language(name, $sLanguagePrefArraySQL) AS placename,";
-         $sSQL .= "    get_name_by_language(name, ARRAY['ref']) AS ref,";
-         if ($this->bIncludeExtraTags) $sSQL .= "hstore_to_json(extratags)::text AS extra,";
-         if ($this->bIncludeNameDetails) $sSQL .= "hstore_to_json(name)::text AS names,";
-         $sSQL .= "    avg(ST_X(centroid)) AS lon, ";
-         $sSQL .= "    avg(ST_Y(centroid)) AS lat, ";
-         $sSQL .= "    COALESCE(importance,0.75-(rank_search::float/40)) $sImportanceSQL AS importance, ";
-         if ($oCtx->hasNearPoint()) {
-             $sSQL .= $oCtx->distanceSQL('ST_Collect(centroid)')." AS addressimportance,";
-         } else {
-             $sSQL .= "    ( ";
-             $sSQL .= "       SELECT max(p.importance*(p.rank_address+2))";
-             $sSQL .= "       FROM ";
-             $sSQL .= "         place_addressline s, ";
-             $sSQL .= "         placex p";
-             $sSQL .= "       WHERE s.place_id = min(CASE WHEN placex.rank_search < 28 THEN placex.place_id ELSE placex.parent_place_id END)";
-             $sSQL .= "         AND p.place_id = s.address_place_id ";
-             $sSQL .= "         AND s.isaddress ";
-             $sSQL .= "         AND p.importance is not null ";
-             $sSQL .= "    ) AS addressimportance, ";
-         }
-         $sSQL .= "    (extratags->'place') AS extra_place ";
-         $sSQL .= " FROM placex";
-         $sSQL .= " WHERE place_id in ($sPlaceIDs) ";
-         $sSQL .= "   AND (";
-         $sSQL .= "            placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
-         if (14 >= $this->iMinAddressRank && 14 <= $this->iMaxAddressRank) {
-             $sSQL .= "        OR (extratags->'place') = 'city'";
-         }
-         if ($this->aAddressRankList) {
-             $sSQL .= "        OR placex.rank_address in (".join(',', $this->aAddressRankList).")";
-         }
-         $sSQL .= "       ) ";
-         if ($this->sAllowedTypesSQLList) {
-             $sSQL .= "AND placex.class in $this->sAllowedTypesSQLList ";
-         }
-         $sSQL .= "    AND linked_place_id is null ";
-         $sSQL .= " GROUP BY ";
-         $sSQL .= "     osm_type, ";
-         $sSQL .= "     osm_id, ";
-         $sSQL .= "     class, ";
-         $sSQL .= "     type, ";
-         $sSQL .= "     admin_level, ";
-         $sSQL .= "     rank_search, ";
-         $sSQL .= "     rank_address, ";
-         $sSQL .= "     country_code, ";
-         $sSQL .= "     importance, ";
-         if (!$this->bDeDupe) $sSQL .= "place_id,";
-         $sSQL .= "     langaddress, ";
-         $sSQL .= "     placename, ";
-         $sSQL .= "     ref, ";
-         if ($this->bIncludeExtraTags) $sSQL .= "extratags, ";
-         if ($this->bIncludeNameDetails) $sSQL .= "name, ";
-         $sSQL .= "     extratags->'place' ";
-         // postcode table
-         $sSQL .= "UNION ";
-         $sSQL .= "SELECT";
-         $sSQL .= "  'P' as osm_type,";
-         $sSQL .= "  (SELECT osm_id from placex p WHERE p.place_id = lp.parent_place_id) as osm_id,";
-         $sSQL .= "  'place' as class, 'postcode' as type,";
-         $sSQL .= "  null as admin_level, rank_search, rank_address,";
-         $sSQL .= "  place_id, parent_place_id, country_code,";
-         $sSQL .= "  get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) AS langaddress,";
-         $sSQL .= "  postcode as placename,";
-         $sSQL .= "  postcode as ref,";
-         if ($this->bIncludeExtraTags) $sSQL .= "null AS extra,";
-         if ($this->bIncludeNameDetails) $sSQL .= "null AS names,";
-         $sSQL .= "  ST_x(st_centroid(geometry)) AS lon, ST_y(st_centroid(geometry)) AS lat,";
-         $sSQL .= "  (0.75-(rank_search::float/40)) $sImportanceSQLGeom AS importance, ";
-         if ($oCtx->hasNearPoint()) {
-             $sSQL .= $oCtx->distanceSQL('geometry')." AS addressimportance,";
-         } else {
-             $sSQL .= "  (";
-             $sSQL .= "     SELECT max(p.importance*(p.rank_address+2))";
-             $sSQL .= "     FROM ";
-             $sSQL .= "       place_addressline s, ";
-             $sSQL .= "       placex p";
-             $sSQL .= "     WHERE s.place_id = lp.parent_place_id";
-             $sSQL .= "       AND p.place_id = s.address_place_id ";
-             $sSQL .= "       AND s.isaddress";
-             $sSQL .= "       AND p.importance is not null";
-             $sSQL .= "  ) AS addressimportance, ";
-         }
-         $sSQL .= "  null AS extra_place ";
-         $sSQL .= "FROM location_postcode lp";
-         $sSQL .= " WHERE place_id in ($sPlaceIDs) ";
-         if (30 >= $this->iMinAddressRank && 30 <= $this->iMaxAddressRank) {
-             // only Tiger housenumbers and interpolation lines need to be interpolated, because they are saved as lines
-             // with start- and endnumber, the common osm housenumbers are usually saved as points
-             $sHousenumbers = "";
-             $i = 0;
-             $length = count($aPlaceIDs);
-             foreach ($aPlaceIDs as $placeID => $housenumber) {
-                 $i++;
-                 $sHousenumbers .= "(".$placeID.", ".$housenumber.")";
-                 if ($i<$length) $sHousenumbers .= ", ";
-             }
-             if (CONST_Use_US_Tiger_Data) {
-                 // Tiger search only if a housenumber was searched and if it was found (i.e. aPlaceIDs[placeID] = housenumber != -1) (realized through a join)
-                 $sSQL .= " union";
-                 $sSQL .= " SELECT ";
-                 $sSQL .= "     'T' AS osm_type, ";
-                 $sSQL .= "     (SELECT osm_id from placex p WHERE p.place_id=min(blub.parent_place_id)) as osm_id, ";
-                 $sSQL .= "     'place' AS class, ";
-                 $sSQL .= "     'house' AS type, ";
-                 $sSQL .= "     null AS admin_level, ";
-                 $sSQL .= "     30 AS rank_search, ";
-                 $sSQL .= "     30 AS rank_address, ";
-                 $sSQL .= "     min(place_id) AS place_id, ";
-                 $sSQL .= "     min(parent_place_id) AS parent_place_id, ";
-                 $sSQL .= "     'us' AS country_code, ";
-                 $sSQL .= "     get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) AS langaddress,";
-                 $sSQL .= "     null AS placename, ";
-                 $sSQL .= "     null AS ref, ";
-                 if ($this->bIncludeExtraTags) $sSQL .= "null AS extra,";
-                 if ($this->bIncludeNameDetails) $sSQL .= "null AS names,";
-                 $sSQL .= "     avg(st_x(centroid)) AS lon, ";
-                 $sSQL .= "     avg(st_y(centroid)) AS lat,";
-                 $sSQL .= "     -1.15".$sImportanceSQL." AS importance, ";
-                 if ($oCtx->hasNearPoint()) {
-                     $sSQL .= $oCtx->distanceSQL('ST_Collect(centroid)')." AS addressimportance,";
-                 } else {
-                     $sSQL .= "     (";
-                     $sSQL .= "        SELECT max(p.importance*(p.rank_address+2))";
-                     $sSQL .= "        FROM ";
-                     $sSQL .= "          place_addressline s, ";
-                     $sSQL .= "          placex p";
-                     $sSQL .= "        WHERE s.place_id = min(blub.parent_place_id)";
-                     $sSQL .= "          AND p.place_id = s.address_place_id ";
-                     $sSQL .= "          AND s.isaddress";
-                     $sSQL .= "          AND p.importance is not null";
-                     $sSQL .= "     ) AS addressimportance, ";
-                 }
-                 $sSQL .= "     null AS extra_place ";
-                 $sSQL .= " FROM (";
-                 $sSQL .= "     SELECT place_id, ";    // interpolate the Tiger housenumbers here
-                 $sSQL .= "         ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) AS centroid, ";
-                 $sSQL .= "         parent_place_id, ";
-                 $sSQL .= "         housenumber_for_place";
-                 $sSQL .= "     FROM (";
-                 $sSQL .= "            location_property_tiger ";
-                 $sSQL .= "            JOIN (values ".$sHousenumbers.") AS housenumbers(place_id, housenumber_for_place) USING(place_id)) ";
-                 $sSQL .= "     WHERE ";
-                 $sSQL .= "         housenumber_for_place>=0";
-                 $sSQL .= "         AND 30 between $this->iMinAddressRank AND $this->iMaxAddressRank";
-                 $sSQL .= " ) AS blub"; //postgres wants an alias here
-                 $sSQL .= " GROUP BY";
-                 $sSQL .= "      place_id, ";
-                 $sSQL .= "      housenumber_for_place"; //is this group by really needed?, place_id + housenumber (in combination) are unique
-                 if (!$this->bDeDupe) $sSQL .= ", place_id ";
-             }
-             // osmline
-             // interpolation line search only if a housenumber was searched and if it was found (i.e. aPlaceIDs[placeID] = housenumber != -1) (realized through a join)
-             $sSQL .= " UNION ";
-             $sSQL .= "SELECT ";
-             $sSQL .= "  'W' AS osm_type, ";
-             $sSQL .= "  osm_id, ";
-             $sSQL .= "  'place' AS class, ";
-             $sSQL .= "  'house' AS type, ";
-             $sSQL .= "  null AS admin_level, ";
-             $sSQL .= "  30 AS rank_search, ";
-             $sSQL .= "  30 AS rank_address, ";
-             $sSQL .= "  min(place_id) as place_id, ";
-             $sSQL .= "  min(parent_place_id) AS parent_place_id, ";
-             $sSQL .= "  country_code, ";
-             $sSQL .= "  get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) AS langaddress, ";
-             $sSQL .= "  null AS placename, ";
-             $sSQL .= "  null AS ref, ";
-             if ($this->bIncludeExtraTags) $sSQL .= "null AS extra, ";
-             if ($this->bIncludeNameDetails) $sSQL .= "null AS names, ";
-             $sSQL .= "  AVG(st_x(centroid)) AS lon, ";
-             $sSQL .= "  AVG(st_y(centroid)) AS lat, ";
-             $sSQL .= "  -0.1".$sImportanceSQL." AS importance, ";  // slightly smaller than the importance for normal houses with rank 30, which is 0
-             if ($oCtx->hasNearPoint()) {
-                 $sSQL .= $oCtx->distanceSQL('ST_Collect(centroid)')." AS addressimportance,";
-             } else {
-                 $sSQL .= "  (";
-                 $sSQL .= "     SELECT ";
-                 $sSQL .= "       MAX(p.importance*(p.rank_address+2)) ";
-                 $sSQL .= "     FROM";
-                 $sSQL .= "       place_addressline s, ";
-                 $sSQL .= "       placex p";
-                 $sSQL .= "     WHERE s.place_id = min(blub.parent_place_id) ";
-                 $sSQL .= "       AND p.place_id = s.address_place_id ";
-                 $sSQL .= "       AND s.isaddress ";
-                 $sSQL .= "       AND p.importance is not null";
-                 $sSQL .= "  ) AS addressimportance,";
-             }
-             $sSQL .= "  null AS extra_place ";
-             $sSQL .= "  FROM (";
-             $sSQL .= "     SELECT ";
-             $sSQL .= "         osm_id, ";
-             $sSQL .= "         place_id, ";
-             $sSQL .= "         country_code, ";
-             $sSQL .= "         CASE ";             // interpolate the housenumbers here
-             $sSQL .= "           WHEN startnumber != endnumber ";
-             $sSQL .= "           THEN ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) ";
-             $sSQL .= "           ELSE ST_LineInterpolatePoint(linegeo, 0.5) ";
-             $sSQL .= "         END as centroid, ";
-             $sSQL .= "         parent_place_id, ";
-             $sSQL .= "         housenumber_for_place ";
-             $sSQL .= "     FROM (";
-             $sSQL .= "            location_property_osmline ";
-             $sSQL .= "            JOIN (values ".$sHousenumbers.") AS housenumbers(place_id, housenumber_for_place) USING(place_id)";
-             $sSQL .= "          ) ";
-             $sSQL .= "     WHERE housenumber_for_place>=0 ";
-             $sSQL .= "       AND 30 between $this->iMinAddressRank AND $this->iMaxAddressRank";
-             $sSQL .= "  ) as blub"; //postgres wants an alias here
-             $sSQL .= "  GROUP BY ";
-             $sSQL .= "    osm_id, ";
-             $sSQL .= "    place_id, ";
-             $sSQL .= "    housenumber_for_place, ";
-             $sSQL .= "    country_code "; //is this group by really needed?, place_id + housenumber (in combination) are unique
-             if (!$this->bDeDupe) $sSQL .= ", place_id ";
-             if (CONST_Use_Aux_Location_data) {
-                 $sSQL .= " UNION ";
-                 $sSQL .= "  SELECT ";
-                 $sSQL .= "     'L' AS osm_type, ";
-                 $sSQL .= "     place_id AS osm_id, ";
-                 $sSQL .= "     'place' AS class,";
-                 $sSQL .= "     'house' AS type, ";
-                 $sSQL .= "     null AS admin_level, ";
-                 $sSQL .= "     0 AS rank_search,";
-                 $sSQL .= "     0 AS rank_address, ";
-                 $sSQL .= "     min(place_id) AS place_id,";
-                 $sSQL .= "     min(parent_place_id) AS parent_place_id, ";
-                 $sSQL .= "     'us' AS country_code, ";
-                 $sSQL .= "     get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) AS langaddress, ";
-                 $sSQL .= "     null AS placename, ";
-                 $sSQL .= "     null AS ref, ";
-                 if ($this->bIncludeExtraTags) $sSQL .= "null AS extra, ";
-                 if ($this->bIncludeNameDetails) $sSQL .= "null AS names, ";
-                 $sSQL .= "     avg(ST_X(centroid)) AS lon, ";
-                 $sSQL .= "     avg(ST_Y(centroid)) AS lat, ";
-                 $sSQL .= "     -1.10".$sImportanceSQL." AS importance, ";
-                 if ($oCtx->hasNearPoint()) {
-                     $sSQL .= $oCtx->distanceSQL('ST_Collect(centroid)')." AS addressimportance,";
-                 } else {
-                     $sSQL .= "     ( ";
-                     $sSQL .= "       SELECT max(p.importance*(p.rank_address+2))";
-                     $sSQL .= "       FROM ";
-                     $sSQL .= "          place_addressline s, ";
-                     $sSQL .= "          placex p";
-                     $sSQL .= "       WHERE s.place_id = min(location_property_aux.parent_place_id)";
-                     $sSQL .= "         AND p.place_id = s.address_place_id ";
-                     $sSQL .= "         AND s.isaddress";
-                     $sSQL .= "         AND p.importance is not null";
-                     $sSQL .= "     ) AS addressimportance, ";
-                 }
-                 $sSQL .= "     null AS extra_place ";
-                 $sSQL .= "  FROM location_property_aux ";
-                 $sSQL .= "  WHERE place_id in ($sPlaceIDs) ";
-                 $sSQL .= "    AND 30 between $this->iMinAddressRank and $this->iMaxAddressRank ";
-                 $sSQL .= "  GROUP BY ";
-                 $sSQL .= "     place_id, ";
-                 if (!$this->bDeDupe) $sSQL .= "place_id, ";
-                 $sSQL .= "     get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) ";
-             }
-         }
-         $sSQL .= " order by importance desc";
-         if (CONST_Debug) {
-             echo "<hr>";
-             var_dump($sSQL);
-         }
-         $aSearchResults = chksql(
-             $this->oDB->getAll($sSQL),
-             "Could not get details for place."
-         );
-         return $aSearchResults;
-     }
      public function getGroupedSearches($aSearches, $aPhrases, $aValidTokens, $bIsStructured)
      {
          /*
  
               Score how good the search is so they can be ordered
           */
-         $iGlobalRank = 0;
          foreach ($aPhrases as $iPhrase => $oPhrase) {
              $aNewPhraseSearches = array();
              $sPhraseType = $bIsStructured ? $oPhrase->getPhraseType() : '';
                                      $iToken == 0 && $iPhrase == 0,
                                      $iPhrase == 0,
                                      $iToken + 1 == sizeof($aWordset)
-                                       && $iPhrase + 1 == sizeof($aPhrases),
-                                     $iGlobalRank
+                                       && $iPhrase + 1 == sizeof($aPhrases)
                                  );
  
                                  foreach ($aNewSearches as $oSearch) {
                  continue;
              }
  
-             $iRank = $oSearch->addToRank($iGlobalRank);
+             $iRank = $oSearch->getRank();
              if (!isset($aGroupedSearches[$iRank])) {
                  $aGroupedSearches[$iRank] = array();
              }
          // Do we have anything that looks like a lat/lon pair?
          $sQuery = $oCtx->setNearPointFromQuery($sQuery);
  
-         $aSearchResults = array();
+         $aResults = array();
          if ($sQuery || $this->aStructuredQuery) {
              // Start with a single blank search
              $aSearches = array(new SearchDescription($oCtx));
              if (CONST_Debug) _debugDumpGroupedSearches($aGroupedSearches, $aValidTokens);
  
              // Start the search process
-             // array with: placeid => -1 | tiger-housenumber
-             $aResultPlaceIDs = array();
              $iGroupLoop = 0;
              $iQueryLoop = 0;
              foreach ($aGroupedSearches as $iGroupedRank => $aSearches) {
                          _debugDumpGroupedSearches(array($iGroupedRank => array($oSearch)), $aValidTokens);
                      }
  
-                     $aRes = $oSearch->query(
+                     $aResults += $oSearch->query(
                          $this->oDB,
                          $aWordFrequencyScores,
-                         $this->exactMatchCache,
                          $this->iMinAddressRank,
                          $this->iMaxAddressRank,
                          $this->iLimit
                      );
  
-                     foreach ($aRes['IDs'] as $iPlaceID) {
-                         // array for placeID => -1 | Tiger housenumber
-                         $aResultPlaceIDs[$iPlaceID] = $aRes['houseNumber'];
-                     }
                      if ($iQueryLoop > 20) break;
                  }
  
-                 if (sizeof($aResultPlaceIDs) && ($this->iMinAddressRank != 0 || $this->iMaxAddressRank != 30)) {
+                 if (sizeof($aResults) && ($this->iMinAddressRank != 0 || $this->iMaxAddressRank != 30)) {
                      // Need to verify passes rank limits before dropping out of the loop (yuk!)
                      // reduces the number of place ids, like a filter
                      // rank_address is 30 for interpolated housenumbers
-                     $sWherePlaceId = 'WHERE place_id in (';
-                     $sWherePlaceId .= join(',', array_keys($aResultPlaceIDs)).') ';
-                     $sSQL = "SELECT place_id ";
-                     $sSQL .= "FROM placex ".$sWherePlaceId;
-                     $sSQL .= "  AND (";
-                     $sSQL .= "         placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
-                     if (14 >= $this->iMinAddressRank && 14 <= $this->iMaxAddressRank) {
-                         $sSQL .= "     OR (extratags->'place') = 'city'";
-                     }
-                     if ($this->aAddressRankList) {
-                         $sSQL .= "     OR placex.rank_address in (".join(',', $this->aAddressRankList).")";
-                     }
-                     $sSQL .= "  ) UNION ";
-                     $sSQL .= " SELECT place_id FROM location_postcode lp ".$sWherePlaceId;
-                     $sSQL .= "  AND (lp.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
-                     if ($this->aAddressRankList) {
-                         $sSQL .= "     OR lp.rank_address in (".join(',', $this->aAddressRankList).")";
+                     $aFilterSql = array();
+                     $sPlaceIds = Result::joinIdsByTable($aResults, Result::TABLE_PLACEX);
+                     if ($sPlaceIds) {
+                         $sSQL = 'SELECT place_id FROM placex ';
+                         $sSQL .= 'WHERE place_id in ('.$sPlaceIds.') ';
+                         $sSQL .= "  AND (";
+                         $sSQL .= "         placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
+                         if (14 >= $this->iMinAddressRank && 14 <= $this->iMaxAddressRank) {
+                             $sSQL .= "     OR (extratags->'place') = 'city'";
+                         }
+                         if ($this->aAddressRankList) {
+                             $sSQL .= "     OR placex.rank_address in (".join(',', $this->aAddressRankList).")";
+                         }
+                         $sSQL .= ")";
+                         $aFilterSql[] = $sSQL;
                      }
-                     $sSQL .= ") ";
-                     if (CONST_Use_US_Tiger_Data && $this->iMaxAddressRank == 30) {
-                         $sSQL .= "UNION ";
-                         $sSQL .= "  SELECT place_id ";
-                         $sSQL .= "  FROM location_property_tiger ".$sWherePlaceId;
+                     $sPlaceIds = Result::joinIdsByTable($aResults, Result::TABLE_POSTCODE);
+                     if ($sPlaceIds) {
+                         $sSQL = ' SELECT place_id FROM location_postcode lp ';
+                         $sSQL .= 'WHERE place_id in ('.$sPlaceIds.') ';
+                         $sSQL .= "  AND (lp.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
+                         if ($this->aAddressRankList) {
+                             $sSQL .= "     OR lp.rank_address in (".join(',', $this->aAddressRankList).")";
+                         }
+                         $sSQL .= ") ";
+                         $aFilterSql[] = $sSQL;
                      }
-                     if ($this->iMaxAddressRank == 30) {
-                         $sSQL .= "UNION ";
-                         $sSQL .= "  SELECT place_id ";
-                         $sSQL .= "  FROM location_property_osmline ".$sWherePlaceId;
+                     $aFilteredIDs = array();
+                     if ($aFilterSql) {
+                         $sSQL = join(' UNION ', $aFilterSql);
+                         if (CONST_Debug) var_dump($sSQL);
+                         $aFilteredIDs = chksql($this->oDB->getCol($sSQL));
                      }
-                     if (CONST_Debug) var_dump($sSQL);
-                     $aFilteredPlaceIDs = chksql($this->oDB->getCol($sSQL));
                      $tempIDs = array();
-                     foreach ($aFilteredPlaceIDs as $placeID) {
-                         $tempIDs[$placeID] = $aResultPlaceIDs[$placeID];  //assign housenumber to placeID
+                     foreach ($aResults as $oResult) {
+                         if (($this->iMaxAddressRank == 30 &&
+                              ($oResult->iTable == Result::TABLE_OSMLINE
+                               || $oResult->iTable == Result::TABLE_AUX
+                               || $oResult->iTable == Result::TABLE_TIGER))
+                             || in_array($oResult->iId, $aFilteredIDs)
+                         ) {
+                             $tempIDs[$oResult->iId] = $oResult;
+                         }
                      }
-                     $aResultPlaceIDs = $tempIDs;
+                     $aResults = $tempIDs;
                  }
  
-                 if (sizeof($aResultPlaceIDs)) break;
+                 if (sizeof($aResults)) break;
                  if ($iGroupLoop > 4) break;
                  if ($iQueryLoop > 30) break;
              }
-             // Did we find anything?
-             if (sizeof($aResultPlaceIDs)) {
-                 $aSearchResults = $this->getDetails($aResultPlaceIDs, $oCtx);
-             }
          } else {
              // Just interpret as a reverse geocode
              $oReverse = new ReverseGeocode($this->oDB);
              $oReverse->setZoom(18);
  
-             $aLookup = $oReverse->lookupPoint($oCtx->sqlNear, false);
+             $oLookup = $oReverse->lookupPoint($oCtx->sqlNear, false);
  
              if (CONST_Debug) var_dump("Reverse search", $aLookup);
  
-             if ($aLookup['place_id']) {
-                 $aSearchResults = $this->getDetails(array($aLookup['place_id'] => -1), $oCtx);
-                 $aResultPlaceIDs[$aLookup['place_id']] = -1;
-             } else {
-                 $aSearchResults = array();
+             if ($oLookup) {
+                 $aResults = array($oLookup->iId => $oLookup);
              }
          }
  
          // No results? Done
-         if (!sizeof($aSearchResults)) {
+         if (!sizeof($aResults)) {
              if ($this->bFallback) {
                  if ($this->fallbackStructuredQuery()) {
                      return $this->lookup();
              return array();
          }
  
+         if ($this->aAddressRankList) {
+             $this->oPlaceLookup->setAddressRankList($this->aAddressRankList);
+         }
+         $this->oPlaceLookup->setAllowedTypesSQLList($this->sAllowedTypesSQLList);
+         $this->oPlaceLookup->setLanguagePreference($this->aLangPrefOrder);
+         if ($oCtx->hasNearPoint()) {
+             $this->oPlaceLookup->setAnchorSql($oCtx->sqlNear);
+         }
+         $aSearchResults = $this->oPlaceLookup->lookup($aResults);
          $aClassType = getClassTypesWithImportance();
          $aRecheckWords = preg_split('/\b[\s,\\-]*/u', $sQuery);
          foreach ($aRecheckWords as $i => $sWord) {
              var_dump($aRecheckWords);
          }
  
-         $oPlaceLookup = new PlaceLookup($this->oDB);
-         $oPlaceLookup->setIncludePolygonAsPoints($this->bIncludePolygonAsPoints);
-         $oPlaceLookup->setIncludePolygonAsText($this->bIncludePolygonAsText);
-         $oPlaceLookup->setIncludePolygonAsGeoJSON($this->bIncludePolygonAsGeoJSON);
-         $oPlaceLookup->setIncludePolygonAsKML($this->bIncludePolygonAsKML);
-         $oPlaceLookup->setIncludePolygonAsSVG($this->bIncludePolygonAsSVG);
-         $oPlaceLookup->setPolygonSimplificationThreshold($this->fPolygonSimplificationThreshold);
-         foreach ($aSearchResults as $iResNum => $aResult) {
+         foreach ($aSearchResults as $iIdx => $aResult) {
              // Default
              $fDiameter = getResultDiameter($aResult);
  
-             $aOutlineResult = $oPlaceLookup->getOutlines($aResult['place_id'], $aResult['lon'], $aResult['lat'], $fDiameter/2);
+             $aOutlineResult = $this->oPlaceLookup->getOutlines($aResult['place_id'], $aResult['lon'], $aResult['lat'], $fDiameter/2);
              if ($aOutlineResult) {
                  $aResult = array_merge($aResult, $aOutlineResult);
              }
-             
              if ($aResult['extra_place'] == 'city') {
                  $aResult['class'] = 'place';
                  $aResult['type'] = 'city';
              // if tag '&addressdetails=1' is set in query
              if ($this->bIncludeAddressDetails) {
                  // getAddressDetails() is defined in lib.php and uses the SQL function get_addressdata in functions.sql
-                 $aResult['address'] = getAddressDetails($this->oDB, $sLanguagePrefArraySQL, $aResult['place_id'], $aResult['country_code'], $aResultPlaceIDs[$aResult['place_id']]);
+                 $aResult['address'] = getAddressDetails($this->oDB, $sLanguagePrefArraySQL, $aResult['place_id'], $aResult['country_code'], $aResults[$aResult['place_id']]->iHouseNumber);
                  if ($aResult['extra_place'] == 'city' && !isset($aResult['address']['city'])) {
                      $aResult['address'] = array_merge(array('city' => array_values($aResult['address'])[0]), $aResult['address']);
                  }
              }
  
-             if ($this->bIncludeExtraTags) {
-                 if ($aResult['extra']) {
-                     $aResult['sExtraTags'] = json_decode($aResult['extra']);
-                 } else {
-                     $aResult['sExtraTags'] = (object) array();
-                 }
-             }
-             if ($this->bIncludeNameDetails) {
-                 if ($aResult['names']) {
-                     $aResult['sNameDetails'] = json_decode($aResult['names']);
-                 } else {
-                     $aResult['sNameDetails'] = (object) array();
-                 }
-             }
              $aResult['name'] = $aResult['langaddress'];
  
              if ($oCtx->hasNearPoint()) {
                  $aResult['foundorder'] = $aResult['addressimportance'];
              } else {
                  // Adjust importance for the number of exact string matches in the result
+                 $aResult['importance'] *= $this->viewboxImportanceFactor(
+                     $aResult['lon'],
+                     $aResult['lat']
+                 );
                  $aResult['importance'] = max(0.001, $aResult['importance']);
                  $iCountWords = 0;
                  $sAddress = $aResult['langaddress'];
                  // - approximate importance of address parts
                  $aResult['foundorder'] = -$aResult['addressimportance']/10;
                  // - number of exact matches from the query
-                 if (isset($this->exactMatchCache[$aResult['place_id']])) {
-                     $aResult['foundorder'] -= $this->exactMatchCache[$aResult['place_id']];
-                 } elseif (isset($this->exactMatchCache[$aResult['parent_place_id']])) {
-                     $aResult['foundorder'] -= $this->exactMatchCache[$aResult['parent_place_id']];
-                 }
+                 $aResult['foundorder'] -= $aResults[$aResult['place_id']]->iExactMatches;
                  // - importance of the class/type
                  if (isset($aClassType[$aResult['class'].':'.$aResult['type']]['importance'])
                      && $aClassType[$aResult['class'].':'.$aResult['type']]['importance']
                  }
              }
              if (CONST_Debug) var_dump($aResult);
-             $aSearchResults[$iResNum] = $aResult;
+             $aSearchResults[$iIdx] = $aResult;
          }
          uasort($aSearchResults, 'byImportance');
  
          $aToFilter = $aSearchResults;
          $aSearchResults = array();
  
+         if (CONST_Debug) var_dump($aToFilter);
          $bFirst = true;
-         foreach ($aToFilter as $iResNum => $aResult) {
+         foreach ($aToFilter as $aResult) {
              $this->aExcludePlaceIDs[$aResult['place_id']] = $aResult['place_id'];
              if ($bFirst) {
                  $fLat = $aResult['lat'];
                  if (isset($aResult['zoom'])) $iZoom = $aResult['zoom'];
                  $bFirst = false;
              }
-             if (!$this->bDeDupe || (!isset($aOSMIDDone[$aResult['osm_type'].$aResult['osm_id']])
+             if (!$this->oPlaceLookup->doDeDupe() || (!isset($aOSMIDDone[$aResult['osm_type'].$aResult['osm_id']])
                  && !isset($aClassTypeNameDone[$aResult['osm_type'].$aResult['class'].$aResult['type'].$aResult['name'].$aResult['admin_level']]))
              ) {
                  $aOSMIDDone[$aResult['osm_type'].$aResult['osm_id']] = true;
              if (sizeof($aSearchResults) >= $this->iFinalLimit) break;
          }
  
+         if (CONST_Debug) var_dump($aSearchResults);
          return $aSearchResults;
      } // end lookup()
  } // end class
diff --combined lib/lib.php
index 3db3a825b50603bb606bd6f14de80f2fde71eef4,afcc3c7ffbbcaa22bfb255a947e5b1191fe29118..9bf15964bd9410397d3f91ae4cafdd1e3447f3f4
@@@ -584,10 -584,10 +584,10 @@@ function geometryText2Points($geometry_
          //
          preg_match_all('/(-?[0-9.]+) (-?[0-9.]+)/', $aMatch[1], $aPolyPoints, PREG_SET_ORDER);
          //
 -    } elseif (preg_match('#MULTIPOLYGON\\(\\(\\(([- 0-9.,]+)#', $geometry_as_text, $aMatch)) {
 +/*    } elseif (preg_match('#MULTIPOLYGON\\(\\(\\(([- 0-9.,]+)#', $geometry_as_text, $aMatch)) {
          //
          preg_match_all('/(-?[0-9.]+) (-?[0-9.]+)/', $aMatch[1], $aPolyPoints, PREG_SET_ORDER);
 -        //
 +        */
      } elseif (preg_match('#POINT\\((-?[0-9.]+) (-?[0-9.]+)\\)#', $geometry_as_text, $aMatch)) {
          //
          $aPolyPoints = createPointsAroundCenter($aMatch[1], $aMatch[2], $fRadius);
@@@ -615,3 -615,23 +615,23 @@@ function createPointsAroundCenter($fLon
      }
      return $aPolyPoints;
  }
+ function closestHouseNumber($aRow)
+ {
+     $fHouse = $aRow['startnumber']
+                 + ($aRow['endnumber'] - $aRow['startnumber']) * $aRow['fraction'];
+     switch ($aRow['interpolationtype']) {
+         case 'odd':
+             $iHn = (int)($fHouse/2) * 2 + 1;
+             break;
+         case 'even':
+             $iHn = (int)(round($fHouse/2)) * 2;
+             break;
+         default:
+             $iHn = (int)(round($fHouse));
+             break;
+     }
+     return max(min($aRow['endnumber'], $iHn), $aRow['startnumber']);
+ }
index d1b69764f01198a1ac9e8f8da8af17f41b9b4e57,7413581833b8f0061101345a652bffb3b2d92382..8bfce8ef588d3fd1c2cd3c14de604e87f02c75c8
@@@ -1,11 -1,9 +1,11 @@@
  <h2>Welcome to Nominatim</h2>
  
- <p>Nominatim is a search engine for <a href="http://www.openstreetmap.org">OpenStreetMap</a>
+ <p>Nominatim is a search engine for <a href="https://www.openstreetmap.org">OpenStreetMap</a>
  data. This is the debugging interface. You may search for a name or address(forward search) or
  look up data by its geographic coordinate(reverse search). Each result comes with a
  link to a details page where you can inspect what data about the object is saved in 
  the database and investigate how the address of the object has been computed.</p>
  
- <p>For more information visit the <a href="http://wiki.openstreetmap.org/wiki/Nominatim">Nominatim wiki page</a>.</p>
 -For more information visit the <a href="https://wiki.openstreetmap.org/wiki/Nominatim">Nominatim wiki page</a>.
++<p>For more information visit the <a href="https://wiki.openstreetmap.org/wiki/Nominatim">Nominatim wiki page</a>.</p>
 +
 +<p>All usage of nominatim.openstreetmap.org must follow the <a href="https://operations.osmfoundation.org/policies/nominatim/">Nominatim Usage Policy</a>.</p>
diff --combined website/reverse.php
index 00bcf6356db1ba819058a5df6f2c8a449b5e4bd0,85ca19816b196662b7864374c1d8b5863e264fdf..41e1a725d0eb610ae8b6126e945a4bbad3bf7203
@@@ -11,23 -11,6 +11,6 @@@ ini_set('memory_limit', '200M')
  
  $oParams = new Nominatim\ParameterParser();
  
- $bAsGeoJSON = $oParams->getBool('polygon_geojson');
- $bAsKML = $oParams->getBool('polygon_kml');
- $bAsSVG = $oParams->getBool('polygon_svg');
- $bAsText = $oParams->getBool('polygon_text');
- $iWantedTypes = ($bAsGeoJSON?1:0) + ($bAsKML?1:0) + ($bAsSVG?1:0) + ($bAsText?1:0);
- if ($iWantedTypes > CONST_PolygonOutput_MaximumTypes) {
-     if (CONST_PolygonOutput_MaximumTypes) {
-         userError("Select only ".CONST_PolygonOutput_MaximumTypes." polgyon output option");
-     } else {
-         userError("Polygon output is disabled");
-     }
- }
- // Polygon simplification threshold (optional)
- $fThreshold = $oParams->getFloat('polygon_threshold', 0.0);
  // Format for output
  $sOutputFormat = $oParams->getSet('format', array('html', 'xml', 'json', 'jsonv2'), 'xml');
  
@@@ -38,44 -21,35 +21,35 @@@ $oDB =& getDB()
  
  $hLog = logStart($oDB, 'reverse', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
  
  $oPlaceLookup = new Nominatim\PlaceLookup($oDB);
- $oPlaceLookup->setLanguagePreference($aLangPrefOrder);
- $oPlaceLookup->setIncludeAddressDetails($oParams->getBool('addressdetails', true));
- $oPlaceLookup->setIncludeExtraTags($oParams->getBool('extratags', false));
- $oPlaceLookup->setIncludeNameDetails($oParams->getBool('namedetails', false));
+ $oPlaceLookup->loadParamArray($oParams);
  
  $sOsmType = $oParams->getSet('osm_type', array('N', 'W', 'R'));
  $iOsmId = $oParams->getInt('osm_id', -1);
  $fLat = $oParams->getFloat('lat');
  $fLon = $oParams->getFloat('lon');
- $iZoom = $oParams->getInt('zoom');
+ $iZoom = $oParams->getInt('zoom', 18);
  if ($sOsmType && $iOsmId > 0) {
      $aPlace = $oPlaceLookup->lookupOSMID($sOsmType, $iOsmId);
  } elseif ($fLat !== false && $fLon !== false) {
      $oReverseGeocode = new Nominatim\ReverseGeocode($oDB);
-     $oReverseGeocode->setZoom($iZoom !== false ? $iZoom : 18);
+     $oReverseGeocode->setZoom($iZoom);
  
-     $aLookup = $oReverseGeocode->lookup($fLat, $fLon);
-     if (CONST_Debug) var_dump($aLookup);
+     $oLookup = $oReverseGeocode->lookup($fLat, $fLon);
+     if (CONST_Debug) var_dump($oLookup);
  
-     $aPlace = $oPlaceLookup->lookup(
-         (int)$aLookup['place_id'],
-         $aLookup['type'],
-         $aLookup['fraction']
-     );
+     if ($oLookup) {
+         $aPlaces = $oPlaceLookup->lookup(array($oLookup->iId => $oLookup));
+         if (sizeof($aPlaces)) {
+             $aPlace = reset($aPlaces);
+         }
+     }
  } elseif ($sOutputFormat != 'html') {
      userError("Need coordinates or OSM object to lookup.");
  }
  
  if (isset($aPlace)) {
-     $oPlaceLookup->setIncludePolygonAsPoints(false);
-     $oPlaceLookup->setIncludePolygonAsText($bAsText);
-     $oPlaceLookup->setIncludePolygonAsGeoJSON($bAsGeoJSON);
-     $oPlaceLookup->setIncludePolygonAsKML($bAsKML);
-     $oPlaceLookup->setIncludePolygonAsSVG($bAsSVG);
-     $oPlaceLookup->setPolygonSimplificationThreshold($fThreshold);
      $fRadius = $fDiameter = getResultDiameter($aPlace);
      $aOutlineResult = $oPlaceLookup->getOutlines(
          $aPlace['place_id'],
@@@ -91,7 -65,6 +65,7 @@@
      $aPlace = [];
  }
  
 +logEnd($oDB, $hLog, sizeof($aPlace)?1:0);
  
  if (CONST_Debug) {
      var_dump($aPlace);