]> git.openstreetmap.org Git - nominatim.git/commitdiff
Merge pull request #2955 from lonvia/fix-importance-refresh
authorSarah Hoffmann <lonvia@denofr.de>
Mon, 23 Jan 2023 08:07:43 +0000 (09:07 +0100)
committerGitHub <noreply@github.com>
Mon, 23 Jan 2023 08:07:43 +0000 (09:07 +0100)
Fix importance recalculation

nominatim/tools/refresh.py
test/python/tools/test_refresh.py

index 457960146b6b0343d1f9934ee42cfa0f0e9db697..5dd98c0eda730e1cc4170296526fc7693502e9d2 100644 (file)
@@ -176,7 +176,7 @@ def recompute_importance(conn: Connection) -> None:
         cur.execute("""
             UPDATE placex SET (wikipedia, importance) =
                (SELECT wikipedia, importance
-                FROM compute_importance(extratags, country_code, osm_type, osm_id, centroid))
+                FROM compute_importance(extratags, country_code, rank_search, centroid))
             """)
         cur.execute("""
             UPDATE placex s SET wikipedia = d.wikipedia, importance = d.importance
index c6be4fe72774068e9476a79299feba0dc7e30c03..3e0a280127a1e38b1f7122592bad922882734bc5 100644 (file)
@@ -48,7 +48,7 @@ def test_refresh_import_wikipedia(dsn, src_dir, table_factory, temp_db_cursor, r
 def test_recompute_importance(placex_table, table_factory, temp_db_conn, temp_db_cursor):
     temp_db_cursor.execute("""CREATE OR REPLACE FUNCTION compute_importance(extratags HSTORE,
                                               country_code varchar(2),
-                                              osm_type varchar(1), osm_id BIGINT,
+                                              rank_search SMALLINT,
                                               centroid GEOMETRY,
                                               OUT importance FLOAT,
                                               OUT wikipedia TEXT)