Merge remote-tracking branch 'upstream/master'

Conflicts:
	lib/Geocode.php
	utils/update.php

diff --git a/lib/Geocode.php b/lib/Geocode.php
index 52f66e5b9a5b229d9e9af18e71817477322642b2..eda692b00d792d695db4d020edb34078dc3af444 100644 (file)
--- a/lib/Geocode.php
+++ b/lib/Geocode.php
@@ -34,6 +34,7 @@
                protected $iMinAddressRank = 0;
                protected $iMaxAddressRank = 30;
                protected $aAddressRankList = array();
+               protected $exactMatchCache = array();
 
                protected $sAllowedTypesSQLList = false;
 
@@ -250,13 +251,13 @@
                        if ($this->sViewboxSmallSQL) $sImportanceSQL .= " case when ST_Contains($this->sViewboxSmallSQL, ST_Collect(centroid)) THEN 1 ELSE 0.75 END * ";
                        if ($this->sViewboxLargeSQL) $sImportanceSQL .= " case when ST_Contains($this->sViewboxLargeSQL, ST_Collect(centroid)) THEN 1 ELSE 0.75 END * ";
 
-                       $sSQL = "select osm_type,osm_id,class,type,admin_level,rank_search,rank_address,min(place_id) as place_id,calculated_country_code as country_code,";
+                       $sSQL = "select osm_type,osm_id,class,type,admin_level,rank_search,rank_address,min(place_id) as place_id, min(parent_place_id) as parent_place_id, calculated_country_code as country_code,";
                        $sSQL .= "get_address_by_language(place_id, $sLanguagePrefArraySQL) as langaddress,";
                        $sSQL .= "get_name_by_language(name, $sLanguagePrefArraySQL) as placename,";
                        $sSQL .= "get_name_by_language(name, ARRAY['ref']) as ref,";
                        $sSQL .= "avg(ST_X(centroid)) as lon,avg(ST_Y(centroid)) as lat, ";
                        $sSQL .= $sImportanceSQL."coalesce(importance,0.75-(rank_search::float/40)) as importance, ";
-                       $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(placex.place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
+                       $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(CASE WHEN placex.rank_search < 28 THEN placex.place_id ELSE placex.parent_place_id END) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
                        $sSQL .= "(extratags->'place') as extra_place ";
                        $sSQL .= "from placex where place_id in ($sPlaceIDs) ";
                        $sSQL .= "and (placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
@@ -275,13 +276,13 @@
                        if (30 >= $this->iMinAddressRank && 30 <= $this->iMaxAddressRank)
                        {
                                $sSQL .= " union ";
-                               $sSQL .= "select 'T' as osm_type,place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id,'us' as country_code,";
+                               $sSQL .= "select 'T' as osm_type,place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id, min(parent_place_id) as parent_place_id,'us' as country_code,";
                                $sSQL .= "get_address_by_language(place_id, $sLanguagePrefArraySQL) as langaddress,";
                                $sSQL .= "null as placename,";
                                $sSQL .= "null as ref,";
                                $sSQL .= "avg(ST_X(centroid)) as lon,avg(ST_Y(centroid)) as lat, ";
                                $sSQL .= $sImportanceSQL."-1.15 as importance, ";
-                               $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(location_property_tiger.place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
+                               $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(location_property_tiger.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
                                $sSQL .= "null as extra_place ";
                                $sSQL .= "from location_property_tiger where place_id in ($sPlaceIDs) ";
                                $sSQL .= "and 30 between $this->iMinAddressRank and $this->iMaxAddressRank ";
@@ -289,13 +290,13 @@
                                if (!$this->bDeDupe) $sSQL .= ",place_id ";
                                /*
                                $sSQL .= " union ";
-                               $sSQL .= "select 'L' as osm_type,place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id,'us' as country_code,";
+                               $sSQL .= "select 'L' as osm_type,place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id, min(parent_place_id) as parent_place_id,'us' as country_code,";
                                $sSQL .= "get_address_by_language(place_id, $sLanguagePrefArraySQL) as langaddress,";
                                $sSQL .= "null as placename,";
                                $sSQL .= "null as ref,";
                                $sSQL .= "avg(ST_X(centroid)) as lon,avg(ST_Y(centroid)) as lat, ";
                                $sSQL .= $sImportanceSQL."-1.10 as importance, ";
-                               $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(location_property_aux.place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
+                               $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(location_property_aux.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
                                $sSQL .= "null as extra_place ";
                                $sSQL .= "from location_property_aux where place_id in ($sPlaceIDs) ";
                                $sSQL .= "and 30 between $this->iMinAddressRank and $this->iMaxAddressRank ";
@@ -317,6 +318,36 @@
                        return $aSearchResults;
                }
 
+               /* Perform the actual query lookup.
+
+                       Returns an ordered list of results, each with the following fields:
+                         osm_type: type of corresponding OSM object
+                                                       N - node
+                                                       W - way
+                                                       R - relation
+                                                       P - postcode (internally computed)
+                         osm_id: id of corresponding OSM object
+                         class: general object class (corresponds to tag key of primary OSM tag)
+                         type: subclass of object (corresponds to tag value of primary OSM tag)
+                         admin_level: see http://wiki.openstreetmap.org/wiki/Admin_level
+                         rank_search: rank in search hierarchy
+                                                       (see also http://wiki.openstreetmap.org/wiki/Nominatim/Development_overview#Country_to_street_level)
+                         rank_address: rank in address hierarchy (determines orer in address)
+                         place_id: internal key (may differ between different instances)
+                         country_code: ISO country code
+                         langaddress: localized full address
+                         placename: localized name of object
+                         ref: content of ref tag (if available)
+                         lon: longitude
+                         lat: latitude
+                         importance: importance of place based on Wikipedia link count
+                         addressimportance: cumulated importance of address elements
+                         extra_place: type of place (for admin boundaries, if there is a place tag)
+                         aBoundingBox: bounding Box
+                         label: short description of the object class/type (English only) 
+                         name: full name (currently the same as langaddress)
+                         foundorder: secondary ordering for places with same importance
+               */
                function lookup()
                {
                        if (!$this->sQuery && !$this->aStructuredQuery) return false;
@@ -1126,12 +1157,16 @@
                                                        $aOrder[] = "$sImportanceSQL DESC";
                                                        if (sizeof($aSearch['aFullNameAddress']))
                                                        {
-                                                               $aOrder[] = '(select count(*) from (select unnest(ARRAY['.join($aSearch['aFullNameAddress'],",").']) INTERSECT select unnest(nameaddress_vector))s) DESC';
+                                                               $sExactMatchSQL = '(select count(*) from (select unnest(ARRAY['.join($aSearch['aFullNameAddress'],",").']) INTERSECT select unnest(nameaddress_vector))s) as exactmatch';
+                                                               $aOrder[] = 'exactmatch DESC';
+                                                       } else {
+                                                               $sExactMatchSQL = '0::int as exactmatch';
                                                        }
 
                                                        if (sizeof($aTerms))
                                                        {
-                                                               $sSQL = "select place_id";
+                                                               $sSQL = "select place_id, ";
+                                                               $sSQL .= $sExactMatchSQL;
                                                                $sSQL .= " from search_name";
                                                                $sSQL .= " where ".join(' and ',$aTerms);
                                                                $sSQL .= " order by ".join(', ',$aOrder);
@@ -1159,6 +1194,7 @@
                                                                        //if ($aViewBoxRow['in_small'] == 't') $bViewBoxMatch = 1;
                                                                        //else if ($aViewBoxRow['in_large'] == 't') $bViewBoxMatch = 2;
                                                                        $aPlaceIDs[] = $aViewBoxRow['place_id'];
+                                                                       $this->exactMatchCache[$aViewBoxRow['place_id']] = $aViewBoxRow['exactmatch'];
                                                                }
                                                        }
                                                        //var_Dump($aPlaceIDs);
@@ -1560,7 +1596,24 @@
                                $aResult['importance'] = $aResult['importance'] + ($iCountWords*0.1); // 0.1 is a completely arbitrary number but something in the range 0.1 to 0.5 would seem right
 
                                $aResult['name'] = $aResult['langaddress'];
-                               $aResult['foundorder'] = -$aResult['addressimportance'];
+                               // secondary ordering (for results with same importance (the smaller the better):
+                               //   - approximate importance of address parts
+                               $aResult['foundorder'] = -$aResult['addressimportance']/10;
+                               //   - number of exact matches from the query
+                               if (isset($this->exactMatchCache[$aResult['place_id']]))
+                                       $aResult['foundorder'] -= $this->exactMatchCache[$aResult['place_id']];
+                               else if (isset($this->exactMatchCache[$aResult['parent_place_id']]))
+                                       $aResult['foundorder'] -= $this->exactMatchCache[$aResult['parent_place_id']];
+                               //  - importance of the class/type
+                               if (isset($aClassType[$aResult['class'].':'.$aResult['type']]['importance'])
+                                       && $aClassType[$aResult['class'].':'.$aResult['type']]['importance'])
+                               {
+                                       $aResult['foundorder'] = $aResult['foundorder'] + 0.000001 * $aClassType[$aResult['class'].':'.$aResult['type']]['importance'];
+                               }
+                               else
+                               {
+                                       $aResult['foundorder'] = $aResult['foundorder'] + 0.001;
+                               }
                                $aSearchResults[$iResNum] = $aResult;
                        }
                        uasort($aSearchResults, 'byImportance');

diff --git a/lib/ReverseGeocode.php b/lib/ReverseGeocode.php
index 8503e1eb5c3ad138bb920dcec4ae5add4581384b..cb8c0c6bcf84b7febe7b17a053b12ab1cfd9fe8f 100644 (file)
--- a/lib/ReverseGeocode.php
+++ b/lib/ReverseGeocode.php
@@ -95,8 +95,8 @@
                                $sSQL .= ' and rank_search != 28 and rank_search >= '.$iMaxRank;
                                $sSQL .= ' and (name is not null or housenumber is not null)';
                                $sSQL .= ' and class not in (\'waterway\',\'railway\',\'tunnel\',\'bridge\')';
-                               $sSQL .= ' and (ST_GeometryType(geometry) not in (\'ST_Polygon\',\'ST_MultiPolygon\') ';
                                $sSQL .= ' and indexed_status = 0 ';
+                               $sSQL .= ' and (ST_GeometryType(geometry) not in (\'ST_Polygon\',\'ST_MultiPolygon\') ';
                                $sSQL .= ' OR ST_DWithin('.$sPointSQL.', centroid, '.$fSearchDiam.'))';
                                $sSQL .= ' ORDER BY ST_distance('.$sPointSQL.', geometry) ASC limit 1';
                                if (CONST_Debug) var_dump($sSQL);

diff --git a/sql/functions.sql b/sql/functions.sql
index 05de978ec415a6e3c594ad6eaaec470ea4e042eb..fcd895646c3ffcefc9404e0937d60f3fdab4a220 100644 (file)
--- a/sql/functions.sql
+++ b/sql/functions.sql
@@ -1250,7 +1250,7 @@ BEGIN
    -- Note: won't work on initial import because the classtype tables
    -- do not yet exist. It won't hurt either.
   classtable := 'place_classtype_' || NEW.class || '_' || NEW.type;
-  SELECT count(*)>0 FROM pg_tables WHERE tablename = classtable INTO result;
+  SELECT count(*)>0 FROM pg_tables WHERE tablename = classtable and schemaname = current_schema() INTO result;
   IF result THEN
     EXECUTE 'INSERT INTO ' || classtable::regclass || ' (place_id, centroid) VALUES ($1,$2)' 
     USING NEW.place_id, ST_Centroid(NEW.geometry);
@@ -2005,7 +2005,7 @@ BEGIN
 
   -- remove from tables for special search
   classtable := 'place_classtype_' || OLD.class || '_' || OLD.type;
-  SELECT count(*)>0 FROM pg_tables WHERE tablename = classtable INTO b;
+  SELECT count(*)>0 FROM pg_tables WHERE tablename = classtable and schemaname = current_schema() INTO b;
   IF b THEN
     EXECUTE 'DELETE FROM ' || classtable::regclass || ' WHERE place_id = $1' USING OLD.place_id;
   END IF;

diff --git a/utils/update.php b/utils/update.php
index 7448348f14cfb99bad81b045380eaa67ab8b8a5a..256d5a158c455c1866ec3cedfa859e63aa82fdf7 100755 (executable)
--- a/utils/update.php
+++ b/utils/update.php
@@ -73,6 +73,7 @@
        $oDB =& getDB();
 
        $aDSNInfo = DB::parseDSN(CONST_Database_DSN);
+       if (!isset($aDSNInfo['port']) || !$aDSNInfo['port']) $aDSNInfo['port'] = 5432;
 
        // cache memory to be used by osm2pgsql, should not be more than the available memory
        $iCacheMemory = (isset($aResult['osm2pgsql-cache'])?$aResult['osm2pgsql-cache']:2000);
@@ -81,7 +82,7 @@
                $iCacheMemory = getCacheMemoryMB();
                echo "WARNING: resetting cache memory to $iCacheMemory\n";
        }
-       $sOsm2pgsqlCmd = CONST_Osm2pgsql_Binary.' -klas -C '.$iCacheMemory.' -O gazetteer -d '.$aDSNInfo['database'];
+       $sOsm2pgsqlCmd = CONST_Osm2pgsql_Binary.' -klas -C '.$iCacheMemory.' -O gazetteer -d '.$aDSNInfo['database'].' -P '.$aDSNInfo['port'];
        if (!is_null(CONST_Osm2pgsql_Flatnode_File))
        {
                $sOsm2pgsqlCmd .= ' --flat-nodes '.CONST_Osm2pgsql_Flatnode_File;
@@ -360,7 +361,7 @@
        if ($aResult['index'])
        {
                if (!isset($aResult['index-instances'])) $aResult['index-instances'] = 1;
-               passthru(CONST_BasePath.'/nominatim/nominatim -i -d '.$aDSNInfo['database'].' -t '.$aResult['index-instances'].' -r '.$aResult['index-rank']);
+               passthru(CONST_BasePath.'/nominatim/nominatim -i -d '.$aDSNInfo['database'].' -P '.$aDSNInfo['port'].' -t '.$aResult['index-instances'].' -r '.$aResult['index-rank']);
        }
 
        if ($aResult['import-osmosis'] || $aResult['import-osmosis-all'])
@@ -377,7 +378,7 @@
                $sCMDDownload = $sOsmosisCMD.' --read-replication-interval workingDirectory='.$sOsmosisConfigDirectory.' --simplify-change --write-xml-change '.$sImportFile;
                $sCMDCheckReplicationLag = $sOsmosisCMD.' -q --read-replication-lag workingDirectory='.$sOsmosisConfigDirectory;
                $sCMDImport = $sOsm2pgsqlCmd.' '.$sImportFile;
-               $sCMDIndex = $sBasePath.'/nominatim/nominatim -i -d '.$aDSNInfo['database'];
+               $sCMDIndex = $sBasePath.'/nominatim/nominatim -i -d '.$aDSNInfo['database'].' -P '.$aDSNInfo['port'];
                if (!$aResult['no-npi']) {
                        $sCMDIndex .= '-F ';
                }