]> git.openstreetmap.org Git - nominatim.git/commitdiff
adapt to code style conventions
authorMarkus Gail <markus.gail.94@gmail.com>
Mon, 21 Mar 2016 11:42:38 +0000 (12:42 +0100)
committerMarkus Gail <markus.gail.94@gmail.com>
Mon, 21 Mar 2016 13:15:22 +0000 (14:15 +0100)
lib/Geocode.php
lib/PlaceLookup.php
lib/ReverseGeocode.php
lib/lib.php

index 340f233e548d01bce4227db067ea6d8e6190677a..8eaa540263c0fc825bc368a077325c4264305520 100644 (file)
                        $this->loadStructuredAddressElement($sPostalCode, 'postalcode' , 5, 11, array(5, 11));
                        $this->loadStructuredAddressElement($sCountry, 'country', 4, 4, false);
 
-                       if (sizeof($this->aStructuredQuery) > 0) 
+                       if (sizeof($this->aStructuredQuery) > 0)
                        {
                                $this->sQuery = join(', ', $this->aStructuredQuery);
                                if ($this->iMaxAddressRank < 30)
 
                function getDetails($aPlaceIDs)
                {
-            //$aPlaceIDs is an array with key: placeID and value: tiger-housenumber, if found, else -1
+                       //$aPlaceIDs is an array with key: placeID and value: tiger-housenumber, if found, else -1
                        if (sizeof($aPlaceIDs) == 0)  return array();
 
                        $sLanguagePrefArraySQL = "ARRAY[".join(',',array_map("getDBQuoted",$this->aLangPrefOrder))."]";
                        if (30 >= $this->iMinAddressRank && 30 <= $this->iMaxAddressRank)
                        {
                                //query also location_property_tiger and location_property_aux
-                //Tiger search only if a housenumber was searched and if it was found (i.e. aPlaceIDs[placeID] = housenumber != -1) (realized through a join)
-                //only Tiger housenumbers need to be interpolated, because they are saved as lines with start- and endnumber, the common osm housenumbers are usually saved as points
-                $sHousenumbers = "";
-                $i=0;
-                $length=count($aPlaceIDs);
-                foreach($aPlaceIDs as $placeID => $housenumber){
-                    $i++;
-                    $sHousenumbers .= "(".$placeID.",".$housenumber.")";
-                    if($i<$length)
-                        $sHousenumbers .= ",";
-                }
-                
-                $sSQL .= "union ";
-                $sSQL .= "select 'T' as osm_type, place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id, min(parent_place_id) as parent_place_id,'us' as country_code";
-                $sSQL .= ", get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) as langaddress ";
-                $sSQL .= ", null as placename";
-                $sSQL .= ", null as ref";
-                if ($this->bIncludeExtraTags) $sSQL .= ", null as extra";
-                if ($this->bIncludeNameDetails) $sSQL .= ", null as names";
-                $sSQL .= ", avg(st_x(point)) as lon, avg(st_y(point)) as lat";
-                $sSQL .= $sImportanceSQL.", -1.15 as importance ";
-                $sSQL .= ", (select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(blub.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance ";
-                $sSQL .= ", null as extra_place ";
-                $sSQL .= " from (select place_id";
-                //interpolate the Tiger housenumbers here
-                $sSQL .= ",ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) as point, parent_place_id, housenumber_for_place ";
-                $sSQL .= "from (location_property_tiger ";
-                $sSQL .= " join (values ".$sHousenumbers.") as housenumbers(place_id,housenumber_for_place) using(place_id)) ";
-                $sSQL .= " where housenumber_for_place>=0 and 30 between $this->iMinAddressRank and $this->iMaxAddressRank) as blub"; //postgres wants an alias here
-                $sSQL .= " group by place_id, housenumber_for_place"; //is this group by really needed?, place_id + housenumber (in combination) are unique
-                if (!$this->bDeDupe) $sSQL .= ",place_id ";
-                    
+                               //Tiger search only if a housenumber was searched and if it was found (i.e. aPlaceIDs[placeID] = housenumber != -1) (realized through a join)
+                               //only Tiger housenumbers need to be interpolated, because they are saved as lines with start- and endnumber, the common osm housenumbers are usually saved as points
+                               $sHousenumbers = "";
+                               $i=0;
+                               $length=count($aPlaceIDs);
+                               foreach($aPlaceIDs as $placeID => $housenumber){
+                                       $i++;
+                                       $sHousenumbers .= "(".$placeID.", ".$housenumber.")";
+                                       if($i<$length)
+                                               $sHousenumbers .= ", ";
+                               }
+
+                               $sSQL .= "union ";
+                               $sSQL .= "select 'T' as osm_type, place_id as osm_id, 'place' as class, 'house' as type, null as admin_level, 30 as rank_search, 30 as rank_address, min(place_id) as place_id, min(parent_place_id) as parent_place_id, 'us' as country_code";
+                               $sSQL .= ", get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) as langaddress ";
+                               $sSQL .= ", null as placename";
+                               $sSQL .= ", null as ref";
+                               if ($this->bIncludeExtraTags) $sSQL .= ", null as extra";
+                               if ($this->bIncludeNameDetails) $sSQL .= ", null as names";
+                               $sSQL .= ", avg(st_x(point)) as lon, avg(st_y(point)) as lat";
+                               $sSQL .= $sImportanceSQL.", -1.15 as importance ";
+                               $sSQL .= ", (select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(blub.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance ";
+                               $sSQL .= ", null as extra_place ";
+                               $sSQL .= " from (select place_id";
+                               //interpolate the Tiger housenumbers here
+                               $sSQL .= ", ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) as point, parent_place_id, housenumber_for_place ";
+                               $sSQL .= "from (location_property_tiger ";
+                               $sSQL .= " join (values ".$sHousenumbers.") as housenumbers(place_id, housenumber_for_place) using(place_id)) ";
+                               $sSQL .= " where housenumber_for_place>=0 and 30 between $this->iMinAddressRank and $this->iMaxAddressRank) as blub"; //postgres wants an alias here
+                               $sSQL .= " group by place_id, housenumber_for_place"; //is this group by really needed?, place_id + housenumber (in combination) are unique
+                               if (!$this->bDeDupe) $sSQL .= ", place_id ";
+
                                $sSQL .= " union ";
-                               $sSQL .= "select 'L' as osm_type,place_id as osm_id,'place' as class,'house' as type,null as admin_level,30 as rank_search,30 as rank_address,min(place_id) as place_id, min(parent_place_id) as parent_place_id,'us' as country_code,";
-                               $sSQL .= "get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) as langaddress,";
-                               $sSQL .= "null as placename,";
-                               $sSQL .= "null as ref,";
-                               if ($this->bIncludeExtraTags) $sSQL .= "null as extra,";
-                               if ($this->bIncludeNameDetails) $sSQL .= "null as names,";
-                               $sSQL .= "avg(ST_X(centroid)) as lon,avg(ST_Y(centroid)) as lat, ";
+                               $sSQL .= "select 'L' as osm_type, place_id as osm_id, 'place' as class, 'house' as type, null as admin_level, 0 as rank_search, 0 as rank_address, min(place_id) as place_id, min(parent_place_id) as parent_place_id, 'us' as country_code, ";
+                               $sSQL .= "get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) as langaddress, ";
+                               $sSQL .= "null as placename, ";
+                               $sSQL .= "null as ref, ";
+                               if ($this->bIncludeExtraTags) $sSQL .= "null as extra, ";
+                               if ($this->bIncludeNameDetails) $sSQL .= "null as names, ";
+                               $sSQL .= "avg(ST_X(centroid)) as lon, avg(ST_Y(centroid)) as lat, ";
                                $sSQL .= $sImportanceSQL."-1.10 as importance, ";
                                $sSQL .= "(select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(location_property_aux.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
                                $sSQL .= "null as extra_place ";
                                $sSQL .= "from location_property_aux where place_id in ($sPlaceIDs) ";
                                $sSQL .= "and 30 between $this->iMinAddressRank and $this->iMaxAddressRank ";
                                $sSQL .= "group by place_id";
-                               if (!$this->bDeDupe) $sSQL .= ",place_id";
-                               $sSQL .= ",get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) ";
+                               if (!$this->bDeDupe) $sSQL .= ", place_id";
+                               $sSQL .= ", get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) ";
                        }
 
                        $sSQL .= " order by importance desc";
                                addressimportance: cumulated importance of address elements
                                extra_place: type of place (for admin boundaries, if there is a place tag)
                                aBoundingBox: bounding Box
-                               label: short description of the object class/type (English only) 
+                               label: short description of the object class/type (English only)
                                name: full name (currently the same as langaddress)
                                foundorder: secondary ordering for places with same importance
                */
                        // Do we have anything that looks like a lat/lon pair?
                        if ( $aLooksLike = looksLikeLatLonPair($sQuery) ){
                                $this->setNearPoint(array($aLooksLike['lat'], $aLooksLike['lon']));
-                               $sQuery = $aLooksLike['query'];                 
+                               $sQuery = $aLooksLike['query'];
                        }
 
                        $aSearchResults = array();
                        {
                                // Start with a blank search
                                $aSearches = array(
-                                       array('iSearchRank' => 0, 
-                                                               'iNamePhrase' => -1, 
-                                                               'sCountryCode' => false, 
-                                                               'aName' => array(), 
-                                                               'aAddress' => array(), 
+                                       array('iSearchRank' => 0,
+                                                               'iNamePhrase' => -1,
+                                                               'sCountryCode' => false,
+                                                               'aName' => array(),
+                                                               'aAddress' => array(),
                                                                'aFullNameAddress' => array(),
-                                                               'aNameNonSearch' => array(), 
+                                                               'aNameNonSearch' => array(),
                                                                'aAddressNonSearch' => array(),
-                                                               'sOperator' => '', 
-                                                               'aFeatureName' => array(), 
-                                                               'sClass' => '', 
-                                                               'sType' => '', 
-                                                               'sHouseNumber' => '', 
-                                                               'fLat' => '', 
-                                                               'fLon' => '', 
+                                                               'sOperator' => '',
+                                                               'aFeatureName' => array(),
+                                                               'sClass' => '',
+                                                               'sType' => '',
+                                                               'sHouseNumber' => '',
+                                                               'fLat' => '',
+                                                               'fLon' => '',
                                                                'fRadius' => ''
                                                        )
                                );
                                        // TODO: suggestions
 
                                        // Start the search process
-                    // array with: placeid => -1 | tiger-housenumber
+                                       // array with: placeid => -1 | tiger-housenumber
                                        $aResultPlaceIDs = array();
 
                                        $aGroupedSearches = $this->getGroupedSearches($aSearches, $aPhraseTypes, $aPhrases, $aValidTokens, $aWordFrequencyScores, $bStructuredPhrases);
                                        foreach($aSearches as $aSearch)
                                        {
                                                $iQueryLoop++;
-                        $searchedHousenumber=-1;
+                                               $searchedHousenumber=-1;
 
                                                if (CONST_Debug) { echo "<hr><b>Search Loop, group $iGroupLoop, loop $iQueryLoop</b>"; }
                                                if (CONST_Debug) _debugDumpGroupedSearches(array($iGroupedRank => array($aSearch)), $aValidTokens);
                                                                        if (CONST_Debug) var_dump($sSQL);
                                                                        $aPlaceIDs = $this->oDB->getCol($sSQL);
                                                                }
-                                //if nothing was found in placex or location_property_aux, then search in Tiger data for this housenumber(location_property_tiger)
-                                $searchedHousenumber = intval($aSearch['sHouseNumber']);
+                                                               //if nothing was found in placex or location_property_aux, then search in Tiger data for this housenumber(location_property_tiger)
+                                                               $searchedHousenumber = intval($aSearch['sHouseNumber']);
                                                                if (!sizeof($aPlaceIDs))
                                                                {
-                                                                       //$sSQL = "select place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and housenumber = '".pg_escape_string($aSearch['sHouseNumber'])."'";
                                                                        //new query for lines, not housenumbers anymore
-                                    if($searchedHousenumber%2==0){
-                                        //if housenumber is even, look for housenumber in streets with interpolationtype even or all
-                                        $sSQL = "select distinct place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='even' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
-                                    }else{
-                                        //look for housenumber in streets with interpolationtype odd or all
-                                        $sSQL = "select distinct place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='odd' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
-                                    }
-                    
-                                    if (sizeof($this->aExcludePlaceIDs))
+                                                                       if($searchedHousenumber%2==0){
+                                                                               //if housenumber is even, look for housenumber in streets with interpolationtype even or all
+                                                                               $sSQL = "select distinct place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='even' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
+                                                                       }else{
+                                                                               //look for housenumber in streets with interpolationtype odd or all
+                                                                               $sSQL = "select distinct place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='odd' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
+                                                                       }
+
+                                                                       if (sizeof($this->aExcludePlaceIDs))
                                                                        {
-                                                                               $sSQL .= " and place_id not in (".join(',',$this->aExcludePlaceIDs).")";
+                                                                               $sSQL .= " and place_id not in (".join(',', $this->aExcludePlaceIDs).")";
                                                                        }
                                                                        //$sSQL .= " limit $this->iLimit";
                                                                        if (CONST_Debug) var_dump($sSQL);
-                                    //get place IDs
-                                                                       $aPlaceIDs = $this->oDB->getCol($sSQL,0);
+                                                                       //get place IDs
+                                                                       $aPlaceIDs = $this->oDB->getCol($sSQL, 0);
                                                                }
 
                                                                // Fallback to the road (if no housenumber was found)
                                                                if (!sizeof($aPlaceIDs) && preg_match('/[0-9]+/', $aSearch['sHouseNumber']))
                                                                {
                                                                        $aPlaceIDs = $aRoadPlaceIDs;
-                                    //set to -1, if no housenumbers were found
-                                    $searchedHousenumber=-1;
+                                                                       //set to -1, if no housenumbers were found
+                                                                       $searchedHousenumber=-1;
                                                                }else{
-                                    //housenumber was found, remains saved in searchedHousenumber
-                                }
+                                                                       //housenumber was found, remains saved in searchedHousenumber
+                                                               }
                                                        }
 
 
                                                        if ($aSearch['sClass'] && sizeof($aPlaceIDs))
                                                        {
-                                                               $sPlaceIDs = join(',',$aPlaceIDs);
+                                                               $sPlaceIDs = join(',', aPlaceIDs);
                                                                $aClassPlaceIDs = array();
 
                                                                if (!$aSearch['sOperator'] || $aSearch['sOperator'] == 'name')
 
                                                foreach($aPlaceIDs as $iPlaceID)
                                                {
-                            // array for placeID => -1 | Tiger housenumber
+                                                       // array for placeID => -1 | Tiger housenumber
                                                        $aResultPlaceIDs[$iPlaceID] = $searchedHousenumber;
                                                }
                                                if ($iQueryLoop > 20) break;
                                        if (isset($aResultPlaceIDs) && sizeof($aResultPlaceIDs) && ($this->iMinAddressRank != 0 || $this->iMaxAddressRank != 30))
                                        {
                                                // Need to verify passes rank limits before dropping out of the loop (yuk!)
-                        // reduces the number of place ids, like a filter
+                                               // reduces the number of place ids, like a filter
                                                $sSQL = "select place_id from placex where place_id in (".join(',',array_keys($aResultPlaceIDs)).") ";
                                                $sSQL .= "and (placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
                                                if (14 >= $this->iMinAddressRank && 14 <= $this->iMaxAddressRank) $sSQL .= " OR (extratags->'place') = 'city'";
                                                $sSQL .= ")";
                                                if (CONST_Debug) var_dump($sSQL);
                                                $aFilteredPlaceIDs = $this->oDB->getCol($sSQL);
-                        $tempIDs = array();
-                        foreach($aFilteredPlaceIDs as $placeID){
-                            $tempIDs[$placeID]= $aResultPlaceIDs[$placeID];  //assign housenumber to placeID
-                        }
-                        $aResultPlaceIDs=$tempIDs;
+                                               $tempIDs = array();
+                                               foreach($aFilteredPlaceIDs as $placeID){
+                                                       $tempIDs[$placeID]= $aResultPlaceIDs[$placeID];  //assign housenumber to placeID
+                                               }
+                                               $aResultPlaceIDs=$tempIDs;
                                        }
 
                                        //exit;
                                {
                                        $aResult['label'] = $aClassType[$aResult['class'].':'.$aResult['type']]['label'];
                                }
-                // if tag '&addressdetails=1' is set in query
+                               // if tag '&addressdetails=1' is set in query
                                if ($this->bIncludeAddressDetails)
                                {
-                    // getAddressDetails() is defined in lib.php and uses the SQL function get_addressdata in functions.sql
+                                       // getAddressDetails() is defined in lib.php and uses the SQL function get_addressdata in functions.sql
                                        $aResult['address'] = getAddressDetails($this->oDB, $sLanguagePrefArraySQL, $aResult['place_id'], $aResult['country_code'], $aResultPlaceIDs[$aResult['place_id']]);
                                        if ($aResult['extra_place'] == 'city' && !isset($aResult['address']['city']))
                                        {
index e29b6d0ae693aec509a40e590b145e0e09fbc514..f62ca6275a73941c8ad1c7bbde29c6af7c619628 100644 (file)
@@ -6,8 +6,8 @@
                protected $iPlaceID;
 
                protected $sType = false;
-        
-        protected $fTigerFraction =-1;
+
+               protected $fTigerFraction =-1;
 
                protected $aLangPrefOrder = array();
 
                        {
                                $this->setOSMID($details['osm_type'], $details['osm_id']);
                        }
-            if (isset($details['fraction'])) $this->fTigerFraction = $details['fraction'];
+                       if (isset($details['fraction'])) $this->fTigerFraction = $details['fraction'];
 
                        return $this->lookup();
                }
                                if ($this->bNameDetails) $sSQL .= " null as names,";
                                $sSQL .= " ST_X(point) as lon, ST_Y(point) as lat from (select *, ST_LineInterpolatePoint(linegeo, (housenumber-startnumber::float)/(endnumber-startnumber)::float) as point from ";
                                $sSQL .= " (select *, ";
-                $sSQL .= " CASE WHEN interpolationtype='odd' THEN floor((".$this->fTigerFraction."*(endnumber-startnumber)+startnumber)/2)::int*2+1";
-                $sSQL .= " WHEN interpolationtype='even' THEN ((".$this->fTigerFraction."*(endnumber-startnumber)+startnumber+1)/2)::int*2";
-                $sSQL .= " WHEN interpolationtype='all' THEN (".$this->fTigerFraction."*(endnumber-startnumber)+startnumber)::int";
-                $sSQL .= " END as housenumber";
-                $sSQL .= " from location_property_tiger where place_id = ".(int)$this->iPlaceID.") as blub1) as blub2";
+                               $sSQL .= " CASE WHEN interpolationtype='odd' THEN floor((".$this->fTigerFraction."*(endnumber-startnumber)+startnumber)/2)::int*2+1";
+                               $sSQL .= " WHEN interpolationtype='even' THEN ((".$this->fTigerFraction."*(endnumber-startnumber)+startnumber+1)/2)::int*2";
+                               $sSQL .= " WHEN interpolationtype='all' THEN (".$this->fTigerFraction."*(endnumber-startnumber)+startnumber)::int";
+                               $sSQL .= " END as housenumber";
+                               $sSQL .= " from location_property_tiger where place_id = ".(int)$this->iPlaceID.") as blub1) as blub2";
                        }
                        else
                        {
 
                        if ($this->bAddressDetails)
                        {
-                if($this->sType == 'tiger') // to get addressdetails for tiger data, the housenumber is needed
-                    $aAddress = $this->getAddressNames($aPlace['housenumber']);
-                else
-                    $aAddress = $this->getAddressNames();
+                               if($this->sType == 'tiger') // to get addressdetails for tiger data, the housenumber is needed
+                                       $aAddress = $this->getAddressNames($aPlace['housenumber']);
+                               else
+                                       $aAddress = $this->getAddressNames();
                                $aPlace['aAddress'] = $aAddress;
                        }
 
index e8a85867f1702e08cfa0335c2dff048e37c02493..9eb7f7f2834f003e7f9b63abd7fcc6e30e4c5ef8 100644 (file)
                        }
 
                        // Only street found? If it's in the US we can check TIGER data for nearest housenumber
-                       if ($bIsInUnitedStates && $iMaxRank_orig >= 28 && $iPlaceID && ($aPlace['rank_search'] == 26 || $aPlace['rank_search'] == 27 )) 
+                       if ($bIsInUnitedStates && $iMaxRank_orig >= 28 && $iPlaceID && ($aPlace['rank_search'] == 26 || $aPlace['rank_search'] == 27 ))
                        {
                                $fSearchDiam = 0.001;
                                $sSQL = 'SELECT place_id,parent_place_id,30 as rank_search, ST_line_locate_point(linegeo,'.$sPointSQL.') as fraction';
                                        $aPlace = $aPlaceTiger;
                                        $iPlaceID = $aPlaceTiger['place_id'];
                                        $iParentPlaceID = $aPlaceTiger['parent_place_id']; // the street
-                    $iFraction = $aPlaceTiger['fraction'];
+                                       $iFraction = $aPlaceTiger['fraction'];
                                }
                        }
 
index ac99b1d24bfbb20390c0c9749833785f3431f0e6..b2924d5851c6f5daff27e401b843198a95aef7f0 100644 (file)
@@ -77,7 +77,7 @@
        function getProcessorCount()
        {
                $sCPU = file_get_contents('/proc/cpuinfo');
-               preg_match_all('#processor      : [0-9]+#', $sCPU, $aMatches);
+               preg_match_all('#processor  : [0-9]+#', $sCPU, $aMatches);
                return sizeof($aMatches[0]);
        }
 
                   return ($a['aPointPolygon']['numfeatures'] > $b['aPointPolygon']['numfeatures']?-1:1);
                   if ($a['aPointPolygon']['area'] != $b['aPointPolygon']['area'])
                   return ($a['aPointPolygon']['area'] > $b['aPointPolygon']['area']?-1:1);
-               //              if ($a['levenshtein'] != $b['levenshtein'])
-               //                      return ($a['levenshtein'] < $b['levenshtein']?-1:1);
+               //      if ($a['levenshtein'] != $b['levenshtein'])
+               //          return ($a['levenshtein'] < $b['levenshtein']?-1:1);
                if ($a['rank_search'] != $b['rank_search'])
                return ($a['rank_search'] < $b['rank_search']?-1:1);
                 */