per-file-ignores =
__init__.py: F401
test/python/utils/test_json_writer.py: E131
- test/python/conftest.py: E402
+ **/conftest.py: E402
test/bdd/*: F821
with:
dependencies: ${{ matrix.dependencies }}
+ - uses: actions/cache@v4
+ with:
+ path: |
+ /usr/local/bin/osm2pgsql
+ key: osm2pgsql-bin-22-1
+ if: matrix.ubuntu == '22'
+
- name: Compile osm2pgsql
run: |
- sudo apt-get install -y -qq libboost-system-dev libboost-filesystem-dev libexpat1-dev zlib1g-dev libbz2-dev libpq-dev libproj-dev libicu-dev liblua${LUA_VERSION}-dev lua-dkjson nlohmann-json3-dev
- mkdir osm2pgsql-build
- cd osm2pgsql-build
- git clone https://github.com/osm2pgsql-dev/osm2pgsql
- mkdir build
- cd build
- cmake ../osm2pgsql
- make
- sudo make install
- cd ../..
- rm -rf osm2pgsql-build
+ if [ ! -f /usr/local/bin/osm2pgsql ]; then
+ sudo apt-get install -y -qq libboost-system-dev libboost-filesystem-dev libexpat1-dev zlib1g-dev libbz2-dev libpq-dev libproj-dev libicu-dev liblua${LUA_VERSION}-dev lua-dkjson nlohmann-json3-dev
+ mkdir osm2pgsql-build
+ cd osm2pgsql-build
+ git clone https://github.com/osm2pgsql-dev/osm2pgsql
+ mkdir build
+ cd build
+ cmake ../osm2pgsql
+ make
+ sudo make install
+ cd ../..
+ rm -rf osm2pgsql-build
+ else
+ sudo apt-get install -y -qq libexpat1 liblua${LUA_VERSION}
+ fi
if: matrix.ubuntu == '22'
env:
LUA_VERSION: ${{ matrix.lua }}
- - name: Install test prerequisites
- run: ./venv/bin/pip install behave==1.2.6
-
- name: Install test prerequisites (apt)
run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn python3-falcon python3-aiosqlite python3-pyosmium
if: matrix.dependencies == 'apt'
run: ./venv/bin/pip install pytest-asyncio falcon starlette asgi_lifespan aiosqlite osmium uvicorn
if: matrix.dependencies == 'pip'
+ - name: Install test prerequisites
+ run: ./venv/bin/pip install pytest-bdd
+
- name: Install latest flake8
run: ./venv/bin/pip install -U flake8
- name: BDD tests
run: |
- ../../../venv/bin/python -m behave -DREMOVE_TEMPLATE=1 --format=progress3
- working-directory: Nominatim/test/bdd
+ ../venv/bin/python -m pytest test/bdd --nominatim-purge
+ working-directory: Nominatim
install:
runs-on: ubuntu-latest
flake8 src test/python test/bdd
bdd:
- cd test/bdd; behave -DREMOVE_TEMPLATE=1
+ pytest test/bdd --nominatim-purge
# Documentation
## Prerequisites for testing and documentation
-The Nominatim test suite consists of behavioural tests (using behave) and
+The Nominatim test suite consists of behavioural tests (using pytest-bdd) and
unit tests (using pytest). It has the following additional requirements:
-* [behave test framework](https://behave.readthedocs.io) >= 1.2.6
* [flake8](https://flake8.pycqa.org/en/stable/) (CI always runs the latest version from pip)
* [mypy](http://mypy-lang.org/) (plus typing information for external libs)
* [Python Typing Extensions](https://github.com/python/typing_extensions) (for Python < 3.9)
* [pytest](https://pytest.org)
* [pytest-asyncio](https://pytest-asyncio.readthedocs.io)
+* [pytest-bdd](https://pytest-bdd.readthedocs.io)
For testing the Python search frontend, you need to install extra dependencies
depending on your choice of webserver framework:
* [mkdocs-material](https://squidfunk.github.io/mkdocs-material/)
* [mkdocs-gen-files](https://oprypin.github.io/mkdocs-gen-files/)
-Please be aware that tests always run against the globally installed
-osm2pgsql, so you need to have this set up. If you want to test against
-the vendored version of osm2pgsql, you need to set the PATH accordingly.
### Installing prerequisites on Ubuntu/Debian
virtualenv ~/nominatim-dev-venv
~/nominatim-dev-venv/bin/pip install\
psutil 'psycopg[binary]' PyICU SQLAlchemy \
- python-dotenv jinja2 pyYAML behave \
- mkdocs 'mkdocstrings[python]' mkdocs-gen-files pytest pytest-asyncio flake8 \
+ python-dotenv jinja2 pyYAML \
+ mkdocs 'mkdocstrings[python]' mkdocs-gen-files \
+ pytest pytest-asyncio pytest-bdd flake8 \
types-jinja2 types-markupsafe types-psutil types-psycopg2 \
types-pygments types-pyyaml types-requests types-ujson \
types-urllib3 typing-extensions unicorn falcon starlette \
## BDD Functional Tests (`test/bdd`)
Functional tests are written as BDD instructions. For more information on
-the philosophy of BDD testing, see the
-[Behave manual](http://pythonhosted.org/behave/philosophy.html).
-
-The following explanation assume that the reader is familiar with the BDD
-notations of features, scenarios and steps.
-
-All possible steps can be found in the `steps` directory and should ideally
-be documented.
+the philosophy of BDD testing, read the Wikipedia article on
+[Behaviour-driven development](https://en.wikipedia.org/wiki/Behavior-driven_development).
### General Usage
To run the functional tests, do
- cd test/bdd
- behave
-
-The tests can be configured with a set of environment variables (`behave -D key=val`):
-
- * `TEMPLATE_DB` - name of template database used as a skeleton for
- the test databases (db tests)
- * `TEST_DB` - name of test database (db tests)
- * `API_TEST_DB` - name of the database containing the API test data (api tests)
- * `API_TEST_FILE` - OSM file to be imported into the API test database (api tests)
- * `API_ENGINE` - webframe to use for running search queries, same values as
- `nominatim serve --engine` parameter
- * `DB_HOST` - (optional) hostname of database host
- * `DB_PORT` - (optional) port of database on host
- * `DB_USER` - (optional) username of database login
- * `DB_PASS` - (optional) password for database login
- * `REMOVE_TEMPLATE` - if true, the template and API database will not be reused
- during the next run. Reusing the base templates speeds
- up tests considerably but might lead to outdated errors
- for some changes in the database layout.
- * `KEEP_TEST_DB` - if true, the test database will not be dropped after a test
- is finished. Should only be used if one single scenario is
- run, otherwise the result is undefined.
-
-Logging can be defined through command line parameters of behave itself. Check
-out `behave --help` for details. Also have a look at the 'work-in-progress'
-feature of behave which comes in handy when writing new tests.
+ pytest test/bdd
+
+The BDD tests create databases for the tests. You can set name of the databases
+through configuration variables in your `pytest.ini`:
+
+ * `nominatim_test_db` defines the name of the temporary database created for
+ a single test (default: `test_nominatim`)
+ * `nominatim_api_test_db` defines the name of the database containing
+ the API test data, see also below (default: `test_api_nominatim`)
+ * `nominatim_template_db` defines the name of the template database used
+ for creating the temporary test databases. It contains some static setup
+ which usually doesn't change between imports of OSM data
+ (default: `test_template_nominatim`)
+
+To change other connection parameters for the PostgreSQL database, use
+the [libpq enivronment variables](https://www.postgresql.org/docs/current/libpq-envars.html).
+Never set a password through these variables. Use a
+[password file](https://www.postgresql.org/docs/current/libpq-pgpass.html) instead.
+
+The API test database and the template database are only created once and then
+left untouched. This is usually what you want because it speeds up subsequent
+runs of BDD tests. If you do change code that has an influence on the content
+of these databases, you can run pytest with the `--nominatim-purge` parameter
+and the databases will be dropped and recreated from scratch.
+
+When running the BDD tests with make (using `make tests` or `make bdd`), then
+the databases will always be purged.
+
+The temporary test database is usually dropped directly after the test, so
+it does not take up unnecessary space. If you want to keep the database around,
+for example while debugging a specific BDD test, use the parameter
+`--nominatim-keep-db`.
+
### API Tests (`test/bdd/api`)
These tests are meant to test the different API endpoints and their parameters.
They require to import several datasets into a test database. This is normally
done automatically during setup of the test. The API test database is then
-kept around and reused in subsequent runs of behave. Use `behave -DREMOVE_TEMPLATE`
+kept around and reused in subsequent runs of behave. Use `--nominatim-purge`
to force a reimport of the database.
The official test dataset is saved in the file `test/testdb/apidb-test-data.pbf`
table (and optionally the `planet_osm_*` tables if required) and then run
Nominatim's processing functions on that.
-These tests need to create their own test databases. By default they will be
-called `test_template_nominatim` and `test_nominatim`. Names can be changed with
-the environment variables `TEMPLATE_DB` and `TEST_DB`. The user running the tests
-needs superuser rights for postgres.
+These tests use the template database and create temporary test databases for
+each test.
### Import Tests (`test/bdd/osm2pgsql`)
-These tests check that data is imported correctly into the place table. They
-use the same template database as the DB Creation tests, so the same remarks apply.
+These tests check that data is imported correctly into the place table.
+
+These tests also use the template database and create temporary test databases
+for each test.
passing_place = group,
street_lamp = 'named',
traffic_signals = 'named'},
- historic = {'always',
+ historic = {'fallback',
yes = group,
no = group},
information = {include_when_tag_present('tourism', 'information'),
shop = {'always',
no = group},
tourism = {'always',
+ attraction = 'fallback',
no = group,
yes = group,
information = exclude_when_key_present('information')},
[project]
name = "nominatim-api"
-version = "5.1.0.post1"
+version = "5.1.0.post5"
description = "A tool for building a database of OpenStreetMap for geocoding and for searching the database. Search library."
readme = "README.md"
requires-python = ">=3.7"
dependencies = [
"SQLAlchemy==2.0.40",
"falcon==4.0.2",
- "uvicorn==0.34.0",
+ "uvicorn==0.34.1",
"gunicorn==23.0.0"
]
[project]
name = "nominatim-db"
-version = "5.1.0.post1"
+version = "5.1.0.post5"
description = "A tool for building a database of OpenStreetMap for geocoding and for searching the database. Database backend."
readme = "README.md"
requires-python = ">=3.7"
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Conversion from token assignment to an abstract DB search.
if address:
sdata.lookups = [dbf.FieldLookup('nameaddress_vector',
[t.token for r in address
- for t in self.query.get_partials_list(r)],
+ for t in self.query.iter_partials(r)],
lookups.Restrict)]
yield dbs.PostcodeSearch(penalty, sdata)
expected_count = sum(t.count for t in hnrs)
partials = {t.token: t.addr_count for trange in address
- for t in self.query.get_partials_list(trange)}
+ for t in self.query.iter_partials(trange)}
if not partials:
# can happen when none of the partials is indexed
are and tries to find a lookup that optimizes index use.
"""
penalty = 0.0 # extra penalty
- name_partials = {t.token: t for t in self.query.get_partials_list(name)}
+ name_partials = {t.token: t for t in self.query.iter_partials(name)}
- addr_partials = [t for r in address for t in self.query.get_partials_list(r)]
+ addr_partials = [t for r in address for t in self.query.iter_partials(r)]
addr_tokens = list({t.token for t in addr_partials})
exp_count = min(t.count for t in name_partials.values()) / (3**(len(name_partials) - 1))
ranks = [dbf.RankedTokens(t.penalty, [t.token]) for t in name_fulls]
ranks.sort(key=lambda r: r.penalty)
# Fallback, sum of penalty for partials
- name_partials = self.query.get_partials_list(trange)
- default = sum(t.penalty for t in name_partials) + 0.2
+ default = sum(t.penalty for t in self.query.iter_partials(trange)) + 0.2
return dbf.FieldRanking(db_field, default, ranks)
def get_addr_ranking(self, trange: qmod.TokenRange) -> dbf.FieldRanking:
while todo:
neglen, pos, rank = heapq.heappop(todo)
+ # partial node
+ partial = self.query.nodes[pos].partial
+ if partial is not None:
+ if pos + 1 < trange.end:
+ penalty = rank.penalty + partial.penalty \
+ + PENALTY_WORDCHANGE[self.query.nodes[pos + 1].btype]
+ heapq.heappush(todo, (neglen - 1, pos + 1,
+ dbf.RankedTokens(penalty, rank.tokens)))
+ else:
+ ranks.append(dbf.RankedTokens(rank.penalty + partial.penalty,
+ rank.tokens))
+ # full words
for tlist in self.query.nodes[pos].starting:
- if tlist.ttype in (qmod.TOKEN_PARTIAL, qmod.TOKEN_WORD):
+ if tlist.ttype == qmod.TOKEN_WORD:
if tlist.end < trange.end:
chgpenalty = PENALTY_WORDCHANGE[self.query.nodes[tlist.end].btype]
- if tlist.ttype == qmod.TOKEN_PARTIAL:
- penalty = rank.penalty + chgpenalty \
- + max(t.penalty for t in tlist.tokens)
+ for t in tlist.tokens:
heapq.heappush(todo, (neglen - 1, tlist.end,
- dbf.RankedTokens(penalty, rank.tokens)))
- else:
- for t in tlist.tokens:
- heapq.heappush(todo, (neglen - 1, tlist.end,
- rank.with_token(t, chgpenalty)))
+ rank.with_token(t, chgpenalty)))
elif tlist.end == trange.end:
- if tlist.ttype == qmod.TOKEN_PARTIAL:
- ranks.append(dbf.RankedTokens(rank.penalty
- + max(t.penalty for t in tlist.tokens),
- rank.tokens))
- else:
- ranks.extend(rank.with_token(t, 0.0) for t in tlist.tokens)
- if len(ranks) >= 10:
- # Too many variants, bail out and only add
- # Worst-case Fallback: sum of penalty of partials
- name_partials = self.query.get_partials_list(trange)
- default = sum(t.penalty for t in name_partials) + 0.2
- ranks.append(dbf.RankedTokens(rank.penalty + default, []))
- # Bail out of outer loop
- todo.clear()
- break
+ ranks.extend(rank.with_token(t, 0.0) for t in tlist.tokens)
+
+ if len(ranks) >= 10:
+ # Too many variants, bail out and only add
+ # Worst-case Fallback: sum of penalty of partials
+ default = sum(t.penalty for t in self.query.iter_partials(trange)) + 0.2
+ ranks.append(dbf.RankedTokens(rank.penalty + default, []))
+ # Bail out of outer loop
+ break
ranks.sort(key=lambda r: len(r.tokens))
default = ranks[0].penalty + 0.3
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Public interface to the search code.
self.query_analyzer = await make_query_analyzer(self.conn)
query = await self.query_analyzer.analyze_query(phrases)
+ query.compute_direction_penalty()
+ log().var_dump('Query direction penalty',
+ lambda: f"[{'LR' if query.dir_penalty < 0 else 'RL'}] {query.dir_penalty}")
searches: List[AbstractSearch] = []
if query.num_token_slots() > 0:
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Implementation of query analysis for the ICU tokenizer.
def rerank_tokens(self, query: qmod.QueryStruct) -> None:
""" Add penalties to tokens that depend on presence of other token.
"""
- for i, node, tlist in query.iter_token_lists():
- if tlist.ttype == qmod.TOKEN_POSTCODE:
- tlen = len(cast(ICUToken, tlist.tokens[0]).word_token)
- for repl in node.starting:
- if repl.end == tlist.end and repl.ttype != qmod.TOKEN_POSTCODE \
- and (repl.ttype != qmod.TOKEN_HOUSENUMBER or tlen > 4):
- repl.add_penalty(0.39)
- elif (tlist.ttype == qmod.TOKEN_HOUSENUMBER
- and len(tlist.tokens[0].lookup_word) <= 3):
- if any(c.isdigit() for c in tlist.tokens[0].lookup_word):
- for repl in node.starting:
- if repl.end == tlist.end and repl.ttype != qmod.TOKEN_HOUSENUMBER:
- repl.add_penalty(0.5 - tlist.tokens[0].penalty)
- elif tlist.ttype not in (qmod.TOKEN_COUNTRY, qmod.TOKEN_PARTIAL):
- norm = ' '.join(n.term_normalized for n in query.nodes[i + 1:tlist.end + 1]
- if n.btype != qmod.BREAK_TOKEN)
- if not norm:
- # Can happen when the token only covers a partial term
- norm = query.nodes[i + 1].term_normalized
- for token in tlist.tokens:
- cast(ICUToken, token).rematch(norm)
+ for start, end, tlist in query.iter_tokens_by_edge():
+ if len(tlist) > 1:
+ # If it looks like a Postcode, give preference.
+ if qmod.TOKEN_POSTCODE in tlist:
+ for ttype, tokens in tlist.items():
+ if ttype != qmod.TOKEN_POSTCODE and \
+ (ttype != qmod.TOKEN_HOUSENUMBER or
+ start + 1 > end or
+ len(query.nodes[end].term_lookup) > 4):
+ for token in tokens:
+ token.penalty += 0.39
+
+ # If it looks like a simple housenumber, prefer that.
+ if qmod.TOKEN_HOUSENUMBER in tlist:
+ hnr_lookup = tlist[qmod.TOKEN_HOUSENUMBER][0].lookup_word
+ if len(hnr_lookup) <= 3 and any(c.isdigit() for c in hnr_lookup):
+ penalty = 0.5 - tlist[qmod.TOKEN_HOUSENUMBER][0].penalty
+ for ttype, tokens in tlist.items():
+ if ttype != qmod.TOKEN_HOUSENUMBER:
+ for token in tokens:
+ token.penalty += penalty
+
+ # rerank tokens against the normalized form
+ norm = ' '.join(n.term_normalized for n in query.nodes[start + 1:end + 1]
+ if n.btype != qmod.BREAK_TOKEN)
+ if not norm:
+ # Can happen when the token only covers a partial term
+ norm = query.nodes[start + 1].term_normalized
+ for ttype, tokens in tlist.items():
+ if ttype != qmod.TOKEN_COUNTRY:
+ for token in tokens:
+ cast(ICUToken, token).rematch(norm)
def _dump_word_tokens(query: qmod.QueryStruct) -> Iterator[List[Any]]:
yield ['type', 'from', 'to', 'token', 'word_token', 'lookup_word', 'penalty', 'count', 'info']
for i, node in enumerate(query.nodes):
+ if node.partial is not None:
+ t = cast(ICUToken, node.partial)
+ yield [qmod.TOKEN_PARTIAL, str(i), str(i + 1), t.token,
+ t.word_token, t.lookup_word, t.penalty, t.count, t.info]
for tlist in node.starting:
for token in tlist.tokens:
t = cast(ICUToken, token)
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Datastructures for a tokenized query.
from collections import defaultdict
import dataclasses
+# Precomputed denominator for the computation of the linear regression slope
+# used to determine the query direction.
+# The x value for the regression computation will be the position of the
+# token in the query. Thus we know the x values will be [0, query length).
+# As the denominator only depends on the x values, we can pre-compute here
+# the denominatior to use for a given query length.
+# Note that query length of two or less is special cased and will not use
+# the values from this array. Thus it is not a problem that they are 0.
+LINFAC = [i * (sum(si * si for si in range(i)) - (i - 1) * i * (i - 1) / 4)
+ for i in range(50)]
+
BreakType = str
""" Type of break between tokens.
""" Penalty for the break at this node.
"""
term_lookup: str
- """ Transliterated term following this node.
+ """ Transliterated term ending at this node.
"""
term_normalized: str
- """ Normalised form of term following this node.
+ """ Normalised form of term ending at this node.
When the token resulted from a split during transliteration,
then this string contains the complete source term.
"""
starting: List[TokenList] = dataclasses.field(default_factory=list)
+ """ List of all full tokens starting at this node.
+ """
+ partial: Optional[Token] = None
+ """ Base token going to the next node.
+ May be None when the query has parts for which no words are known.
+ Note that the query may still be parsable when there are other
+ types of tokens spanning over the gap.
+ """
+
+ def name_address_ratio(self) -> float:
+ """ Return the propability that the partial token belonging to
+ this node forms part of a name (as opposed of part of the address).
+ """
+ if self.partial is None:
+ return 0.5
+
+ return self.partial.count / (self.partial.count + self.partial.addr_count)
def adjust_break(self, btype: BreakType, penalty: float) -> None:
""" Change the break type and penalty for this node.
need to be direct neighbours. Thus the query is represented as a
directed acyclic graph.
+ A query also has a direction penalty 'dir_penalty'. This describes
+ the likelyhood if the query should be read from left-to-right or
+ vice versa. A negative 'dir_penalty' should be read as a penalty on
+ right-to-left reading, while a positive value represents a penalty
+ for left-to-right reading. The default value is 0, which is equivalent
+ to having no information about the reading.
+
When created, a query contains a single node: the start of the
query. Further nodes can be added by appending to 'nodes'.
"""
def __init__(self, source: List[Phrase]) -> None:
self.source = source
+ self.dir_penalty = 0.0
self.nodes: List[QueryNode] = \
[QueryNode(BREAK_START, source[0].ptype if source else PHRASE_ANY,
0.0, '', '')]
be added to, then the token is silently dropped.
"""
snode = self.nodes[trange.start]
- full_phrase = snode.btype in (BREAK_START, BREAK_PHRASE)\
- and self.nodes[trange.end].btype in (BREAK_PHRASE, BREAK_END)
- if _phrase_compatible_with(snode.ptype, ttype, full_phrase):
- tlist = snode.get_tokens(trange.end, ttype)
- if tlist is None:
- snode.starting.append(TokenList(trange.end, ttype, [token]))
- else:
- tlist.append(token)
+ if ttype == TOKEN_PARTIAL:
+ assert snode.partial is None
+ if _phrase_compatible_with(snode.ptype, TOKEN_PARTIAL, False):
+ snode.partial = token
+ else:
+ full_phrase = snode.btype in (BREAK_START, BREAK_PHRASE)\
+ and self.nodes[trange.end].btype in (BREAK_PHRASE, BREAK_END)
+ if _phrase_compatible_with(snode.ptype, ttype, full_phrase):
+ tlist = snode.get_tokens(trange.end, ttype)
+ if tlist is None:
+ snode.starting.append(TokenList(trange.end, ttype, [token]))
+ else:
+ tlist.append(token)
+
+ def compute_direction_penalty(self) -> None:
+ """ Recompute the direction probability from the partial tokens
+ of each node.
+ """
+ n = len(self.nodes) - 1
+ if n == 1 or n >= 50:
+ self.dir_penalty = 0
+ elif n == 2:
+ self.dir_penalty = (self.nodes[1].name_address_ratio()
+ - self.nodes[0].name_address_ratio()) / 3
+ else:
+ ratios = [n.name_address_ratio() for n in self.nodes[:-1]]
+ self.dir_penalty = (n * sum(i * r for i, r in enumerate(ratios))
+ - sum(ratios) * n * (n - 1) / 2) / LINFAC[n]
def get_tokens(self, trange: TokenRange, ttype: TokenType) -> List[Token]:
""" Get the list of tokens of a given type, spanning the given
nodes. The nodes must exist. If no tokens exist, an
empty list is returned.
+
+ Cannot be used to get the partial token.
"""
+ assert ttype != TOKEN_PARTIAL
return self.nodes[trange.start].get_tokens(trange.end, ttype) or []
- def get_partials_list(self, trange: TokenRange) -> List[Token]:
- """ Create a list of partial tokens between the given nodes.
- The list is composed of the first token of type PARTIAL
- going to the subsequent node. Such PARTIAL tokens are
- assumed to exist.
+ def iter_partials(self, trange: TokenRange) -> Iterator[Token]:
+ """ Iterate over the partial tokens between the given nodes.
+ Missing partials are ignored.
"""
- return [next(iter(self.get_tokens(TokenRange(i, i+1), TOKEN_PARTIAL)))
- for i in range(trange.start, trange.end)]
+ return (n.partial for n in self.nodes[trange.start:trange.end] if n.partial is not None)
+
+ def iter_tokens_by_edge(self) -> Iterator[Tuple[int, int, Dict[TokenType, List[Token]]]]:
+ """ Iterator over all tokens except partial ones grouped by edge.
- def iter_token_lists(self) -> Iterator[Tuple[int, QueryNode, TokenList]]:
- """ Iterator over all token lists in the query.
+ Returns the start and end node indexes and a dictionary
+ of list of tokens by token type.
"""
for i, node in enumerate(self.nodes):
+ by_end: Dict[int, Dict[TokenType, List[Token]]] = defaultdict(dict)
for tlist in node.starting:
- yield i, node, tlist
+ by_end[tlist.end][tlist.ttype] = tlist.tokens
+ for end, endlist in by_end.items():
+ yield i, end, endlist
def find_lookup_word_by_id(self, token: int) -> str:
""" Find the first token with the given token ID and return
debugging.
"""
for node in self.nodes:
+ if node.partial is not None and node.partial.token == token:
+ return f"[P]{node.partial.lookup_word}"
for tlist in node.starting:
for t in tlist.tokens:
if t.token == token:
words: Dict[str, List[TokenRange]] = defaultdict(list)
- for first in range(start, endpos - 1):
- word = self.nodes[first + 1].term_lookup
+ for first, first_node in enumerate(self.nodes[start + 1:endpos], start):
+ word = first_node.term_lookup
penalty = base_penalty
words[word].append(TokenRange(first, first + 1, penalty=penalty))
- if self.nodes[first + 1].btype != BREAK_PHRASE:
- for last in range(first + 2, min(first + 20, endpos)):
- word = ' '.join((word, self.nodes[last].term_lookup))
- penalty += self.nodes[last - 1].penalty
+ if first_node.btype != BREAK_PHRASE:
+ penalty += first_node.penalty
+ max_last = min(first + 20, endpos)
+ for last, last_node in enumerate(self.nodes[first + 2:max_last], first + 2):
+ word = ' '.join((word, last_node.term_lookup))
words[word].append(TokenRange(first, last, penalty=penalty))
- if self.nodes[last].btype == BREAK_PHRASE:
+ if last_node.btype == BREAK_PHRASE:
break
+ penalty += last_node.penalty
return words
log().var_dump('skip forward', (base.postcode, first))
return
+ penalty = self.penalty
+ if self.direction == 1 and query.dir_penalty > 0:
+ penalty += query.dir_penalty
+
log().comment('first word = name')
- yield dataclasses.replace(base, penalty=self.penalty,
+ yield dataclasses.replace(base, penalty=penalty,
name=first, address=base.address[1:])
# To paraphrase:
or (query.nodes[first.start].ptype != qmod.PHRASE_ANY):
return
- penalty = self.penalty
-
# Penalty for:
# * <name>, <street>, <housenumber> , ...
# * queries that are comma-separated
if (base.housenumber and base.housenumber > first) or len(query.source) > 1:
penalty += 0.25
+ if self.direction == 0 and query.dir_penalty > 0:
+ penalty += query.dir_penalty
+
for i in range(first.start + 1, first.end):
name, addr = first.split(i)
log().comment(f'split first word = name ({i - first.start})')
log().var_dump('skip backward', (base.postcode, last))
return
+ penalty = self.penalty
+ if self.direction == -1 and query.dir_penalty < 0:
+ penalty -= query.dir_penalty
+
if self.direction == -1 or len(base.address) > 1 or base.postcode:
log().comment('last word = name')
- yield dataclasses.replace(base, penalty=self.penalty,
+ yield dataclasses.replace(base, penalty=penalty,
name=last, address=base.address[:-1])
# To paraphrase:
or (query.nodes[last.start].ptype != qmod.PHRASE_ANY):
return
- penalty = self.penalty
if base.housenumber and base.housenumber < last:
penalty += 0.4
if len(query.source) > 1:
penalty += 0.25
+ if self.direction == 0 and query.dir_penalty < 0:
+ penalty -= query.dir_penalty
+
for i in range(last.start + 1, last.end):
addr, name = last.split(i)
log().comment(f'split last word = name ({i - last.start})')
if base.postcode and base.postcode.start == 0:
self.penalty += 0.1
- # Right-to-left reading of the address
+ # Left-to-right reading of the address
if self.direction != -1:
yield from self._get_assignments_address_forward(base, query)
- # Left-to-right reading of the address
+ # Right-to-left reading of the address
if self.direction != 1:
yield from self._get_assignments_address_backward(base, query)
node = query.nodes[state.end_pos]
for tlist in node.starting:
- newstate = state.advance(tlist.ttype, tlist.end, node.btype)
- if newstate is not None:
- if newstate.end_pos == query.num_token_slots():
- if newstate.recheck_sequence():
- log().var_dump('Assignment', newstate)
- yield from newstate.get_assignments(query)
- elif not newstate.is_final():
- todo.append(newstate)
+ yield from _append_state_to_todo(
+ query, todo,
+ state.advance(tlist.ttype, tlist.end, node.btype))
+
+ if node.partial is not None:
+ yield from _append_state_to_todo(
+ query, todo,
+ state.advance(qmod.TOKEN_PARTIAL, state.end_pos + 1, node.btype))
+
+
+def _append_state_to_todo(query: qmod.QueryStruct, todo: List[_TokenSequence],
+ newstate: Optional[_TokenSequence]) -> Iterator[TokenAssignment]:
+ if newstate is not None:
+ if newstate.end_pos == query.num_token_slots():
+ if newstate.recheck_sequence():
+ log().var_dump('Assignment', newstate)
+ yield from newstate.get_assignments(query)
+ elif not newstate.is_final():
+ todo.append(newstate)
_write_osm_id(out, result.osm_object)
- out.keyval('lat', f"{result.centroid.lat}")\
- .keyval('lon', f"{result.centroid.lon}")\
+ # lat and lon must be string values
+ out.keyval('lat', f"{result.centroid.lat:0.7f}")\
+ .keyval('lon', f"{result.centroid.lon:0.7f}")\
.keyval(class_label, result.category[0])\
.keyval('type', result.category[1])\
.keyval('place_rank', result.rank_search)\
if options.get('namedetails', False):
out.keyval('namedetails', result.names)
+ # must be string values
bbox = cl.bbox_from_result(result)
out.key('boundingbox').start_array()\
.value(f"{bbox.minlat:0.7f}").next()\
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Abstract class definitions for tokenizers. These base classes are here
"""
from abc import ABC, abstractmethod
from typing import List, Tuple, Dict, Any, Optional, Iterable
-from pathlib import Path
from ..typing import Protocol
from ..config import Configuration
own tokenizer.
"""
- def create(self, dsn: str, data_dir: Path) -> AbstractTokenizer:
+ def create(self, dsn: str) -> AbstractTokenizer:
""" Factory for new tokenizers.
"""
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Functions for creating a tokenizer or initialising the right one for an
if module_name is None:
module_name = config.TOKENIZER
- # Create the directory for the tokenizer data
- assert config.project_dir is not None
- basedir = config.project_dir / 'tokenizer'
- if not basedir.exists():
- basedir.mkdir()
- elif not basedir.is_dir():
- LOG.fatal("Tokenizer directory '%s' cannot be created.", basedir)
- raise UsageError("Tokenizer setup failed.")
-
# Import and initialize the tokenizer.
tokenizer_module = _import_tokenizer(module_name)
- tokenizer = tokenizer_module.create(config.get_libpq_dsn(), basedir)
+ tokenizer = tokenizer_module.create(config.get_libpq_dsn())
tokenizer.init_new_db(config, init_db=init_db)
with connect(config.get_libpq_dsn()) as conn:
The function looks up the appropriate tokenizer in the database
and initialises it.
"""
- assert config.project_dir is not None
- basedir = config.project_dir / 'tokenizer'
- if not basedir.is_dir():
- # Directory will be repopulated by tokenizer below.
- basedir.mkdir()
-
with connect(config.get_libpq_dsn()) as conn:
name = properties.get_property(conn, 'tokenizer')
tokenizer_module = _import_tokenizer(name)
- tokenizer = tokenizer_module.create(config.get_libpq_dsn(), basedir)
+ tokenizer = tokenizer_module.create(config.get_libpq_dsn())
tokenizer.init_from_project(config)
return tokenizer
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Tokenizer implementing normalisation as used before Nominatim 4 but using
Dict, Set, Iterable
import itertools
import logging
-from pathlib import Path
from psycopg.types.json import Jsonb
from psycopg import sql as pysql
('housenumbers', 'H'))
-def create(dsn: str, data_dir: Path) -> 'ICUTokenizer':
+def create(dsn: str) -> 'ICUTokenizer':
""" Create a new instance of the tokenizer provided by this module.
"""
- return ICUTokenizer(dsn, data_dir)
+ return ICUTokenizer(dsn)
class ICUTokenizer(AbstractTokenizer):
normalization routines in Nominatim 3.
"""
- def __init__(self, dsn: str, data_dir: Path) -> None:
+ def __init__(self, dsn: str) -> None:
self.dsn = dsn
- self.data_dir = data_dir
self.loader: Optional[ICURuleLoader] = None
def init_new_db(self, config: Configuration, init_db: bool = True) -> None:
#
# This file is part of Nominatim. (https://nominatim.org)
#
-# Copyright (C) 2024 by the Nominatim developer community.
+# Copyright (C) 2025 by the Nominatim developer community.
# For a full list of authors see the git log.
"""
Functions for importing, updating and otherwise maintaining the table
if normalized:
self.collected[normalized] += (x, y)
- def commit(self, conn: Connection, analyzer: AbstractAnalyzer, project_dir: Path) -> None:
- """ Update postcodes for the country from the postcodes selected so far
- as well as any externally supplied postcodes.
+ def commit(self, conn: Connection, analyzer: AbstractAnalyzer,
+ project_dir: Optional[Path]) -> None:
+ """ Update postcodes for the country from the postcodes selected so far.
+
+ When 'project_dir' is set, then any postcode files found in this
+ directory are taken into account as well.
"""
- self._update_from_external(analyzer, project_dir)
+ if project_dir is not None:
+ self._update_from_external(analyzer, project_dir)
to_add, to_delete, to_update = self._compute_changes(conn)
LOG.info("Processing country '%s' (%s added, %s deleted, %s updated).",
return None
-def update_postcodes(dsn: str, project_dir: Path, tokenizer: AbstractTokenizer) -> None:
+def update_postcodes(dsn: str, project_dir: Optional[Path], tokenizer: AbstractTokenizer) -> None:
""" Update the table of artificial postcodes.
Computes artificial postcode centroids from the placex table,
+++ /dev/null
-all: bdd python
-
-bdd:
- cd bdd && behave -DREMOVE_TEMPLATE=1
-
-python:
- pytest python
-
-
-.PHONY: bdd python
+++ /dev/null
-[behave]
-show_skipped=False
-default_tags=~@Fail
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Localization of search results
-
- Scenario: default language
- When sending details query for R1155955
- Then results contain
- | ID | localname |
- | 0 | Liechtenstein |
-
- Scenario: accept-language first
- When sending details query for R1155955
- | accept-language |
- | zh,de |
- Then results contain
- | ID | localname |
- | 0 | 列支敦士登 |
-
- Scenario: accept-language missing
- When sending details query for R1155955
- | accept-language |
- | xx,fr,en,de |
- Then results contain
- | ID | localname |
- | 0 | Liechtenstein |
-
- Scenario: http accept language header first
- Given the HTTP header
- | accept-language |
- | fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending details query for R1155955
- Then results contain
- | ID | localname |
- | 0 | Liktinstein |
-
- Scenario: http accept language header and accept-language
- Given the HTTP header
- | accept-language |
- | fr-ca,fr;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending details query for R1155955
- | accept-language |
- | fo,en |
- Then results contain
- | ID | localname |
- | 0 | Liktinstein |
-
- Scenario: http accept language header fallback
- Given the HTTP header
- | accept-language |
- | fo-ca,en-ca;q=0.5 |
- When sending details query for R1155955
- Then results contain
- | ID | localname |
- | 0 | Liktinstein |
-
- Scenario: http accept language header fallback (upper case)
- Given the HTTP header
- | accept-language |
- | fo-FR;q=0.8,en-ca;q=0.5 |
- When sending details query for R1155955
- Then results contain
- | ID | localname |
- | 0 | Liktinstein |
+++ /dev/null
-@APIDB
-Feature: Object details
- Testing different parameter options for details API.
-
- @SQLITE
- Scenario: JSON Details
- When sending json details query for W297699560
- Then the result is valid json
- And result has attributes geometry
- And result has not attributes keywords,address,linked_places,parentof
- And results contain in field geometry
- | type |
- | Point |
-
- @SQLITE
- Scenario: JSON Details with pretty printing
- When sending json details query for W297699560
- | pretty |
- | 1 |
- Then the result is valid json
- And result has attributes geometry
- And result has not attributes keywords,address,linked_places,parentof
-
- @SQLITE
- Scenario: JSON Details with addressdetails
- When sending json details query for W297699560
- | addressdetails |
- | 1 |
- Then the result is valid json
- And result has attributes address
-
- @SQLITE
- Scenario: JSON Details with linkedplaces
- When sending json details query for R123924
- | linkedplaces |
- | 1 |
- Then the result is valid json
- And result has attributes linked_places
-
- @SQLITE
- Scenario: JSON Details with hierarchy
- When sending json details query for W297699560
- | hierarchy |
- | 1 |
- Then the result is valid json
- And result has attributes hierarchy
-
- @SQLITE
- Scenario: JSON Details with grouped hierarchy
- When sending json details query for W297699560
- | hierarchy | group_hierarchy |
- | 1 | 1 |
- Then the result is valid json
- And result has attributes hierarchy
-
- Scenario Outline: JSON Details with keywords
- When sending json details query for <osmid>
- | keywords |
- | 1 |
- Then the result is valid json
- And result has attributes keywords
-
- Examples:
- | osmid |
- | W297699560 |
- | W243055645 |
- | W243055716 |
- | W43327921 |
-
- # ticket #1343
- Scenario: Details of a country with keywords
- When sending details query for R1155955
- | keywords |
- | 1 |
- Then the result is valid json
- And result has attributes keywords
-
- @SQLITE
- Scenario Outline: JSON details with full geometry
- When sending json details query for <osmid>
- | polygon_geojson |
- | 1 |
- Then the result is valid json
- And result has attributes geometry
- And results contain in field geometry
- | type |
- | <geometry> |
-
- Examples:
- | osmid | geometry |
- | W297699560 | LineString |
- | W243055645 | Polygon |
- | W243055716 | Polygon |
- | W43327921 | LineString |
-
-
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Object details
- Check details page for correctness
-
- Scenario Outline: Details via OSM id
- When sending details query for <type><id>
- Then the result is valid json
- And results contain
- | osm_type | osm_id |
- | <type> | <id> |
-
- Examples:
- | type | id |
- | N | 5484325405 |
- | W | 43327921 |
- | R | 123924 |
-
-
- Scenario Outline: Details for different class types for the same OSM id
- When sending details query for N300209696:<class>
- Then the result is valid json
- And results contain
- | osm_type | osm_id | category |
- | N | 300209696 | <class> |
-
- Examples:
- | class |
- | tourism |
- | mountain_pass |
-
-
- Scenario Outline: Details via unknown OSM id
- When sending details query for <object>
- Then a HTTP 404 is returned
-
- Examples:
- | object |
- | 1 |
- | R1 |
- | N300209696:highway |
-
-
- Scenario: Details for interpolation way return the interpolation
- When sending details query for W1
- Then the result is valid json
- And results contain
- | category | type | osm_type | osm_id | admin_level |
- | place | houses | W | 1 | 15 |
-
-
- @Fail
- Scenario: Details for interpolation way return the interpolation
- When sending details query for 112871
- Then the result is valid json
- And results contain
- | category | type | admin_level |
- | place | houses | 15 |
- And result has not attributes osm_type,osm_id
-
-
- @Fail
- Scenario: Details for interpolation way return the interpolation
- When sending details query for 112820
- Then the result is valid json
- And results contain
- | category | type | admin_level |
- | place | postcode | 15 |
- And result has not attributes osm_type,osm_id
-
-
- Scenario Outline: Details debug output returns no errors
- When sending debug details query for <feature>
- Then the result is valid html
-
- Examples:
- | feature |
- | N5484325405 |
- | W1 |
- | 112820 |
- | 112871 |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Places by osm_type and osm_id Tests
- Simple tests for errors in various response formats.
-
- Scenario Outline: Force error by providing too many ids
- When sending <format> lookup query for N1,N2,N3,N4,N5,N6,N7,N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20,N21,N22,N23,N24,N25,N26,N27,N28,N29,N30,N31,N32,N33,N34,N35,N36,N37,N38,N39,N40,N41,N42,N43,N44,N45,N46,N47,N48,N49,N50,N51
- Then a <format> user error is returned
-
- Examples:
- | format |
- | xml |
- | json |
- | geojson |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Places by osm_type and osm_id Tests
- Simple tests for response format.
-
- Scenario Outline: address lookup for existing node, way, relation
- When sending <format> lookup query for N5484325405,W43327921,,R123924,X99,N0
- Then the result is valid <outformat>
- And exactly 3 results are returned
-
- Examples:
- | format | outformat |
- | xml | xml |
- | json | json |
- | jsonv2 | json |
- | geojson | geojson |
- | geocodejson | geocodejson |
-
- Scenario: address lookup for non-existing or invalid node, way, relation
- When sending xml lookup query for X99,,N0,nN158845944,ABC,,W9
- Then exactly 0 results are returned
-
- Scenario Outline: Boundingbox is returned
- When sending <format> lookup query for N5484325405,W43327921
- Then exactly 2 results are returned
- And result 0 has bounding box in 47.135,47.14,9.52,9.525
- And result 1 has bounding box in 47.07,47.08,9.50,9.52
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | geojson |
- | xml |
-
-
- Scenario: Lookup of a linked place
- When sending geocodejson lookup query for N1932181216
- Then exactly 1 result is returned
- And results contain
- | name |
- | Vaduz |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Geometries for reverse geocoding
- Tests for returning geometries with reverse
-
-
- Scenario: Polygons are returned fully by default
- When sending v1/reverse at 47.13803,9.52264
- | polygon_text |
- | 1 |
- Then results contain
- | geotext |
- | ^POLYGON\(\(9.5225302 47.138066, ?9.5225348 47.1379282, ?9.5226142 47.1379294, ?9.5226143 47.1379257, ?9.522615 47.137917, ?9.5226225 47.1379098, ?9.5226334 47.1379052, ?9.5226461 47.1379037, ?9.5226588 47.1379056, ?9.5226693 47.1379107, ?9.5226762 47.1379181, ?9.5226762 47.1379268, ?9.5226761 47.1379308, ?9.5227366 47.1379317, ?9.5227352 47.1379753, ?9.5227608 47.1379757, ?9.5227595 47.1380148, ?9.5227355 47.1380145, ?9.5227337 47.1380692, ?9.5225302 47.138066\)\) |
-
-
- Scenario: Polygons can be slightly simplified
- When sending v1/reverse at 47.13803,9.52264
- | polygon_text | polygon_threshold |
- | 1 | 0.00001 |
- Then results contain
- | geotext |
- | ^POLYGON\(\(9.5225302 47.138066, ?9.5225348 47.1379282, ?9.5226142 47.1379294, ?9.5226225 47.1379098, ?9.5226588 47.1379056, ?9.5226761 47.1379308, ?9.5227366 47.1379317, ?9.5227352 47.1379753, ?9.5227608 47.1379757, ?9.5227595 47.1380148, ?9.5227355 47.1380145, ?9.5227337 47.1380692, ?9.5225302 47.138066\)\) |
-
-
- Scenario: Polygons can be much simplified
- When sending v1/reverse at 47.13803,9.52264
- | polygon_text | polygon_threshold |
- | 1 | 0.9 |
- Then results contain
- | geotext |
- | ^POLYGON\(\([0-9. ]+, ?[0-9. ]+, ?[0-9. ]+, ?[0-9. ]+(, ?[0-9. ]+)?\)\) |
-
-
- Scenario: For polygons return the centroid as center point
- When sending v1/reverse at 47.13836,9.52304
- Then results contain
- | centroid |
- | 9.52271080 47.13818045 |
-
-
- Scenario: For streets return the closest point as center point
- When sending v1/reverse at 47.13368,9.52942
- Then results contain
- | centroid |
- | 9.529431527 47.13368172 |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Localization of reverse search results
-
- Scenario: default language
- When sending v1/reverse at 47.14,9.55
- Then result addresses contain
- | ID | country |
- | 0 | Liechtenstein |
-
- Scenario: accept-language parameter
- When sending v1/reverse at 47.14,9.55
- | accept-language |
- | ja,en |
- Then result addresses contain
- | ID | country |
- | 0 | リヒテンシュタイン |
-
- Scenario: HTTP accept language header
- Given the HTTP header
- | accept-language |
- | fo-ca,fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending v1/reverse at 47.14,9.55
- Then result addresses contain
- | ID | country |
- | 0 | Liktinstein |
-
- Scenario: accept-language parameter and HTTP header
- Given the HTTP header
- | accept-language |
- | fo-ca,fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending v1/reverse at 47.14,9.55
- | accept-language |
- | en |
- Then result addresses contain
- | ID | country |
- | 0 | Liechtenstein |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Reverse geocoding
- Testing the reverse function
-
- Scenario Outline: Simple reverse-geocoding with no results
- When sending v1/reverse at <lat>,<lon>
- Then exactly 0 results are returned
-
- Examples:
- | lat | lon |
- | 0.0 | 0.0 |
- | 91.3 | 0.4 |
- | -700 | 0.4 |
- | 0.2 | 324.44 |
- | 0.2 | -180.4 |
-
-
- Scenario: Unknown countries fall back to default country grid
- When sending v1/reverse at 45.174,-103.072
- Then results contain
- | category | type | display_name |
- | place | country | United States |
-
-
- @Tiger
- Scenario: TIGER house number
- When sending v1/reverse at 32.4752389363,-86.4810198619
- Then results contain
- | category | type |
- | place | house |
- And result addresses contain
- | house_number | road | postcode | country_code |
- | 707 | Upper Kingston Road | 36067 | us |
-
- @Tiger
- Scenario: No TIGER house number for zoom < 18
- When sending v1/reverse at 32.4752389363,-86.4810198619
- | zoom |
- | 17 |
- Then results contain
- | osm_type | category |
- | way | highway |
- And result addresses contain
- | road | postcode | country_code |
- | Upper Kingston Road | 36067 | us |
-
- Scenario: Interpolated house number
- When sending v1/reverse at 47.118533,9.57056562
- Then results contain
- | osm_type | category | type |
- | way | place | house |
- And result addresses contain
- | house_number | road |
- | 1019 | Grosssteg |
-
- Scenario: Address with non-numerical house number
- When sending v1/reverse at 47.107465,9.52838521614
- Then result addresses contain
- | house_number | road |
- | 39A/B | Dorfstrasse |
-
-
- Scenario: Address with numerical house number
- When sending v1/reverse at 47.168440329479594,9.511551699184338
- Then result addresses contain
- | house_number | road |
- | 6 | Schmedgässle |
-
- Scenario Outline: Zoom levels below 5 result in country
- When sending v1/reverse at 47.16,9.51
- | zoom |
- | <zoom> |
- Then results contain
- | display_name |
- | Liechtenstein |
-
- Examples:
- | zoom |
- | 0 |
- | 1 |
- | 2 |
- | 3 |
- | 4 |
-
- Scenario: When on a street, the closest interpolation is shown
- When sending v1/reverse at 47.118457166193245,9.570678289621355
- | zoom |
- | 18 |
- Then results contain
- | display_name |
- | 1021, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
-
- # github 2214
- Scenario: Interpolations do not override house numbers when they are closer
- When sending v1/reverse at 47.11778,9.57255
- | zoom |
- | 18 |
- Then results contain
- | display_name |
- | 5, Grosssteg, Steg, Triesenberg, Oberland, 9497, Liechtenstein |
-
- Scenario: Interpolations do not override house numbers when they are closer (2)
- When sending v1/reverse at 47.11834,9.57167
- | zoom |
- | 18 |
- Then results contain
- | display_name |
- | 3, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
-
- Scenario: When on a street with zoom 18, the closest housenumber is returned
- When sending v1/reverse at 47.11755503977281,9.572722250405036
- | zoom |
- | 18 |
- Then result addresses contain
- | house_number |
- | 7 |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Geocodejson for Reverse API
- Testing correctness of geocodejson output (API version v1).
-
- Scenario Outline: Simple OSM result
- When sending v1/reverse at 47.066,9.504 with format geocodejson
- | addressdetails |
- | <has_address> |
- Then result has attributes place_id, accuracy
- And result has <attributes> country,postcode,county,city,district,street,housenumber, admin
- Then results contain
- | osm_type | osm_id | osm_key | osm_value | type |
- | node | 6522627624 | shop | bakery | house |
- And results contain
- | name | label |
- | Dorfbäckerei Herrmann | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
- And results contain in field geojson
- | type | coordinates |
- | Point | [9.5036065, 47.0660892] |
- And results contain in field __geocoding
- | version | licence | attribution |
- | 0.1.0 | ODbL | ^Data © OpenStreetMap contributors, ODbL 1.0. https?://osm.org/copyright$ |
-
- Examples:
- | has_address | attributes |
- | 1 | attributes |
- | 0 | not attributes |
-
-
- Scenario: City housenumber-level address with street
- When sending v1/reverse at 47.1068011,9.52810091 with format geocodejson
- Then results contain
- | housenumber | street | postcode | city | country |
- | 8 | Im Winkel | 9495 | Triesen | Liechtenstein |
- And results contain in field admin
- | level6 | level8 |
- | Oberland | Triesen |
-
-
- Scenario: Town street-level address with street
- When sending v1/reverse at 47.066,9.504 with format geocodejson
- | zoom |
- | 16 |
- Then results contain
- | name | city | postcode | country |
- | Gnetsch | Balzers | 9496 | Liechtenstein |
-
-
- Scenario: Poi street-level address with footway
- When sending v1/reverse at 47.06515,9.50083 with format geocodejson
- Then results contain
- | street | city | postcode | country |
- | Burgweg | Balzers | 9496 | Liechtenstein |
-
-
- Scenario: City address with suburb
- When sending v1/reverse at 47.146861,9.511771 with format geocodejson
- Then results contain
- | housenumber | street | district | city | postcode | country |
- | 5 | Lochgass | Ebenholz | Vaduz | 9490 | Liechtenstein |
-
-
- @Tiger
- Scenario: Tiger address
- When sending v1/reverse at 32.4752389363,-86.4810198619 with format geocodejson
- Then results contain
- | osm_type | osm_id | osm_key | osm_value | type |
- | way | 396009653 | place | house | house |
- And results contain
- | housenumber | street | city | county | postcode | country |
- | 707 | Upper Kingston Road | Prattville | Autauga County | 36067 | United States |
-
-
- Scenario: Interpolation address
- When sending v1/reverse at 47.118533,9.57056562 with format geocodejson
- Then results contain
- | osm_type | osm_id | osm_key | osm_value | type |
- | way | 1 | place | house | house |
- And results contain
- | label |
- | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
- And result has not attributes name
-
-
- Scenario: Line geometry output is supported
- When sending v1/reverse at 47.06597,9.50467 with format geocodejson
- | param | value |
- | polygon_geojson | 1 |
- Then results contain in field geojson
- | type |
- | LineString |
-
-
- Scenario Outline: Only geojson polygons are supported
- When sending v1/reverse at 47.06597,9.50467 with format geocodejson
- | param | value |
- | <param> | 1 |
- Then results contain in field geojson
- | type |
- | Point |
-
- Examples:
- | param |
- | polygon_text |
- | polygon_svg |
- | polygon_kml |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Geojson for Reverse API
- Testing correctness of geojson output (API version v1).
-
- Scenario Outline: Simple OSM result
- When sending v1/reverse at 47.066,9.504 with format geojson
- | addressdetails |
- | <has_address> |
- Then result has attributes place_id, importance, __licence
- And result has <attributes> address
- And results contain
- | osm_type | osm_id | place_rank | category | type | addresstype |
- | node | 6522627624 | 30 | shop | bakery | shop |
- And results contain
- | name | display_name |
- | Dorfbäckerei Herrmann | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
- And results contain
- | boundingbox |
- | [47.0660392, 47.0661392, 9.5035565, 9.5036565] |
- And results contain in field geojson
- | type | coordinates |
- | Point | [9.5036065, 47.0660892] |
-
- Examples:
- | has_address | attributes |
- | 1 | attributes |
- | 0 | not attributes |
-
-
- @Tiger
- Scenario: Tiger address
- When sending v1/reverse at 32.4752389363,-86.4810198619 with format geojson
- Then results contain
- | osm_type | osm_id | category | type | addresstype | place_rank |
- | way | 396009653 | place | house | place | 30 |
-
-
- Scenario: Interpolation address
- When sending v1/reverse at 47.118533,9.57056562 with format geojson
- Then results contain
- | osm_type | osm_id | place_rank | category | type | addresstype |
- | way | 1 | 30 | place | house | place |
- And results contain
- | boundingbox |
- | ^\[47.118495\d*, 47.118595\d*, 9.570496\d*, 9.570596\d*\] |
- And results contain
- | display_name |
- | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
-
-
- Scenario: Line geometry output is supported
- When sending v1/reverse at 47.06597,9.50467 with format geojson
- | param | value |
- | polygon_geojson | 1 |
- Then results contain in field geojson
- | type |
- | LineString |
-
-
- Scenario Outline: Only geojson polygons are supported
- When sending v1/reverse at 47.06597,9.50467 with format geojson
- | param | value |
- | <param> | 1 |
- Then results contain in field geojson
- | type |
- | Point |
-
- Examples:
- | param |
- | polygon_text |
- | polygon_svg |
- | polygon_kml |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Json output for Reverse API
- Testing correctness of json and jsonv2 output (API version v1).
-
- Scenario Outline: OSM result with and without addresses
- When sending v1/reverse at 47.066,9.504 with format json
- | addressdetails |
- | <has_address> |
- Then result has <attributes> address
- When sending v1/reverse at 47.066,9.504 with format jsonv2
- | addressdetails |
- | <has_address> |
- Then result has <attributes> address
-
- Examples:
- | has_address | attributes |
- | 1 | attributes |
- | 0 | not attributes |
-
- Scenario Outline: Simple OSM result
- When sending v1/reverse at 47.066,9.504 with format <format>
- Then result has attributes place_id
- And results contain
- | licence |
- | ^Data © OpenStreetMap contributors, ODbL 1.0. https?://osm.org/copyright$ |
- And results contain
- | osm_type | osm_id |
- | node | 6522627624 |
- And results contain
- | centroid | boundingbox |
- | 9.5036065 47.0660892 | ['47.0660392', '47.0661392', '9.5035565', '9.5036565'] |
- And results contain
- | display_name |
- | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
- And result has not attributes namedetails,extratags
-
- Examples:
- | format |
- | json |
- | jsonv2 |
-
- Scenario: Extra attributes of jsonv2 result
- When sending v1/reverse at 47.066,9.504 with format jsonv2
- Then result has attributes importance
- Then results contain
- | category | type | name | place_rank | addresstype |
- | shop | bakery | Dorfbäckerei Herrmann | 30 | shop |
-
-
- @Tiger
- Scenario: Tiger address
- When sending v1/reverse at 32.4752389363,-86.4810198619 with format jsonv2
- Then results contain
- | osm_type | osm_id | category | type | addresstype |
- | way | 396009653 | place | house | place |
-
-
- Scenario Outline: Interpolation address
- When sending v1/reverse at 47.118533,9.57056562 with format <format>
- Then results contain
- | osm_type | osm_id |
- | way | 1 |
- And results contain
- | centroid | boundingbox |
- | 9.57054676 47.118545392 | ^\['47.118495\d*', '47.118595\d*', '9.570496\d*', '9.570596\d*'\] |
- And results contain
- | display_name |
- | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
-
-
- Scenario Outline: Output of geojson
- When sending v1/reverse at 47.06597,9.50467 with format <format>
- | param | value |
- | polygon_geojson | 1 |
- Then results contain in field geojson
- | type | coordinates |
- | LineString | [[9.5039353, 47.0657546], [9.5040437, 47.0657781], [9.5040808, 47.065787], [9.5054298, 47.0661407]] |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
-
-
- Scenario Outline: Output of WKT
- When sending v1/reverse at 47.06597,9.50467 with format <format>
- | param | value |
- | polygon_text | 1 |
- Then results contain
- | geotext |
- | ^LINESTRING\(9.5039353 47.0657546, ?9.5040437 47.0657781, ?9.5040808 47.065787, ?9.5054298 47.0661407\) |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
-
-
- Scenario Outline: Output of SVG
- When sending v1/reverse at 47.06597,9.50467 with format <format>
- | param | value |
- | polygon_svg | 1 |
- Then results contain
- | svg |
- | M 9.5039353 -47.0657546 L 9.5040437 -47.0657781 9.5040808 -47.065787 9.5054298 -47.0661407 |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
-
-
- Scenario Outline: Output of KML
- When sending v1/reverse at 47.06597,9.50467 with format <format>
- | param | value |
- | polygon_kml | 1 |
- Then results contain
- | geokml |
- | ^<LineString><coordinates>9.5039\d*,47.0657\d* 9.5040\d*,47.0657\d* 9.5040\d*,47.065\d* 9.5054\d*,47.0661\d*</coordinates></LineString> |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: v1/reverse Parameter Tests
- Tests for parameter inputs for the v1 reverse endpoint.
- This file contains mostly bad parameter input. Valid parameters
- are tested in the format tests.
-
- Scenario: Bad format
- When sending v1/reverse at 47.14122383,9.52169581334 with format sdf
- Then a HTTP 400 is returned
-
- Scenario: Missing lon parameter
- When sending v1/reverse at 52.52,
- Then a HTTP 400 is returned
-
-
- Scenario: Missing lat parameter
- When sending v1/reverse at ,52.52
- Then a HTTP 400 is returned
-
-
- Scenario Outline: Bad format for lat or lon
- When sending v1/reverse at ,
- | lat | lon |
- | <lat> | <lon> |
- Then a HTTP 400 is returned
-
- Examples:
- | lat | lon |
- | 48.9660 | 8,4482 |
- | 48,9660 | 8.4482 |
- | 48,9660 | 8,4482 |
- | 48.966.0 | 8.4482 |
- | 48.966 | 8.448.2 |
- | Nan | 8.448 |
- | 48.966 | Nan |
- | Inf | 5.6 |
- | 5.6 | -Inf |
- | <script></script> | 3.4 |
- | 3.4 | <script></script> |
- | -45.3 | ; |
- | gkjd | 50 |
-
-
- Scenario: Non-numerical zoom levels return an error
- When sending v1/reverse at 47.14122383,9.52169581334
- | zoom |
- | adfe |
- Then a HTTP 400 is returned
-
-
- Scenario Outline: Truthy values for boolean parameters
- When sending v1/reverse at 47.14122383,9.52169581334
- | addressdetails |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes address
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | extratags |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes extratags
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | namedetails |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes namedetails
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | polygon_geojson |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes geojson
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | polygon_kml |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes geokml
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | polygon_svg |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes svg
-
- When sending v1/reverse at 47.14122383,9.52169581334
- | polygon_text |
- | <value> |
- Then exactly 1 result is returned
- And result has attributes geotext
-
- Examples:
- | value |
- | yes |
- | no |
- | -1 |
- | 100 |
- | false |
- | 00 |
-
-
- Scenario: Only one geometry can be requested
- When sending v1/reverse at 47.165989816710066,9.515774846076965
- | polygon_text | polygon_svg |
- | 1 | 1 |
- Then a HTTP 400 is returned
-
-
- Scenario Outline: Wrapping of legal jsonp requests
- When sending v1/reverse at 67.3245,0.456 with format <format>
- | json_callback |
- | foo |
- Then the result is valid <outformat>
-
- Examples:
- | format | outformat |
- | json | json |
- | jsonv2 | json |
- | geojson | geojson |
- | geocodejson | geocodejson |
-
-
- Scenario Outline: Illegal jsonp are not allowed
- When sending v1/reverse at 47.165989816710066,9.515774846076965
- | param | value |
- |json_callback | <data> |
- Then a HTTP 400 is returned
-
- Examples:
- | data |
- | 1asd |
- | bar(foo) |
- | XXX['bad'] |
- | foo; evil |
-
-
- Scenario Outline: Reverse debug mode produces valid HTML
- When sending v1/reverse at , with format debug
- | lat | lon |
- | <lat> | <lon> |
- Then the result is valid html
-
- Examples:
- | lat | lon |
- | 0.0 | 0.0 |
- | 47.06645 | 9.56601 |
- | 47.14081 | 9.52267 |
-
-
- Scenario Outline: Full address display for city housenumber-level address with street
- When sending v1/reverse at 47.1068011,9.52810091 with format <format>
- Then address of result 0 is
- | type | value |
- | house_number | 8 |
- | road | Im Winkel |
- | neighbourhood | Oberdorf |
- | village | Triesen |
- | ISO3166-2-lvl8 | LI-09 |
- | county | Oberland |
- | postcode | 9495 |
- | country | Liechtenstein |
- | country_code | li |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | geojson |
- | xml |
-
-
- Scenario Outline: Results with name details
- When sending v1/reverse at 47.14052,9.52202 with format <format>
- | zoom | namedetails |
- | 14 | 1 |
- Then results contain in field namedetails
- | name |
- | Ebenholz |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | xml |
- | geojson |
-
-
- Scenario Outline: Results with extratags
- When sending v1/reverse at 47.14052,9.52202 with format <format>
- | zoom | extratags |
- | 14 | 1 |
- Then results contain in field extratags
- | wikidata |
- | Q4529531 |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | xml |
- | geojson |
-
-
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: XML output for Reverse API
- Testing correctness of xml output (API version v1).
-
- Scenario Outline: OSM result with and without addresses
- When sending v1/reverse at 47.066,9.504 with format xml
- | addressdetails |
- | <has_address> |
- Then result has attributes place_id
- Then result has <attributes> address
- And results contain
- | osm_type | osm_id | place_rank | address_rank |
- | node | 6522627624 | 30 | 30 |
- And results contain
- | centroid | boundingbox |
- | 9.5036065 47.0660892 | 47.0660392,47.0661392,9.5035565,9.5036565 |
- And results contain
- | ref | display_name |
- | Dorfbäckerei Herrmann | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
-
- Examples:
- | has_address | attributes |
- | 1 | attributes |
- | 0 | not attributes |
-
-
- @Tiger
- Scenario: Tiger address
- When sending v1/reverse at 32.4752389363,-86.4810198619 with format xml
- Then results contain
- | osm_type | osm_id | place_rank | address_rank |
- | way | 396009653 | 30 | 30 |
- And results contain
- | centroid | boundingbox |
- | -86.4808553 32.4753580 | ^32.4753080\d*,32.4754080\d*,-86.4809053\d*,-86.4808053\d* |
- And results contain
- | display_name |
- | 707, Upper Kingston Road, Upper Kingston, Prattville, Autauga County, 36067, United States |
-
-
- Scenario: Interpolation address
- When sending v1/reverse at 47.118533,9.57056562 with format xml
- Then results contain
- | osm_type | osm_id | place_rank | address_rank |
- | way | 1 | 30 | 30 |
- And results contain
- | centroid | boundingbox |
- | 9.57054676 47.118545392 | ^47.118495\d*,47.118595\d*,9.570496\d*,9.570596\d* |
- And results contain
- | display_name |
- | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
-
-
- Scenario: Output of geojson
- When sending v1/reverse at 47.06597,9.50467 with format xml
- | param | value |
- | polygon_geojson | 1 |
- Then results contain
- | geojson |
- | {"type":"LineString","coordinates":[[9.5039353,47.0657546],[9.5040437,47.0657781],[9.5040808,47.065787],[9.5054298,47.0661407]]} |
-
-
- Scenario: Output of WKT
- When sending v1/reverse at 47.06597,9.50467 with format xml
- | param | value |
- | polygon_text | 1 |
- Then results contain
- | geotext |
- | ^LINESTRING\(9.5039353 47.0657546, ?9.5040437 47.0657781, ?9.5040808 47.065787, ?9.5054298 47.0661407\) |
-
-
- Scenario: Output of SVG
- When sending v1/reverse at 47.06597,9.50467 with format xml
- | param | value |
- | polygon_svg | 1 |
- Then results contain
- | geosvg |
- | M 9.5039353 -47.0657546 L 9.5040437 -47.0657781 9.5040808 -47.065787 9.5054298 -47.0661407 |
-
-
- Scenario: Output of KML
- When sending v1/reverse at 47.06597,9.50467 with format xml
- | param | value |
- | polygon_kml | 1 |
- Then results contain
- | geokml |
- | ^<geokml><LineString><coordinates>9.5039\d*,47.0657\d* 9.5040\d*,47.0657\d* 9.5040\d*,47.065\d* 9.5054\d*,47.0661\d*</coordinates></LineString></geokml> |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Parameters for Search API
- Testing correctness of geocodejson output.
-
- Scenario: City housenumber-level address with street
- When sending geocodejson search query "Im Winkel 8, Triesen" with address
- Then results contain
- | housenumber | street | postcode | city | country |
- | 8 | Im Winkel | 9495 | Triesen | Liechtenstein |
-
- Scenario: Town street-level address with street
- When sending geocodejson search query "Gnetsch, Balzers" with address
- Then results contain
- | name | city | postcode | country |
- | Gnetsch | Balzers | 9496 | Liechtenstein |
-
- Scenario: Town street-level address with footway
- When sending geocodejson search query "burg gutenberg 6000 jahre geschichte" with address
- Then results contain
- | street | city | postcode | country |
- | Burgweg | Balzers | 9496 | Liechtenstein |
-
- Scenario: City address with suburb
- When sending geocodejson search query "Lochgass 5, Ebenholz, Vaduz" with address
- Then results contain
- | housenumber | street | district | city | postcode | country |
- | 5 | Lochgass | Ebenholz | Vaduz | 9490 | Liechtenstein |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Localization of search results
-
- Scenario: default language
- When sending json search query "Liechtenstein"
- Then results contain
- | ID | display_name |
- | 0 | Liechtenstein |
-
- Scenario: accept-language first
- When sending json search query "Liechtenstein"
- | accept-language |
- | zh,de |
- Then results contain
- | ID | display_name |
- | 0 | 列支敦士登 |
-
- Scenario: accept-language missing
- When sending json search query "Liechtenstein"
- | accept-language |
- | xx,fr,en,de |
- Then results contain
- | ID | display_name |
- | 0 | Liechtenstein |
-
- Scenario: http accept language header first
- Given the HTTP header
- | accept-language |
- | fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending json search query "Liechtenstein"
- Then results contain
- | ID | display_name |
- | 0 | Liktinstein |
-
- Scenario: http accept language header and accept-language
- Given the HTTP header
- | accept-language |
- | fr-ca,fr;q=0.8,en-ca;q=0.5,en;q=0.3 |
- When sending json search query "Liechtenstein"
- | accept-language |
- | fo,en |
- Then results contain
- | ID | display_name |
- | 0 | Liktinstein |
-
- Scenario: http accept language header fallback
- Given the HTTP header
- | accept-language |
- | fo-ca,en-ca;q=0.5 |
- When sending json search query "Liechtenstein"
- Then results contain
- | ID | display_name |
- | 0 | Liktinstein |
-
- Scenario: http accept language header fallback (upper case)
- Given the HTTP header
- | accept-language |
- | fo-FR;q=0.8,en-ca;q=0.5 |
- When sending json search query "Liechtenstein"
- Then results contain
- | ID | display_name |
- | 0 | Liktinstein |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Search queries
- Testing different queries and parameters
-
- Scenario: Simple XML search
- When sending xml search query "Schaan"
- Then result 0 has attributes place_id,osm_type,osm_id
- And result 0 has attributes place_rank,boundingbox
- And result 0 has attributes lat,lon,display_name
- And result 0 has attributes class,type,importance
- And result 0 has not attributes address
- And result 0 has bounding box in 46.5,47.5,9,10
-
- Scenario: Simple JSON search
- When sending json search query "Vaduz"
- Then result 0 has attributes place_id,licence,class,type
- And result 0 has attributes osm_type,osm_id,boundingbox
- And result 0 has attributes lat,lon,display_name,importance
- And result 0 has not attributes address
- And result 0 has bounding box in 46.5,47.5,9,10
-
- Scenario: Unknown formats returns a user error
- When sending search query "Vaduz"
- | format |
- | x45 |
- Then a HTTP 400 is returned
-
- Scenario Outline: Search with addressdetails
- When sending <format> search query "Triesen" with address
- Then address of result 0 is
- | type | value |
- | village | Triesen |
- | county | Oberland |
- | postcode | 9495 |
- | country | Liechtenstein |
- | country_code | li |
- | ISO3166-2-lvl8 | LI-09 |
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | geojson |
- | xml |
-
- Scenario: Coordinate search with addressdetails
- When sending json search query "47.12400621,9.6047552"
- | accept-language |
- | en |
- Then results contain
- | display_name |
- | Guschg, Valorschstrasse, Balzers, Oberland, 9497, Liechtenstein |
-
- Scenario: Address details with unknown class types
- When sending json search query "Kloster St. Elisabeth" with address
- Then results contain
- | ID | class | type |
- | 0 | amenity | monastery |
- And result addresses contain
- | ID | amenity |
- | 0 | Kloster St. Elisabeth |
-
- Scenario: Disabling deduplication
- When sending json search query "Malbunstr"
- Then there are no duplicates
- When sending json search query "Malbunstr"
- | dedupe |
- | 0 |
- Then there are duplicates
-
- Scenario: Search with bounded viewbox in right area
- When sending json search query "post" with address
- | bounded | viewbox |
- | 1 | 9,47,10,48 |
- Then result addresses contain
- | ID | town |
- | 0 | Vaduz |
- When sending json search query "post" with address
- | bounded | viewbox |
- | 1 | 9.49712,47.17122,9.52605,47.16242 |
- Then result addresses contain
- | town |
- | Schaan |
-
- Scenario: Country search with bounded viewbox remain in the area
- When sending json search query "" with address
- | bounded | viewbox | country |
- | 1 | 9.49712,47.17122,9.52605,47.16242 | de |
- Then less than 1 result is returned
-
- Scenario: Search with bounded viewboxlbrt in right area
- When sending json search query "bar" with address
- | bounded | viewboxlbrt |
- | 1 | 9.49712,47.16242,9.52605,47.17122 |
- Then result addresses contain
- | town |
- | Schaan |
-
- @Fail
- Scenario: No POI search with unbounded viewbox
- When sending json search query "restaurant"
- | viewbox |
- | 9.93027,53.61634,10.10073,53.54500 |
- Then results contain
- | display_name |
- | ^[^,]*[Rr]estaurant.* |
-
- Scenario: bounded search remains within viewbox, even with no results
- When sending json search query "[restaurant]"
- | bounded | viewbox |
- | 1 | 43.5403125,-5.6563282,43.54285,-5.662003 |
- Then less than 1 result is returned
-
- Scenario: bounded search remains within viewbox with results
- When sending json search query "restaurant"
- | bounded | viewbox |
- | 1 | 9.49712,47.17122,9.52605,47.16242 |
- Then result has centroid in 9.49712,47.16242,9.52605,47.17122
-
- Scenario: Prefer results within viewbox
- When sending json search query "Gässle" with address
- | accept-language | viewbox |
- | en | 9.52413,47.10759,9.53140,47.10539 |
- Then result addresses contain
- | ID | village |
- | 0 | Triesen |
- When sending json search query "Gässle" with address
- | accept-language | viewbox |
- | en | 9.45949,47.08421,9.54094,47.05466 |
- Then result addresses contain
- | ID | town |
- | 0 | Balzers |
-
- Scenario: viewboxes cannot be points
- When sending json search query "foo"
- | viewbox |
- | 1.01,34.6,1.01,34.6 |
- Then a HTTP 400 is returned
-
- Scenario Outline: viewbox must have four coordinate numbers
- When sending json search query "foo"
- | viewbox |
- | <viewbox> |
- Then a HTTP 400 is returned
-
- Examples:
- | viewbox |
- | 34 |
- | 0.003,-84.4 |
- | 5.2,4.5542,12.4 |
- | 23.1,-6,0.11,44.2,9.1 |
-
- Scenario Outline: viewboxlbrt must have four coordinate numbers
- When sending json search query "foo"
- | viewboxlbrt |
- | <viewbox> |
- Then a HTTP 400 is returned
-
- Examples:
- | viewbox |
- | 34 |
- | 0.003,-84.4 |
- | 5.2,4.5542,12.4 |
- | 23.1,-6,0.11,44.2,9.1 |
-
- Scenario: Overly large limit number for search results
- When sending json search query "restaurant"
- | limit |
- | 1000 |
- Then at most 50 results are returned
-
- Scenario: Limit number of search results
- When sending json search query "landstr"
- | dedupe |
- | 0 |
- Then more than 4 results are returned
- When sending json search query "landstr"
- | limit | dedupe |
- | 4 | 0 |
- Then exactly 4 results are returned
-
- Scenario: Limit parameter must be a number
- When sending search query "Blue Laguna"
- | limit |
- | ); |
- Then a HTTP 400 is returned
-
- Scenario: Restrict to feature type country
- When sending xml search query "fürstentum"
- | featureType |
- | country |
- Then results contain
- | place_rank |
- | 4 |
-
- Scenario: Restrict to feature type state
- When sending xml search query "Wangerberg"
- Then at least 1 result is returned
- When sending xml search query "Wangerberg"
- | featureType |
- | state |
- Then exactly 0 results are returned
-
- Scenario: Restrict to feature type city
- When sending xml search query "vaduz"
- Then at least 1 result is returned
- When sending xml search query "vaduz"
- | featureType |
- | city |
- Then results contain
- | place_rank |
- | 16 |
-
- Scenario: Restrict to feature type settlement
- When sending json search query "Malbun"
- Then results contain
- | ID | class |
- | 1 | landuse |
- When sending json search query "Malbun"
- | featureType |
- | settlement |
- Then results contain
- | class | type |
- | place | village |
-
- Scenario Outline: Search with polygon threshold (json)
- When sending json search query "triesenberg"
- | polygon_geojson | polygon_threshold |
- | 1 | <th> |
- Then at least 1 result is returned
- And result 0 has attributes geojson
-
- Examples:
- | th |
- | -1 |
- | 0.0 |
- | 0.5 |
- | 999 |
-
- Scenario Outline: Search with polygon threshold (xml)
- When sending xml search query "triesenberg"
- | polygon_geojson | polygon_threshold |
- | 1 | <th> |
- Then at least 1 result is returned
- And result 0 has attributes geojson
-
- Examples:
- | th |
- | -1 |
- | 0.0 |
- | 0.5 |
- | 999 |
-
- Scenario Outline: Search with invalid polygon threshold (xml)
- When sending xml search query "triesenberg"
- | polygon_geojson | polygon_threshold |
- | 1 | <th> |
- Then a HTTP 400 is returned
-
- Examples:
- | th |
- | x |
- | ;; |
- | 1m |
-
- Scenario Outline: Search with extratags
- When sending <format> search query "Landstr"
- | extratags |
- | 1 |
- Then result has attributes extratags
-
- Examples:
- | format |
- | xml |
- | json |
- | jsonv2 |
- | geojson |
-
- Scenario Outline: Search with namedetails
- When sending <format> search query "Landstr"
- | namedetails |
- | 1 |
- Then result has attributes namedetails
-
- Examples:
- | format |
- | xml |
- | json |
- | jsonv2 |
- | geojson |
-
- Scenario Outline: Search result with contains TEXT geometry
- When sending <format> search query "triesenberg"
- | polygon_text |
- | 1 |
- Then result has attributes <response_attribute>
-
- Examples:
- | format | response_attribute |
- | xml | geotext |
- | json | geotext |
- | jsonv2 | geotext |
-
- Scenario Outline: Search result contains SVG geometry
- When sending <format> search query "triesenberg"
- | polygon_svg |
- | 1 |
- Then result has attributes <response_attribute>
-
- Examples:
- | format | response_attribute |
- | xml | geosvg |
- | json | svg |
- | jsonv2 | svg |
-
- Scenario Outline: Search result contains KML geometry
- When sending <format> search query "triesenberg"
- | polygon_kml |
- | 1 |
- Then result has attributes <response_attribute>
-
- Examples:
- | format | response_attribute |
- | xml | geokml |
- | json | geokml |
- | jsonv2 | geokml |
-
- Scenario Outline: Search result contains GEOJSON geometry
- When sending <format> search query "triesenberg"
- | polygon_geojson |
- | 1 |
- Then result has attributes <response_attribute>
-
- Examples:
- | format | response_attribute |
- | xml | geojson |
- | json | geojson |
- | jsonv2 | geojson |
- | geojson | geojson |
-
- Scenario Outline: Search result in geojson format contains no non-geojson geometry
- When sending geojson search query "triesenberg"
- | polygon_text | polygon_svg | polygon_geokml |
- | 1 | 1 | 1 |
- Then result 0 has not attributes <response_attribute>
-
- Examples:
- | response_attribute |
- | geotext |
- | polygonpoints |
- | svg |
- | geokml |
-
-
- Scenario: Array parameters are ignored
- When sending json search query "Vaduz" with address
- | countrycodes[] | polygon_svg[] | limit[] | polygon_threshold[] |
- | IT | 1 | 3 | 3.4 |
- Then result addresses contain
- | ID | country_code |
- | 0 | li |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Search queries
- Generic search result correctness
-
- Scenario: Search for natural object
- When sending json search query "Samina"
- | accept-language |
- | en |
- Then results contain
- | ID | class | type | display_name |
- | 0 | waterway | river | Samina, Austria |
-
- Scenario: House number search for non-street address
- When sending json search query "6 Silum, Liechtenstein" with address
- | accept-language |
- | en |
- Then address of result 0 is
- | type | value |
- | house_number | 6 |
- | village | Silum |
- | town | Triesenberg |
- | county | Oberland |
- | postcode | 9497 |
- | country | Liechtenstein |
- | country_code | li |
- | ISO3166-2-lvl8 | LI-10 |
-
- Scenario: House number interpolation
- When sending json search query "Grosssteg 1023, Triesenberg" with address
- | accept-language |
- | de |
- Then address of result 0 contains
- | type | value |
- | house_number | 1023 |
- | road | Grosssteg |
- | village | Sücka |
- | postcode | 9497 |
- | town | Triesenberg |
- | country | Liechtenstein |
- | country_code | li |
-
- Scenario: With missing housenumber search falls back to road
- When sending json search query "Bündaweg 555" with address
- Then address of result 0 is
- | type | value |
- | road | Bündaweg |
- | village | Silum |
- | postcode | 9497 |
- | county | Oberland |
- | town | Triesenberg |
- | country | Liechtenstein |
- | country_code | li |
- | ISO3166-2-lvl8 | LI-10 |
-
- Scenario Outline: Housenumber 0 can be found
- When sending <format> search query "Gnalpstrasse 0" with address
- Then results contain
- | display_name |
- | ^0,.* |
- And result addresses contain
- | house_number |
- | 0 |
-
- Examples:
- | format |
- | xml |
- | json |
- | jsonv2 |
- | geojson |
-
- @Tiger
- Scenario: TIGER house number
- When sending json search query "697 Upper Kingston Road"
- Then results contain
- | osm_type | display_name |
- | way | ^697,.* |
-
- Scenario: Search with class-type feature
- When sending jsonv2 search query "bars in ebenholz"
- Then results contain
- | place_rank |
- | 30 |
-
- Scenario: Search with specific amenity
- When sending json search query "[restaurant] Vaduz" with address
- Then result addresses contain
- | country |
- | Liechtenstein |
- And results contain
- | class | type |
- | amenity | restaurant |
-
- Scenario: Search with specific amenity also work in country
- When sending json search query "restaurants in liechtenstein" with address
- Then result addresses contain
- | country |
- | Liechtenstein |
- And results contain
- | class | type |
- | amenity | restaurant |
-
- Scenario: Search with key-value amenity
- When sending json search query "[club=scout] Vaduz"
- Then results contain
- | class | type |
- | club | scout |
-
- Scenario: POI search near given coordinate
- When sending json search query "restaurant near 47.16712,9.51100"
- Then results contain
- | class | type |
- | amenity | restaurant |
-
- Scenario: Arbitrary key/value search near given coordinate
- When sending json search query "[leisure=firepit] 47.150° N 9.5340493° E"
- Then results contain
- | class | type |
- | leisure | firepit |
-
-
- Scenario: POI search in a bounded viewbox
- When sending json search query "restaurants"
- | viewbox | bounded |
- | 9.50830,47.15253,9.52043,47.14866 | 1 |
- Then results contain
- | class | type |
- | amenity | restaurant |
-
- Scenario Outline: Key/value search near given coordinate can be restricted to country
- When sending json search query "[natural=peak] 47.06512,9.53965" with address
- | countrycodes |
- | <cc> |
- Then result addresses contain
- | country_code |
- | <cc> |
-
- Examples:
- | cc |
- | li |
- | ch |
-
- Scenario: Name search near given coordinate
- When sending json search query "sporry" with address
- Then result addresses contain
- | ID | town |
- | 0 | Vaduz |
- When sending json search query "sporry, 47.10791,9.52676" with address
- Then result addresses contain
- | ID | village |
- | 0 | Triesen |
-
- Scenario: Name search near given coordinate without result
- When sending json search query "sporry, N 47 15 7 W 9 61 26"
- Then exactly 0 results are returned
-
- Scenario: Arbitrary key/value search near a road
- When sending json search query "[amenity=drinking_water] Wissfläckaweg"
- Then results contain
- | class | type |
- | amenity | drinking_water |
-
- Scenario: Ignore other country codes in structured search with country
- When sending json search query ""
- | city | country |
- | li | de |
- Then exactly 0 results are returned
-
- Scenario: Ignore country searches when query is restricted to countries
- When sending json search query "fr"
- | countrycodes |
- | li |
- Then exactly 0 results are returned
-
- Scenario: Country searches only return results for the given country
- When sending search query "Ans Trail" with address
- | countrycodes |
- | li |
- Then result addresses contain
- | country_code |
- | li |
-
- # https://trac.openstreetmap.org/ticket/5094
- Scenario: housenumbers are ordered by complete match first
- When sending json search query "Austrasse 11, Vaduz" with address
- Then result addresses contain
- | ID | house_number |
- | 0 | 11 |
-
- Scenario Outline: Coordinate searches with white spaces
- When sending json search query "<data>"
- Then exactly 1 result is returned
- And results contain
- | class |
- | water |
-
- Examples:
- | data |
- | sporry weiher, N 47.10791° E 9.52676° |
- | sporry weiher, N 47.10791° E 9.52676° |
- | sporry weiher , N 47.10791° E 9.52676° |
- | sporry weiher, N 47.10791° E 9.52676° |
- | sporry weiher\v, N 47.10791° E 9.52676° |
-
- Scenario: Searches with white spaces
- When sending json search query "52 Bodastr\v,\fTriesenberg"
- Then results contain
- | class | type |
- | highway | residential |
-
-
- # github #1949
- Scenario: Addressdetails always return the place type
- When sending json search query "Vaduz" with address
- Then result addresses contain
- | ID | town |
- | 0 | Vaduz |
-
- Scenario: Search can handle complex query word sets
- When sending search query "aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus"
- Then a HTTP 200 is returned
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Simple Tests
- Simple tests for internal server errors and response format.
-
- Scenario Outline: Testing different parameters
- When sending search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
- When sending xml search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
- When sending json search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
- When sending jsonv2 search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
- When sending geojson search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
- When sending geocodejson search query "Vaduz"
- | param | value |
- | <parameter> | <value> |
- Then at least 1 result is returned
-
- Examples:
- | parameter | value |
- | addressdetails | 0 |
- | polygon_text | 0 |
- | polygon_kml | 0 |
- | polygon_geojson | 0 |
- | polygon_svg | 0 |
- | accept-language | de,en |
- | countrycodes | li |
- | bounded | 1 |
- | bounded | 0 |
- | exclude_place_ids| 385252,1234515 |
- | limit | 1000 |
- | dedupe | 1 |
- | dedupe | 0 |
- | extratags | 0 |
- | namedetails | 0 |
-
- Scenario: Search with invalid output format
- When sending search query "Berlin"
- | format |
- | fd$# |
- Then a HTTP 400 is returned
-
- Scenario Outline: Simple Searches
- When sending search query "<query>"
- Then the result is valid json
- When sending xml search query "<query>"
- Then the result is valid xml
- When sending json search query "<query>"
- Then the result is valid json
- When sending jsonv2 search query "<query>"
- Then the result is valid json
- When sending geojson search query "<query>"
- Then the result is valid geojson
-
- Examples:
- | query |
- | New York, New York |
- | France |
- | 12, Main Street, Houston |
- | München |
- | 東京都 |
- | hotels in nantes |
- | xywxkrf |
- | gh; foo() |
- | %#$@*&l;der#$! |
- | 234 |
- | 47.4,8.3 |
-
- Scenario: Empty XML search
- When sending xml search query "xnznxvcx"
- Then result header contains
- | attr | value |
- | querystring | xnznxvcx |
- | more_url | .*q=xnznxvcx.*format=xml |
-
- Scenario: Empty XML search with special XML characters
- When sending xml search query "xfdghn&zxn"xvbyx<vxx>cssdex"
- Then result header contains
- | attr | value |
- | querystring | xfdghn&zxn"xvbyx<vxx>cssdex |
- | more_url | .*q=xfdghn%26zxn%22xvbyx%3Cvxx%3Ecssdex.*format=xml |
-
- Scenario: Empty XML search with viewbox
- When sending xml search query "xnznxvcx"
- | viewbox |
- | 12,33,77,45.13 |
- Then result header contains
- | attr | value |
- | querystring | xnznxvcx |
- | viewbox | 12,33,77,45.13 |
-
- Scenario: Empty XML search with viewboxlbrt
- When sending xml search query "xnznxvcx"
- | viewboxlbrt |
- | 12,34.13,77,45 |
- Then result header contains
- | attr | value |
- | querystring | xnznxvcx |
- | viewbox | 12,34.13,77,45 |
-
- Scenario: Empty XML search with viewboxlbrt and viewbox
- When sending xml search query "pub"
- | viewbox | viewboxblrt |
- | 12,33,77,45.13 | 1,2,3,4 |
- Then result header contains
- | attr | value |
- | querystring | pub |
- | viewbox | 12,33,77,45.13 |
-
- Scenario: Empty XML search with excluded place ids
- When sending xml search query "jghrleoxsbwjer"
- | exclude_place_ids |
- | 123,76,342565 |
- Then result header contains
- | attr | value |
- | exclude_place_ids | 123,76,342565 |
-
- Scenario: Empty XML search with bad excluded place ids
- When sending xml search query "jghrleoxsbwjer"
- | exclude_place_ids |
- | , |
- Then result header has not attributes exclude_place_ids
-
- Scenario Outline: Wrapping of legal jsonp search requests
- When sending json search query "Tokyo"
- | param | value |
- |json_callback | <data> |
- Then result header contains
- | attr | value |
- | json_func | <result> |
-
- Examples:
- | data | result |
- | foo | foo |
- | FOO | FOO |
- | __world | __world |
-
- Scenario Outline: Wrapping of illegal jsonp search requests
- When sending json search query "Tokyo"
- | param | value |
- |json_callback | <data> |
- Then a json user error is returned
-
- Examples:
- | data |
- | 1asd |
- | bar(foo) |
- | XXX['bad'] |
- | foo; evil |
-
- Scenario: Ignore jsonp parameter for anything but json
- When sending json search query "Malibu"
- | json_callback |
- | 234 |
- Then a HTTP 400 is returned
- When sending xml search query "Malibu"
- | json_callback |
- | 234 |
- Then the result is valid xml
-
- Scenario Outline: Empty search
- When sending <format> search query "YHlERzzx"
- Then exactly 0 results are returned
-
- Examples:
- | format |
- | json |
- | jsonv2 |
- | geojson |
- | geocodejson |
-
- Scenario: Search for non-existing coordinates
- When sending json search query "-21.0,-33.0"
- Then exactly 0 results are returned
-
- Scenario: Country code selection is retained in more URL (#596)
- When sending xml search query "Vaduz"
- | countrycodes |
- | pl,1,,invalid,undefined,%3Cb%3E,bo,, |
- Then result header contains
- | attr | value |
- | more_url | .*&countrycodes=pl%2Cbo&.* |
-
- Scenario Outline: Search debug output does not return errors
- When sending debug search query "<query>"
- Then a HTTP 200 is returned
-
- Examples:
- | query |
- | Liechtenstein |
- | Triesen |
- | Pfarrkirche |
- | Landstr 27 Steinort, Triesenberg, 9495 |
- | 9497 |
- | restaurant in triesen |
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Structured search queries
- Testing correctness of results with
- structured queries
-
- Scenario: Country only
- When sending json search query "" with address
- | country |
- | Liechtenstein |
- Then address of result 0 is
- | type | value |
- | country | Liechtenstein |
- | country_code | li |
-
- Scenario: Postcode only
- When sending json search query "" with address
- | postalcode |
- | 9495 |
- Then results contain
- | type |
- | ^post(al_)?code |
- And result addresses contain
- | postcode |
- | 9495 |
-
- Scenario: Street, postcode and country
- When sending xml search query "" with address
- | street | postalcode | country |
- | Old Palace Road | GU2 7UP | United Kingdom |
- Then result header contains
- | attr | value |
- | querystring | Old Palace Road, GU2 7UP, United Kingdom |
-
- Scenario: Street with housenumber, city and postcode
- When sending xml search query "" with address
- | street | city | postalcode |
- | 19 Am schrägen Weg | Vaduz | 9490 |
- Then result addresses contain
- | house_number | road |
- | 19 | Am Schrägen Weg |
-
- Scenario: Street with housenumber, city and bad postcode
- When sending xml search query "" with address
- | street | city | postalcode |
- | 19 Am schrägen Weg | Vaduz | 9491 |
- Then result addresses contain
- | house_number | road |
- | 19 | Am Schrägen Weg |
-
- Scenario: Amenity, city
- When sending json search query "" with address
- | city | amenity |
- | Vaduz | bar |
- Then result addresses contain
- | country |
- | Liechtenstein |
- And results contain
- | class | type |
- | amenity | ^(pub)\|(bar)\|(restaurant) |
-
- #176
- Scenario: Structured search restricts rank
- When sending json search query "" with address
- | city |
- | Vaduz |
- Then result addresses contain
- | town |
- | Vaduz |
-
- #3651
- Scenario: Structured search with surrounding extra characters
- When sending xml search query "" with address
- | street | city | postalcode |
- | "19 Am schrägen Weg" | "Vaduz" | "9491" |
- Then result addresses contain
- | house_number | road |
- | 19 | Am Schrägen Weg |
-
+++ /dev/null
-@UNKNOWNDB
-Feature: Status queries against unknown database
- Testing status query
-
- Scenario: Failed status as text
- When sending text status query
- Then a HTTP 500 is returned
- And the page contents equals "ERROR: Database connection failed"
-
- Scenario: Failed status as json
- When sending json status query
- Then a HTTP 200 is returned
- And the result is valid json
- And results contain
- | status | message |
- | 700 | Database connection failed |
- And result has not attributes data_updated
+++ /dev/null
-@SQLITE
-@APIDB
-Feature: Status queries
- Testing status query
-
- Scenario: Status as text
- When sending status query
- Then a HTTP 200 is returned
- And the page contents equals "OK"
-
- Scenario: Status as json
- When sending json status query
- Then the result is valid json
- And results contain
- | status | message |
- | 0 | OK |
- And result has attributes data_updated
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Fixtures for BDD test steps
+"""
+import sys
+import json
+from pathlib import Path
+
+import psycopg
+from psycopg import sql as pysql
+
+# always test against the source
+SRC_DIR = (Path(__file__) / '..' / '..' / '..').resolve()
+sys.path.insert(0, str(SRC_DIR / 'src'))
+
+import pytest
+from pytest_bdd.parsers import re as step_parse
+from pytest_bdd import given, when, then
+
+pytest.register_assert_rewrite('utils')
+
+from utils.api_runner import APIRunner
+from utils.api_result import APIResult
+from utils.checks import ResultAttr, COMPARATOR_TERMS
+from utils.geometry_alias import ALIASES
+from utils.grid import Grid
+from utils.db import DBManager
+
+from nominatim_db.config import Configuration
+from nominatim_db.data.country_info import setup_country_config
+
+
+def _strlist(inp):
+ return [s.strip() for s in inp.split(',')]
+
+
+def _pretty_json(inp):
+ return json.dumps(inp, indent=2)
+
+
+def pytest_addoption(parser, pluginmanager):
+ parser.addoption('--nominatim-purge', dest='NOMINATIM_PURGE', action='store_true',
+ help='Force recreation of test databases from scratch.')
+ parser.addoption('--nominatim-keep-db', dest='NOMINATIM_KEEP_DB', action='store_true',
+ help='Do not drop the database after tests are finished.')
+ parser.addoption('--nominatim-api-engine', dest='NOMINATIM_API_ENGINE',
+ default='falcon',
+ help='Chose the API engine to use when sending requests.')
+ parser.addoption('--nominatim-tokenizer', dest='NOMINATIM_TOKENIZER',
+ metavar='TOKENIZER',
+ help='Use the specified tokenizer for importing data into '
+ 'a Nominatim database.')
+
+ parser.addini('nominatim_test_db', default='test_nominatim',
+ help='Name of the database used for running a single test.')
+ parser.addini('nominatim_api_test_db', default='test_api_nominatim',
+ help='Name of the database for storing API test data.')
+ parser.addini('nominatim_template_db', default='test_template_nominatim',
+ help='Name of database used as a template for test databases.')
+
+
+@pytest.fixture
+def datatable():
+ """ Default fixture for datatables, so that their presence can be optional.
+ """
+ return None
+
+
+@pytest.fixture
+def node_grid():
+ """ Default fixture for node grids. Nothing set.
+ """
+ return Grid([[]], None, None)
+
+
+@pytest.fixture(scope='session', autouse=True)
+def setup_country_info():
+ setup_country_config(Configuration(None))
+
+
+@pytest.fixture(scope='session')
+def template_db(pytestconfig):
+ """ Create a template database containing the extensions and base data
+ needed by Nominatim. Using the template instead of doing the full
+ setup can speed up the tests.
+
+ The template database will only be created if it does not exist yet
+ or a purge has been explicitly requested.
+ """
+ dbm = DBManager(purge=pytestconfig.option.NOMINATIM_PURGE)
+
+ template_db = pytestconfig.getini('nominatim_template_db')
+
+ template_config = Configuration(
+ None, environ={'NOMINATIM_DATABASE_DSN': f"pgsql:dbname={template_db}"})
+
+ dbm.setup_template_db(template_config)
+
+ return template_db
+
+
+@pytest.fixture
+def def_config(pytestconfig):
+ dbname = pytestconfig.getini('nominatim_test_db')
+
+ return Configuration(None,
+ environ={'NOMINATIM_DATABASE_DSN': f"pgsql:dbname={dbname}"})
+
+
+@pytest.fixture
+def db(template_db, pytestconfig):
+ """ Set up an empty database for use with osm2pgsql.
+ """
+ dbm = DBManager(purge=pytestconfig.option.NOMINATIM_PURGE)
+
+ dbname = pytestconfig.getini('nominatim_test_db')
+
+ dbm.create_db_from_template(dbname, template_db)
+
+ yield dbname
+
+ if not pytestconfig.option.NOMINATIM_KEEP_DB:
+ dbm.drop_db(dbname)
+
+
+@pytest.fixture
+def db_conn(db, def_config):
+ with psycopg.connect(def_config.get_libpq_dsn()) as conn:
+ info = psycopg.types.TypeInfo.fetch(conn, "hstore")
+ psycopg.types.hstore.register_hstore(info, conn)
+ yield conn
+
+
+@when(step_parse(r'reverse geocoding (?P<lat>[\d.-]*),(?P<lon>[\d.-]*)'),
+ target_fixture='nominatim_result')
+def reverse_geocode_via_api(test_config_env, pytestconfig, datatable, lat, lon):
+ runner = APIRunner(test_config_env, pytestconfig.option.NOMINATIM_API_ENGINE)
+ api_response = runner.run_step('reverse',
+ {'lat': float(lat), 'lon': float(lon)},
+ datatable, 'jsonv2', {})
+
+ assert api_response.status == 200
+ assert api_response.headers['content-type'] == 'application/json; charset=utf-8'
+
+ result = APIResult('json', 'reverse', api_response.body)
+ assert result.is_simple()
+
+ assert isinstance(result.result['lat'], str)
+ assert isinstance(result.result['lon'], str)
+ result.result['centroid'] = f"POINT({result.result['lon']} {result.result['lat']})"
+
+ return result
+
+
+@when(step_parse(r'reverse geocoding at node (?P<node>[\d]+)'),
+ target_fixture='nominatim_result')
+def reverse_geocode_via_api_and_grid(test_config_env, pytestconfig, node_grid, datatable, node):
+ coords = node_grid.get(node)
+ if coords is None:
+ raise ValueError('Unknown node id')
+
+ return reverse_geocode_via_api(test_config_env, pytestconfig, datatable, coords[1], coords[0])
+
+
+@when(step_parse(r'geocoding(?: "(?P<query>.*)")?'),
+ target_fixture='nominatim_result')
+def forward_geocode_via_api(test_config_env, pytestconfig, datatable, query):
+ runner = APIRunner(test_config_env, pytestconfig.option.NOMINATIM_API_ENGINE)
+
+ params = {'addressdetails': '1'}
+ if query:
+ params['q'] = query
+
+ api_response = runner.run_step('search', params, datatable, 'jsonv2', {})
+
+ assert api_response.status == 200
+ assert api_response.headers['content-type'] == 'application/json; charset=utf-8'
+
+ result = APIResult('json', 'search', api_response.body)
+ assert not result.is_simple()
+
+ for res in result.result:
+ assert isinstance(res['lat'], str)
+ assert isinstance(res['lon'], str)
+ res['centroid'] = f"POINT({res['lon']} {res['lat']})"
+
+ return result
+
+
+@then(step_parse(r'(?P<op>[a-z ]+) (?P<num>\d+) results? (?:are|is) returned'),
+ converters={'num': int})
+def check_number_of_results(nominatim_result, op, num):
+ assert not nominatim_result.is_simple()
+ assert COMPARATOR_TERMS[op](num, len(nominatim_result))
+
+
+@then(step_parse('the result metadata contains'))
+def check_metadata_for_fields(nominatim_result, datatable):
+ if datatable[0] == ['param', 'value']:
+ pairs = datatable[1:]
+ else:
+ pairs = zip(datatable[0], datatable[1])
+
+ for k, v in pairs:
+ assert ResultAttr(nominatim_result.meta, k) == v
+
+
+@then(step_parse('the result metadata has no attributes (?P<attributes>.*)'),
+ converters={'attributes': _strlist})
+def check_metadata_for_field_presence(nominatim_result, attributes):
+ assert all(a not in nominatim_result.meta for a in attributes), \
+ f"Unexpectedly have one of the attributes '{attributes}' in\n" \
+ f"{_pretty_json(nominatim_result.meta)}"
+
+
+@then(step_parse(r'the result contains(?: in field (?P<field>\S+))?'))
+def check_result_for_fields(nominatim_result, datatable, node_grid, field):
+ assert nominatim_result.is_simple()
+
+ if datatable[0] == ['param', 'value']:
+ pairs = datatable[1:]
+ else:
+ pairs = zip(datatable[0], datatable[1])
+
+ prefix = field + '+' if field else ''
+
+ for k, v in pairs:
+ assert ResultAttr(nominatim_result.result, prefix + k, grid=node_grid) == v
+
+
+@then(step_parse('the result has attributes (?P<attributes>.*)'),
+ converters={'attributes': _strlist})
+def check_result_for_field_presence(nominatim_result, attributes):
+ assert nominatim_result.is_simple()
+ assert all(a in nominatim_result.result for a in attributes)
+
+
+@then(step_parse('the result has no attributes (?P<attributes>.*)'),
+ converters={'attributes': _strlist})
+def check_result_for_field_absence(nominatim_result, attributes):
+ assert nominatim_result.is_simple()
+ assert all(a not in nominatim_result.result for a in attributes)
+
+
+@then(step_parse('the result set contains(?P<exact> exactly)?'))
+def check_result_list_match(nominatim_result, datatable, exact):
+ assert not nominatim_result.is_simple()
+
+ result_set = set(range(len(nominatim_result.result)))
+
+ for row in datatable[1:]:
+ for idx in result_set:
+ for key, value in zip(datatable[0], row):
+ if ResultAttr(nominatim_result.result[idx], key) != value:
+ break
+ else:
+ # found a match
+ result_set.remove(idx)
+ break
+ else:
+ assert False, f"Missing data row {row}. Full response:\n{nominatim_result}"
+
+ if exact:
+ assert not [nominatim_result.result[i] for i in result_set]
+
+
+@then(step_parse('all results have attributes (?P<attributes>.*)'),
+ converters={'attributes': _strlist})
+def check_all_results_for_field_presence(nominatim_result, attributes):
+ assert not nominatim_result.is_simple()
+ assert len(nominatim_result) > 0
+ for res in nominatim_result.result:
+ assert all(a in res for a in attributes), \
+ f"Missing one of the attributes '{attributes}' in\n{_pretty_json(res)}"
+
+
+@then(step_parse('all results have no attributes (?P<attributes>.*)'),
+ converters={'attributes': _strlist})
+def check_all_result_for_field_absence(nominatim_result, attributes):
+ assert not nominatim_result.is_simple()
+ assert len(nominatim_result) > 0
+ for res in nominatim_result.result:
+ assert all(a not in res for a in attributes), \
+ f"Unexpectedly have one of the attributes '{attributes}' in\n{_pretty_json(res)}"
+
+
+@then(step_parse(r'all results contain(?: in field (?P<field>\S+))?'))
+def check_all_results_contain(nominatim_result, datatable, node_grid, field):
+ assert not nominatim_result.is_simple()
+ assert len(nominatim_result) > 0
+
+ if datatable[0] == ['param', 'value']:
+ pairs = datatable[1:]
+ else:
+ pairs = zip(datatable[0], datatable[1])
+
+ prefix = field + '+' if field else ''
+
+ for k, v in pairs:
+ for r in nominatim_result.result:
+ assert ResultAttr(r, prefix + k, grid=node_grid) == v
+
+
+@then(step_parse(r'result (?P<num>\d+) contains(?: in field (?P<field>\S+))?'),
+ converters={'num': int})
+def check_specific_result_for_fields(nominatim_result, datatable, num, field):
+ assert not nominatim_result.is_simple()
+ assert len(nominatim_result) > num
+
+ if datatable[0] == ['param', 'value']:
+ pairs = datatable[1:]
+ else:
+ pairs = zip(datatable[0], datatable[1])
+
+ prefix = field + '+' if field else ''
+
+ for k, v in pairs:
+ assert ResultAttr(nominatim_result.result[num], prefix + k) == v
+
+
+@given(step_parse(r'the (?P<step>[0-9.]+ )?grid(?: with origin (?P<origin>.*))?'),
+ target_fixture='node_grid')
+def set_node_grid(datatable, step, origin):
+ if step is not None:
+ step = float(step)
+
+ if origin:
+ if ',' in origin:
+ coords = origin.split(',')
+ if len(coords) != 2:
+ raise RuntimeError('Grid origin expects origin with x,y coordinates.')
+ origin = list(map(float, coords))
+ elif origin in ALIASES:
+ origin = ALIASES[origin]
+ else:
+ raise RuntimeError('Grid origin must be either coordinate or alias.')
+
+ return Grid(datatable, step, origin)
+
+
+@then(step_parse('(?P<table>placex?) has no entry for '
+ r'(?P<osm_type>[NRW])(?P<osm_id>\d+)(?::(?P<osm_class>\S+))?'),
+ converters={'osm_id': int})
+def check_place_missing_lines(db_conn, table, osm_type, osm_id, osm_class):
+ sql = pysql.SQL("""SELECT count(*) FROM {}
+ WHERE osm_type = %s and osm_id = %s""").format(pysql.Identifier(table))
+ params = [osm_type, int(osm_id)]
+ if osm_class:
+ sql += pysql.SQL(' AND class = %s')
+ params.append(osm_class)
+
+ with db_conn.cursor() as cur:
+ assert cur.execute(sql, params).fetchone()[0] == 0
+++ /dev/null
-@DB
-Feature: Import and search of names
- Tests all naming related import issues
-
- Scenario: No copying name tag if only one name
- Given the places
- | osm | class | type | name | geometry |
- | N1 | place | locality | german | country:de |
- When importing
- Then placex contains
- | object | country_code | name+name |
- | N1 | de | german |
-
- Scenario: Copying name tag to default language if it does not exist
- Given the places
- | osm | class | type | name | name+name:fi | geometry |
- | N1 | place | locality | german | finnish | country:de |
- When importing
- Then placex contains
- | object | country_code | name | name+name:fi | name+name:de |
- | N1 | de | german | finnish | german |
-
- Scenario: Copying default language name tag to name if it does not exist
- Given the places
- | osm | class | type | name+name:de | name+name:fi | geometry |
- | N1 | place | locality | german | finnish | country:de |
- When importing
- Then placex contains
- | object | country_code | name | name+name:fi | name+name:de |
- | N1 | de | german | finnish | german |
-
- Scenario: Do not overwrite default language with name tag
- Given the places
- | osm | class | type | name | name+name:fi | name+name:de | geometry |
- | N1 | place | locality | german | finnish | local | country:de |
- When importing
- Then placex contains
- | object | country_code | name | name+name:fi | name+name:de |
- | N1 | de | german | finnish | local |
-
- Scenario Outline: Names in any script can be found
- Given the places
- | osm | class | type | name |
- | N1 | place | hamlet | <name> |
- When importing
- And sending search query "<name>"
- Then results contain
- | osm |
- | N1 |
-
- Examples:
- | name |
- | Berlin |
- | 北京 |
- | Вологда |
- | Αθήνα |
- | القاهرة |
- | រាជធានីភ្នំពេញ |
- | 東京都 |
- | ပုဗ္ဗသီရိ |
-
-
- Scenario: German umlauts can be found when expanded
- Given the places
- | osm | class | type | name+name:de |
- | N1 | place | city | Münster |
- | N2 | place | city | Köln |
- | N3 | place | city | Gräfenroda |
- When importing
- When sending search query "münster"
- Then results contain
- | osm |
- | N1 |
- When sending search query "muenster"
- Then results contain
- | osm |
- | N1 |
- When sending search query "munster"
- Then results contain
- | osm |
- | N1 |
- When sending search query "Köln"
- Then results contain
- | osm |
- | N2 |
- When sending search query "Koeln"
- Then results contain
- | osm |
- | N2 |
- When sending search query "Koln"
- Then results contain
- | osm |
- | N2 |
- When sending search query "gräfenroda"
- Then results contain
- | osm |
- | N3 |
- When sending search query "graefenroda"
- Then results contain
- | osm |
- | N3 |
- When sending search query "grafenroda"
- Then results contain
- | osm |
- | N3 |
+++ /dev/null
-@DB
-Feature: Import and search of names
- Tests all naming related issues: normalisation,
- abbreviations, internationalisation, etc.
-
- Scenario: non-latin scripts can be found
- Given the places
- | osm | class | type | name |
- | N1 | place | locality | Речицкий район |
- | N2 | place | locality | Refugio de montaña |
- | N3 | place | locality | 高槻市|
- | N4 | place | locality | الدوحة |
- When importing
- When sending search query "Речицкий район"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Refugio de montaña"
- Then results contain
- | ID | osm |
- | 0 | N2 |
- When sending search query "高槻市"
- Then results contain
- | ID | osm |
- | 0 | N3 |
- When sending search query "الدوحة"
- Then results contain
- | ID | osm |
- | 0 | N4 |
-
- Scenario: Case-insensitivity of search
- Given the places
- | osm | class | type | name |
- | N1 | place | locality | FooBar |
- When importing
- Then placex contains
- | object | class | type | name+name |
- | N1 | place | locality | FooBar |
- When sending search query "FooBar"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "foobar"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "fOObar"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "FOOBAR"
- Then results contain
- | ID | osm |
- | 0 | N1 |
-
- Scenario: Multiple spaces in name
- Given the places
- | osm | class | type | name |
- | N1 | place | locality | one two three |
- When importing
- When sending search query "one two three"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "one two three"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "one two three"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query " one two three"
- Then results contain
- | ID | osm |
- | 0 | N1 |
-
- Scenario: Special characters in name
- Given the places
- | osm | class | type | name+name:de |
- | N1 | place | locality | Jim-Knopf-Straße |
- | N2 | place | locality | Smith/Weston |
- | N3 | place | locality | space mountain |
- | N4 | place | locality | space |
- | N5 | place | locality | mountain |
- When importing
- When sending search query "Jim-Knopf-Str"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Jim Knopf-Str"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Jim Knopf Str"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Jim/Knopf-Str"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Jim-Knopfstr"
- Then results contain
- | ID | osm |
- | 0 | N1 |
- When sending search query "Smith/Weston"
- Then results contain
- | ID | osm |
- | 0 | N2 |
- When sending search query "Smith Weston"
- Then results contain
- | ID | osm |
- | 0 | N2 |
- When sending search query "Smith-Weston"
- Then results contain
- | ID | osm |
- | 0 | N2 |
- When sending search query "space mountain"
- Then results contain
- | ID | osm |
- | 0 | N3 |
- When sending search query "space-mountain"
- Then results contain
- | ID | osm |
- | 0 | N3 |
- When sending search query "space/mountain"
- Then results contain
- | ID | osm |
- | 0 | N3 |
- When sending search query "space\mountain"
- Then results contain
- | ID | osm |
- | 0 | N3 |
- When sending search query "space(mountain)"
- Then results contain
- | ID | osm |
- | 0 | N3 |
-
- Scenario: Landuse with name are found
- Given the grid
- | 1 | 2 |
- | 3 | |
- Given the places
- | osm | class | type | name | geometry |
- | R1 | natural | meadow | landuse1 | (1,2,3,1) |
- | R2 | landuse | industrial | landuse2 | (2,3,1,2) |
- When importing
- When sending search query "landuse1"
- Then results contain
- | ID | osm |
- | 0 | R1 |
- When sending search query "landuse2"
- Then results contain
- | ID | osm |
- | 0 | R2 |
-
- Scenario: Postcode boundaries without ref
- Given the grid with origin FR
- | | 2 | |
- | 1 | | 3 |
- Given the places
- | osm | class | type | postcode | geometry |
- | R1 | boundary | postal_code | 123-45 | (1,2,3,1) |
- When importing
- When sending search query "123-45"
- Then results contain
- | ID | osm |
- | 0 | R1 |
-
- Scenario Outline: Housenumbers with special characters are found
- Given the grid
- | 1 | | | | 2 |
- | | | 9 | | |
- And the places
- | osm | class | type | name | geometry |
- | W1 | highway | primary | Main St | 1,2 |
- And the places
- | osm | class | type | housenr | geometry |
- | N1 | building | yes | <nr> | 9 |
- When importing
- And sending search query "Main St <nr>"
- Then results contain
- | osm | display_name |
- | N1 | <nr>, Main St |
-
- Examples:
- | nr |
- | 1 |
- | 3456 |
- | 1 a |
- | 56b |
- | 1 A |
- | 2號 |
- | 1Б |
- | 1 к1 |
- | 23-123 |
-
- Scenario Outline: Housenumbers in lists are found
- Given the grid
- | 1 | | | | 2 |
- | | | 9 | | |
- And the places
- | osm | class | type | name | geometry |
- | W1 | highway | primary | Main St | 1,2 |
- And the places
- | osm | class | type | housenr | geometry |
- | N1 | building | yes | <nr-list> | 9 |
- When importing
- And sending search query "Main St <nr>"
- Then results contain
- | ID | osm | display_name |
- | 0 | N1 | <nr-list>, Main St |
-
- Examples:
- | nr-list | nr |
- | 1,2,3 | 1 |
- | 1,2,3 | 2 |
- | 1, 2, 3 | 3 |
- | 45 ;67;3 | 45 |
- | 45 ;67;3 | 67 |
- | 1a;1k | 1a |
- | 1a;1k | 1k |
- | 34/678 | 34 |
- | 34/678 | 678 |
- | 34/678 | 34/678 |
+++ /dev/null
-# SPDX-License-Identifier: GPL-3.0-or-later
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-from pathlib import Path
-import sys
-
-from behave import * # noqa
-
-sys.path.insert(1, str(Path(__file__, '..', '..', '..', 'src').resolve()))
-
-from steps.geometry_factory import GeometryFactory # noqa: E402
-from steps.nominatim_environment import NominatimEnvironment # noqa: E402
-
-TEST_BASE_DIR = Path(__file__, '..', '..').resolve()
-
-userconfig = {
- 'REMOVE_TEMPLATE': False,
- 'KEEP_TEST_DB': False,
- 'DB_HOST': None,
- 'DB_PORT': None,
- 'DB_USER': None,
- 'DB_PASS': None,
- 'TEMPLATE_DB': 'test_template_nominatim',
- 'TEST_DB': 'test_nominatim',
- 'API_TEST_DB': 'test_api_nominatim',
- 'API_TEST_FILE': TEST_BASE_DIR / 'testdb' / 'apidb-test-data.pbf',
- 'TOKENIZER': None, # Test with a custom tokenizer
- 'STYLE': 'extratags',
- 'API_ENGINE': 'falcon'
-}
-
-
-use_step_matcher("re") # noqa: F405
-
-
-def before_all(context):
- # logging setup
- context.config.setup_logging()
- # set up -D options
- for k, v in userconfig.items():
- context.config.userdata.setdefault(k, v)
- # Nominatim test setup
- context.nominatim = NominatimEnvironment(context.config.userdata)
- context.osm = GeometryFactory()
-
-
-def before_scenario(context, scenario):
- if 'SQLITE' not in context.tags \
- and context.config.userdata['API_TEST_DB'].startswith('sqlite:'):
- context.scenario.skip("Not usable with Sqlite database.")
- elif 'DB' in context.tags:
- context.nominatim.setup_db(context)
- elif 'APIDB' in context.tags:
- context.nominatim.setup_api_db()
- elif 'UNKNOWNDB' in context.tags:
- context.nominatim.setup_unknown_db()
-
-
-def after_scenario(context, scenario):
- if 'DB' in context.tags:
- context.nominatim.teardown_db(context)
--- /dev/null
+Feature: Localization of search results
+
+ Scenario: default language
+ When sending v1/details
+ | osmtype | osmid |
+ | R | 1155955 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liechtenstein |
+
+ Scenario: accept-language first
+ When sending v1/details
+ | osmtype | osmid | accept-language |
+ | R | 1155955 | zh,de |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | 列支敦士登 |
+
+ Scenario: accept-language missing
+ When sending v1/details
+ | osmtype | osmid | accept-language |
+ | R | 1155955 | xx,fr,en,de |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liechtenstein |
+
+ Scenario: http accept language header first
+ Given the HTTP header
+ | accept-language |
+ | fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/details
+ | osmtype | osmid |
+ | R | 1155955 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liktinstein |
+
+ Scenario: http accept language header and accept-language
+ Given the HTTP header
+ | accept-language |
+ | fr-ca,fr;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/details
+ | osmtype | osmid | accept-language |
+ | R | 1155955 | fo,en |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liktinstein |
+
+ Scenario: http accept language header fallback
+ Given the HTTP header
+ | accept-language |
+ | fo-ca,en-ca;q=0.5 |
+ When sending v1/details
+ | osmtype | osmid |
+ | R | 1155955 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liktinstein |
+
+ Scenario: http accept language header fallback (upper case)
+ Given the HTTP header
+ | accept-language |
+ | fo-FR;q=0.8,en-ca;q=0.5 |
+ When sending v1/details
+ | osmtype | osmid |
+ | R | 1155955 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | localname |
+ | Liktinstein |
--- /dev/null
+Feature: Object details
+ Testing different parameter options for details API.
+
+ Scenario: Basic details
+ When sending v1/details
+ | osmtype | osmid |
+ | W | 297699560 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes geometry
+ And the result has no attributes keywords,address,linked_places,parentof
+ And the result contains
+ | geometry+type |
+ | Point |
+
+ Scenario: Basic details with pretty printing
+ When sending v1/details
+ | osmtype | osmid | pretty |
+ | W | 297699560 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes geometry
+ And the result has no attributes keywords,address,linked_places,parentof
+
+ Scenario: Details with addressdetails
+ When sending v1/details
+ | osmtype | osmid | addressdetails |
+ | W | 297699560 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes address
+
+ Scenario: Details with linkedplaces
+ When sending v1/details
+ | osmtype | osmid | linkedplaces |
+ | R | 123924 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes linked_places
+
+ Scenario: Details with hierarchy
+ When sending v1/details
+ | osmtype | osmid | hierarchy |
+ | W | 297699560 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes hierarchy
+
+ Scenario: Details with grouped hierarchy
+ When sending v1/details
+ | osmtype | osmid | hierarchy | group_hierarchy |
+ | W | 297699560 | 1 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes hierarchy
+
+ Scenario Outline: Details with keywords
+ When sending v1/details
+ | osmtype | osmid | keywords |
+ | <type> | <id> | 1 |
+ Then a HTTP 200 is returned
+ Then the result is valid json
+ And the result has attributes keywords
+
+ Examples:
+ | type | id |
+ | W | 297699560 |
+ | W | 243055645 |
+ | W | 243055716 |
+ | W | 43327921 |
+
+ # ticket #1343
+ Scenario: Details of a country with keywords
+ When sending v1/details
+ | osmtype | osmid | keywords |
+ | R | 1155955 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes keywords
+
+ Scenario Outline: Details with full geometry
+ When sending v1/details
+ | osmtype | osmid | polygon_geojson |
+ | <type> | <id> | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes geometry
+ And the result contains
+ | geometry+type |
+ | <geometry> |
+
+ Examples:
+ | type | id | geometry |
+ | W | 297699560 | LineString |
+ | W | 243055645 | Polygon |
+ | W | 243055716 | Polygon |
+ | W | 43327921 | LineString |
+
+
--- /dev/null
+Feature: Object details
+ Check details page for correctness
+
+ Scenario Outline: Details request with OSM id
+ When sending v1/details
+ | osmtype | osmid |
+ | <type> | <id> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | osm_type | osm_id |
+ | <type> | <id> |
+
+ Examples:
+ | type | id |
+ | N | 5484325405 |
+ | W | 43327921 |
+ | R | 123924 |
+
+ Scenario Outline: Details request with different class types for the same OSM id
+ When sending v1/details
+ | osmtype | osmid | class |
+ | N | 300209696 | <class> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | osm_type | osm_id | category |
+ | N | 300209696 | <class> |
+
+ Examples:
+ | class |
+ | tourism |
+ | mountain_pass |
+
+ Scenario: Details request without osmtype
+ When sending v1/details
+ | osmid |
+ | <id> |
+ Then a HTTP 400 is returned
+ And the result is valid json
+
+ Scenario: Details request with unknown OSM id
+ When sending v1/details
+ | osmtype | osmid |
+ | R | 1 |
+ Then a HTTP 404 is returned
+ And the result is valid json
+
+ Scenario: Details request with unknown class
+ When sending v1/details
+ | osmtype | osmid | class |
+ | N | 300209696 | highway |
+ Then a HTTP 404 is returned
+ And the result is valid json
+
+ Scenario: Details for interpolation way return the interpolation
+ When sending v1/details
+ | osmtype | osmid |
+ | W | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | category | type | osm_type | osm_id | admin_level |
+ | place | houses | W | 1 | 15 |
+
+
+ @skip
+ Scenario: Details for interpolation way return the interpolation
+ When sending details query for 112871
+ Then the result is valid json
+ And the result contains
+ | category | type | admin_level |
+ | place | houses | 15 |
+ And result has not attributes osm_type,osm_id
+
+
+ @skip
+ Scenario: Details for postcode
+ When sending details query for 112820
+ Then the result is valid json
+ And the result contains
+ | category | type | admin_level |
+ | place | postcode | 15 |
+ And result has not attributes osm_type,osm_id
+
+
+ Scenario Outline: Details debug output returns no errors
+ When sending v1/details
+ | osmtype | osmid | debug |
+ | <type> | <id> | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid html
+
+ Examples:
+ | type | id |
+ | N | 5484325405 |
+ | W | 43327921 |
+ | R | 123924 |
+
--- /dev/null
+Feature: Tests for finding places by osm_type and osm_id
+ Simple tests for response format.
+
+ Scenario Outline: Address lookup for existing object
+ When sending v1/lookup with format <format>
+ | osm_ids |
+ | N5484325405,W43327921,,R123924,X99,N0 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And exactly 3 results are returned
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+ | geocodejson | geocodejson |
+
+ Scenario: Address lookup for non-existing or invalid object
+ When sending v1/lookup
+ | osm_ids |
+ | X99,,N0,nN158845944,ABC,,W9 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And exactly 0 results are returned
+
+ Scenario Outline: Boundingbox is returned
+ When sending v1/lookup with format <format>
+ | osm_ids |
+ | N5484325405,W43327921 |
+ Then the result is valid <outformat>
+ And the result set contains exactly
+ | object | boundingbox!in_box |
+ | N5484325405 | 47.135,47.14,9.52,9.525 |
+ | W43327921 | 47.07,47.08,9.50,9.52 |
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+
+ Scenario: Linked places return information from the linkee
+ When sending v1/lookup with format geocodejson
+ | osm_ids |
+ | N1932181216 |
+ Then the result is valid geocodejson
+ And exactly 1 result is returned
+ And all results contain
+ | name |
+ | Vaduz |
+
+ Scenario Outline: Force error by providing too many ids
+ When sending v1/lookup with format <format>
+ | osm_ids |
+ | N1,N2,N3,N4,N5,N6,N7,N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20,N21,N22,N23,N24,N25,N26,N27,N28,N29,N30,N31,N32,N33,N34,N35,N36,N37,N38,N39,N40,N41,N42,N43,N44,N45,N46,N47,N48,N49,N50,N51 |
+ Then a HTTP 400 is returned
+ And the result is valid <outformat>
+ And the result contains
+ | error+code | error+message |
+ | 400 | Too many object IDs. |
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | json |
+ | geocodejson | json |
--- /dev/null
+Feature: Geometries for reverse geocoding
+ Tests for returning geometries with reverse
+
+ Scenario: Reverse - polygons are returned fully by default
+ When sending v1/reverse
+ | lat | lon | polygon_text |
+ | 47.13803 | 9.52264 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geotext!fm |
+ | POLYGON\(\(9.5225302 47.138066, ?9.5225348 47.1379282, ?9.5226142 47.1379294, ?9.5226143 47.1379257, ?9.522615 47.137917, ?9.5226225 47.1379098, ?9.5226334 47.1379052, ?9.5226461 47.1379037, ?9.5226588 47.1379056, ?9.5226693 47.1379107, ?9.5226762 47.1379181, ?9.5226762 47.1379268, ?9.5226761 47.1379308, ?9.5227366 47.1379317, ?9.5227352 47.1379753, ?9.5227608 47.1379757, ?9.5227595 47.1380148, ?9.5227355 47.1380145, ?9.5227337 47.1380692, ?9.5225302 47.138066\)\) |
+
+
+ Scenario: Reverse - polygons can be slightly simplified
+ When sending v1/reverse
+ | lat | lon | polygon_text | polygon_threshold |
+ | 47.13803 | 9.52264 | 1 | 0.00001 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geotext!fm |
+ | POLYGON\(\(9.5225302 47.138066, ?9.5225348 47.1379282, ?9.5226142 47.1379294, ?9.5226225 47.1379098, ?9.5226588 47.1379056, ?9.5226761 47.1379308, ?9.5227366 47.1379317, ?9.5227352 47.1379753, ?9.5227608 47.1379757, ?9.5227595 47.1380148, ?9.5227355 47.1380145, ?9.5227337 47.1380692, ?9.5225302 47.138066\)\) |
+
+
+ Scenario: Reverse - polygons can be much simplified
+ When sending v1/reverse
+ | lat | lon | polygon_text | polygon_threshold |
+ | 47.13803 | 9.52264 | 1 | 0.9 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geotext!fm |
+ | POLYGON\(\([0-9. ]+, ?[0-9. ]+, ?[0-9. ]+, ?[0-9. ]+(, ?[0-9. ]+)?\)\) |
+
+
+ Scenario: Reverse - for polygons return the centroid as center point
+ When sending v1/reverse
+ | lat | lon |
+ | 47.13836 | 9.52304 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | lon | lat |
+ | 9.5227108 | 47.1381805 |
+
+
+ Scenario: Reverse - for streets return the closest point as center point
+ When sending v1/reverse
+ | lat | lon |
+ | 47.13368 | 9.52942 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | lon | lat |
+ | 9.5294315 | 47.1336817 |
--- /dev/null
+Feature: Localization of reverse search results
+
+ Scenario: Reverse - default language
+ When sending v1/reverse with format jsonv2
+ | lat | lon |
+ | 47.14 | 9.55 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | address+country |
+ | Liechtenstein |
+
+ Scenario: Reverse - accept-language parameter
+ When sending v1/reverse with format jsonv2
+ | lat | lon | accept-language |
+ | 47.14 | 9.55 | ja,en |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | address+country |
+ | リヒテンシュタイン |
+
+ Scenario: Reverse - HTTP accept language header
+ Given the HTTP header
+ | accept-language |
+ | fo-ca,fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/reverse with format jsonv2
+ | lat | lon |
+ | 47.14 | 9.55 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | address+country |
+ | Liktinstein |
+
+ Scenario: Reverse - accept-language parameter and HTTP header
+ Given the HTTP header
+ | accept-language |
+ | fo-ca,fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/reverse with format jsonv2
+ | lat | lon | accept-language |
+ | 47.14 | 9.55 | en |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | address+country |
+ | Liechtenstein |
-@SQLITE
-@APIDB
Feature: Layer parameter in reverse geocoding
Testing correct function of layer selection while reverse geocoding
Scenario: POIs are selected by default
- When sending v1/reverse at 47.14077,9.52414
- Then results contain
+ When reverse geocoding 47.14077,9.52414
+ Then the result contains
| category | type |
| tourism | viewpoint |
-
Scenario Outline: Same address level POI with different layers
- When sending v1/reverse at 47.14077,9.52414
+ When reverse geocoding 47.14077,9.52414
| layer |
| <layer> |
- Then results contain
+ Then the result contains
| category |
| <category> |
-
Examples:
| layer | category |
| address | highway |
| address,natural | highway |
| natural,poi | tourism |
-
Scenario Outline: POIs are not selected without housenumber for address layer
- When sending v1/reverse at 47.13816,9.52168
+ When reverse geocoding 47.13816,9.52168
| layer |
| <layer> |
- Then results contain
+ Then the result contains
| category | type |
| <category> | <type> |
| address,poi | highway | bus_stop |
| address | amenity | parking |
-
Scenario: Between natural and low-zoom address prefer natural
- When sending v1/reverse at 47.13636,9.52094
+ When reverse geocoding 47.13636,9.52094
| layer | zoom |
| natural,address | 15 |
- Then results contain
+ Then the result contains
| category |
| waterway |
-
Scenario Outline: Search for mountain peaks begins at level 12
- When sending v1/reverse at 47.08293,9.57109
+ When reverse geocoding 47.08293,9.57109
| layer | zoom |
| natural | <zoom> |
- Then results contain
+ Then the result contains
| category | type |
| <category> | <type> |
| 12 | natural | peak |
| 13 | waterway | river |
-
Scenario Outline: Reverse search with manmade layers
- When sending v1/reverse at 32.46904,-86.44439
+ When reverse geocoding 32.46904,-86.44439
| layer |
| <layer> |
- Then results contain
+ Then the result contains
| category | type |
| <category> | <type> |
--- /dev/null
+Feature: Reverse geocoding
+ Testing the reverse function
+
+ Scenario: Reverse - Unknown countries fall back to default country grid
+ When reverse geocoding 45.174,-103.072
+ Then the result contains
+ | category | type | display_name |
+ | place | country | United States |
+
+ Scenario: Reverse - No TIGER house number for zoom < 18
+ When reverse geocoding 32.4752389363,-86.4810198619
+ | zoom |
+ | 17 |
+ Then the result contains
+ | osm_type | category |
+ | way | highway |
+ And the result contains in field address
+ | road | postcode | country_code |
+ | Upper Kingston Road | 36067 | us |
+
+ Scenario: Reverse - Address with non-numerical house number
+ When reverse geocoding 47.107465,9.52838521614
+ Then the result contains in field address
+ | house_number | road |
+ | 39A/B | Dorfstrasse |
+
+ Scenario: Reverse - Address with numerical house number
+ When reverse geocoding 47.168440329479594,9.511551699184338
+ Then the result contains in field address
+ | house_number | road |
+ | 6 | Schmedgässle |
+
+ Scenario Outline: Reverse - Zoom levels below 5 result in country
+ When reverse geocoding 47.16,9.51
+ | zoom |
+ | <zoom> |
+ Then the result contains
+ | display_name |
+ | Liechtenstein |
+
+ Examples:
+ | zoom |
+ | 0 |
+ | 1 |
+ | 2 |
+ | 3 |
+ | 4 |
+
+ Scenario: Reverse - When on a street, the closest interpolation is shown
+ When reverse geocoding 47.118457166193245,9.570678289621355
+ | zoom |
+ | 18 |
+ Then the result contains
+ | display_name |
+ | 1021, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ # github 2214
+ Scenario: Reverse - Interpolations do not override house numbers when they are closer
+ When reverse geocoding 47.11778,9.57255
+ | zoom |
+ | 18 |
+ Then the result contains
+ | display_name |
+ | 5, Grosssteg, Steg, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ Scenario: Reverse - Interpolations do not override house numbers when they are closer (2)
+ When reverse geocoding 47.11834,9.57167
+ | zoom |
+ | 18 |
+ Then the result contains
+ | display_name |
+ | 3, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ Scenario: Reverse - When on a street with zoom 18, the closest housenumber is returned
+ When reverse geocoding 47.11755503977281,9.572722250405036
+ | zoom |
+ | 18 |
+ Then the result contains in field address
+ | house_number |
+ | 7 |
--- /dev/null
+Feature: Geocodejson for Reverse API
+ Testing correctness of geocodejson output (API version v1).
+
+ Scenario Outline: Reverse geocodejson - Simple with no results
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | error |
+ | Unable to geocode |
+
+ Examples:
+ | lat | lon |
+ | 0.0 | 0.0 |
+ | 91.3 | 0.4 |
+ | -700 | 0.4 |
+ | 0.2 | 324.44 |
+ | 0.2 | -180.4 |
+
+ Scenario Outline: Reverse geocodejson - Simple OSM result
+ When sending v1/reverse with format geocodejson
+ | lat | lon | addressdetails |
+ | 47.066 | 9.504 | <has_address> |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And the result metadata contains
+ | version | licence | attribution!fm |
+ | 0.1.0 | ODbL | Data © OpenStreetMap contributors, ODbL 1.0. https?://osm.org/copyright |
+ And all results have <attributes> country,postcode,county,city,district,street,housenumber,admin
+ And all results contain
+ | param | value |
+ | osm_type | node |
+ | osm_id | 6522627624 |
+ | osm_key | shop |
+ | osm_value | bakery |
+ | type | house |
+ | name | Dorfbäckerei Herrmann |
+ | label | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
+ | geojson+type | Point |
+ | geojson+coordinates | [9.5036065, 47.0660892] |
+
+ Examples:
+ | has_address | attributes |
+ | 1 | attributes |
+ | 0 | no attributes |
+
+ Scenario: Reverse geocodejson - City housenumber-level address with street
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | 47.1068011 | 9.52810091 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | housenumber | street | postcode | city | country |
+ | 8 | Im Winkel | 9495 | Triesen | Liechtenstein |
+ And all results contain
+ | admin+level6 | admin+level8 |
+ | Oberland | Triesen |
+
+ Scenario: Reverse geocodejson - Town street-level address with street
+ When sending v1/reverse with format geocodejson
+ | lat | lon | zoom |
+ | 47.066 | 9.504 | 16 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | name | city | postcode | country |
+ | Gnetsch | Balzers | 9496 | Liechtenstein |
+
+ Scenario: Reverse geocodejson - Poi street-level address with footway
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | 47.06515 | 9.50083 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | street | city | postcode | country |
+ | Burgweg | Balzers | 9496 | Liechtenstein |
+
+ Scenario: Reverse geocodejson - City address with suburb
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | 47.146861 | 9.511771 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | housenumber | street | district | city | postcode | country |
+ | 5 | Lochgass | Ebenholz | Vaduz | 9490 | Liechtenstein |
+
+ Scenario: Reverse geocodejson - Tiger address
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | 32.4752389363 | -86.4810198619 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | osm_type | osm_id | osm_key | osm_value | type |
+ | way | 396009653 | place | house | house |
+ And all results contain
+ | housenumber | street | city | county | postcode | country |
+ | 707 | Upper Kingston Road | Prattville | Autauga County | 36067 | United States |
+
+ Scenario: Reverse geocodejson - Interpolation address
+ When sending v1/reverse with format geocodejson
+ | lat | lon |
+ | 47.118533 | 9.57056562 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | osm_type | osm_id | osm_key | osm_value | type |
+ | way | 1 | place | house | house |
+ And all results contain
+ | label |
+ | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+ And all results have no attributes name
+
+ Scenario: Reverse geocodejson - Line geometry output is supported
+ When sending v1/reverse with format geocodejson
+ | lat | lon | polygon_geojson |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | geojson+type |
+ | LineString |
+
+ Scenario Outline: Reverse geocodejson - Only geojson polygons are supported
+ When sending v1/reverse with format geocodejson
+ | lat | lon | <param> |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson with 1 result
+ And all results contain
+ | geojson+type |
+ | Point |
+
+ Examples:
+ | param |
+ | polygon_text |
+ | polygon_svg |
+ | polygon_kml |
--- /dev/null
+Feature: Geojson for Reverse API
+ Testing correctness of geojson output (API version v1).
+
+ Scenario Outline: Reverse geojson - Simple with no results
+ When sending v1/reverse with format geojson
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | error |
+ | Unable to geocode |
+
+ Examples:
+ | lat | lon |
+ | 0.0 | 0.0 |
+ | 91.3 | 0.4 |
+ | -700 | 0.4 |
+ | 0.2 | 324.44 |
+ | 0.2 | -180.4 |
+
+ Scenario Outline: Reverse geojson - Simple OSM result
+ When sending v1/reverse with format geojson
+ | lat | lon | addressdetails |
+ | 47.066 | 9.504 | <has_address> |
+ Then a HTTP 200 is returned
+ And the result is valid geojson with 1 result
+ And the result metadata contains
+ | licence!fm |
+ | Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright |
+ And all results have attributes place_id, importance
+ And all results have <attributes> address
+ And all results contain
+ | param | value |
+ | osm_type | node |
+ | osm_id | 6522627624 |
+ | place_rank | 30 |
+ | category | shop |
+ | type | bakery |
+ | addresstype | shop |
+ | name | Dorfbäckerei Herrmann |
+ | display_name | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
+ | boundingbox | [47.0660392, 47.0661392, 9.5035565, 9.5036565] |
+ | geojson+type | Point |
+ | geojson+coordinates | [9.5036065, 47.0660892] |
+
+ Examples:
+ | has_address | attributes |
+ | 1 | attributes |
+ | 0 | no attributes |
+
+ Scenario: Reverse geojson - Tiger address
+ When sending v1/reverse with format geojson
+ | lat | lon |
+ | 32.4752389363 | -86.4810198619 |
+ Then a HTTP 200 is returned
+ And the result is valid geojson with 1 result
+ And all results contain
+ | osm_type | osm_id | category | type | addresstype | place_rank |
+ | way | 396009653 | place | house | place | 30 |
+
+ Scenario: Reverse geojson - Interpolation address
+ When sending v1/reverse with format geojson
+ | lat | lon |
+ | 47.118533 | 9.57056562 |
+ Then a HTTP 200 is returned
+ And the result is valid geojson with 1 result
+ And all results contain
+ | osm_type | osm_id | place_rank | category | type | addresstype |
+ | way | 1 | 30 | place | house | place |
+ And all results contain
+ | boundingbox!in_box |
+ | 47.118494, 47.118596, 9.570495, 9.570597 |
+ And all results contain
+ | display_name |
+ | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ Scenario: Reverse geojson - Line geometry output is supported
+ When sending v1/reverse with format geojson
+ | lat | lon | polygon_geojson |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geojson with 1 result
+ And all results contain
+ | geojson+type |
+ | LineString |
+
+ Scenario Outline: Reverse geojson - Only geojson polygons are supported
+ When sending v1/reverse with format geojson
+ | lat | lon | <param> |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geojson with 1 result
+ And all results contain
+ | geojson+type |
+ | Point |
+
+ Examples:
+ | param |
+ | polygon_text |
+ | polygon_svg |
+ | polygon_kml |
--- /dev/null
+Feature: Json output for Reverse API
+ Testing correctness of json and jsonv2 output (API version v1).
+
+ Scenario Outline: Reverse json - Simple with no results
+ When sending v1/reverse with format json
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | error |
+ | Unable to geocode |
+ When sending v1/reverse with format jsonv2
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | error |
+ | Unable to geocode |
+
+ Examples:
+ | lat | lon |
+ | 0.0 | 0.0 |
+ | 91.3 | 0.4 |
+ | -700 | 0.4 |
+ | 0.2 | 324.44 |
+ | 0.2 | -180.4 |
+
+ Scenario Outline: Reverse json - OSM result with and without addresses
+ When sending v1/reverse with format json
+ | lat | lon | addressdetails |
+ | 47.066 | 9.504 | <has_address> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has <attributes> address
+ When sending v1/reverse with format jsonv2
+ | lat | lon | addressdetails |
+ | 47.066 | 9.504 | <has_address> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has <attributes> address
+
+ Examples:
+ | has_address | attributes |
+ | 1 | attributes |
+ | 0 | no attributes |
+
+ Scenario Outline: Reverse json - Simple OSM result
+ When sending v1/reverse with format <format>
+ | lat | lon |
+ | 47.066 | 9.504 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes place_id
+ And the result contains
+ | licence!fm |
+ | Data © OpenStreetMap contributors, ODbL 1.0. https?://osm.org/copyright |
+ And the result contains
+ | osm_type | osm_id |
+ | node | 6522627624 |
+ And the result contains
+ | lon | lat | boundingbox!in_box |
+ | 9.5036065 | 47.0660892 | 47.0660391, 47.0661393, 9.5035564, 9.5036566 |
+ And the result contains
+ | display_name |
+ | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
+ And the result has no attributes namedetails,extratags
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
+
+ Scenario: Reverse json - Extra attributes of jsonv2 result
+ When sending v1/reverse with format jsonv2
+ | lat | lon |
+ | 47.066 | 9.504 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result has attributes importance
+ And the result contains
+ | category | type | name | place_rank | addresstype |
+ | shop | bakery | Dorfbäckerei Herrmann | 30 | shop |
+
+ Scenario: Reverse json - Tiger address
+ When sending v1/reverse with format jsonv2
+ | lat | lon |
+ | 32.4752389363 | -86.4810198619 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | osm_type | osm_id | category | type | addresstype |
+ | way | 396009653 | place | house | place |
+
+ Scenario Outline: Reverse json - Interpolation address
+ When sending v1/reverse with format <format>
+ | lat | lon |
+ | 47.118533 | 9.57056562 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | osm_type | osm_id |
+ | way | 1 |
+ And the result contains
+ | lon | lat | boundingbox!in_box |
+ | 9.5705468 | 47.1185454 | 47.118494, 47.118596, 9.570495, 9.570597 |
+ And the result contains
+ | display_name |
+ | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
+
+ Scenario Outline: Reverse json - Output of geojson
+ When sending v1/reverse with format <format>
+ | lat | lon | polygon_geojson |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | geojson+type | geojson+coordinates |
+ | LineString | [[9.5039353, 47.0657546], [9.5040437, 47.0657781], [9.5040808, 47.065787], [9.5054298, 47.0661407]] |
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
+
+ Scenario Outline: Reverse json - Output of WKT
+ When sending v1/reverse with format <format>
+ | lat | lon | polygon_text |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | geotext!wkt |
+ | 9.5039353 47.0657546, 9.5040437 47.0657781, 9.5040808 47.065787, 9.5054298 47.0661407 |
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
+
+ Scenario Outline: Reverse json - Output of SVG
+ When sending v1/reverse with format <format>
+ | lat | lon | polygon_svg |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | svg |
+ | M 9.5039353 -47.0657546 L 9.5040437 -47.0657781 9.5040808 -47.065787 9.5054298 -47.0661407 |
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
+
+ Scenario Outline: Reverse json - Output of KML
+ When sending v1/reverse with format <format>
+ | lat | lon | polygon_kml |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | geokml!fm |
+ | <LineString><coordinates>9.5039\d*,47.0657\d* 9.5040\d*,47.0657\d* 9.5040\d*,47.065\d* 9.5054\d*,47.0661\d*</coordinates></LineString> |
+
+ Examples:
+ | format |
+ | json |
+ | jsonv2 |
--- /dev/null
+Feature: v1/reverse Parameter Tests
+ Tests for parameter inputs for the v1 reverse endpoint.
+ This file contains mostly bad parameter input. Valid parameters
+ are tested in the format tests.
+
+ Scenario: Bad format
+ When sending v1/reverse
+ | lat | lon | format |
+ | 47.14122383 | 9.52169581334 | sdf |
+ Then a HTTP 400 is returned
+
+ Scenario: Missing lon parameter
+ When sending v1/reverse
+ | lat |
+ | 52.52 |
+ Then a HTTP 400 is returned
+
+ Scenario: Missing lat parameter
+ When sending v1/reverse
+ | lon |
+ | 52.52 |
+ Then a HTTP 400 is returned
+
+ Scenario Outline: Bad format for lat or lon
+ When sending v1/reverse
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 400 is returned
+
+ Examples:
+ | lat | lon |
+ | 48.9660 | 8,4482 |
+ | 48,9660 | 8.4482 |
+ | 48,9660 | 8,4482 |
+ | 48.966.0 | 8.4482 |
+ | 48.966 | 8.448.2 |
+ | Nan | 8.448 |
+ | 48.966 | Nan |
+ | Inf | 5.6 |
+ | 5.6 | -Inf |
+ | <script></script> | 3.4 |
+ | 3.4 | <script></script> |
+ | -45.3 | ; |
+ | gkjd | 50 |
+
+ Scenario: Non-numerical zoom levels return an error
+ When sending v1/reverse
+ | lat | lon | zoom |
+ | 47.14122383 | 9.52169581334 | adfe |
+ Then a HTTP 400 is returned
+
+ Scenario Outline: Truthy values for boolean parameters
+ When sending v1/reverse
+ | lat | lon | addressdetails |
+ | 47.14122383 | 9.52169581334 | <value> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result has attributes address
+
+ When sending v1/reverse
+ | lat | lon | extratags |
+ | 47.14122383 | 9.52169581334 | <value> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result has attributes extratags
+
+ When sending v1/reverse
+ | lat | lon | namedetails |
+ | 47.14122383 | 9.52169581334 | <value> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result has attributes namedetails
+
+ Examples:
+ | value |
+ | yes |
+ | no |
+ | -1 |
+ | 100 |
+ | false |
+ | 00 |
+
+ Scenario: Only one geometry can be requested
+ When sending v1/reverse
+ | lat | lon | polygon_text | polygon_svg |
+ | 47.14122383 | 9.52169581334 | 1 | 1 |
+ Then a HTTP 400 is returned
+
+ Scenario Outline: Illegal jsonp are not allowed
+ When sending v1/reverse with format json
+ | lat | lon | json_callback |
+ | 47.14122383 | 9.52169581334 | <data> |
+ Then a HTTP 400 is returned
+
+ Examples:
+ | data |
+ | 1asd |
+ | bar(foo) |
+ | XXX['bad'] |
+ | foo; evil |
+
+ Scenario Outline: Reverse debug mode produces valid HTML
+ When sending v1/reverse
+ | lat | lon | debug |
+ | <lat> | <lon> | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid html
+
+ Examples:
+ | lat | lon |
+ | 0.0 | 0.0 |
+ | 47.06645 | 9.56601 |
+ | 47.14081 | 9.52267 |
+
+ Scenario Outline: Full address display for city housenumber-level address with street
+ When sending v1/reverse with format <format>
+ | lat | lon |
+ | 47.1068011 | 9.52810091 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And the result contains in field address
+ | param | value |
+ | house_number | 8 |
+ | road | Im Winkel |
+ | neighbourhood | Oberdorf |
+ | village | Triesen |
+ | ISO3166-2-lvl8 | LI-09 |
+ | county | Oberland |
+ | postcode | 9495 |
+ | country | Liechtenstein |
+ | country_code | li |
+
+ Examples:
+ | format | outformat |
+ | json | json |
+ | jsonv2 | json |
+ | xml | xml |
+
+ Scenario Outline: Results with name details
+ When sending v1/reverse with format <format>
+ | lat | lon | zoom | namedetails |
+ | 47.14052 | 9.52202 | 14 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And the result contains in field namedetails
+ | name |
+ | Ebenholz |
+
+ Examples:
+ | format | outformat |
+ | json | json |
+ | jsonv2 | json |
+ | xml | xml |
+
+ Scenario Outline: Results with extratags
+ When sending v1/reverse with format <format>
+ | lat | lon | zoom | extratags |
+ | 47.14052 | 9.52202 | 14 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And the result contains in field extratags
+ | wikidata |
+ | Q4529531 |
+
+ Examples:
+ | format | outformat |
+ | json | json |
+ | jsonv2 | json |
+ | xml | xml |
--- /dev/null
+Feature: XML output for Reverse API
+ Testing correctness of xml output (API version v1).
+
+ Scenario Outline: Reverse XML - Simple reverse-geocoding with no results
+ When sending v1/reverse
+ | lat | lon |
+ | <lat> | <lon> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result has no attributes osm_type, address, extratags
+ And the result contains
+ | error |
+ | Unable to geocode |
+
+ Examples:
+ | lat | lon |
+ | 0.0 | 0.0 |
+ | 91.3 | 0.4 |
+ | -700 | 0.4 |
+ | 0.2 | 324.44 |
+ | 0.2 | -180.4 |
+
+ Scenario Outline: Reverse XML - OSM result with and without addresses
+ When sending v1/reverse with format xml
+ | lat | lon | addressdetails |
+ | 47.066 | 9.504 | <has_address> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result has attributes place_id
+ And the result has <attributes> address
+ And the result contains
+ | osm_type | osm_id | place_rank | address_rank |
+ | node | 6522627624 | 30 | 30 |
+ And the result contains
+ | lon | lat | boundingbox |
+ | 9.5036065 | 47.0660892 | 47.0660392,47.0661392,9.5035565,9.5036565 |
+ And the result contains
+ | ref | display_name |
+ | Dorfbäckerei Herrmann | Dorfbäckerei Herrmann, 29, Gnetsch, Mäls, Balzers, Oberland, 9496, Liechtenstein |
+
+ Examples:
+ | has_address | attributes |
+ | 1 | attributes |
+ | 0 | no attributes |
+
+ Scenario: Reverse XML - Tiger address
+ When sending v1/reverse with format xml
+ | lat | lon |
+ | 32.4752389363 | -86.4810198619 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | osm_type | osm_id | place_rank | address_rank |
+ | way | 396009653 | 30 | 30 |
+ And the result contains
+ | lon | lat | boundingbox |
+ | -86.4808553 | 32.4753580 | 32.4753080,32.4754080,-86.4809053,-86.4808053 |
+ And the result contains
+ | display_name |
+ | 707, Upper Kingston Road, Upper Kingston, Prattville, Autauga County, 36067, United States |
+
+ Scenario: Reverse XML - Interpolation address
+ When sending v1/reverse with format xml
+ | lat | lon |
+ | 47.118533 | 9.57056562 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | osm_type | osm_id | place_rank | address_rank |
+ | way | 1 | 30 | 30 |
+ And the result contains
+ | lon | lat | boundingbox |
+ | 9.5705468 | 47.1185454 | 47.1184954,47.1185954,9.5704968,9.5705968 |
+ And the result contains
+ | display_name |
+ | 1019, Grosssteg, Sücka, Triesenberg, Oberland, 9497, Liechtenstein |
+
+ Scenario: Reverse XML - Output of geojson
+ When sending v1/reverse with format xml
+ | lat | lon | polygon_geojson |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geojson |
+ | {"type":"LineString","coordinates":[[9.5039353,47.0657546],[9.5040437,47.0657781],[9.5040808,47.065787],[9.5054298,47.0661407]]} |
+
+ Scenario: Reverse XML - Output of WKT
+ When sending v1/reverse with format xml
+ | lat | lon | polygon_text |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geotext!wkt |
+ | 9.5039353 47.0657546, 9.5040437 47.0657781, 9.5040808 47.065787, 9.5054298 47.0661407 |
+
+ Scenario: Reverse XML - Output of SVG
+ When sending v1/reverse with format xml
+ | lat | lon | polygon_svg |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geosvg |
+ | M 9.5039353 -47.0657546 L 9.5040437 -47.0657781 9.5040808 -47.065787 9.5054298 -47.0661407 |
+
+ Scenario: Reverse XML - Output of KML
+ When sending v1/reverse with format xml
+ | lat | lon | polygon_kml |
+ | 47.06597 | 9.50467 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result contains
+ | geokml!fm |
+ | <geokml><LineString><coordinates>9.5039\d*,47.0657\d* 9.5040\d*,47.0657\d* 9.5040\d*,47.065\d* 9.5054\d*,47.0661\d*</coordinates></LineString></geokml> |
--- /dev/null
+Feature: Localization of search results
+
+ Scenario: Search - default language
+ When sending v1/search
+ | q |
+ | Liechtenstein |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liechtenstein |
+
+ Scenario: Search - accept-language first
+ When sending v1/search
+ | q | accept-language |
+ | Liechtenstein | zh,de |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | 列支敦士登 |
+
+ Scenario: Search - accept-language missing
+ When sending v1/search
+ | q | accept-language |
+ | Liechtenstein | xx,fr,en,de |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liechtenstein |
+
+ Scenario: Search - http accept language header first
+ Given the HTTP header
+ | accept-language |
+ | fo;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/search
+ | q |
+ | Liechtenstein |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liktinstein |
+
+ Scenario: Search - http accept language header and accept-language
+ Given the HTTP header
+ | accept-language |
+ | fr-ca,fr;q=0.8,en-ca;q=0.5,en;q=0.3 |
+ When sending v1/search
+ | q | accept-language |
+ | Liechtenstein | fo,en |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liktinstein |
+
+ Scenario: Search - http accept language header fallback
+ Given the HTTP header
+ | accept-language |
+ | fo-ca,en-ca;q=0.5 |
+ When sending v1/search
+ | q |
+ | Liechtenstein |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liktinstein |
+
+ Scenario: Search - http accept language header fallback (upper case)
+ Given the HTTP header
+ | accept-language |
+ | fo-FR;q=0.8,en-ca;q=0.5 |
+ When sending v1/search
+ | q |
+ | Liechtenstein |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And result 0 contains
+ | display_name |
+ | Liktinstein |
--- /dev/null
+Feature: Search queries
+ Testing different queries and parameters
+
+ Scenario: Simple XML search
+ When sending v1/search with format xml
+ | q |
+ | Schaan |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And all results have attributes place_id,osm_type,osm_id
+ And all results have attributes place_rank,boundingbox
+ And all results have attributes lat,lon,display_name
+ And all results have attributes class,type,importance
+ And all results have no attributes address
+ And all results contain
+ | boundingbox!in_box |
+ | 46.5,47.5,9,10 |
+
+ Scenario Outline: Simple JSON search
+ When sending v1/search with format <format>
+ | q |
+ | Vaduz |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And all results have attributes place_id,licence,<cname>,type
+ And all results have attributes osm_type,osm_id,boundingbox
+ And all results have attributes lat,lon,display_name,importance
+ And all results have no attributes address
+ And all results contain
+ | boundingbox!in_box |
+ | 46.5,47.5,9,10 |
+
+ Examples:
+ | format | cname |
+ | json | class |
+ | jsonv2 | category |
+
+ Scenario: Unknown formats returns a user error
+ When sending v1/search with format x45
+ | q |
+ | Vaduz |
+ Then a HTTP 400 is returned
+
+ Scenario Outline: Search with addressdetails
+ When sending v1/search with format <format>
+ | q | addressdetails |
+ | Triesen | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And result 0 contains in field address
+ | param | value |
+ | village | Triesen |
+ | county | Oberland |
+ | postcode | 9495 |
+ | country | Liechtenstein |
+ | country_code | li |
+ | ISO3166-2-lvl8 | LI-09 |
+
+ Examples:
+ | format | outformat |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+ | xml | xml |
+
+ Scenario: Coordinate search with addressdetails
+ When geocoding "47.12400621,9.6047552"
+ | accept-language |
+ | en |
+ Then all results contain
+ | display_name |
+ | Guschg, Valorschstrasse, Balzers, Oberland, 9497, Liechtenstein |
+
+ Scenario: Address details with unknown class types
+ When geocoding "Kloster St. Elisabeth"
+ Then result 0 contains
+ | category | type | address+amenity |
+ | amenity | monastery | Kloster St. Elisabeth |
+
+ Scenario: Disabling deduplication
+ When geocoding "Malbunstr, Schaan"
+ Then exactly 1 result is returned
+ When geocoding "Malbunstr, Schaan"
+ | dedupe |
+ | 0 |
+ Then exactly 4 results are returned
+
+ Scenario: Search with bounded viewbox in right area
+ When geocoding "post"
+ | bounded | viewbox |
+ | 1 | 9,47,10,48 |
+ Then result 0 contains
+ | address+town |
+ | Vaduz |
+ When geocoding "post"
+ | bounded | viewbox |
+ | 1 | 9.49712,47.17122,9.52605,47.16242 |
+ Then result 0 contains
+ | address+town |
+ | Schaan |
+
+ Scenario: Country search with bounded viewbox remain in the area
+ When geocoding
+ | bounded | viewbox | country |
+ | 1 | 9.49712,47.17122,9.52605,47.16242 | de |
+ Then exactly 0 results are returned
+
+ Scenario: Search with bounded viewboxlbrt in right area
+ When geocoding "bar"
+ | bounded | viewboxlbrt |
+ | 1 | 9.49712,47.16242,9.52605,47.17122 |
+ Then all results contain
+ | address+town |
+ | Schaan |
+
+ Scenario: No POI search with unbounded viewbox
+ When geocoding "restaurant"
+ | viewbox |
+ | 9.93027,53.61634,10.10073,53.54500 |
+ Then all results contain
+ | display_name!fm |
+ | .*[Rr]estaurant.* |
+
+ Scenario: bounded search remains within viewbox, even with no results
+ When geocoding "[restaurant]"
+ | bounded | viewbox |
+ | 1 | 43.5403125,-5.6563282,43.54285,-5.662003 |
+ Then exactly 0 results are returned
+
+ Scenario: bounded search remains within viewbox with results
+ When geocoding "restaurant"
+ | bounded | viewbox |
+ | 1 | 9.49712,47.17122,9.52605,47.16242 |
+ Then all results contain
+ | boundingbox!in_box |
+ | 47.16242,47.17122,9.49712,9.52605 |
+
+ Scenario: Prefer results within viewbox
+ When geocoding "Gässle"
+ | accept-language | viewbox |
+ | en | 9.52413,47.10759,9.53140,47.10539 |
+ Then result 0 contains
+ | address+village |
+ | Triesen |
+ When geocoding "Gässle"
+ | accept-language | viewbox |
+ | en | 9.45949,47.08421,9.54094,47.05466 |
+ Then result 0 contains
+ | address+town |
+ | Balzers |
+
+ Scenario: viewboxes cannot be points
+ When sending v1/search
+ | q | viewbox |
+ | foo | 1.01,34.6,1.01,34.6 |
+ Then a HTTP 400 is returned
+
+ Scenario Outline: viewbox must have four coordinate numbers
+ When sending v1/search
+ | q | viewbox |
+ | foo | <viewbox> |
+ Then a HTTP 400 is returned
+
+ Examples:
+ | viewbox |
+ | 34 |
+ | 0.003,-84.4 |
+ | 5.2,4.5542,12.4 |
+ | 23.1,-6,0.11,44.2,9.1 |
+
+ Scenario Outline: viewboxlbrt must have four coordinate numbers
+ When sending v1/search
+ | q | viewboxlbrt |
+ | foo | <viewbox> |
+ Then a HTTP 400 is returned
+
+ Examples:
+ | viewbox |
+ | 34 |
+ | 0.003,-84.4 |
+ | 5.2,4.5542,12.4 |
+ | 23.1,-6,0.11,44.2,9.1 |
+
+ Scenario: Overly large limit number for search results
+ When geocoding "restaurant"
+ | limit |
+ | 1000 |
+ Then exactly 35 results are returned
+
+ Scenario: Limit number of non-duplicated search results
+ When geocoding "landstr"
+ | dedupe |
+ | 0 |
+ Then exactly 10 results are returned
+ When geocoding "landstr"
+ | limit | dedupe |
+ | 4 | 0 |
+ Then exactly 4 results are returned
+
+ Scenario: Limit parameter must be a number
+ When sending v1/search
+ | q | limit |
+ | Blue Laguna | ); |
+ Then a HTTP 400 is returned
+
+ Scenario: Restrict to feature type country
+ When geocoding "fürstentum"
+ | featureType |
+ | country |
+ Then all results contain
+ | place_rank |
+ | 4 |
+
+ Scenario: Restrict to feature type state
+ When geocoding "Wangerberg"
+ Then more than 0 results are returned
+ When geocoding "Wangerberg"
+ | featureType |
+ | state |
+ Then exactly 0 results are returned
+
+ Scenario: Restrict to feature type city
+ When geocoding "vaduz"
+ | featureType |
+ | state |
+ Then exactly 0 results are returned
+ When geocoding "vaduz"
+ | featureType |
+ | city |
+ Then more than 0 results are returned
+ Then all results contain
+ | place_rank |
+ | 16 |
+
+ Scenario: Restrict to feature type settlement
+ When geocoding "Malbun"
+ Then result 1 contains
+ | category |
+ | landuse |
+ When geocoding "Malbun"
+ | featureType |
+ | settlement |
+ Then all results contain
+ | category | type |
+ | place | village |
+
+ Scenario Outline: Search with polygon threshold (json)
+ When sending v1/search with format json
+ | q | polygon_geojson | polygon_threshold |
+ | Triesenberg | 1 | <th> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And more than 0 results are returned
+ And all results have attributes geojson
+
+ Examples:
+ | th |
+ | -1 |
+ | 0.0 |
+ | 0.5 |
+ | 999 |
+
+ Scenario Outline: Search with polygon threshold (xml)
+ When sending v1/search with format xml
+ | q | polygon_geojson | polygon_threshold |
+ | Triesenberg | 1 | <th> |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And more than 0 results are returned
+ And all results have attributes geojson
+
+ Examples:
+ | th |
+ | -1 |
+ | 0.0 |
+ | 0.5 |
+ | 999 |
+
+ Scenario Outline: Search with invalid polygon threshold (xml)
+ When sending v1/search with format xml
+ | q | polygon_geojson | polygon_threshold |
+ | Triesenberg | 1 | <th> |
+ Then a HTTP 400 is returned
+
+ Examples:
+ | th |
+ | x |
+ | ;; |
+ | 1m |
+
+ Scenario Outline: Search with extratags
+ When sending v1/search with format <format>
+ | q | extratags |
+ | Landstr | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And more than 0 results are returned
+ Then all results have attributes extratags
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+
+ Scenario Outline: Search with namedetails
+ When sending v1/search with format <format>
+ | q | namedetails |
+ | Landstr | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And more than 0 results are returned
+ Then all results have attributes namedetails
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+
+ Scenario Outline: Search result with contains formatted geometry
+ When sending v1/search with format <format>
+ | q | <param> |
+ | Triesenberg | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And more than 0 results are returned
+ And all results have attributes <response_attribute>
+
+ Examples:
+ | format | outformat | param | response_attribute |
+ | xml | xml | polygon_text | geotext |
+ | json | json | polygon_text | geotext |
+ | jsonv2 | json | polygon_text | geotext |
+ | xml | xml | polygon_svg | geosvg |
+ | json | json | polygon_svg | svg |
+ | jsonv2 | json | polygon_svg | svg |
+ | xml | xml | polygon_kml | geokml |
+ | json | json | polygon_kml | geokml |
+ | jsonv2 | json | polygon_kml | geokml |
+ | xml | xml | polygon_geojson | geojson |
+ | json | json | polygon_geojson | geojson |
+ | jsonv2 | json | polygon_geojson | geojson |
+ | geojson | geojson | polygon_geojson | geojson |
+
+ Scenario Outline: Search result in geojson format contains no non-geojson geometry
+ When sending v1/search with format geojson
+ | q | <param> |
+ | Triesenberg | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geojson
+ And more than 0 results are returned
+ And all results have no attributes <response_attribute>
+
+ Examples:
+ | param | response_attribute |
+ | polygon_text | geotext |
+ | polygon_svg | svg |
+ | polygon_kml | geokml |
-@SQLITE
-@APIDB
Feature: Searches with postcodes
Various searches involving postcodes
Scenario: US 5+4 ZIP codes are shortened to 5 ZIP codes if not found
- When sending json search query "36067-1111, us" with address
- Then result addresses contain
+ When geocoding "36067-1111, us"
+ Then all results contain in field address
| postcode |
| 36067 |
- And results contain
+ And all results contain
| type |
| postcode |
Scenario: Postcode search with address
- When sending json search query "9486, mauren"
- Then at least 1 result is returned
+ When geocoding "9486, mauren"
+ Then result 0 contains
+ | type |
+ | postcode |
Scenario: Postcode search with country
- When sending json search query "9486, li" with address
- Then result addresses contain
+ When geocoding "9486, li"
+ Then all results contain in field address
| country_code |
| li |
Scenario: Postcode search with country code restriction
- When sending json search query "9490" with address
+ When geocoding "9490"
| countrycodes |
| li |
- Then result addresses contain
+ Then all results contain in field address
| country_code |
| li |
Scenario: Postcode search with bounded viewbox restriction
- When sending json search query "9486" with address
+ When geocoding "9486"
| bounded | viewbox |
| 1 | 9.55,47.20,9.58,47.22 |
- Then result addresses contain
+ Then all results contain in field address
| postcode |
| 9486 |
- When sending json search query "9486" with address
+ When geocoding "9486"
| bounded | viewbox |
| 1 | 5.00,20.00,6.00,21.00 |
- Then exactly 0 results are returned
+ Then exactly 0 result is returned
Scenario: Postcode search with structured query
- When sending json search query "" with address
+ When geocoding ""
| postalcode | country |
| 9490 | li |
- Then result addresses contain
+ Then all results contain in field address
| country_code | postcode |
| li | 9490 |
--- /dev/null
+Feature: Search queries
+ Generic search result correctness
+
+ Scenario: Search for natural object
+ When geocoding "Samina"
+ | accept-language |
+ | en |
+ Then result 0 contains
+ | category | type | display_name |
+ | waterway | river | Samina, Austria |
+
+ Scenario: House number search for non-street address
+ When geocoding "6 Silum, Liechtenstein"
+ | accept-language |
+ | en |
+ Then result 0 contains in field address
+ | param | value |
+ | house_number | 6 |
+ | village | Silum |
+ | town | Triesenberg |
+ | county | Oberland |
+ | postcode | 9497 |
+ | country | Liechtenstein |
+ | country_code | li |
+ | ISO3166-2-lvl8 | LI-10 |
+
+ Scenario: Search for house number interpolation
+ When geocoding "Grosssteg 1023, Triesenberg"
+ | accept-language |
+ | de |
+ Then result 0 contains in field address
+ | param | value |
+ | house_number | 1023 |
+ | road | Grosssteg |
+ | village | Sücka |
+ | postcode | 9497 |
+ | town | Triesenberg |
+ | country | Liechtenstein |
+ | country_code | li |
+
+ Scenario: With missing housenumber search falls back to road
+ When geocoding "Bündaweg 555"
+ Then result 0 contains in field address
+ | param | value |
+ | road | Bündaweg |
+ | village | Silum |
+ | postcode | 9497 |
+ | county | Oberland |
+ | town | Triesenberg |
+ | country | Liechtenstein |
+ | country_code | li |
+ | ISO3166-2-lvl8 | LI-10 |
+ And all results have no attributes address+house_number
+
+ Scenario Outline: Housenumber 0 can be found
+ When sending v1/search with format <format>
+ | q | addressdetails |
+ | Gnalpstrasse 0 | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And all results contain
+ | display_name!fm | address+house_number |
+ | 0,.* | 0 |
+
+ Examples:
+ | format | outformat |
+ | xml | xml |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+
+ Scenario: TIGER house number
+ When geocoding "697 Upper Kingston Road"
+ Then all results contain
+ | osm_type | display_name!fm | address+house_number |
+ | way | 697,.* | 697 |
+
+ Scenario: Search with class-type feature
+ When geocoding "bars in ebenholz"
+ Then all results contain
+ | place_rank |
+ | 30 |
+
+ Scenario: Search with specific amenity
+ When geocoding "[restaurant] Vaduz"
+ Then all results contain
+ | category | type | address+country |
+ | amenity | restaurant | Liechtenstein |
+
+ Scenario: Search with specific amenity also work in country
+ When geocoding "restaurants in liechtenstein"
+ Then all results contain
+ | category | type | address+country |
+ | amenity | restaurant | Liechtenstein |
+
+ Scenario: Search with key-value amenity
+ When geocoding "[club=scout] Vaduz"
+ Then all results contain
+ | category | type |
+ | club | scout |
+
+ Scenario: POI search near given coordinate
+ When geocoding "restaurant near 47.16712,9.51100"
+ Then all results contain
+ | category | type |
+ | amenity | restaurant |
+
+ Scenario: Arbitrary key/value search near given coordinate
+ When geocoding "[leisure=firepit] 47.150° N 9.5340493° E"
+ Then all results contain
+ | category | type |
+ | leisure | firepit |
+
+ Scenario: POI search in a bounded viewbox
+ When geocoding "restaurants"
+ | viewbox | bounded |
+ | 9.50830,47.15253,9.52043,47.14866 | 1 |
+ Then all results contain
+ | category | type |
+ | amenity | restaurant |
+
+ Scenario Outline: Key/value search near given coordinate can be restricted to country
+ When geocoding "[natural=peak] 47.06512,9.53965"
+ | countrycodes |
+ | <cc> |
+ Then all results contain
+ | address+country_code |
+ | <cc> |
+
+ Examples:
+ | cc |
+ | li |
+ | ch |
+
+ Scenario: Name search near given coordinate
+ When geocoding "sporry"
+ Then result 0 contains
+ | address+town |
+ | Vaduz |
+ When geocoding "sporry, 47.10791,9.52676"
+ Then result 0 contains
+ | address+village |
+ | Triesen |
+
+ Scenario: Name search near given coordinate without result
+ When geocoding "sporry, N 47 15 7 W 9 61 26"
+ Then exactly 0 results are returned
+
+ Scenario: Arbitrary key/value search near a road
+ When geocoding "[amenity=drinking_water] Wissfläckaweg"
+ Then all results contain
+ | category | type |
+ | amenity | drinking_water |
+
+ Scenario: Ignore other country codes in structured search with country
+ When geocoding
+ | countrycodes | country |
+ | li | de |
+ Then exactly 0 results are returned
+
+ Scenario: Ignore country searches when query is restricted to countries
+ When geocoding "fr"
+ Then all results contain
+ | name |
+ | France |
+ When geocoding "fr"
+ | countrycodes |
+ | li |
+ Then exactly 0 results are returned
+
+ Scenario: Country searches only return results for the given country
+ When geocoding "Ans Trail"
+ | countrycodes |
+ | li |
+ Then all results contain
+ | address+country_code |
+ | li |
+
+ # https://trac.openstreetmap.org/ticket/5094
+ Scenario: housenumbers are ordered by complete match first
+ When geocoding "Austrasse 11, Vaduz"
+ Then result 0 contains
+ | address+house_number |
+ | 11 |
+
+ Scenario Outline: Coordinate searches with white spaces
+ When geocoding "<data>"
+ Then the result set contains exactly
+ | category |
+ | water |
+
+ Examples:
+ | data |
+ | sporry weiher, N 47.10791° E 9.52676° |
+ | sporry weiher, N 47.10791° E 9.52676° |
+ | sporry weiher , N 47.10791° E 9.52676° |
+ | sporry weiher, N 47.10791° E 9.52676° |
+ | sporry weiher\v, N 47.10791° E 9.52676° |
+
+ Scenario: Searches with white spaces
+ When geocoding "52 Bodastr\v,\fTriesenberg"
+ Then all results contain
+ | category | type |
+ | highway | residential |
+
+
+ # github #1949
+ Scenario: Addressdetails always return the place type
+ When geocoding "Vaduz"
+ Then result 0 contains
+ | address+town |
+ | Vaduz |
--- /dev/null
+Feature: Simple Tests
+ Simple tests for internal server errors and response format.
+
+ Scenario Outline: Garbage Searches
+ When sending v1/search
+ | q |
+ | <query> |
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And exactly 0 results are returned
+
+ Examples:
+ | query |
+ | New York, New York |
+ | 12, Main Street, Houston |
+ | München |
+ | 東京都 |
+ | hotels in sdfewf |
+ | xywxkrf |
+ | gh; foo() |
+ | %#$@*&l;der#$! |
+ | 234.23.14.5 |
+ | aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus aussenstelle universitat lichtenstein wachterhaus |
+
+ Scenario: Empty XML search
+ When sending v1/search with format xml
+ | q |
+ | xnznxvcx |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ Then the result metadata contains
+ | param | value |
+ | querystring | xnznxvcx |
+ | more_url!fm | .*q=xnznxvcx.*format=xml |
+
+ Scenario: Empty XML search with special XML characters
+ When sending v1/search with format xml
+ | q |
+ | xfdghn&zxn"xvbyx<vxx>cssdex |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ Then the result metadata contains
+ | param | value |
+ | querystring | xfdghn&zxn"xvbyx<vxx>cssdex |
+ | more_url!fm | .*q=xfdghn%26zxn%22xvbyx%3Cvxx%3Ecssdex.*format=xml |
+
+ Scenario: Empty XML search with viewbox
+ When sending v1/search with format xml
+ | q | viewbox |
+ | xnznxvcx | 12,33,77,45.13 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | param | value |
+ | querystring | xnznxvcx |
+ | viewbox | 12,33,77,45.13 |
+
+ Scenario: Empty XML search with viewboxlbrt
+ When sending v1/search with format xml
+ | q | viewboxlbrt |
+ | xnznxvcx | 12,34.13,77,45 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | param | value |
+ | querystring | xnznxvcx |
+ | viewbox | 12,34.13,77,45 |
+
+ Scenario: Empty XML search with viewboxlbrt and viewbox
+ When sending v1/search with format xml
+ | q | viewbox | viewboxblrt |
+ | pub | 12,33,77,45.13 | 1,2,3,4 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | param | value |
+ | querystring | pub |
+ | viewbox | 12,33,77,45.13 |
+
+ Scenario: Empty XML search with excluded place ids
+ When sending v1/search with format xml
+ | q | exclude_place_ids |
+ | jghrleoxsbwjer | 123,76,342565 |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | param | value |
+ | exclude_place_ids | 123,76,342565 |
+
+ Scenario: Empty XML search with bad excluded place ids
+ When sending v1/search with format xml
+ | q | exclude_place_ids |
+ | jghrleoxsbwjer | , |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata has no attributes exclude_place_ids
+
+ Scenario Outline: Wrapping of illegal jsonp search requests
+ When sending v1/search with format json
+ | q | json_callback |
+ | Tokyo | <data> |
+ Then a HTTP 400 is returned
+ And the result is valid json
+ And the result contains
+ | error+code | error+message |
+ | 400 | Invalid json_callback value |
+
+ Examples:
+ | data |
+ | 1asd |
+ | bar(foo) |
+ | XXX['bad'] |
+ | foo; evil |
+ | 234 |
+
+ Scenario: Ignore jsonp parameter for anything but json
+ When sending v1/search with format xml
+ | q | json_callback |
+ | Tokyo | 234 |
+ Then a HTTP 200 is returned
+ Then the result is valid xml
+
+ Scenario Outline: Empty search for json like
+ When sending v1/search with format <format>
+ | q |
+ | YHlERzzx |
+ Then a HTTP 200 is returned
+ And the result is valid <outformat>
+ And exactly 0 results are returned
+
+ Examples:
+ | format | outformat |
+ | json | json |
+ | jsonv2 | json |
+ | geojson | geojson |
+ | geocodejson | geocodejson |
+
+ Scenario: Search for non-existing coordinates
+ When geocoding "-21.0,-33.0"
+ Then exactly 0 results are returned
+
+ Scenario: Country code selection is retained in more URL (#596)
+ When sending v1/search with format xml
+ | q | countrycodes |
+ | Vaduz | pl,1,,invalid,undefined,%3Cb%3E,bo,, |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | more_url!fm |
+ | .*&countrycodes=pl%2Cbo&.* |
+
+ Scenario Outline: Search debug output does not return errors
+ When sending v1/search
+ | q | debug |
+ | <query> | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid html
+
+ Examples:
+ | query |
+ | Liechtenstein |
+ | Triesen |
+ | Pfarrkirche |
+ | Landstr 27 Steinort, Triesenberg, 9495 |
+ | 9497 |
+ | restaurant in triesen |
--- /dev/null
+Feature: Structured search queries
+ Testing correctness of results with
+ structured queries
+
+ Scenario: Structured search for country only
+ When geocoding
+ | country |
+ | Liechtenstein |
+ Then all results contain in field address
+ | country_code | country |
+ | li | Liechtenstein |
+
+ Scenario: Structured search for postcode only
+ When geocoding
+ | postalcode |
+ | 9495 |
+ Then all results contain
+ | type!fm | address+postcode |
+ | ^post(al_)?code | 9495 |
+
+ Scenario: Structured search for street, postcode and country
+ When sending v1/search with format xml
+ | street | postalcode | country |
+ | Old Palace Road | GU2 7UP | United Kingdom |
+ Then a HTTP 200 is returned
+ And the result is valid xml
+ And the result metadata contains
+ | querystring |
+ | Old Palace Road, GU2 7UP, United Kingdom |
+
+ Scenario: Structured search for street with housenumber, city and postcode
+ When geocoding
+ | street | city | postalcode |
+ | 19 Am schrägen Weg | Vaduz | 9490 |
+ Then all results contain in field address
+ | house_number | road |
+ | 19 | Am Schrägen Weg |
+
+ Scenario: Structured search for street with housenumber, city and bad postcode
+ When geocoding
+ | street | city | postalcode |
+ | 19 Am schrägen Weg | Vaduz | 9491 |
+ Then all results contain in field address
+ | house_number | road |
+ | 19 | Am Schrägen Weg |
+
+ Scenario: Structured search for amenity, city
+ When geocoding
+ | city | amenity |
+ | Vaduz | bar |
+ Then all results contain
+ | address+country | category | type!fm |
+ | Liechtenstein | amenity | (pub)\|(bar)\|(restaurant) |
+
+ #176
+ Scenario: Structured search restricts rank
+ When geocoding
+ | city |
+ | Steg |
+ Then all results contain
+ | addresstype |
+ | village |
+
+ #3651
+ Scenario: Structured search with surrounding extra characters
+ When geocoding
+ | street | city | postalcode |
+ | "19 Am schrägen Weg" | "Vaduz" | "9491" |
+ Then all results contain in field address
+ | house_number | road |
+ | 19 | Am Schrägen Weg |
+
--- /dev/null
+Feature: Search API geocodejson output
+ Testing correctness of geocodejson output.
+
+ Scenario: Search geocodejson - City housenumber-level address with street
+ When sending v1/search with format geocodejson
+ | q | addressdetails |
+ | Im Winkel 8, Triesen | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson
+ And all results contain
+ | housenumber | street | postcode | city | country |
+ | 8 | Im Winkel | 9495 | Triesen | Liechtenstein |
+
+ Scenario: Search geocodejson - Town street-level address with street
+ When sending v1/search with format geocodejson
+ | q | addressdetails |
+ | Gnetsch, Balzers | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson
+ And all results contain
+ | name | city | postcode | country |
+ | Gnetsch | Balzers | 9496 | Liechtenstein |
+
+ Scenario: Search geocodejson - Town street-level address with footway
+ When sending v1/search with format geocodejson
+ | q | addressdetails |
+ | burg gutenberg 6000 jahre geschichte | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson
+ And all results contain
+ | street | city | postcode | country |
+ | Burgweg | Balzers | 9496 | Liechtenstein |
+
+ Scenario: Search geocodejson - City address with suburb
+ When sending v1/search with format geocodejson
+ | q | addressdetails |
+ | Lochgass 5, Ebenholz, Vaduz | 1 |
+ Then a HTTP 200 is returned
+ And the result is valid geocodejson
+ And all results contain
+ | housenumber | street | district | city | postcode | country |
+ | 5 | Lochgass | Ebenholz | Vaduz | 9490 | Liechtenstein |
--- /dev/null
+Feature: Status queries against unknown database
+ Testing status query
+
+ Background:
+ Given an unknown database
+
+ Scenario: Failed status as text
+ When sending v1/status
+ Then a HTTP 500 is returned
+ And the page content equals "ERROR: Database connection failed"
+
+ Scenario: Failed status as json
+ When sending v1/status with format json
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | status!:d | message |
+ | 700 | Database connection failed |
+ And the result has no attributes data_updated
--- /dev/null
+Feature: Status queries
+ Testing status query
+
+ Scenario: Status as text
+ When sending v1/status
+ Then a HTTP 200 is returned
+ And the page content equals "OK"
+
+ Scenario: Status as json
+ When sending v1/status with format json
+ Then a HTTP 200 is returned
+ And the result is valid json
+ And the result contains
+ | status!:d | message | data_updated!fm |
+ | 0 | OK | ....-..-..T..:..:...00:00 |
-@DB
Feature: Address computation
Tests for filling of place_addressline
| N2 | place | hamlet | West Farm | 2 |
| N3 | place | hamlet | East Farm | 3 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | fromarea |
| N1 | N3 | False |
- Then place_addressline doesn't contain
- | object | address |
- | N1 | N2 |
- When sending search query "Square"
- Then results contain
- | osm | display_name |
- | N1 | Square, East Farm |
+ When geocoding "Square"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Square, East Farm |
Scenario: given two place nodes, the closer one wins for the address
Given the grid
| N2 | place | city | 15 | 9 |
| R1 | place | city | 8 | (1,2,3,4,1) |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress | cached_rank_address |
| N1 | R1 | True | 16 |
- And place_addressline doesn't contain
- | object | address |
- | N1 | N2 |
Scenario: place nodes close enough to smaller ranked place nodes are included
| W10 | boundary | administrative | 5 | (1, 2, 8, 5, 4, 1) |
| W11 | boundary | administrative | 5 | (2, 3, 6, 5, 8, 2) |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | cached_rank_address |
| W1 | W10 | 10 |
- Then place_addressline doesn't contain
- | object | address |
- | W1 | W11 |
Scenario: Roads should not contain boundaries they touch in a middle point
Given the grid
| W10 | boundary | administrative | 5 | (1, 2, 8, 5, 4, 1) |
| W11 | boundary | administrative | 5 | (2, 3, 6, 5, 8, 2) |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | cached_rank_address |
| W1 | W10 | 10 |
- Then place_addressline doesn't contain
- | object | address |
- | W1 | W11 |
Scenario: Locality points should contain all boundaries they touch
Given the 0.001 grid
| osm | class | type | admin | geometry |
| W10 | boundary | administrative | 5 | (2, 3, 6, 5, 2) |
When importing
- Then place_addressline doesn't contain
+ Then place_addressline contains exactly
| object | address |
- | W1 | W10 |
Scenario: buildings with only addr:postcodes do not appear in the address of a way
Given the grid with origin DE
| osm | class | type | addr+postcode | geometry |
| W22 | place | postcode | 11234 | (10,11,12,13,10) |
When importing
- Then place_addressline doesn't contain
+ Then place_addressline contains exactly
| object | address |
- | W93 | W22 |
+ | R4 | R1 |
+ | R4 | R34 |
+ | R34 | R1 |
+ | W93 | R1 |
+ | W93 | R34 |
+ | W93 | R4 |
Scenario: postcode boundaries do appear in the address of a way
Given the grid with origin DE
| W1 | highway | residential | 8, 9 |
| W2 | place | square | (1, 2, 3 ,4, 1) |
When importing
- Then place_addressline doesn't contain
+ Then place_addressline contains exactly
| object | address |
- | W1 | W2 |
Scenario: addr:* tags are honored even when a street is far away from the place
Given the grid
| W1 | highway | primary | Left | 8,9 |
| W2 | highway | primary | Right | 8,9 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | True |
| W1 | R2 | False |
| W2 | R2 | True |
- And place_addressline doesn't contain
- | object | address |
- | W2 | R1 |
Scenario: addr:* tags are honored even when a POI is far away from the place
| W1 | highway | primary | Wonderway | Right | 8,9 |
| N1 | amenity | cafe | Bolder | Left | 9 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R2 | True |
| N1 | R1 | True |
- And place_addressline doesn't contain
- | object | address |
- | W1 | R1 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Left |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Left |
Scenario: addr:* tags do not produce addresslines when the parent has the address part
Given the grid
| W1 | highway | primary | Wonderway | Outer | 8,9 |
| N1 | amenity | cafe | Bolder | Outer | 9 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | True |
- And place_addressline doesn't contain
- | object | address |
- | N1 | R1 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Outer |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Outer |
Scenario: addr:* tags on outside do not produce addresslines when the parent has the address part
Given the grid
| W1 | highway | primary | Wonderway | Left | 8,9 |
| N1 | amenity | cafe | Bolder | Left | 9 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | True |
| W1 | R2 | False |
- And place_addressline doesn't contain
- | object | address |
- | N1 | R1 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Left |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Left |
Scenario: POIs can correct address parts on the fly
Given the grid
| N1 | amenity | cafe | Bolder | 9 |
| N2 | amenity | cafe | Leftside | 8 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | False |
| W1 | R2 | True |
- And place_addressline doesn't contain
- | object | address |
- | N1 | R1 |
- | N2 | R2 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Left |
- When sending search query "Leftside"
- Then results contain
- | osm | display_name |
- | N2 | Leftside, Wonderway, Right |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Left |
+ When geocoding "Leftside"
+ Then the result set contains
+ | object | display_name |
+ | N2 | Leftside, Wonderway, Right |
Scenario: POIs can correct address parts on the fly (with partial unmatching address)
| N1 | amenity | cafe | Bolder | Boring | 9 |
| N2 | amenity | cafe | Leftside | Boring | 8 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | True |
| W1 | R2 | False |
- And place_addressline doesn't contain
- | object | address |
- | N1 | R1 |
- | N2 | R2 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Left |
- When sending search query "Leftside"
- Then results contain
- | osm | display_name |
- | N2 | Leftside, Wonderway, Right |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Left |
+ When geocoding "Leftside"
+ Then the result set contains
+ | object | display_name |
+ | N2 | Leftside, Wonderway, Right |
| N1 | amenity | cafe | Bolder | Left | 9 |
| N2 | amenity | cafe | Leftside | Left | 8 |
When importing
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | isaddress |
| W1 | R1 | True |
| W1 | R2 | False |
- And place_addressline doesn't contain
- | object | address |
- | N1 | R1 |
- | N2 | R2 |
- When sending search query "Bolder"
- Then results contain
- | osm | display_name |
- | N1 | Bolder, Wonderway, Left |
- When sending search query "Leftside"
- Then results contain
- | osm | display_name |
- | N2 | Leftside, Wonderway, Left |
+ When geocoding "Bolder"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Bolder, Wonderway, Left |
+ When geocoding "Leftside"
+ Then the result set contains
+ | object | display_name |
+ | N2 | Leftside, Wonderway, Left |
Scenario: addr:* tags always match the closer area
Given the grid
| 1 | | | | 2 | | 5 |
| | | | | | | |
- | | 10| 11| | | | |
| 4 | | | | 3 | | 6 |
+ | | 10| 11| | | | |
And the places
| osm | class | type | admin | name | geometry |
| R1 | boundary | administrative | 8 | Left | (1,2,3,4,1) |
| osm | class | type | name | addr+city | geometry |
| W1 | highway | primary | Wonderway | Left | 10,11 |
When importing
- Then place_addressline doesn't contain
+ Then place_addressline contains exactly
| object | address |
- | W1 | R2 |
+ | W1 | R1 |
Scenario: Full name is prefered for unlisted addr:place tags
Given the grid
| osm | class | type | housenr | addr+street | geometry |
| N2 | place | house | 2 | Royal Terrace | 2 |
When importing
- When sending search query "1, Royal Terrace Gardens"
- Then results contain
- | ID | osm |
- | 0 | N1 |
+ When geocoding "1, Royal Terrace Gardens"
+ Then result 0 contains
+ | object |
+ | N1 |
-@DB
Feature: Country handling
Tests for import and use of country information
| osm | class | type | name | geometry |
| N1 | place | town | Wenig | country:de |
When importing
- When sending search query "Wenig, Loudou"
- Then results contain
- | osm | display_name |
- | N1 | Wenig, Deutschland |
- When sending search query "Wenig"
+ When geocoding "Wenig, Loudou"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Wenig, Deutschland |
+ When geocoding "Wenig"
| accept-language |
| xy,en |
- Then results contain
- | osm | display_name |
- | N1 | Wenig, Loudou |
+ Then the result set contains
+ | object | display_name |
+ | N1 | Wenig, Loudou |
Scenario: OSM country relations outside expected boundaries are ignored for naming
Given the grid
| osm | class | type | name | geometry |
| N1 | place | town | Wenig | country:de |
When importing
- When sending search query "Wenig"
+ When geocoding "Wenig"
| accept-language |
| xy,en |
- Then results contain
- | osm | display_name |
- | N1 | Wenig, Germany |
+ Then the result set contains
+ | object | display_name |
+ | N1 | Wenig, Germany |
Scenario: Pre-defined country names are used
Given the grid with origin CH
| osm | class | type | name | geometry |
| N1 | place | town | Ingb | 1 |
When importing
- And sending search query "Ingb"
+ And geocoding "Ingb"
| accept-language |
| en,de |
- Then results contain
- | osm | display_name |
- | N1 | Ingb, Switzerland |
+ Then the result set contains
+ | object | display_name |
+ | N1 | Ingb, Switzerland |
Scenario: For overlapping countries, pre-defined countries are tie-breakers
Given the grid with origin US
-@DB
Feature: Import of address interpolations
Tests that interpolated addresses are added correctly
When importing
Then W1 expands to interpolation
| start | end | geometry |
- | 4 | 6 | 9,8 |
+ | 4 | 6 | 8,9 |
Scenario: Simple odd two point interpolation
Given the grid with origin 1,1
Scenario: Even three point interpolation line with odd center point
Given the grid
- | 1 | | 10 | | | 11 | 3 | 2 |
- | 4 | | | | | | | 5 |
+ | 1 | | 10 | | 11 | 3 | 2 |
+ | 4 | | | | | | 5 |
Given the places
| osm | class | type | housenr |
| N1 | place | house | 2 |
Then W11 expands to interpolation
| parent_place_id | start | end |
| W3 | 14 | 14 |
- When sending search query "16 Cloud Street"
- Then results contain
- | ID | osm |
- | 0 | N4 |
- When sending search query "14 Cloud Street"
- Then results contain
- | ID | osm |
- | 0 | W11 |
+ When geocoding "16 Cloud Street"
+ Then result 0 contains
+ | object |
+ | N4 |
+ When geocoding "14 Cloud Street"
+ Then result 0 contains
+ | object |
+ | W11 |
Scenario: addr:street on housenumber way
Given the grid
Then W11 expands to interpolation
| parent_place_id | start | end |
| W3 | 14 | 14 |
- When sending search query "16 Cloud Street"
- Then results contain
- | ID | osm |
- | 0 | N4 |
- When sending search query "14 Cloud Street"
- Then results contain
- | ID | osm |
- | 0 | W11 |
+ When geocoding "16 Cloud Street"
+ Then result 0 contains
+ | object |
+ | N4 |
+ When geocoding "14 Cloud Street"
+ Then result 0 contains
+ | object |
+ | W11 |
Scenario: Geometry of points and way don't match (github #253)
Given the places
When importing
Then W1 expands to interpolation
| start | end | geometry |
- | 4 | 4 | 144.963016 -37.762946 |
+ | 4 | 4 | 144.96301672 -37.76294644 |
| 8 | 8 | 144.96314407 -37.762223692 |
Scenario: Place with missing address information
When importing
Then W1 expands to interpolation
| start | end | geometry |
- | 25 | 27 | 0.000016 0,0.00002 0,0.000033 0 |
+ | 25 | 27 | 0.0000166 0,0.00002 0,0.0000333 0 |
Scenario: Ways without node entries are ignored
Given the places
Then W1 expands to interpolation
| start | end | geometry |
| 2 | 8 | 10,11 |
- When sending v1/reverse at 1,1
- Then results contain
- | ID | osm | type | display_name |
- | 0 | N1 | house | 0, London Road |
+ When reverse geocoding 1,1
+ Then the result contains
+ | object | type | display_name |
+ | N1 | house | 0, London Road |
Scenario: Parenting of interpolation with additional tags
Given the grid
-@DB
Feature: Linking of places
Tests for correctly determining linked places
| W2 | R13 |
| R13 | - |
| R23 | - |
- When sending search query "rhein"
- Then results contain
- | osm |
- | R13 |
+ When geocoding "rhein"
+ Then the result set contains
+ | object |
+ | R13 |
Scenario: Relations are not linked when in waterway relations
Given the grid
| W2 | - |
| R1 | - |
| R2 | - |
- When sending search query "rhein"
- Then results contain
- | ID | osm |
- | 0 | R1 |
- | 1 | W2 |
+ When geocoding "rhein"
+ Then result 0 contains
+ | object |
+ | R1 |
+ And result 1 contains
+ | object |
+ | W2 |
Scenario: Empty waterway relations are handled correctly
| object | linked_place_id |
| W1 | - |
| W2 | R1 |
- When sending search query "rhein2"
- Then results contain
- | osm |
+ When geocoding "rhein2"
+ Then the result set contains
+ | object |
| W1 |
# github #573
| object | linked_place_id |
| N2 | R13 |
And placex contains
- | object | centroid | name+name | extratags+linked_place |
- | R13 | 9 | Garbo | hamlet |
+ | object | centroid!wkt | name+name | extratags+linked_place |
+ | R13 | 9 | Garbo | hamlet |
Scenario: Boundaries with place tags are linked against places with same type
Given the 0.01 grid
And placex contains
| object | rank_address |
| R13 | 16 |
- When sending search query ""
+ When geocoding ""
| city |
| Berlin |
- Then results contain
- | ID | osm |
- | 0 | R13 |
- When sending search query ""
+ Then result 0 contains
+ | object |
+ | R13 |
+ When geocoding ""
| state |
| Berlin |
- Then results contain
- | ID | osm |
- | 0 | R13 |
+ Then result 0 contains
+ | object |
+ | R13 |
Scenario: Boundaries without place tags only link against same admin level
And placex contains
| object | rank_address |
| R13 | 8 |
- When sending search query ""
+ When geocoding ""
| state |
| Berlin |
- Then results contain
- | ID | osm |
- | 0 | R13 |
- When sending search query ""
+ Then result 0 contains
+ | object |
+ | R13 |
+ When geocoding ""
| city |
| Berlin |
- Then results contain
- | ID | osm |
- | 0 | N2 |
+ Then result 0 contains
+ | object |
+ | N2 |
# github #1352
Scenario: Do not use linked centroid when it is outside the area
| object | linked_place_id |
| N2 | R13 |
And placex contains
- | object | centroid |
- | R13 | in geometry |
+ | object | centroid!in_box |
+ | R13 | 0,0,0.1,0.1 |
Scenario: Place nodes can only be linked once
Given the 0.02 grid
| object | linked_place_id |
| N2 | R1 |
And placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'linked_place' : 'city', 'wikidata': 'Q1234' |
| R2 | 'wikidata': 'Q1234' |
| object | name+_place_name |
| R1 | LabelPlace |
+
+ @skip
+ Scenario: Linked places expand default language names
+ Given the grid
+ | 1 | | 2 |
+ | | 9 | |
+ | 4 | | 3 |
+ Given the places
+ | osm | class | type | name+name | geometry |
+ | N9 | place | city | Popayán | 9 |
+ | R1 | boundary | administrative | Perímetro Urbano Popayán | (1,2,3,4,1) |
+ And the relations
+ | id | members |
+ | 1 | N9:label |
+ When importing
+ Then placex contains
+ | object | name+_place_name | name+_place_name:es |
+ | R1 | Popayán | Popayán |
+
--- /dev/null
+Feature: Import and search of names
+ Tests all naming related import issues
+
+ Scenario: No copying name tag if only one name
+ Given the places
+ | osm | class | type | name+name | geometry |
+ | N1 | place | locality | german | country:de |
+ When importing
+ Then placex contains
+ | object | country_code | name+name |
+ | N1 | de | german |
+
+ Scenario: Copying name tag to default language if it does not exist
+ Given the places
+ | osm | class | type | name+name | name+name:fi | geometry |
+ | N1 | place | locality | german | finnish | country:de |
+ When importing
+ Then placex contains
+ | object | country_code | name+name | name+name:fi | name+name:de |
+ | N1 | de | german | finnish | german |
+
+ Scenario: Copying default language name tag to name if it does not exist
+ Given the places
+ | osm | class | type | name+name:de | name+name:fi | geometry |
+ | N1 | place | locality | german | finnish | country:de |
+ When importing
+ Then placex contains
+ | object | country_code | name+name | name+name:fi | name+name:de |
+ | N1 | de | german | finnish | german |
+
+ Scenario: Do not overwrite default language with name tag
+ Given the places
+ | osm | class | type | name+name | name+name:fi | name+name:de | geometry |
+ | N1 | place | locality | german | finnish | local | country:de |
+ When importing
+ Then placex contains
+ | object | country_code | name+name | name+name:fi | name+name:de |
+ | N1 | de | german | finnish | local |
+
+ Scenario Outline: Names in any script can be found
+ Given the places
+ | osm | class | type | name+name |
+ | N1 | place | hamlet | <name> |
+ When importing
+ And geocoding "<name>"
+ Then the result set contains
+ | object |
+ | N1 |
+
+ Examples:
+ | name |
+ | Berlin |
+ | 北京 |
+ | Вологда |
+ | Αθήνα |
+ | القاهرة |
+ | រាជធានីភ្នំពេញ |
+ | 東京都 |
+ | ပုဗ္ဗသီရိ |
+
+
+ Scenario: German umlauts can be found when expanded
+ Given the places
+ | osm | class | type | name+name:de |
+ | N1 | place | city | Münster |
+ | N2 | place | city | Köln |
+ | N3 | place | city | Gräfenroda |
+ When importing
+ When geocoding "münster"
+ Then the result set contains
+ | object |
+ | N1 |
+ When geocoding "muenster"
+ Then the result set contains
+ | object |
+ | N1 |
+ When geocoding "munster"
+ Then the result set contains
+ | object |
+ | N1 |
+ When geocoding "Köln"
+ Then the result set contains
+ | object |
+ | N2 |
+ When geocoding "Koeln"
+ Then the result set contains
+ | object |
+ | N2 |
+ When geocoding "Koln"
+ Then the result set contains
+ | object |
+ | N2 |
+ When geocoding "gräfenroda"
+ Then the result set contains
+ | object |
+ | N3 |
+ When geocoding "graefenroda"
+ Then the result set contains
+ | object |
+ | N3 |
+ When geocoding "grafenroda"
+ Then the result set contains
+ | object |
+ | N3 |
-@DB
Feature: Parenting of objects
Tests that the correct parent is chosen
| object | parent_place_id |
| N1 | W1 |
| N2 | W1 |
- When sending search query "4 galoo"
- Then results contain
- | ID | osm | display_name |
- | 0 | N1 | 4, galoo, 12345, Deutschland |
- When sending search query "5 galoo"
- Then results contain
- | ID | osm | display_name |
- | 0 | N2 | 5, galoo, 99999, Deutschland |
+ When geocoding "4 galoo"
+ Then result 0 contains
+ | object | display_name |
+ | N1 | 4, galoo, 12345, Deutschland |
+ When geocoding "5 galoo"
+ Then result 0 contains
+ | object | display_name |
+ | N2 | 5, galoo, 99999, Deutschland |
Scenario: Address without tags, closest street
Given the grid
| N1 | W3 | 3 |
| N2 | W3 | 3 |
| N3 | W3 | 3 |
- When sending geocodejson search query "3, foo" with address
- Then results contain
- | housenumber |
+ When geocoding "3, foo"
+ Then the result set contains
+ | address+house_number |
| 3 |
Scenario: POIs don't inherit from streets
-@DB
Feature: Import into placex
Tests that data in placex is completed correctly.
| N1 | highway | primary | country:us |
When importing
Then placex contains
- | object | addr+country | country_code |
- | N1 | - | us |
+ | object | address | country_code |
+ | N1 | - | us |
Scenario: Location overwrites country code tag
Given the named places
-@DB
Feature: Import of postcodes
Tests for postcode estimation
| N34 | place | house | 01982 | 111 |country:de |
When importing
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 01982 | country:de |
+ | country_code | postcode | geometry!wkt |
+ | de | 01982 | country:de |
-
- @Fail
+ @skip
Scenario: search and address ranks for GB post codes correctly assigned
Given the places
| osm | class | type | postcode | geometry |
| N3 | place | postcode | Y45 | country:gb |
When importing
Then location_postcode contains exactly
- | postcode | country | rank_search | rank_address |
- | E45 2CD | gb | 25 | 5 |
- | E45 2 | gb | 23 | 5 |
- | Y45 | gb | 21 | 5 |
+ | postcode | country_code | rank_search | rank_address |
+ | E45 2CD | gb | 25 | 5 |
+ | E45 2 | gb | 23 | 5 |
+ | Y45 | gb | 21 | 5 |
Scenario: Postcodes outside all countries are not added to the postcode table
Given the places
| N1 | place | hamlet | Null Island | 0 0 |
When importing
Then location_postcode contains exactly
- | country | postcode | geometry |
- When sending search query "111, 01982 Null Island"
- Then results contain
- | osm | display_name |
- | N34 | 111, Null Island, 01982 |
+ | place_id |
+ When geocoding "111, 01982 Null Island"
+ Then the result set contains
+ | object | display_name |
+ | N34 | 111, Null Island, 01982 |
-@DB
Feature: Rank assignment
Tests for assignment of search and address ranks.
| R23 | 20 | 0 |
| R21 | 18 | 0 |
| R22 | 16 | 16 |
- Then place_addressline contains
+ Then place_addressline contains exactly
| object | address | cached_rank_address |
| N20 | R22 | 16 |
- Then place_addressline doesn't contain
- | object | address |
- | N20 | R21 |
- | N20 | R23 |
Scenario: adjacent admin_levels are considered different objects when they have different wikidata
Given the named places
-@DB
Feature: Creation of search terms
Tests that search_name table is filled correctly
Given the places
| osm | class | type | name+alt_name |
| N1 | place | city | New York; Big Apple |
+ | N2 | place | town | New York Big Apple |
When importing
- Then search_name contains
- | object | name_vector |
- | N1 | #New York, #Big Apple |
+ And geocoding "New York Big Apple"
+ Then result 0 contains
+ | object |
+ | N2 |
Scenario: Comma-separated names appear as a single full name
Given the places
- | osm | class | type | name+alt_name |
+ | osm | class | type | name+name |
| N1 | place | city | New York, Big Apple |
+ | N2 | place | town | New York Big Apple |
When importing
- Then search_name contains
- | object | name_vector |
- | N1 | #New York Big Apple |
+ And geocoding "New York Big Apple"
+ Then result 0 contains
+ | object |
+ | N1 |
Scenario: Name parts before brackets appear as full names
Given the places
| osm | class | type | name+name |
| N1 | place | city | Halle (Saale) |
+ | N2 | place | town | Halle |
When importing
- Then search_name contains
- | object | name_vector |
- | N1 | #Halle Saale, #Halle |
+ And geocoding "Halle"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Halle (Saale)"
+ Then the result set contains
+ | object |
+ | N1 |
- Scenario: Unnamed POIs have no search entry
- Given the grid
- | | 1 | | |
- | 10 | | | 11 |
- And the places
- | osm | class | type |
- | N1 | place | house |
- And the named places
- | osm | class | type | geometry |
- | W1 | highway | residential | 10,11 |
- When importing
- Then search_name has no entry for N1
-
- Scenario: Unnamed POI has a search entry when it has unknown addr: tags
+ Scenario: Unknown addr: tags can be found for unnamed POIs
Given the grid
| | 1 | | |
| 10 | | | 11 |
| osm | class | type | name+name | geometry |
| W1 | highway | residential | Rose Street | 10,11 |
When importing
- Then search_name contains
- | object | nameaddress_vector |
- | N1 | #Rose Street, Walltown |
- When sending search query "23 Rose Street, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "Walltown, Rose Street 23"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "Rose Street 23, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
+ When geocoding "23 Rose Street, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "Walltown, Rose Street 23"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "Rose Street 23, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
Scenario: Searching for unknown addr: tags also works for multiple words
Given the grid
| osm | class | type | name+name | geometry |
| W1 | highway | residential | Rose Street | 10,11 |
When importing
- Then search_name contains
- | object | nameaddress_vector |
- | N1 | #Rose Street, rose, Little, Big, Town |
- When sending search query "23 Rose Street, Little Big Town"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "Rose Street 23, Little Big Town"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "Little big Town, Rose Street 23"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
+ When geocoding "23 Rose Street, Little Big Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "Rose Street 23, Little Big Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "Little big Town, Rose Street 23"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
- Scenario: Unnamed POI has no search entry when it has known addr: tags
+ Scenario: Unnamed POI can be found when it has known addr: tags
Given the grid
| | 1 | | |
| 10 | | | 11 |
| osm | class | type | name+name | addr+city | geometry |
| W1 | highway | residential | Rose Street | Walltown | 10,11 |
When importing
- Then search_name has no entry for N1
- When sending search query "23 Rose Street, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
-
- Scenario: Unnamed POI must have a house number to get a search entry
- Given the grid
- | | 1 | | |
- | 10 | | | 11 |
- And the places
- | osm | class | type | addr+city |
- | N1 | place | house | Walltown |
- And the places
- | osm | class | type | name+name | geometry |
- | W1 | highway | residential | Rose Street | 10,11 |
- When importing
- Then search_name has no entry for N1
+ When geocoding "23 Rose Street, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
Scenario: Unnamed POIs inherit parent name when unknown addr:place is present
Given the grid
Then placex contains
| object | parent_place_id |
| N1 | R1 |
- When sending search query "23 Rose Street"
- Then exactly 1 results are returned
- And results contain
- | osm | display_name |
- | W1 | Rose Street, Strange Town |
- When sending search query "23 Walltown, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | 23, Walltown, Strange Town |
- When sending search query "Walltown 23, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | 23, Walltown, Strange Town |
- When sending search query "Strange Town, Walltown 23"
- Then results contain
- | osm | display_name |
- | N1 | 23, Walltown, Strange Town |
+ When geocoding "23 Rose Street"
+ Then all results contain
+ | object | display_name |
+ | W1 | Rose Street, Strange Town |
+ When geocoding "23 Walltown, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Walltown, Strange Town |
+ When geocoding "Walltown 23, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Walltown, Strange Town |
+ When geocoding "Strange Town, Walltown 23"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Walltown, Strange Town |
Scenario: Named POIs can be searched by housenumber when unknown addr:place is present
Given the grid
| W1 | highway | residential | Rose Street | 10,11 |
| R1 | place | city | Strange Town | (100,101,102,103,100) |
When importing
- When sending search query "23 Walltown, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Walltown, Strange Town |
- When sending search query "Walltown 23, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Walltown, Strange Town |
- When sending search query "Strange Town, Walltown 23"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Walltown, Strange Town |
- When sending search query "Strange Town, Walltown 23, Blue house"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Walltown, Strange Town |
- When sending search query "Strange Town, Walltown, Blue house"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Walltown, Strange Town |
+ When geocoding "23 Walltown, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Walltown, Strange Town |
+ When geocoding "Walltown 23, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Walltown, Strange Town |
+ When geocoding "Strange Town, Walltown 23"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Walltown, Strange Town |
+ When geocoding "Strange Town, Walltown 23, Blue house"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Walltown, Strange Town |
+ When geocoding "Strange Town, Walltown, Blue house"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Walltown, Strange Town |
Scenario: Named POIs can be found when unknown multi-word addr:place is present
Given the grid
| W1 | highway | residential | Rose Street | 10,11 |
| R1 | place | city | Strange Town | (100,101,102,103,100) |
When importing
- When sending search query "23 Moon Sun, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Moon sun, Strange Town |
- When sending search query "Blue house, Moon Sun, Strange Town"
- Then results contain
- | osm | display_name |
- | N1 | Blue house, 23, Moon sun, Strange Town |
+ When geocoding "23 Moon Sun, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Moon sun, Strange Town |
+ When geocoding "Blue house, Moon Sun, Strange Town"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Blue house, 23, Moon sun, Strange Town |
Scenario: Unnamed POIs doesn't inherit parent name when addr:place is present only in parent address
Given the grid
| W1 | highway | residential | Rose Street | Walltown | 10,11 |
| R1 | place | suburb | Strange Town | Walltown | (100,101,102,103,100) |
When importing
- When sending search query "23 Rose Street, Walltown"
- Then exactly 1 result is returned
- And results contain
- | osm | display_name |
- | W1 | Rose Street, Strange Town |
- When sending search query "23 Walltown"
- Then exactly 1 result is returned
- And results contain
- | osm | display_name |
- | N1 | 23, Walltown, Strange Town |
+ When geocoding "23 Rose Street, Walltown"
+ Then all results contain
+ | object | display_name |
+ | W1 | Rose Street, Strange Town |
+ When geocoding "23 Walltown"
+ Then all results contain
+ | object | display_name |
+ | N1 | 23, Walltown, Strange Town |
Scenario: Unnamed POIs does inherit parent name when unknown addr:place and addr:street is present
Given the grid
| osm | class | type | name+name | geometry |
| W1 | highway | residential | Rose Street | 10,11 |
When importing
- Then search_name has no entry for N1
- When sending search query "23 Rose Street"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "23 Lily Street"
+ When geocoding "23 Rose Street"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "23 Lily Street"
Then exactly 0 results are returned
Scenario: An unknown addr:street is ignored
| osm | class | type | name+name | geometry |
| W1 | highway | residential | Rose Street | 10,11 |
When importing
- Then search_name has no entry for N1
- When sending search query "23 Rose Street"
- Then results contain
- | osm | display_name |
- | N1 | 23, Rose Street |
- When sending search query "23 Lily Street"
+ When geocoding "23 Rose Street"
+ Then the result set contains
+ | object | display_name |
+ | N1 | 23, Rose Street |
+ When geocoding "23 Lily Street"
Then exactly 0 results are returned
- Scenario: Named POIs get unknown address tags added in the search_name table
+ Scenario: Named POIs can be found through unknown address tags
Given the grid
| | 1 | | |
| 10 | | | 11 |
| osm | class | type | name+name | geometry |
| W1 | highway | residential | Rose Street | 10,11 |
When importing
- Then search_name contains
- | object | name_vector | nameaddress_vector |
- | N1 | #Green Moss | #Rose Street, Walltown |
- When sending search query "Green Moss, Rose Street, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, 26, Rose Street |
- When sending search query "Green Moss, 26, Rose Street, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, 26, Rose Street |
- When sending search query "26, Rose Street, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, 26, Rose Street |
- When sending search query "Rose Street 26, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, 26, Rose Street |
- When sending search query "Walltown, Rose Street 26"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, 26, Rose Street |
+ When geocoding "Green Moss, Rose Street, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, 26, Rose Street |
+ When geocoding "Green Moss, 26, Rose Street, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, 26, Rose Street |
+ When geocoding "26, Rose Street, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, 26, Rose Street |
+ When geocoding "Rose Street 26, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, 26, Rose Street |
+ When geocoding "Walltown, Rose Street 26"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, 26, Rose Street |
Scenario: Named POI doesn't inherit parent name when addr:place is present only in parent address
Given the grid
| W1 | highway | residential | Rose Street | 10,11 |
| R1 | place | suburb | Strange Town | (100,101,102,103,100) |
When importing
- When sending search query "Green Moss, Rose Street, Walltown"
- Then exactly 0 result is returned
- When sending search query "Green Moss, Walltown"
- Then results contain
- | osm | display_name |
- | N1 | Green Moss, Walltown, Strange Town |
+ When geocoding "Green Moss, Rose Street, Walltown"
+ Then exactly 0 results are returned
+ When geocoding "Green Moss, Walltown"
+ Then the result set contains
+ | object | display_name |
+ | N1 | Green Moss, Walltown, Strange Town |
Scenario: Named POIs inherit address from parent
Given the grid
| N1 | place | house | foo | 1 |
| W1 | highway | residential | the road | 10,11 |
When importing
- Then search_name contains
- | object | name_vector | nameaddress_vector |
- | N1 | foo | #the road |
+ When geocoding "foo, the road"
+ Then all results contain
+ | object |
+ | N1 |
Scenario: Some addr: tags are added to address
Given the grid
| osm | class | type | name |
| N2 | place | city | bonn |
| N3 | place | suburb | smalltown|
- And the named places
- | osm | class | type | addr+city | addr+municipality | addr+suburb | geometry |
- | W1 | highway | service | bonn | New York | Smalltown | 10,11 |
+ And the places
+ | osm | class | type | name | addr+city | addr+municipality | addr+suburb | geometry |
+ | W1 | highway | service | the end | bonn | New York | Smalltown | 10,11 |
When importing
- Then search_name contains
- | object | nameaddress_vector |
- | W1 | bonn, new, york, smalltown |
+ When geocoding "the end, new york, bonn, smalltown"
+ Then all results contain
+ | object |
+ | W1 |
Scenario: A known addr:* tag is added even if the name is unknown
Given the grid
| osm | class | type | name | addr+city | geometry |
| W1 | highway | residential | Road | Nandu | 10,11 |
When importing
- Then search_name contains
- | object | nameaddress_vector |
- | W1 | nandu |
-
- Scenario: addr:postcode is not added to the address terms
- Given the grid with origin DE
- | | 1 | | |
- | 10 | | | 11 |
- And the places
- | osm | class | type | name+ref |
- | N1 | place | state | 12345 |
- And the named places
- | osm | class | type | addr+postcode | geometry |
- | W1 | highway | residential | 12345 | 10,11 |
- When importing
- Then search_name contains not
- | object | nameaddress_vector |
- | W1 | 12345 |
+ And geocoding "Road, Nandu"
+ Then all results contain
+ | object |
+ | W1 |
Scenario: a linked place does not show up in search name
Given the 0.01 grid
| 10 | | 11 |
| | 2 | |
| 13 | | 12 |
- Given the named places
- | osm | class | type | admin | geometry |
- | R13 | boundary | administrative | 9 | (10,11,12,13,10) |
- And the named places
- | osm | class | type |
- | N2 | place | city |
+ Given the places
+ | osm | class | type | name | admin | geometry |
+ | R13 | boundary | administrative | Roma | 9 | (10,11,12,13,10) |
+ And the places
+ | osm | class | type | name |
+ | N2 | place | city | Cite |
And the relations
| id | members | tags+type |
| 13 | N2:label | boundary |
Then placex contains
| object | linked_place_id |
| N2 | R13 |
- And search_name has no entry for N2
+ When geocoding "Cite"
+ Then all results contain
+ | object |
+ | R13 |
Scenario: a linked waterway does not show up in search name
Given the grid
| object | linked_place_id |
| W1 | R13 |
| W2 | R13 |
- And search_name has no entry for W1
- And search_name has no entry for W2
+ When geocoding "Rhein"
+ Then all results contain
+ | object |
+ | R13 |
-@DB
Feature: Searching of house numbers
Test for specialised treeatment of housenumbers
| osm | class | type | name | geometry |
| W10 | highway | path | North Road | 1,2,3 |
When importing
- And sending search query "45, North Road"
- Then results contain
- | osm |
+ And geocoding "45, North Road"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "North Road 45"
- Then results contain
- | osm |
+ When geocoding "North Road 45"
+ Then the result set contains
+ | object |
| N1 |
| osm | class | type | name | geometry |
| W10 | highway | path | North Road | 1,2,3 |
When importing
- And sending search query "45, North Road"
- Then results contain
- | osm |
+ And geocoding "45, North Road"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "North Road ④⑤"
- Then results contain
- | osm |
+ When geocoding "North Road ④⑤"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "North Road 𑁪𑁫"
- Then results contain
- | osm |
+ When geocoding "North Road 𑁪𑁫"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Multistr | 1,2,3 |
When importing
- When sending search query "2 Multistr"
- Then results contain
- | osm |
+ When geocoding "2 Multistr"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "4 Multistr"
- Then results contain
- | osm |
+ When geocoding "4 Multistr"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "12 Multistr"
- Then results contain
- | osm |
+ When geocoding "12 Multistr"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Multistr | 1,2,3 |
When importing
- When sending search query "2A Multistr"
- Then results contain
- | osm |
+ When geocoding "2A Multistr"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "2 a Multistr"
- Then results contain
- | osm |
+ When geocoding "2 a Multistr"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "2-A Multistr"
- Then results contain
- | osm |
+ When geocoding "2-A Multistr"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Multistr 2 A"
- Then results contain
- | osm |
+ When geocoding "Multistr 2 A"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Chester St | 1,2,3 |
When importing
- When sending search query "34-10 Chester St"
- Then results contain
- | osm |
+ When geocoding "34-10 Chester St"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "34/10 Chester St"
- Then results contain
- | osm |
+ When geocoding "34/10 Chester St"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "34 10 Chester St"
- Then results contain
- | osm |
+ When geocoding "34 10 Chester St"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "3410 Chester St"
- Then results contain
- | osm |
+ When geocoding "3410 Chester St"
+ Then the result set contains
+ | object |
| W10 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Rue Paris | 1,2,3 |
When importing
- When sending search query "Rue Paris 45bis"
- Then results contain
- | osm |
+ When geocoding "Rue Paris 45bis"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue Paris 45 BIS"
- Then results contain
- | osm |
+ When geocoding "Rue Paris 45 BIS"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue Paris 45BIS"
- Then results contain
- | osm |
+ When geocoding "Rue Paris 45BIS"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue Paris 45 bis"
- Then results contain
- | osm |
+ When geocoding "Rue Paris 45 bis"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Rue du Berger | 1,2,3 |
When importing
- When sending search query "Rue du Berger 45ter"
- Then results contain
- | osm |
+ When geocoding "Rue du Berger 45ter"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue du Berger 45 TER"
- Then results contain
- | osm |
+ When geocoding "Rue du Berger 45 TER"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue du Berger 45TER"
- Then results contain
- | osm |
+ When geocoding "Rue du Berger 45TER"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Rue du Berger 45 ter"
- Then results contain
- | osm |
+ When geocoding "Rue du Berger 45 ter"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Herengracht | 1,2,3 |
When importing
- When sending search query "501-H 1 Herengracht"
- Then results contain
- | osm |
+ When geocoding "501-H 1 Herengracht"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "501H-1 Herengracht"
- Then results contain
- | osm |
+ When geocoding "501H-1 Herengracht"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "501H1 Herengracht"
- Then results contain
- | osm |
+ When geocoding "501H1 Herengracht"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "501-H1 Herengracht"
- Then results contain
- | osm |
+ When geocoding "501-H1 Herengracht"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Голубинская улица | 1,2,3 |
When importing
- When sending search query "Голубинская улица 55к3"
- Then results contain
- | osm |
+ When geocoding "Голубинская улица 55к3"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Голубинская улица 55 k3"
- Then results contain
- | osm |
+ When geocoding "Голубинская улица 55 k3"
+ Then the result set contains
+ | object |
| N1 |
- When sending search query "Голубинская улица 55 к-3"
- Then results contain
- | osm |
+ When geocoding "Голубинская улица 55 к-3"
+ Then the result set contains
+ | object |
| N1 |
Examples:
| osm | class | type | name | geometry |
| W10 | highway | path | Chester St | 1,2,3 |
When importing
- When sending search query "Chester St Warring"
- Then results contain
- | osm |
+ When geocoding "Chester St Warring"
+ Then the result set contains
+ | object |
| N1 |
| 10 | 10, 11 |
| 20 | 20, 21 |
When importing
- When sending search query "Ringstr 12"
- Then results contain
- | osm |
+ When geocoding "Ringstr 12"
+ Then the result set contains
+ | object |
| W10 |
- When sending search query "Ringstr 13"
- Then results contain
- | osm |
+ When geocoding "Ringstr 13"
+ Then the result set contains
+ | object |
| W20 |
-@DB
Feature: Query of address interpolations
Tests that interpolated addresses can be queried correctly
| id | nodes |
| 1 | 1,3 |
When importing
- When sending v1/reverse N2
- Then results contain
- | ID | display_name |
- | 0 | 3, Nickway |
- When sending search query "Nickway 3"
- Then results contain
- | osm | display_name |
- | W1 | 3, Nickway |
+ When reverse geocoding at node 2
+ Then the result contains
+ | display_name |
+ | 3, Nickway |
+ When geocoding "Nickway 3"
+ Then all results contain
+ | object | display_name |
+ | W1 | 3, Nickway |
Scenario: Find interpolations with multiple numbers
| id | nodes |
| 1 | 1,3 |
When importing
- When sending v1/reverse N2
- Then results contain
- | ID | display_name | centroid |
- | 0 | 10, Nickway | 2 |
- When sending search query "Nickway 10"
- Then results contain
- | osm | display_name | centroid |
- | W1 | 10, Nickway | 2 |
+ When reverse geocoding at node 2
+ Then the result contains
+ | display_name | centroid!wkt |
+ | 10, Nickway | 2 |
+ When geocoding "Nickway 10"
+ Then all results contain
+ | object | display_name | centroid!wkt |
+ | W1 | 10, Nickway | 2 |
-@DB
Feature: Searches in Japan
Test specifically for searches of Japanese addresses and in Japanese language.
Scenario: A block house-number is parented to the neighbourhood
Then placex contains
| object | parent_place_id |
| N3 | N9 |
- When sending search query "2丁目 6-2"
- Then results contain
- | osm |
+ When geocoding "2丁目 6-2"
+ Then all results contain
+ | object |
| N3 |
-@DB
Feature: Searching linked places
Tests that information from linked places can be searched correctly
Then placex contains
| object | linked_place_id |
| N2 | R13 |
- When sending search query "Vario"
+ When geocoding "Vario"
| namedetails |
| 1 |
- Then results contain
- | osm | display_name | namedetails |
- | R13 | Garbo | "name": "Garbo", "name:it": "Vario" |
- When sending search query "Vario"
+ Then all results contain
+ | object | display_name | namedetails!dict |
+ | R13 | Garbo | "name": "Garbo", "name:it": "Vario" |
+ When geocoding "Vario"
| accept-language |
| it |
- Then results contain
- | osm | display_name |
- | R13 | Vario |
+ Then all results contain
+ | object | display_name |
+ | R13 | Vario |
Scenario: Differing names from linked places are searchable
Then placex contains
| object | linked_place_id |
| N2 | R13 |
- When sending search query "Vario"
+ When geocoding "Vario"
| namedetails |
| 1 |
- Then results contain
- | osm | display_name | namedetails |
- | R13 | Garbo | "name": "Garbo", "_place_name": "Vario" |
- When sending search query "Garbo"
- Then results contain
- | osm | display_name |
- | R13 | Garbo |
+ Then all results contain
+ | object | display_name | namedetails!dict |
+ | R13 | Garbo | "name": "Garbo", "_place_name": "Vario" |
+ When geocoding "Garbo"
+ Then all results contain
+ | object | display_name |
+ | R13 | Garbo |
--- /dev/null
+Feature: Import and search of names
+ Tests all naming related issues: normalisation,
+ abbreviations, internationalisation, etc.
+
+ Scenario: non-latin scripts can be found
+ Given the places
+ | osm | class | type | name |
+ | N1 | place | locality | Речицкий район |
+ | N2 | place | locality | Refugio de montaña |
+ | N3 | place | locality | 高槻市|
+ | N4 | place | locality | الدوحة |
+ When importing
+ When geocoding "Речицкий район"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Refugio de montaña"
+ Then result 0 contains
+ | object |
+ | N2 |
+ When geocoding "高槻市"
+ Then result 0 contains
+ | object |
+ | N3 |
+ When geocoding "الدوحة"
+ Then result 0 contains
+ | object |
+ | N4 |
+
+ Scenario: Case-insensitivity of search
+ Given the places
+ | osm | class | type | name |
+ | N1 | place | locality | FooBar |
+ When importing
+ Then placex contains
+ | object | class | type | name+name |
+ | N1 | place | locality | FooBar |
+ When geocoding "FooBar"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "foobar"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "fOObar"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "FOOBAR"
+ Then result 0 contains
+ | object |
+ | N1 |
+
+ Scenario: Multiple spaces in name
+ Given the places
+ | osm | class | type | name |
+ | N1 | place | locality | one two three |
+ When importing
+ When geocoding "one two three"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "one two three"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "one two three"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding " one two three"
+ Then result 0 contains
+ | object |
+ | N1 |
+
+ Scenario: Special characters in name
+ Given the places
+ | osm | class | type | name+name:de |
+ | N1 | place | locality | Jim-Knopf-Straße |
+ | N2 | place | locality | Smith/Weston |
+ | N3 | place | locality | space mountain |
+ | N4 | place | locality | space |
+ | N5 | place | locality | mountain |
+ When importing
+ When geocoding "Jim-Knopf-Str"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Jim Knopf-Str"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Jim Knopf Str"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Jim/Knopf-Str"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Jim-Knopfstr"
+ Then result 0 contains
+ | object |
+ | N1 |
+ When geocoding "Smith/Weston"
+ Then result 0 contains
+ | object |
+ | N2 |
+ When geocoding "Smith Weston"
+ Then result 0 contains
+ | object |
+ | N2 |
+ When geocoding "Smith-Weston"
+ Then result 0 contains
+ | object |
+ | N2 |
+ When geocoding "space mountain"
+ Then result 0 contains
+ | object |
+ | N3 |
+ When geocoding "space-mountain"
+ Then result 0 contains
+ | object |
+ | N3 |
+ When geocoding "space/mountain"
+ Then result 0 contains
+ | object |
+ | N3 |
+ When geocoding "space\mountain"
+ Then result 0 contains
+ | object |
+ | N3 |
+ When geocoding "space(mountain)"
+ Then result 0 contains
+ | object |
+ | N3 |
+
+ Scenario: Landuse with name are found
+ Given the grid
+ | 1 | 2 |
+ | 3 | |
+ Given the places
+ | osm | class | type | name | geometry |
+ | R1 | natural | meadow | landuse1 | (1,2,3,1) |
+ | R2 | landuse | industrial | landuse2 | (2,3,1,2) |
+ When importing
+ When geocoding "landuse1"
+ Then result 0 contains
+ | object |
+ | R1 |
+ When geocoding "landuse2"
+ Then result 0 contains
+ | object |
+ | R2 |
+
+ Scenario: Postcode boundaries without ref
+ Given the grid with origin FR
+ | | 2 | |
+ | 1 | | 3 |
+ Given the places
+ | osm | class | type | postcode | geometry |
+ | R1 | boundary | postal_code | 123-45 | (1,2,3,1) |
+ When importing
+ When geocoding "123-45"
+ Then result 0 contains
+ | object |
+ | R1 |
+
+ Scenario Outline: Housenumbers with special characters are found
+ Given the grid
+ | 1 | | | | 2 |
+ | | | 9 | | |
+ And the places
+ | osm | class | type | name | geometry |
+ | W1 | highway | primary | Main St | 1,2 |
+ And the places
+ | osm | class | type | housenr | geometry |
+ | N1 | building | yes | <nr> | 9 |
+ When importing
+ And geocoding "Main St <nr>"
+ Then result 0 contains
+ | object | display_name |
+ | N1 | <nr>, Main St |
+
+ Examples:
+ | nr |
+ | 1 |
+ | 3456 |
+ | 1 a |
+ | 56b |
+ | 1 A |
+ | 2號 |
+ | 1Б |
+ | 1 к1 |
+ | 23-123 |
+
+ Scenario Outline: Housenumbers in lists are found
+ Given the grid
+ | 1 | | | | 2 |
+ | | | 9 | | |
+ And the places
+ | osm | class | type | name | geometry |
+ | W1 | highway | primary | Main St | 1,2 |
+ And the places
+ | osm | class | type | housenr | geometry |
+ | N1 | building | yes | <nr-list> | 9 |
+ When importing
+ And geocoding "Main St <nr>"
+ Then result 0 contains
+ | object | display_name |
+ | N1 | <nr-list>, Main St |
+
+ Examples:
+ | nr-list | nr |
+ | 1,2,3 | 1 |
+ | 1,2,3 | 2 |
+ | 1, 2, 3 | 3 |
+ | 45 ;67;3 | 45 |
+ | 45 ;67;3 | 67 |
+ | 1a;1k | 1a |
+ | 1a;1k | 1k |
+ | 34/678 | 34 |
+ | 34/678 | 678 |
+ | 34/678 | 34/678 |
-@DB
Feature: Querying fo postcode variants
Scenario: Postcodes in Singapore (6-digit postcode)
| osm | class | type | name | addr+postcode | geometry |
| W1 | highway | path | Lorang | 399174 | 10,11 |
When importing
- When sending search query "399174"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | 399174, Singapore |
+ When geocoding "399174"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | 399174, Singapore |
Scenario Outline: Postcodes in the Netherlands (mixed postcode with spaces)
| osm | class | type | name | addr+postcode | geometry |
| W1 | highway | path | De Weide | 3993 DX | 10,11 |
When importing
- When sending search query "3993 DX"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | 3993 DX, Nederland |
- When sending search query "3993dx"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | 3993 DX, Nederland |
+ When geocoding "3993 DX"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | 3993 DX, Nederland |
+ When geocoding "3993dx"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | 3993 DX, Nederland |
Examples:
| postcode |
| osm | class | type | name | addr+postcode | geometry |
| W1 | highway | path | Lorang | 399174 | 10,11 |
When importing
- When sending search query "399174"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | 399174, Singapore |
+ When geocoding "399174"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | 399174, Singapore |
Scenario Outline: Postcodes in Andorra (with country code)
| osm | class | type | name | addr+postcode | geometry |
| W1 | highway | path | Lorang | <postcode> | 10,11 |
When importing
- When sending search query "675"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | AD675, Andorra |
- When sending search query "AD675"
- Then results contain
- | ID | type | display_name |
- | 0 | postcode | AD675, Andorra |
+ When geocoding "675"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | AD675, Andorra |
+ When geocoding "AD675"
+ Then result 0 contains
+ | type | display_name |
+ | postcode | AD675, Andorra |
Examples:
| postcode |
| N35 | place | house | E4 7EA | 111 | country:gb |
When importing
Then location_postcode contains exactly
- | country | postcode | geometry |
- | gb | EH4 7EA | country:gb |
- | gb | E4 7EA | country:gb |
- When sending search query "EH4 7EA"
- Then results contain
+ | country_code | postcode | geometry!wkt |
+ | gb | EH4 7EA | country:gb |
+ | gb | E4 7EA | country:gb |
+ When geocoding "EH4 7EA"
+ Then result 0 contains
| type | display_name |
| postcode | EH4 7EA, United Kingdom |
- When sending search query "E4 7EA"
- Then results contain
+ When geocoding "E4 7EA"
+ Then result 0 contains
| type | display_name |
| postcode | E4 7EA, United Kingdom |
| R23 | boundary | postal_code | 12345 | (1,2,3,4,1) |
When importing
Then location_postcode contains exactly
- | country | postcode |
- | de | 12345 |
- When sending search query "12345, de"
- Then results contain
- | osm |
+ | country_code | postcode |
+ | de | 12345 |
+ When geocoding "12345, de"
+ Then result 0 contains
+ | object |
| R23 |
-@DB
Feature: Reverse searches
Test results of reverse queries
| W1 | aeroway | terminal | (1,2,3,4,1) |
| N1 | amenity | restaurant | 9 |
When importing
- And sending v1/reverse at 1.0001,1.0001
- Then results contain
- | osm |
+ And reverse geocoding 1.0001,1.0001
+ Then the result contains
+ | object |
| N1 |
- When sending v1/reverse at 1.0003,1.0001
- Then results contain
- | osm |
+ When reverse geocoding 1.0003,1.0001
+ Then the result contains
+ | object |
| W1 |
-@DB
Feature: Searching of simple objects
Testing simple stuff
| osm | class | type | name+name | geometry |
| N1 | place | village | Foo | 10.0 -10.0 |
When importing
- And sending search query "Foo"
- Then results contain
- | ID | osm | category | type | centroid |
- | 0 | N1 | place | village | 10 -10 |
-
- Scenario: Updating postcode in postcode boundaries without ref
- Given the grid
- | 1 | 2 |
- | 4 | 3 |
- Given the places
- | osm | class | type | postcode | geometry |
- | R1 | boundary | postal_code | 12345 | (1,2,3,4,1) |
- When importing
- And sending search query "12345"
- Then results contain
- | ID | osm |
- | 0 | R1 |
- When updating places
- | osm | class | type | postcode | geometry |
- | R1 | boundary | postal_code | 54321 | (1,2,3,4,1) |
- And sending search query "12345"
- Then exactly 0 results are returned
- When sending search query "54321"
- Then results contain
- | ID | osm |
- | 0 | R1 |
+ And geocoding "Foo"
+ Then result 0 contains
+ | object | category | type | centroid!wkt |
+ | N1 | place | village | 10 -10 |
# github #1763
Scenario: Correct translation of highways under construction
| W1 | highway | construction | The build | 1,2 |
| N1 | amenity | cafe | Bean | 9 |
When importing
- And sending json search query "Bean" with address
- Then result addresses contain
+ And geocoding "Bean"
+ Then result 0 contains in field address
| amenity | road |
| Bean | The build |
| osm | class | type | name | housenr |
| N20 | amenity | restaurant | Red Way | 34 |
When importing
- And sending search query "Wood Street 45"
+ And geocoding "Wood Street 45"
Then exactly 0 results are returned
- When sending search query "Red Way 34"
- Then results contain
- | osm |
+ When geocoding "Red Way 34"
+ Then all results contain
+ | object |
| N20 |
Scenario: when the housenumber is missing the street is still returned
| osm | class | type | name | geometry |
| W1 | highway | residential | Wood Street | 1, 2 |
When importing
- And sending search query "Wood Street"
- Then results contain
- | osm |
+ And geocoding "Wood Street"
+ Then all results contain
+ | object |
| W1 |
-
Scenario Outline: Special cased american states will be found
Given the grid
| 1 | | 2 |
| N2 | place | town | <city> | 10 |
| N3 | place | city | <city> | country:ca |
When importing
- And sending search query "<city>, <state>"
- Then results contain
- | osm |
+ And geocoding "<city>, <state>"
+ Then all results contain
+ | object |
| N2 |
- When sending search query "<city>, <ref>"
+ When geocoding "<city>, <ref>"
| accept-language |
| en |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| N2 |
Examples:
-@DB
Feature: Country handling
Tests for update of country information
| osm | class | type | name |
| N10 | place | town | Wenig |
When importing
- When sending search query "Wenig, Loudou"
- Then results contain
- | osm |
+ When geocoding "Wenig, Loudou"
+ Then all results contain
+ | object |
| N10 |
When updating places
| osm | class | type | admin | name+name:xy | country | geometry |
| R1 | boundary | administrative | 2 | Germany | de | (1,2,3,4,1) |
- When sending search query "Wenig, Loudou"
+ When geocoding "Wenig, Loudou"
Then exactly 0 results are returned
Scenario: When country names are deleted they are no longer searchable
| osm | class | type | name |
| N10 | place | town | Wenig |
When importing
- When sending search query "Wenig, Loudou"
- Then results contain
- | osm |
+ When geocoding "Wenig, Loudou"
+ Then all results contain
+ | object |
| N10 |
When updating places
| osm | class | type | admin | name+name:en | country | geometry |
| R1 | boundary | administrative | 2 | Germany | de | (1,2,3,4,1) |
- When sending search query "Wenig, Loudou"
+ When geocoding "Wenig, Loudou"
Then exactly 0 results are returned
- When sending search query "Wenig"
+ When geocoding "Wenig"
| accept-language |
| xy,en |
- Then results contain
- | osm | display_name |
- | N10 | Wenig, Germany |
+ Then all results contain
+ | object | display_name |
+ | N10 | Wenig, Germany |
Scenario: Default country names are always searchable
| osm | class | type | name |
| N10 | place | town | Wenig |
When importing
- When sending search query "Wenig, Germany"
- Then results contain
- | osm |
+ When geocoding "Wenig, Germany"
+ Then all results contain
+ | object |
| N10 |
- When sending search query "Wenig, de"
- Then results contain
- | osm |
+ When geocoding "Wenig, de"
+ Then all results contain
+ | object |
| N10 |
When updating places
| osm | class | type | admin | name+name:en | country | geometry |
| R1 | boundary | administrative | 2 | Lilly | de | (1,2,3,4,1) |
- When sending search query "Wenig, Germany"
+ When geocoding "Wenig, Germany"
| accept-language |
| en,de |
- Then results contain
- | osm | display_name |
+ Then all results contain
+ | object | display_name |
| N10 | Wenig, Lilly |
- When sending search query "Wenig, de"
+ When geocoding "Wenig, de"
| accept-language |
| en,de |
- Then results contain
- | osm | display_name |
- | N10 | Wenig, Lilly |
+ Then all results contain
+ | object | display_name |
+ | N10 | Wenig, Lilly |
Scenario: When a localised name is deleted, the standard name takes over
| osm | class | type | name |
| N10 | place | town | Wenig |
When importing
- When sending search query "Wenig, Loudou"
+ When geocoding "Wenig, Loudou"
| accept-language |
| de,en |
- Then results contain
- | osm | display_name |
+ Then all results contain
+ | object | display_name |
| N10 | Wenig, Loudou |
When updating places
| osm | class | type | admin | name+name:en | country | geometry |
| R1 | boundary | administrative | 2 | Germany | de | (1,2,3,4,1) |
- When sending search query "Wenig, Loudou"
+ When geocoding "Wenig, Loudou"
Then exactly 0 results are returned
- When sending search query "Wenig"
+ When geocoding "Wenig"
| accept-language |
| de,en |
- Then results contain
- | osm | display_name |
- | N10 | Wenig, Deutschland |
+ Then all results contain
+ | object | display_name |
+ | N10 | Wenig, Deutschland |
-@DB
Feature: Update of address interpolations
Test the interpolated address are updated correctly
| W1 | 4 | 4 |
| W1 | 8 | 8 |
- @Fail
+ @skip
Scenario: housenumber removed in middle of interpolation
Given the grid
| 1 | | | | | 2 |
-@DB
Feature: Updates of linked places
Tests that linked places are correctly added and deleted.
Then placex contains
| object | linked_place_id |
| N1 | R1 |
- When sending search query "foo"
+ When geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| R1 |
When updating places
| osm | class | type | name | admin | geometry |
Then placex contains
| object | linked_place_id |
| N1 | - |
- When sending search query "foo"
+ When geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| N1 |
Scenario: Add linked place when linking relation is removed
| osm | class | type | name | admin | geometry |
| R1 | boundary | administrative | foo | 8 | (10,11,12,13,10) |
When importing
- And sending search query "foo"
+ And geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| R1 |
When marking for delete R1
Then placex contains
| object | linked_place_id |
| N1 | - |
- When sending search query "foo"
+ When geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| N1 |
Scenario: Remove linked place when linking relation is added
| osm | class | type | name |
| N1 | place | city | foo |
When importing
- And sending search query "foo"
+ And geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| N1 |
When updating places
| osm | class | type | name | admin | geometry |
Then placex contains
| object | linked_place_id |
| N1 | R1 |
- When sending search query "foo"
+ When geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| R1 |
Scenario: Remove linked place when linking relation is renamed
| osm | class | type | name | admin | geometry |
| R1 | boundary | administrative | foobar | 8 | (10,11,12,13,10) |
When importing
- And sending search query "foo"
+ And geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| N1 |
When updating places
| osm | class | type | name | admin | geometry |
Then placex contains
| object | linked_place_id |
| N1 | R1 |
- When sending search query "foo"
+ When geocoding "foo"
| dups |
| 1 |
- Then results contain
- | osm |
+ Then all results contain
+ | object |
| R1 |
Scenario: Update linking relation when linkee name is updated
And placex contains
| object | linked_place_id | name+name |
| N3 | R1 | greeny |
- When sending search query "greeny"
- Then results contain
- | osm |
+ When geocoding "greeny"
+ Then all results contain
+ | object |
| R1 |
When updating places
| osm | class | type | name+name:de |
And placex contains
| object | linked_place_id | name+_place_name:de | name+name |
| R1 | - | depnt | rel |
- When sending search query "greeny"
+ When geocoding "greeny"
Then exactly 0 results are returned
Scenario: Updating linkee extratags keeps linker's extratags
| 1 | N3:label |
When importing
Then placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'wikidata' : '34', 'linked_place' : 'city' |
When updating places
| osm | class | type | name | extra+oneway |
| N3 | place | city | newname | yes |
Then placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'wikidata' : '34', 'oneway' : 'yes', 'linked_place' : 'city' |
Scenario: Remove linked_place info when linkee is removed
| R1 | boundary | administrative | foo | 8 | (10,11,12,13,10) |
When importing
Then placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'linked_place' : 'city' |
When marking for delete N1
Then placex contains
| R1 | boundary | administrative | foo | 8 | (10,11,12,13,10) |
When importing
Then placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'linked_place' : 'city' |
When updating places
| osm | class | type | name |
| N1 | place | town | foo |
Then placex contains
- | object | extratags |
+ | object | extratags!dict |
| R1 | 'linked_place' : 'town' |
-@DB
Feature: Update of names in place objects
Test all naming related issues in updates
| osm | class | type | postcode | geometry |
| R1 | boundary | postal_code | 123-45 | (1,2,3,4,1) |
When importing
- And sending search query "123-45"
- Then results contain
- | ID | osm |
- | 0 | R1 |
+ And geocoding "123-45"
+ Then result 0 contains
+ | object |
+ | R1 |
When updating places
| osm | class | type | geometry |
| R1 | boundary | postal_code | (1,2,3,4,1) |
-@DB
Feature: Update parenting of objects
Scenario: POI inside building inherits addr:street change
# Invalidation of geometries currently disabled for addr:place matches.
- @Fail
+ @skip
Scenario: Housenumber is reparented when place is renamed to matching addr:place
Given the grid
| 1 | | | 2 |
-@DB
Feature: Update of postcode
Tests for updating of data related to postcodes
+ Scenario: Updating postcode in postcode boundaries without ref
+ Given the grid
+ | 1 | 2 |
+ | 4 | 3 |
+ Given the places
+ | osm | class | type | postcode | geometry |
+ | R1 | boundary | postal_code | 12345 | (1,2,3,4,1) |
+ When importing
+ And geocoding "12345"
+ Then result 0 contains
+ | object |
+ | R1 |
+ When updating places
+ | osm | class | type | postcode | geometry |
+ | R1 | boundary | postal_code | 54321 | (1,2,3,4,1) |
+ And geocoding "12345"
+ Then exactly 0 results are returned
+ When geocoding "54321"
+ Then result 0 contains
+ | object |
+ | R1 |
+
Scenario: A new postcode appears in the postcode table
Given the places
| osm | class | type | addr+postcode | addr+housenumber | geometry |
- | N34 | place | house | 01982 | 111 |country:de |
+ | N34 | place | house | 01982 | 111 | country:de |
When importing
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 01982 | country:de |
+ | country_code | postcode | geometry!wkt |
+ | de | 01982 | country:de |
When updating places
| osm | class | type | addr+postcode | addr+housenumber | geometry |
- | N35 | place | house | 4567 | 5 |country:ch |
+ | N35 | place | house | 4567 | 5 | country:ch |
And updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 01982 | country:de |
- | ch | 4567 | country:ch |
+ | country_code | postcode | geometry!wkt |
+ | de | 01982 | country:de |
+ | ch | 4567 | country:ch |
Scenario: When the last postcode is deleted, it is deleted from postcode
Given the places
| osm | class | type | addr+postcode | addr+housenumber | geometry |
- | N34 | place | house | 01982 | 111 |country:de |
- | N35 | place | house | 4567 | 5 |country:ch |
+ | N34 | place | house | 01982 | 111 | country:de |
+ | N35 | place | house | 4567 | 5 | country:ch |
When importing
And marking for delete N34
And updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | ch | 4567 | country:ch |
+ | country_code | postcode | geometry!wkt |
+ | ch | 4567 | country:ch |
Scenario: A postcode is not deleted from postcode when it exist in another country
Given the places
| osm | class | type | addr+postcode | addr+housenumber | geometry |
- | N34 | place | house | 01982 | 111 |country:de |
- | N35 | place | house | 01982 | 5 |country:fr |
+ | N34 | place | house | 01982 | 111 | country:de |
+ | N35 | place | house | 01982 | 5 | country:fr |
When importing
And marking for delete N34
And updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | fr | 01982 | country:fr |
+ | country_code | postcode | geometry!wkt|
+ | fr | 01982 | country:fr |
Scenario: Updating a postcode is reflected in postcode table
Given the places
| N34 | place | postcode | 20453 | country:de |
And updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 20453 | country:de |
+ | country_code | postcode | geometry!wkt |
+ | de | 20453 | country:de |
Scenario: When changing from a postcode type, the entry appears in placex
When importing
| osm | class | type | addr+postcode | housenr | geometry |
| N34 | place | house | 20453 | 1 | country:de |
Then placex contains
- | object | addr+housenumber | geometry |
- | N34 | 1 | country:de|
+ | object | addr+housenumber | geometry!wkt |
+ | N34 | 1 | country:de |
And place contains exactly
- | object | class | type |
- | N34 | place | house |
+ | osm_type | osm_id | class | type |
+ | N | 34 | place | house |
When updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 20453 | country:de |
+ | country_code | postcode | geometry!wkt |
+ | de | 20453 | country:de |
Scenario: When changing to a postcode type, the entry disappears from placex
When importing
| osm | class | type | addr+postcode | housenr | geometry |
| N34 | place | house | 20453 | 1 | country:de |
Then placex contains
- | object | addr+housenumber | geometry |
+ | object | addr+housenumber | geometry!wkt |
| N34 | 1 | country:de|
When updating places
| osm | class | type | addr+postcode | geometry |
| N34 | place | postcode | 01982 | country:de |
Then placex has no entry for N34
And place contains exactly
- | object | class | type |
- | N34 | place | postcode |
+ | osm_type | osm_id | class | type |
+ | N | 34 | place | postcode |
When updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry |
- | de | 01982 | country:de |
+ | country_code | postcode | geometry!wkt |
+ | de | 01982 | country:de |
Scenario: When a parent is deleted, the postcode gets a new parent
Given the grid with origin DE
| osm | class | type | name | admin | geometry |
| R1 | boundary | administrative | Big | 6 | (1,4,6,2,1) |
| R2 | boundary | administrative | Small | 6 | (1,3,5,2,1) |
- Given the named places
+ Given the places
| osm | class | type | addr+postcode | geometry |
| N9 | place | postcode | 12345 | 9 |
When importing
- And updating postcodes
Then location_postcode contains exactly
- | country | postcode | geometry | parent_place_id |
- | de | 12345 | 9 | R2 |
+ | postcode | geometry!wkt | parent_place_id |
+ | 12345 | 9 | R2 |
When marking for delete R2
Then location_postcode contains exactly
- | country | postcode | geometry | parent_place_id |
- | de | 12345 | 9 | R1 |
+ | country_code | postcode | geometry!wkt | parent_place_id |
+ | de | 12345 | 9 | R1 |
-@DB
Feature: Update of simple objects
Testing simple updating functionality
| R1 | 0 |
| R2 | 26 |
| W1 | 30 |
- When marking for delete R1,R2,W1
+ When marking for delete R1
+ And marking for delete R2
+ And marking for delete W1
Then placex has no entry for W1
Then placex has no entry for R1
Then placex has no entry for R2
| N3 | shop | toys | 1 -1 |
When importing
Then placex contains
- | object | class | type | centroid |
+ | object | class | type | centroid!wkt |
| N3 | shop | toys | 1 -1 |
When updating places
| osm | class | type | geometry |
| N3 | shop | grocery | 1 -1 |
Then placex contains
- | object | class | type | centroid |
+ | object | class | type | centroid!wkt |
| N3 | shop | grocery | 1 -1 |
Scenario: remove postcode place when house number is added
-@DB
Feature: Import of objects with broken geometries by osm2pgsql
Scenario: Import way with double nodes
w1 Thighway=primary Nn100,n101,n101,n102
"""
Then place contains
- | object | class | type | geometry |
+ | object | class | type | geometry!wkt |
| W1 | highway | primary | 0 0, 0 0.1, 0.1 0.2 |
Scenario: Import of ballon areas
+ Given the grid
+ | 2 | | 3 |
+ | 1 | | 4 |
+ | 5 | | |
When loading osm data
"""
- n1 x0 y0
- n2 x0 y0.0001
- n3 x0.00001 y0.0001
- n4 x0.00001 y0
- n5 x-0.00001 y0
+ n1
+ n2
+ n3
+ n4
+ n5
w1 Thighway=unclassified Nn1,n2,n3,n4,n1,n5
w2 Thighway=unclassified Nn1,n2,n3,n4,n1
w3 Thighway=unclassified Nn1,n2,n3,n4,n3
"""
Then place contains
- | object | geometrytype |
- | W1 | ST_LineString |
- | W2 | ST_Polygon |
- | W3 | ST_LineString |
+ | object | geometry!wkt |
+ | W1 | 1,2,3,4,1,5 |
+ | W2 | (1,2,3,4,1) |
+ | W3 | 1,2,3,4 |
-@DB
Feature: Import with custom styles by osm2pgsql
Tests for the example customizations given in the documentation.
n4 Ttourism=hotel,amenity=telephone x0 y0
"""
Then place contains exactly
- | object | extratags |
- | N2:amenity | - |
- | N3:tourism | 'amenity': 'yes' |
- | N4:tourism | - |
- | N4:amenity | - |
+ | object | class | extratags!dict |
+ | N2 | amenity | - |
+ | N3 | tourism | 'amenity': 'yes' |
+ | N4 | tourism | - |
+ | N4 | amenity | - |
Scenario: Ignore some tags
Given the lua style file
n100 Thighway=residential,ref=34,ref:bodo=34,surface=gray,extra=1 x0 y0
"""
Then place contains exactly
- | object | name | extratags |
- | N100 | 'ref' : '34' | 'extra': '1' |
+ | object | name!dict | extratags!dict |
+ | N100 | 'ref' : '34' | 'extra': '1' |
Scenario: Add for extratags
n100 Thighway=residential,ref=34,ref:bodo=34,surface=gray,extra=1 x0 y0
"""
Then place contains exactly
- | object | name | extratags |
+ | object | name!dict | extratags!dict |
| N100 | 'ref' : '34' | 'ref:bodo': '34', 'surface': 'gray' |
n4 Thighway=traffic_light,name=Red,ref=45 x0 y0
"""
Then place contains exactly
- | object | name |
- | N3:highway | 'name': 'Greens' |
- | N4:highway | 'name': 'Red', 'ref': '45' |
+ | object | class | name!dict |
+ | N3 | highway | 'name': 'Greens' |
+ | N4 | highway | 'name': 'Red', 'ref': '45' |
Scenario: Modify name tags
Given the lua style file
n2 Taddr:housename=Old,addr:street=Away
"""
Then place contains exactly
- | object | name |
- | N1:tourism | 'o': 'good' |
+ | object | class | name!dict |
+ | N1 | tourism | 'o': 'good' |
Scenario: Address tags
Given the lua style file
n3 Taddr:street=None,addr:city=Where x0 y0
"""
Then place contains exactly
- | object | type | address |
- | N1:tourism | hotel | 'street': 'Foo' |
- | N2:place | house | 'housenumber': '23', 'street': 'Budd', 'postcode': '5567' |
+ | object | class | type | address!dict |
+ | N1 | tourism | hotel | 'street': 'Foo' |
+ | N2 | place | house | 'housenumber': '23', 'street': 'Budd', 'postcode': '5567' |
Scenario: Modify address tags
Given the lua style file
n2 Taddr:housenumber=23,addr:street=Budd,is_in:city=Faraway,postal_code=5567 x0 y0
"""
Then place contains exactly
- | object | type | address |
- | N2:place | house | 'housenumber': '23', 'street': 'Budd', 'postcode': '5567' |
+ | object | class | type | address!dict |
+ | N2 | place | house | 'housenumber': '23', 'street': 'Budd', 'postcode': '5567' |
Scenario: Unused handling (delete)
Given the lua style file
n2 Ttourism=hotel,tiger:xxd=56,else=other x0 y0
"""
Then place contains exactly
- | object | type | address | extratags |
- | N1:tourism | hotel | 'tiger:county': 'Fargo' | - |
- | N2:tourism | hotel | - | 'else': 'other' |
+ | object | class | type | address!dict | extratags!dict |
+ | N1 | tourism | hotel | 'tiger:county': 'Fargo' | - |
+ | N2 | tourism | hotel | - | 'else': 'other' |
Scenario: Unused handling (extra)
Given the lua style file
n567 Thighway=path,surface=dirt,wikipedia:en=Path x0 y0
"""
Then place contains exactly
- | object | type | extratags |
- | N100:highway | path | 'wikipedia': 'en:Path' |
- | N234:highway | path | 'surface': 'rough' |
- | N445:highway | path | - |
- | N446:highway | path | 'wikipedia:en': 'Path', 'wikidata': 'Q23' |
- | N567:highway | path | 'surface': 'dirt', 'wikipedia:en': 'Path' |
+ | object | class | type | extratags!dict |
+ | N100 | highway | path | 'wikipedia': 'en:Path' |
+ | N234 | highway | path | 'surface': 'rough' |
+ | N445 | highway | path | - |
+ | N446 | highway | path | 'wikipedia:en': 'Path', 'wikidata': 'Q23' |
+ | N567 | highway | path | 'surface': 'dirt', 'wikipedia:en': 'Path' |
Scenario: Additional relation types
Given the lua style file
r2 Ttype=site,amenity=school Mw1@
"""
Then place contains exactly
- | object | type |
- | R1:amenity | school |
- | R2:amenity | school |
+ | object | class | type |
+ | R1 | amenity | school |
+ | R2 | amenity | school |
Scenario: Exclude country relations
Given the lua style file
r2 Ttype=multipolygon,boundary=administrative,admin_level=2,name=Big Mw1@
"""
Then place contains exactly
- | object | type |
- | R1:boundary | administrative |
+ | object | class | type |
+ | R1 | boundary | administrative |
Scenario: Customize processing functions
Given the lua style file
n2 Thighway=residential,access=no x0 y0
"""
Then place contains exactly
- | object | type |
- | N1:highway | residential |
+ | object | class | type |
+ | N1 | highway | residential |
-@DB
Feature: Import of relations by osm2pgsql
Testing specific relation problems related to members.
-@DB
Feature: Import of simple objects by osm2pgsql
Testing basic tagging in osm2pgsql imports.
r1 Ttype=multipolygon,tourism=hotel,name=XZ Mn1@,w2@
"""
Then place contains exactly
- | object | class | type | name | geometry |
+ | object | class | type | name!dict | geometry!wkt |
| N1 | amenity | prison | 'name' : 'foo' | 34.3 -23 |
| W1 | shop | toys | 'name' : 'tata' | 0 0, 0 0.1, 0.1 0.2 |
| R1 | tourism | hotel | 'name' : 'XZ' | (0 0, 0 1, 1 1, 1 0, 0 0) |
"""
n1 Ttourism=hotel,amenity=restaurant,name=foo
"""
- Then place contains
- | object | type | name |
- | N1:tourism | hotel | 'name' : 'foo' |
- | N1:amenity | restaurant | 'name' : 'foo' |
+ Then place contains exactly
+ | object | class | type | name!dict |
+ | N1 | tourism | hotel | 'name' : 'foo' |
+ | N1 | amenity | restaurant | 'name' : 'foo' |
Scenario: Import stand-alone house number with postcode
When loading osm data
"""
n1 Taddr:housenumber=4,addr:postcode=3345
"""
- Then place contains
+ Then place contains exactly
| object | class | type |
| N1 | place | house |
-@DB
Feature: Tag evaluation
Tests if tags are correctly imported into the place table
n2006 Thighway=yes,name:%9%de=Foo,name=rea\l3
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2001 | highway | road | 'name': 'Foo', 'alt_name:de': 'Bar', 'ref': '45' |
| N2002 | highway | road | - |
| N2003 | highway | yes | 'name: de': 'Foo', 'name': 'real1' |
- | N2004 | highway | yes | 'name:\nde': 'Foo', 'name': 'real2' |
- | N2005 | highway | yes | 'name:\tde': 'Foo', 'name:\\\\': 'real3' |
- | N2006 | highway | yes | 'name:\tde': 'Foo', 'name': 'rea\\l3' |
+ | N2004 | highway | yes | 'name:\\nde': 'Foo', 'name': 'real2' |
+ | N2005 | highway | yes | 'name:\tde': 'Foo', r'name:\\\\': 'real3' |
+ | N2006 | highway | yes | 'name:\tde': 'Foo', 'name': r'rea\l3' |
And place contains
- | object | extratags |
+ | object | extratags!dict |
| N2002 | 'name:prefix': 'Pre', 'name:suffix': 'Post', 'ref:de': '55' |
n3002 Tbridge=yes,bridge:name:en=Rainbow
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N3001 | bridge | yes | 'name': 'GoldenGate' |
| N3002 | bridge | yes | 'name:en': 'Rainbow' |
n4002 Taddr:streetnumber=10,is_in:city=Rootoo,is_in=Gold
"""
Then place contains exactly
- | object | class | address |
+ | object | class | address!dict |
| N4001 | place | 'housenumber': '34', 'city': 'Esmarald', 'county': 'Land' |
| N4002 | place | 'streetnumber': '10', 'city': 'Rootoo' |
n5006 Tshop=yes,addr:country=France
"""
Then place contains exactly
- | object | class | address |
+ | object | class | address!dict |
| N5001 | shop | 'country': 'DE' |
| N5002 | shop | - |
| N5003 | shop | - |
n6003 Tshop=bank,is_in:postcode=9009
"""
Then place contains exactly
- | object | class | address |
+ | object | class | address!dict |
| N6001 | shop | 'postcode': '12345' |
| N6002 | shop | 'postcode': '34343' |
| N6003 | shop | - |
w1 Tboundary=postal_code,ref=3456 Nn1,n2,n3,n4,n1
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| W1 | boundary | postal_code | 'ref': '3456' |
Scenario: Main with extra
n7002 Thighway=primary,bridge=yes,bridge:name=1
"""
Then place contains exactly
- | object | class | type | name | extratags+bridge:name |
- | N7001 | highway | primary | 'name': '1' | - |
- | N7002:highway | highway | primary | - | 1 |
- | N7002:bridge | bridge | yes | 'name': '1' | 1 |
+ | object | class | type | name!dict | extratags!dict |
+ | N7001 | highway | primary | 'name': '1' | 'bridge': 'yes' |
+ | N7002 | highway | primary | - | 'bridge': 'yes', 'bridge:name': '1' |
+ | N7002 | bridge | yes | 'name': '1' | 'highway': 'primary', 'bridge:name': '1' |
Scenario: Global fallback and skipping
n8003 Tshop=shoes,name:source=survey
"""
Then place contains exactly
- | object | class | name | extratags |
- | N8001 | shop | - | 'xx': 'yy' |
- | N8002 | shop | - | 'ele': '234' |
- | N8003 | shop | - | - |
+ | object | class | name!dict | extratags!dict |
+ | N8001 | shop | - | 'xx': 'yy' |
+ | N8002 | shop | - | 'ele': '234' |
+ | N8003 | shop | - | - |
Scenario: Admin levels
n10003 Tboundary=administrative,place=island,name=C
"""
Then place contains
- | object | class | type | extratags |
- | N10001 | boundary | administrative | 'place': 'city' |
+ | object | class | type | extratags!dict |
+ | N10001 | boundary | administrative | 'place': 'city' |
And place contains
- | object | class | type |
- | N10002:boundary | boundary | natural |
- | N10002:place | place | city |
- | N10003:boundary | boundary | administrative |
- | N10003:place | place | island |
+ | object | class | type |
+ | N10002 | boundary | natural |
+ | N10002 | place | city |
+ | N10003 | boundary | administrative |
+ | N10003 | place | island |
Scenario: Building fallbacks
n13002 Taddr:interpolation=even,place=city
"""
Then place contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N13001 | place | houses | 'interpolation': 'odd' |
| N13002 | place | houses | 'interpolation': 'even' |
n105 Ttourism=information,information=route_marker,name=3
"""
Then place contains exactly
- | object | type |
- | N100:tourism | information |
- | N101:tourism | information |
- | N102:information | guidepost |
- | N103:highway | information |
- | N104:tourism | information |
+ | object | class | type |
+ | N100 | tourism | information |
+ | N101 | tourism | information |
+ | N102 | information | guidepost |
+ | N103 | highway | information |
+ | N104 | tourism | information |
Scenario: Water features
n26 Tnatural=water,water=yes,name=Random
"""
Then place contains exactly
- | object | type |
- | N21:natural | water |
- | N23:water | pond |
- | N26:natural | water |
+ | object | class | type |
+ | N21 | natural | water |
+ | N23 | water | pond |
+ | N26 | natural | water |
Scenario: Drop name for address fallback
When loading osm data
n3 Taddr:housenumber=23
"""
Then place contains exactly
- | object | type | address | name |
- | N1:place | house | 'housenumber': '23' | - |
- | N2:place | house | 'housenumber': '23' | 'addr:housename': 'Foo' |
- | N3:place | house | 'housenumber': '23' | - |
+ | object | class | type | address!dict | name!dict |
+ | N1 | place | house | 'housenumber': '23' | - |
+ | N2 | place | house | 'housenumber': '23' | 'addr:housename': 'Foo' |
+ | N3 | place | house | 'housenumber': '23' | - |
Scenario: Waterway locks
n4 Tamenity=parking,lock=yes,lock_name=Gold
"""
Then place contains exactly
- | object | type | name |
- | N2:lock | yes | 'name': 'LeLock' |
- | N3:waterway | river | 'name': 'LeWater' |
- | N4:amenity | parking | - |
+ | object | class | type | name!dict |
+ | N2 | lock | yes | 'name': 'LeLock' |
+ | N3 | waterway | river | 'name': 'LeWater' |
+ | N4 | amenity | parking | - |
-@DB
Feature: Updates of address interpolation objects
Test that changes to address interpolation objects are correctly
propagated.
w33 Thighway=residential,name=Tao Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
When updating osm data
"""
w99 Taddr:interpolation=odd Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | place | houses |
When indexing
Then placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W33:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W33 | highway | residential |
Then location_property_osmline contains exactly
- | object |
- | 99:5 |
+ | osm_id | startnumber |
+ | 99 | 5 |
Scenario: Delete an existing interpolation
w99 Taddr:interpolation=odd Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | place | houses |
When updating osm data
"""
w99 v2 dD
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
When indexing
Then placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
Then location_property_osmline contains exactly
- | object | indexed_status |
+ | osm_id |
Scenario: Changing an object to an interpolation
w99 Thighway=residential Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | highway | residential |
When updating osm data
"""
w99 Taddr:interpolation=odd Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | place | houses |
When indexing
Then placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W33:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W33 | highway | residential |
And location_property_osmline contains exactly
- | object |
- | 99:5 |
+ | osm_id | startnumber |
+ | 99 | 5 |
Scenario: Changing an interpolation to something else
w99 Taddr:interpolation=odd Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | place | houses |
When updating osm data
"""
w99 Thighway=residential Nn1,n2
"""
Then place contains
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | highway | residential |
When indexing
Then placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W99:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W99 | highway | residential |
And location_property_osmline contains exactly
- | object |
-
+ | osm_id |
-@DB
Feature: Update of postcode only objects
Tests that changes to objects containing only a postcode are
propagated correctly.
Scenario: Adding a postcode-only node
When loading osm data
"""
+ n1
"""
Then place contains exactly
| object |
n34 Tpostcode=4456
"""
Then place contains exactly
- | object | type |
- | N34:place | postcode |
+ | object | class | type |
+ | N34 | place | postcode |
When indexing
Then placex contains exactly
| object |
n34 Tpostcode=4456
"""
Then place contains exactly
- | object | type |
- | N34:place | postcode |
+ | object | class | type |
+ | N34 | place | postcode |
When updating osm data
"""
n34 T<class>=<type>
"""
Then place contains exactly
- | object | type |
- | N34:<class> | <type> |
+ | object | class | type |
+ | N34 | <class> | <type> |
When updating osm data
"""
n34 Tpostcode=4456
"""
Then place contains exactly
- | object | type |
- | N34:place | postcode |
+ | object | class | type |
+ | N34 | place | postcode |
When indexing
Then placex contains exactly
| object |
n34 Tpostcode=4456
"""
Then place contains exactly
- | object | type |
- | N34:place | postcode |
+ | object | class | type |
+ | N34 | place | postcode |
When updating osm data
"""
n34 T<class>=<type>
"""
Then place contains exactly
- | object | type |
- | N34:<class> | <type> |
+ | object | class | type |
+ | N34 | <class> | <type> |
When indexing
Then placex contains exactly
- | object | type |
- | N34:<class> | <type> |
+ | object | class | type |
+ | N34 | <class> | <type> |
Examples:
| class | type |
w34 Taddr:interpolation=odd Nn1,n2
"""
Then place contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W34:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W34 | place | houses |
When updating osm data
"""
w34 Tpostcode=4456 Nn1,n2
"""
Then place contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W34:place | postcode |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W34 | place | postcode |
When indexing
Then location_property_osmline contains exactly
- | object |
+ | osm_id |
And placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
Scenario: Converting a postcode-only node into an interpolation
w34 Tpostcode=4456 Nn1,n2
"""
Then place contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W33:highway | residential |
- | W34:place | postcode |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W33 | highway | residential |
+ | W34 | place | postcode |
When updating osm data
"""
w34 Taddr:interpolation=odd Nn1,n2
"""
Then place contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W33:highway | residential |
- | W34:place | houses |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W33 | highway | residential |
+ | W34 | place | houses |
When indexing
Then location_property_osmline contains exactly
- | object |
- | 34:5 |
+ | osm_id | startnumber | endnumber |
+ | 34 | 5 | 15 |
And placex contains exactly
- | object | type |
- | N1:place | house |
- | N2:place | house |
- | W33:highway | residential |
+ | object | class | type |
+ | N1 | place | house |
+ | N2 | place | house |
+ | W33 | highway | residential |
-@DB
Feature: Update of relations by osm2pgsql
Testing relation update by osm2pgsql.
r1 Ttype=multipolygon,tourism=hotel,name=XZ Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XZ' |
When updating osm data
"""
r1 Ttype=multipolygon,tourism=hotel,name=XZ Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XZ' |
When updating osm data
"""
"""
Then place has no entry for R1:tourism
And place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | amenity | prison | 'name' : 'XZ' |
Scenario: Change name of a relation
r1 Ttype=multipolygon,tourism=hotel,name=AB Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'AB' |
When updating osm data
"""
r1 Ttype=multipolygon,tourism=hotel,name=XY Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XY' |
Scenario: Change type of a relation into something unknown
r1 Ttype=multipolygon,tourism=hotel,name=XY Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XY' |
When updating osm data
"""
r1 Ttype=multipolygon,tourism=hotel,name=XY Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XY' |
When updating osm data
"""
r1 Ttype=multipolygon,tourism=hotel,name=XY Mw2@
"""
Then place contains
- | object | class | type | name |
+ | object | class | type | name!dict |
| R1 | tourism | hotel | 'name' : 'XY' |
When updating osm data
"""
r1 Ttype=boundary,boundary=administrative,name=Foo,country_code=XX,admin_level=2 Mw1@
"""
Then place contains
- | object | addr+country | name |
- | R1 | XX | 'name' : 'Foo' |
+ | object | address+country | name!dict |
+ | R1 | XX | 'name' : 'Foo' |
--- /dev/null
+Feature: Update of simple objects by osm2pgsql
+ Testing basic update functions of osm2pgsql.
+
+ Scenario: Adding a new object
+ When loading osm data
+ """
+ n1 Tplace=town,name=Middletown
+ """
+ Then place contains exactly
+ | object | class | type | name+name |
+ | N1 | place | town | Middletown |
+
+ When updating osm data
+ """
+ n2 Tamenity=hotel,name=Posthotel
+ """
+ Then place contains exactly
+ | object | class | type | name+name |
+ | N1 | place | town | Middletown |
+ | N2 | amenity | hotel | Posthotel |
+ And placex contains exactly
+ | object | class | type | name+name | indexed_status |
+ | N1 | place | town | Middletown | 0 |
+ | N2 | amenity | hotel | Posthotel | 1 |
+
+
+ Scenario: Deleting an existing object
+ When loading osm data
+ """
+ n1 Tplace=town,name=Middletown
+ n2 Tamenity=hotel,name=Posthotel
+ """
+ Then place contains exactly
+ | object | class | type | name+name |
+ | N1 | place | town | Middletown |
+ | N2 | amenity | hotel | Posthotel |
+
+ When updating osm data
+ """
+ n2 dD
+ """
+ Then place contains exactly
+ | object | class | type | name+name |
+ | N1 | place | town | Middletown |
+ And placex contains exactly
+ | object | class | type | name+name | indexed_status |
+ | N1 | place | town | Middletown | 0 |
+ | N2 | amenity | hotel | Posthotel | 100 |
-@DB
Feature: Tag evaluation
Tests if tags are correctly updated in the place table
n3 Tamenity=prison
"""
Then place contains exactly
- | object | class | type |
- | N1 | amenity | restaurant |
- | N2:highway | highway | bus_stop |
- | N2:railway | railway | stop |
- | N3 | amenity | prison |
+ | object | class | type |
+ | N1 | amenity | restaurant |
+ | N2 | highway | bus_stop |
+ | N2 | railway | stop |
+ | N3 | amenity | prison |
When updating osm data
"""
n2 Thighway=bus_stop,name=X
"""
Then place contains exactly
- | object | class | type |
- | N2:highway | highway | bus_stop |
- | N3 | amenity | prison |
+ | object | class | type |
+ | N2 | highway | bus_stop |
+ | N3 | amenity | prison |
And placex contains
- | object | indexed_status |
- | N3:amenity | 0 |
+ | object | class | indexed_status |
+ | N3 | amenity | 0 |
When indexing
Then placex contains exactly
- | object | type | name |
- | N2:highway | bus_stop | 'name': 'X' |
- | N3:amenity | prison | - |
+ | object | class | type | name!dict |
+ | N2 | highway | bus_stop | 'name': 'X' |
+ | N3 | amenity | prison | - |
Scenario: Main tag added
n2 Thighway=bus_stop,name=X
"""
Then place contains exactly
- | object | class | type |
- | N2:highway | highway | bus_stop |
+ | object | class | type |
+ | N2 | highway | bus_stop |
When updating osm data
"""
n2 Thighway=bus_stop,railway=stop,name=X
"""
Then place contains exactly
- | object | class | type |
- | N1 | amenity | restaurant |
- | N2:highway | highway | bus_stop |
- | N2:railway | railway | stop |
+ | object | class | type |
+ | N1 | amenity | restaurant |
+ | N2 | highway | bus_stop |
+ | N2 | railway | stop |
When indexing
Then placex contains exactly
- | object | type | name |
- | N1:amenity | restaurant | - |
- | N2:highway | bus_stop | 'name': 'X' |
- | N2:railway | stop | 'name': 'X' |
+ | object | class | type | name!dict |
+ | N1 | amenity | restaurant | - |
+ | N2 | highway | bus_stop | 'name': 'X' |
+ | N2 | railway | stop | 'name': 'X' |
Scenario: Main tag modified
| N11 | highway | primary |
When indexing
Then placex contains exactly
- | object | type | name |
- | N10:highway | path | 'name': 'X' |
- | N11:highway | primary | - |
+ | object | class | type | name!dict |
+ | N10 | highway | path | 'name': 'X' |
+ | N11 | highway | primary | - |
Scenario: Main tags with name, name added
| N46 | building| yes |
When indexing
Then placex contains exactly
- | object | type | name | address |
- | N45:landuse | cemetry | 'name': 'TODO' | - |
- | N46:building| yes | - | 'housenumber': '1' |
+ | object | class | type | name!dict | address!dict |
+ | N45 | landuse | cemetry | 'name': 'TODO' | - |
+ | N46 | building| yes | - | 'housenumber': '1' |
Scenario: Main tags with name, name removed
n46 Tbuilding=yes,addr:housenumber=1
"""
Then place contains exactly
- | object | class | type | name | address |
+ | object | class | type | name!dict | address!dict |
| N45 | landuse | cemetry | 'name' : 'TODO' | - |
| N46 | building| yes | - | 'housenumber': '1'|
n46 Tbuilding=yes,addr:housenumber=10
"""
Then place contains exactly
- | object | class | type | name | address |
+ | object | class | type | name!dict | address!dict |
| N45 | landuse | cemetry | 'name' : 'DONE' | - |
| N46 | building| yes | - | 'housenumber': '10'|
When indexing
Then placex contains exactly
- | object | class | type | name | address |
+ | object | class | type | name!dict | address!dict |
| N45 | landuse | cemetry | 'name' : 'DONE' | - |
| N46 | building| yes | - | 'housenumber': '10'|
n1 Taddr:housenumber=345
"""
Then place contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | place | house | 'housenumber': '345'|
When updating osm data
n1 Taddr:housenumber=345,building=yes
"""
Then place contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | building | yes | 'housenumber': '345'|
When indexing
Then placex contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | building | yes | 'housenumber': '345'|
n1 Taddr:housenumber=345,building=yes
"""
Then place contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | building | yes | 'housenumber': '345'|
When updating osm data
n1 Taddr:housenumber=345
"""
Then place contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | place | house | 'housenumber': '345'|
When indexing
Then placex contains exactly
- | object | class | type | address |
+ | object | class | type | address!dict |
| N1 | place | house | 'housenumber': '345'|
n2 Tbridge=yes,bridge:name=high
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name': 'high' |
When indexing
Then placex contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name': 'high' |
n2 Tbridge=yes,bridge:name=high
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name': 'high' |
When updating osm data
n2 Tbridge=yes,bridge:name=high
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name': 'high' |
When updating osm data
n2 Tbridge=yes,bridge:name:en=high
"""
Then place contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name:en': 'high' |
When indexing
Then placex contains exactly
- | object | class | type | name |
+ | object | class | type | name!dict |
| N2 | bridge | yes | 'name:en': 'high' |
w1 Thighway=residential Nn100,n101
"""
Then place contains exactly
- | object |
- | W1:highway |
+ | object | class |
+ | W1 | highway |
When updating osm data
"""
w1 Thighway=unclassified Nn100,n101
"""
Then place contains exactly
- | object |
- | W1:highway |
+ | object | class |
+ | W1 | highway |
When indexing
Then placex contains exactly
- | object |
- | W1:highway |
+ | object | class |
+ | W1 | highway |
Scenario: Downgrading a highway when a second tag is present
w1 Thighway=residential,tourism=hotel Nn100,n101
"""
Then place contains exactly
- | object | type |
- | W1:highway | residential |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | highway | residential |
+ | W1 | tourism | hotel |
When updating osm data
"""
w1 Thighway=service,tourism=hotel Nn100,n101
"""
Then place contains exactly
- | object | type |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | tourism | hotel |
When indexing
Then placex contains exactly
- | object | type |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | tourism | hotel |
Scenario: Upgrading a highway when a second tag is present
w1 Thighway=service,tourism=hotel Nn100,n101
"""
Then place contains exactly
- | object | type |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | tourism | hotel |
When updating osm data
"""
w1 Thighway=residential,tourism=hotel Nn100,n101
"""
Then place contains exactly
- | object | type |
- | W1:highway | residential |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | highway | residential |
+ | W1 | tourism | hotel |
When indexing
Then placex contains exactly
- | object | type |
- | W1:highway | residential |
- | W1:tourism | hotel |
+ | object | class | type |
+ | W1 | highway | residential |
+ | W1 | tourism | hotel |
Scenario: Replay on administrative boundary
w10 Tboundary=administrative,waterway=river,name=Border,admin_level=2 Nn12,n11,n10
"""
Then place contains exactly
- | object | type | admin_level | name |
- | W10:waterway | river | 2 | 'name': 'Border' |
- | W10:boundary | administrative | 2 | 'name': 'Border' |
+ | object | class | type | admin_level | name!dict |
+ | W10 | waterway | river | 2 | 'name': 'Border' |
+ | W10 | boundary | administrative | 2 | 'name': 'Border' |
When updating osm data
"""
w10 Tboundary=administrative,waterway=river,name=Border,admin_level=2 Nn12,n11,n10
"""
Then place contains exactly
- | object | type | admin_level | name |
- | W10:waterway | river | 2 | 'name': 'Border' |
- | W10:boundary | administrative | 2 | 'name': 'Border' |
+ | object | class | type | admin_level | name!dict |
+ | W10 | waterway | river | 2 | 'name': 'Border' |
+ | W10 | boundary | administrative | 2 | 'name': 'Border' |
When indexing
Then placex contains exactly
- | object | type | admin_level | name |
- | W10:waterway | river | 2 | 'name': 'Border' |
+ | object | class | type | admin_level | name!dict |
+ | W10 | waterway | river | 2 | 'name': 'Border' |
Scenario: Change admin_level on administrative boundary
r10 Ttype=multipolygon,boundary=administrative,name=Border,admin_level=2 Mw10@
"""
Then place contains exactly
- | object | admin_level |
- | R10:boundary | 2 |
+ | object | class | admin_level |
+ | R10 | boundary | 2 |
When updating osm data
"""
r10 Ttype=multipolygon,boundary=administrative,name=Border,admin_level=4 Mw10@
"""
Then place contains exactly
- | object | type | admin_level |
- | R10:boundary | administrative | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | administrative | 4 |
When indexing
Then placex contains exactly
- | object | type | admin_level |
- | R10:boundary | administrative | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | administrative | 4 |
Scenario: Change boundary to administrative
r10 Ttype=multipolygon,boundary=informal,name=Border,admin_level=4 Mw10@
"""
Then place contains exactly
- | object | type | admin_level |
- | R10:boundary | informal | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | informal | 4 |
When updating osm data
"""
r10 Ttype=multipolygon,boundary=administrative,name=Border,admin_level=4 Mw10@
"""
Then place contains exactly
- | object | type | admin_level |
- | R10:boundary | administrative | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | administrative | 4 |
When indexing
Then placex contains exactly
- | object | type | admin_level |
- | R10:boundary | administrative | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | administrative | 4 |
Scenario: Change boundary away from administrative
r10 Ttype=multipolygon,boundary=administrative,name=Border,admin_level=4 Mw10@
"""
Then place contains exactly
- | object | type | admin_level |
- | R10:boundary | administrative | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | administrative | 4 |
When updating osm data
"""
r10 Ttype=multipolygon,boundary=informal,name=Border,admin_level=4 Mw10@
"""
Then place contains exactly
- | object | type | admin_level |
- | R10:boundary | informal | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | informal | 4 |
When indexing
Then placex contains exactly
- | object | type | admin_level |
- | R10:boundary | informal | 4 |
+ | object | class | type | admin_level |
+ | R10 | boundary | informal | 4 |
Scenario: Main tag and geometry is changed
w5 Tbuilding=house,name=Foo Nn1,n2,n3,n4,n1
"""
Then place contains exactly
- | object | type |
- | W5:building | house |
+ | object | class | type |
+ | W5 | building | house |
When updating osm data
"""
w5 Tbuilding=terrace,name=Bar Nn1,n2,n3,n4,n1
"""
Then place contains exactly
- | object | type |
- | W5:building | terrace |
+ | object | class | type |
+ | W5 | building | terrace |
+++ /dev/null
-@DB
-Feature: Update of simple objects by osm2pgsql
- Testing basic update functions of osm2pgsql.
-
- Scenario: Adding a new object
- When loading osm data
- """
- n1 Tplace=town,name=Middletown
- """
- Then place contains exactly
- | object | type | name+name |
- | N1:place | town | Middletown |
-
- When updating osm data
- """
- n2 Tamenity=hotel,name=Posthotel
- """
- Then place contains exactly
- | object | type | name+name |
- | N1:place | town | Middletown |
- | N2:amenity | hotel | Posthotel |
- And placex contains exactly
- | object | type | name+name | indexed_status |
- | N1:place | town | Middletown | 0 |
- | N2:amenity | hotel | Posthotel | 1 |
-
-
- Scenario: Deleting an existing object
- When loading osm data
- """
- n1 Tplace=town,name=Middletown
- n2 Tamenity=hotel,name=Posthotel
- """
- Then place contains exactly
- | object | type | name+name |
- | N1:place | town | Middletown |
- | N2:amenity | hotel | Posthotel |
-
- When updating osm data
- """
- n2 dD
- """
- Then place contains exactly
- | object | type | name+name |
- | N1:place | town | Middletown |
- And placex contains exactly
- | object | type | name+name | indexed_status |
- | N1:place | town | Middletown | 0 |
- | N2:amenity | hotel | Posthotel | 100 |
+++ /dev/null
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-"""
-Collection of assertion functions used for the steps.
-"""
-import json
-import math
-import re
-
-
-OSM_TYPE = {'N': 'node', 'W': 'way', 'R': 'relation',
- 'n': 'node', 'w': 'way', 'r': 'relation',
- 'node': 'n', 'way': 'w', 'relation': 'r'}
-
-
-class OsmType:
- """ Compares an OSM type, accepting both N/R/W and node/way/relation.
- """
-
- def __init__(self, value):
- self.value = value
-
- def __eq__(self, other):
- return other == self.value or other == OSM_TYPE[self.value]
-
- def __str__(self):
- return f"{self.value} or {OSM_TYPE[self.value]}"
-
-
-class Field:
- """ Generic comparator for fields, which looks at the type of the
- value compared.
- """
- def __init__(self, value, **extra_args):
- self.value = value
- self.extra_args = extra_args
-
- def __eq__(self, other):
- if isinstance(self.value, float):
- return math.isclose(self.value, float(other), **self.extra_args)
-
- if self.value.startswith('^'):
- return re.fullmatch(self.value, str(other))
-
- if isinstance(other, dict):
- return other == eval('{' + self.value + '}')
-
- return str(self.value) == str(other)
-
- def __str__(self):
- return str(self.value)
-
-
-class Bbox:
- """ Comparator for bounding boxes.
- """
- def __init__(self, bbox_string):
- self.coord = [float(x) for x in bbox_string.split(',')]
-
- def __contains__(self, item):
- if isinstance(item, str):
- item = item.split(',')
- item = list(map(float, item))
-
- if len(item) == 2:
- return self.coord[0] <= item[0] <= self.coord[2] \
- and self.coord[1] <= item[1] <= self.coord[3]
-
- if len(item) == 4:
- return item[0] >= self.coord[0] and item[1] <= self.coord[1] \
- and item[2] >= self.coord[2] and item[3] <= self.coord[3]
-
- raise ValueError("Not a coordinate or bbox.")
-
- def __str__(self):
- return str(self.coord)
-
-
-def check_for_attributes(obj, attrs, presence='present'):
- """ Check that the object has the given attributes. 'attrs' is a
- string with a comma-separated list of attributes. If 'presence'
- is set to 'absent' then the function checks that the attributes do
- not exist for the object
- """
- def _dump_json():
- return json.dumps(obj, sort_keys=True, indent=2, ensure_ascii=False)
-
- for attr in attrs.split(','):
- attr = attr.strip()
- if presence == 'absent':
- assert attr not in obj, \
- f"Unexpected attribute {attr}. Full response:\n{_dump_json()}"
- else:
- assert attr in obj, \
- f"No attribute '{attr}'. Full response:\n{_dump_json()}"
+++ /dev/null
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-from steps.geometry_alias import ALIASES
-
-
-class GeometryFactory:
- """ Provides functions to create geometries from coordinates and data grids.
- """
-
- def __init__(self):
- self.grid = {}
-
- def parse_geometry(self, geom):
- """ Create a WKT SQL term for the given geometry.
- The function understands the following formats:
-
- country:<country code>
- Point geometry guaranteed to be in the given country
- <P>
- Point geometry
- <P>,...,<P>
- Line geometry
- (<P>,...,<P>)
- Polygon geometry
-
- <P> may either be a coordinate of the form '<x> <y>' or a single
- number. In the latter case it must refer to a point in
- a previously defined grid.
- """
- if geom.startswith('country:'):
- ccode = geom[8:].upper()
- assert ccode in ALIASES, "Geometry error: unknown country " + ccode
- return "ST_SetSRID('POINT({} {})'::geometry, 4326)".format(*ALIASES[ccode])
-
- if geom.find(',') < 0:
- out = "POINT({})".format(self.mk_wkt_point(geom))
- elif geom.find('(') < 0:
- out = "LINESTRING({})".format(self.mk_wkt_points(geom))
- else:
- out = "POLYGON(({}))".format(self.mk_wkt_points(geom.strip('() ')))
-
- return "ST_SetSRID('{}'::geometry, 4326)".format(out)
-
- def mk_wkt_point(self, point):
- """ Parse a point description.
- The point may either consist of 'x y' coordinates or a number
- that refers to a grid setup.
- """
- geom = point.strip()
- if geom.find(' ') >= 0:
- return geom
-
- try:
- pt = self.grid_node(int(geom))
- except ValueError:
- assert False, "Scenario error: Point '{}' is not a number".format(geom)
-
- assert pt is not None, "Scenario error: Point '{}' not found in grid".format(geom)
- return "{} {}".format(*pt)
-
- def mk_wkt_points(self, geom):
- """ Parse a list of points.
- The list must be a comma-separated list of points. Points
- in coordinate and grid format may be mixed.
- """
- return ','.join([self.mk_wkt_point(x) for x in geom.split(',')])
-
- def set_grid(self, lines, grid_step, origin=(0.0, 0.0)):
- """ Replace the grid with one from the given lines.
- """
- self.grid = {}
- y = origin[1]
- for line in lines:
- x = origin[0]
- for pt_id in line:
- if pt_id.isdigit():
- self.grid[int(pt_id)] = (x, y)
- x += grid_step
- y += grid_step
-
- def grid_node(self, nodeid):
- """ Get the coordinates for the given grid node.
- """
- return self.grid.get(nodeid)
+++ /dev/null
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-"""
-Classes wrapping HTTP responses from the Nominatim API.
-"""
-import re
-import json
-import xml.etree.ElementTree as ET
-
-from check_functions import OsmType, Field, check_for_attributes
-
-
-class GenericResponse:
- """ Common base class for all API responses.
- """
- def __init__(self, page, fmt, errorcode=200):
- fmt = fmt.strip()
- if fmt == 'jsonv2':
- fmt = 'json'
-
- self.page = page
- self.format = fmt
- self.errorcode = errorcode
- self.result = []
- self.header = dict()
-
- if errorcode == 200 and fmt != 'debug':
- getattr(self, '_parse_' + fmt)()
-
- def _parse_json(self):
- m = re.fullmatch(r'([\w$][^(]*)\((.*)\)', self.page)
- if m is None:
- code = self.page
- else:
- code = m.group(2)
- self.header['json_func'] = m.group(1)
- self.result = json.JSONDecoder().decode(code)
- if isinstance(self.result, dict):
- if 'error' in self.result:
- self.result = []
- else:
- self.result = [self.result]
-
- def _parse_geojson(self):
- self._parse_json()
- if self.result:
- geojson = self.result[0]
- # check for valid geojson
- check_for_attributes(geojson, 'type,features')
- assert geojson['type'] == 'FeatureCollection'
- assert isinstance(geojson['features'], list)
-
- self.result = []
- for result in geojson['features']:
- check_for_attributes(result, 'type,properties,geometry')
- assert result['type'] == 'Feature'
- new = result['properties']
- check_for_attributes(new, 'geojson', 'absent')
- new['geojson'] = result['geometry']
- if 'bbox' in result:
- check_for_attributes(new, 'boundingbox', 'absent')
- # bbox is minlon, minlat, maxlon, maxlat
- # boundingbox is minlat, maxlat, minlon, maxlon
- new['boundingbox'] = [result['bbox'][1],
- result['bbox'][3],
- result['bbox'][0],
- result['bbox'][2]]
- for k, v in geojson.items():
- if k not in ('type', 'features'):
- check_for_attributes(new, '__' + k, 'absent')
- new['__' + k] = v
- self.result.append(new)
-
- def _parse_geocodejson(self):
- self._parse_geojson()
- if self.result:
- for r in self.result:
- assert set(r.keys()) == {'geocoding', 'geojson', '__geocoding'}, \
- f"Unexpected keys in result: {r.keys()}"
- check_for_attributes(r['geocoding'], 'geojson', 'absent')
- inner = r.pop('geocoding')
- r.update(inner)
-
- def assert_address_field(self, idx, field, value):
- """ Check that result rows`idx` has a field `field` with value `value`
- in its address. If idx is None, then all results are checked.
- """
- if idx is None:
- todo = range(len(self.result))
- else:
- todo = [int(idx)]
-
- for idx in todo:
- self.check_row(idx, 'address' in self.result[idx], "No field 'address'")
-
- address = self.result[idx]['address']
- self.check_row_field(idx, field, value, base=address)
-
- def match_row(self, row, context=None, field=None):
- """ Match the result fields against the given behave table row.
- """
- if 'ID' in row.headings:
- todo = [int(row['ID'])]
- else:
- todo = range(len(self.result))
-
- for i in todo:
- subdict = self.result[i]
- if field is not None:
- for key in field.split('.'):
- self.check_row(i, key in subdict, f"Missing subfield {key}")
- subdict = subdict[key]
- self.check_row(i, isinstance(subdict, dict),
- f"Subfield {key} not a dict")
-
- for name, value in zip(row.headings, row.cells):
- if name == 'ID':
- pass
- elif name == 'osm':
- self.check_row_field(i, 'osm_type', OsmType(value[0]), base=subdict)
- self.check_row_field(i, 'osm_id', Field(value[1:]), base=subdict)
- elif name == 'centroid':
- if ' ' in value:
- lon, lat = value.split(' ')
- elif context is not None:
- lon, lat = context.osm.grid_node(int(value))
- else:
- raise RuntimeError("Context needed when using grid coordinates")
- self.check_row_field(i, 'lat', Field(float(lat), abs_tol=1e-07), base=subdict)
- self.check_row_field(i, 'lon', Field(float(lon), abs_tol=1e-07), base=subdict)
- else:
- self.check_row_field(i, name, Field(value), base=subdict)
-
- def check_row(self, idx, check, msg):
- """ Assert for the condition 'check' and print 'msg' on fail together
- with the contents of the failing result.
- """
- class _RowError:
- def __init__(self, row):
- self.row = row
-
- def __str__(self):
- return f"{msg}. Full row {idx}:\n" \
- + json.dumps(self.row, indent=4, ensure_ascii=False)
-
- assert check, _RowError(self.result[idx])
-
- def check_row_field(self, idx, field, expected, base=None):
- """ Check field 'field' of result 'idx' for the expected value
- and print a meaningful error if the condition fails.
- When 'base' is set to a dictionary, then the field is checked
- in that base. The error message will still report the contents
- of the full result.
- """
- if base is None:
- base = self.result[idx]
-
- self.check_row(idx, field in base, f"No field '{field}'")
- value = base[field]
-
- self.check_row(idx, expected == value,
- f"\nBad value for field '{field}'. Expected: {expected}, got: {value}")
-
-
-class SearchResponse(GenericResponse):
- """ Specialised class for search and lookup responses.
- Transforms the xml response in a format similar to json.
- """
-
- def _parse_xml(self):
- xml_tree = ET.fromstring(self.page)
-
- self.header = dict(xml_tree.attrib)
-
- for child in xml_tree:
- assert child.tag == "place"
- self.result.append(dict(child.attrib))
-
- address = {}
- for sub in child:
- if sub.tag == 'extratags':
- self.result[-1]['extratags'] = {}
- for tag in sub:
- self.result[-1]['extratags'][tag.attrib['key']] = tag.attrib['value']
- elif sub.tag == 'namedetails':
- self.result[-1]['namedetails'] = {}
- for tag in sub:
- self.result[-1]['namedetails'][tag.attrib['desc']] = tag.text
- elif sub.tag == 'geokml':
- self.result[-1][sub.tag] = True
- else:
- address[sub.tag] = sub.text
-
- if address:
- self.result[-1]['address'] = address
-
-
-class ReverseResponse(GenericResponse):
- """ Specialised class for reverse responses.
- Transforms the xml response in a format similar to json.
- """
-
- def _parse_xml(self):
- xml_tree = ET.fromstring(self.page)
-
- self.header = dict(xml_tree.attrib)
- self.result = []
-
- for child in xml_tree:
- if child.tag == 'result':
- assert not self.result, "More than one result in reverse result"
- self.result.append(dict(child.attrib))
- check_for_attributes(self.result[0], 'display_name', 'absent')
- self.result[0]['display_name'] = child.text
- elif child.tag == 'addressparts':
- assert 'address' not in self.result[0], "More than one address in result"
- address = {}
- for sub in child:
- assert len(sub) == 0, f"Address element '{sub.tag}' has subelements"
- address[sub.tag] = sub.text
- self.result[0]['address'] = address
- elif child.tag == 'extratags':
- assert 'extratags' not in self.result[0], "More than one extratags in result"
- self.result[0]['extratags'] = {}
- for tag in child:
- assert len(tag) == 0, f"Extratags element '{tag.attrib['key']}' has subelements"
- self.result[0]['extratags'][tag.attrib['key']] = tag.attrib['value']
- elif child.tag == 'namedetails':
- assert 'namedetails' not in self.result[0], "More than one namedetails in result"
- self.result[0]['namedetails'] = {}
- for tag in child:
- assert len(tag) == 0, \
- f"Namedetails element '{tag.attrib['desc']}' has subelements"
- self.result[0]['namedetails'][tag.attrib['desc']] = tag.text
- elif child.tag == 'geokml':
- assert 'geokml' not in self.result[0], "More than one geokml in result"
- self.result[0]['geokml'] = ET.tostring(child, encoding='unicode')
- else:
- assert child.tag == 'error', \
- f"Unknown XML tag {child.tag} on page: {self.page}"
-
-
-class StatusResponse(GenericResponse):
- """ Specialised class for status responses.
- Can also parse text responses.
- """
-
- def _parse_text(self):
- pass
+++ /dev/null
-# SPDX-License-Identifier: GPL-3.0-or-later
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-from pathlib import Path
-import tempfile
-
-import psycopg
-from psycopg import sql as pysql
-
-from nominatim_db import cli
-from nominatim_db.config import Configuration
-from nominatim_db.db.connection import register_hstore, execute_scalar
-from nominatim_db.tokenizer import factory as tokenizer_factory
-
-
-class NominatimEnvironment:
- """ Collects all functions for the execution of Nominatim functions.
- """
-
- def __init__(self, config):
- self.src_dir = (Path(__file__) / '..' / '..' / '..' / '..').resolve()
- self.db_host = config['DB_HOST']
- self.db_port = config['DB_PORT']
- self.db_user = config['DB_USER']
- self.db_pass = config['DB_PASS']
- self.template_db = config['TEMPLATE_DB']
- self.test_db = config['TEST_DB']
- self.api_test_db = config['API_TEST_DB']
- self.api_test_file = config['API_TEST_FILE']
- self.tokenizer = config['TOKENIZER']
- self.import_style = config['STYLE']
- self.reuse_template = not config['REMOVE_TEMPLATE']
- self.keep_scenario_db = config['KEEP_TEST_DB']
-
- self.default_config = Configuration(None).get_os_env()
- self.test_env = None
- self.template_db_done = False
- self.api_db_done = False
- self.website_dir = None
-
- if not hasattr(self, f"create_api_request_func_{config['API_ENGINE']}"):
- raise RuntimeError(f"Unknown API engine '{config['API_ENGINE']}'")
- self.api_engine = getattr(self, f"create_api_request_func_{config['API_ENGINE']}")()
-
- def connect_database(self, dbname):
- """ Return a connection to the database with the given name.
- Uses configured host, user and port.
- """
- dbargs = {'dbname': dbname, 'row_factory': psycopg.rows.dict_row}
- if self.db_host:
- dbargs['host'] = self.db_host
- if self.db_port:
- dbargs['port'] = self.db_port
- if self.db_user:
- dbargs['user'] = self.db_user
- if self.db_pass:
- dbargs['password'] = self.db_pass
- return psycopg.connect(**dbargs)
-
- def write_nominatim_config(self, dbname):
- """ Set up a custom test configuration that connects to the given
- database. This sets up the environment variables so that they can
- be picked up by dotenv and creates a project directory with the
- appropriate website scripts.
- """
- if dbname.startswith('sqlite:'):
- dsn = 'sqlite:dbname={}'.format(dbname[7:])
- else:
- dsn = 'pgsql:dbname={}'.format(dbname)
- if self.db_host:
- dsn += ';host=' + self.db_host
- if self.db_port:
- dsn += ';port=' + self.db_port
- if self.db_user:
- dsn += ';user=' + self.db_user
- if self.db_pass:
- dsn += ';password=' + self.db_pass
-
- self.test_env = dict(self.default_config)
- self.test_env['NOMINATIM_DATABASE_DSN'] = dsn
- self.test_env['NOMINATIM_LANGUAGES'] = 'en,de,fr,ja'
- self.test_env['NOMINATIM_FLATNODE_FILE'] = ''
- self.test_env['NOMINATIM_IMPORT_STYLE'] = 'full'
- self.test_env['NOMINATIM_USE_US_TIGER_DATA'] = 'yes'
- self.test_env['NOMINATIM_DATADIR'] = str((self.src_dir / 'data').resolve())
- self.test_env['NOMINATIM_SQLDIR'] = str((self.src_dir / 'lib-sql').resolve())
- self.test_env['NOMINATIM_CONFIGDIR'] = str((self.src_dir / 'settings').resolve())
- if self.tokenizer is not None:
- self.test_env['NOMINATIM_TOKENIZER'] = self.tokenizer
- if self.import_style is not None:
- self.test_env['NOMINATIM_IMPORT_STYLE'] = self.import_style
-
- if self.website_dir is not None:
- self.website_dir.cleanup()
-
- self.website_dir = tempfile.TemporaryDirectory()
-
- def get_test_config(self):
- cfg = Configuration(Path(self.website_dir.name), environ=self.test_env)
- return cfg
-
- def get_libpq_dsn(self):
- dsn = self.test_env['NOMINATIM_DATABASE_DSN']
-
- def quote_param(param):
- key, val = param.split('=')
- val = val.replace('\\', '\\\\').replace("'", "\\'")
- if ' ' in val:
- val = "'" + val + "'"
- return key + '=' + val
-
- if dsn.startswith('pgsql:'):
- # Old PHP DSN format. Convert before returning.
- return ' '.join([quote_param(p) for p in dsn[6:].split(';')])
-
- return dsn
-
- def db_drop_database(self, name):
- """ Drop the database with the given name.
- """
- with self.connect_database('postgres') as conn:
- conn.autocommit = True
- conn.execute(pysql.SQL('DROP DATABASE IF EXISTS')
- + pysql.Identifier(name))
-
- def setup_template_db(self):
- """ Setup a template database that already contains common test data.
- Having a template database speeds up tests considerably but at
- the price that the tests sometimes run with stale data.
- """
- if self.template_db_done:
- return
-
- self.template_db_done = True
-
- self.write_nominatim_config(self.template_db)
-
- if not self._reuse_or_drop_db(self.template_db):
- try:
- # execute nominatim import on an empty file to get the right tables
- with tempfile.NamedTemporaryFile(dir='/tmp', suffix='.xml') as fd:
- fd.write(b'<osm version="0.6"></osm>')
- fd.flush()
- self.run_nominatim('import', '--osm-file', fd.name,
- '--osm2pgsql-cache', '1',
- '--ignore-errors',
- '--offline', '--index-noanalyse')
- except: # noqa: E722
- self.db_drop_database(self.template_db)
- raise
-
- self.run_nominatim('refresh', '--functions')
-
- def setup_api_db(self):
- """ Setup a test against the API test database.
- """
- self.write_nominatim_config(self.api_test_db)
-
- if self.api_test_db.startswith('sqlite:'):
- return
-
- if not self.api_db_done:
- self.api_db_done = True
-
- if not self._reuse_or_drop_db(self.api_test_db):
- testdata = (Path(__file__) / '..' / '..' / '..' / 'testdb').resolve()
- self.test_env['NOMINATIM_WIKIPEDIA_DATA_PATH'] = str(testdata)
- simp_file = Path(self.website_dir.name) / 'secondary_importance.sql.gz'
- simp_file.symlink_to(testdata / 'secondary_importance.sql.gz')
-
- try:
- self.run_nominatim('import', '--osm-file', str(self.api_test_file))
- self.run_nominatim('add-data', '--tiger-data', str(testdata / 'tiger'))
- self.run_nominatim('freeze')
-
- csv_path = str(testdata / 'full_en_phrases_test.csv')
- self.run_nominatim('special-phrases', '--import-from-csv', csv_path)
- except: # noqa: E722
- self.db_drop_database(self.api_test_db)
- raise
-
- tokenizer_factory.get_tokenizer_for_db(self.get_test_config())
-
- def setup_unknown_db(self):
- """ Setup a test against a non-existing database.
- """
- # The tokenizer needs an existing database to function.
- # So start with the usual database
- class _Context:
- db = None
-
- context = _Context()
- self.setup_db(context)
- tokenizer_factory.create_tokenizer(self.get_test_config(), init_db=False)
-
- # Then drop the DB again
- self.teardown_db(context, force_drop=True)
-
- def setup_db(self, context):
- """ Setup a test against a fresh, empty test database.
- """
- self.setup_template_db()
- with self.connect_database(self.template_db) as conn:
- conn.autocommit = True
- conn.execute(pysql.SQL('DROP DATABASE IF EXISTS')
- + pysql.Identifier(self.test_db))
- conn.execute(pysql.SQL('CREATE DATABASE {} TEMPLATE = {}').format(
- pysql.Identifier(self.test_db),
- pysql.Identifier(self.template_db)))
-
- self.write_nominatim_config(self.test_db)
- context.db = self.connect_database(self.test_db)
- context.db.autocommit = True
- register_hstore(context.db)
-
- def teardown_db(self, context, force_drop=False):
- """ Remove the test database, if it exists.
- """
- if hasattr(context, 'db'):
- context.db.close()
-
- if force_drop or not self.keep_scenario_db:
- self.db_drop_database(self.test_db)
-
- def _reuse_or_drop_db(self, name):
- """ Check for the existence of the given DB. If reuse is enabled,
- then the function checks for existnce and returns True if the
- database is already there. Otherwise an existing database is
- dropped and always false returned.
- """
- if self.reuse_template:
- with self.connect_database('postgres') as conn:
- num = execute_scalar(conn,
- 'select count(*) from pg_database where datname = %s',
- (name,))
- if num == 1:
- return True
- else:
- self.db_drop_database(name)
-
- return False
-
- def reindex_placex(self, db):
- """ Run the indexing step until all data in the placex has
- been processed. Indexing during updates can produce more data
- to index under some circumstances. That is why indexing may have
- to be run multiple times.
- """
- self.run_nominatim('index')
-
- def run_nominatim(self, *cmdline):
- """ Run the nominatim command-line tool via the library.
- """
- if self.website_dir is not None:
- cmdline = list(cmdline) + ['--project-dir', self.website_dir.name]
-
- cli.nominatim(cli_args=cmdline,
- environ=self.test_env)
-
- def copy_from_place(self, db):
- """ Copy data from place to the placex and location_property_osmline
- tables invoking the appropriate triggers.
- """
- self.run_nominatim('refresh', '--functions', '--no-diff-updates')
-
- with db.cursor() as cur:
- cur.execute("""INSERT INTO placex (osm_type, osm_id, class, type,
- name, admin_level, address,
- extratags, geometry)
- SELECT osm_type, osm_id, class, type,
- name, admin_level, address,
- extratags, geometry
- FROM place
- WHERE not (class='place' and type='houses' and osm_type='W')""")
- cur.execute("""INSERT INTO location_property_osmline (osm_id, address, linegeo)
- SELECT osm_id, address, geometry
- FROM place
- WHERE class='place' and type='houses'
- and osm_type='W'
- and ST_GeometryType(geometry) = 'ST_LineString'""")
-
- def create_api_request_func_starlette(self):
- import nominatim_api.server.starlette.server
- from asgi_lifespan import LifespanManager
- import httpx
-
- async def _request(endpoint, params, project_dir, environ, http_headers):
- app = nominatim_api.server.starlette.server.get_application(project_dir, environ)
-
- async with LifespanManager(app):
- async with httpx.AsyncClient(app=app, base_url="http://nominatim.test") as client:
- response = await client.get(f"/{endpoint}", params=params,
- headers=http_headers)
-
- return response.text, response.status_code
-
- return _request
-
- def create_api_request_func_falcon(self):
- import nominatim_api.server.falcon.server
- import falcon.testing
-
- async def _request(endpoint, params, project_dir, environ, http_headers):
- app = nominatim_api.server.falcon.server.get_application(project_dir, environ)
-
- async with falcon.testing.ASGIConductor(app) as conductor:
- response = await conductor.get(f"/{endpoint}", params=params,
- headers=http_headers)
-
- return response.text, response.status_code
-
- return _request
+++ /dev/null
-# SPDX-License-Identifier: GPL-3.0-or-later
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-""" Steps that run queries against the API.
-"""
-from pathlib import Path
-import re
-import logging
-import asyncio
-import xml.etree.ElementTree as ET
-
-from http_responses import GenericResponse, SearchResponse, ReverseResponse, StatusResponse
-from check_functions import Bbox, check_for_attributes
-from table_compare import NominatimID
-
-LOG = logging.getLogger(__name__)
-
-
-def make_todo_list(context, result_id):
- if result_id is None:
- context.execute_steps("then at least 1 result is returned")
- return range(len(context.response.result))
-
- context.execute_steps(f"then more than {result_id}results are returned")
- return (int(result_id.strip()), )
-
-
-def compare(operator, op1, op2):
- if operator == 'less than':
- return op1 < op2
- elif operator == 'more than':
- return op1 > op2
- elif operator == 'exactly':
- return op1 == op2
- elif operator == 'at least':
- return op1 >= op2
- elif operator == 'at most':
- return op1 <= op2
- else:
- raise ValueError(f"Unknown operator '{operator}'")
-
-
-def send_api_query(endpoint, params, fmt, context):
- if fmt is not None:
- if fmt.strip() == 'debug':
- params['debug'] = '1'
- else:
- params['format'] = fmt.strip()
-
- if context.table:
- if context.table.headings[0] == 'param':
- for line in context.table:
- params[line['param']] = line['value']
- else:
- for h in context.table.headings:
- params[h] = context.table[0][h]
-
- return asyncio.run(context.nominatim.api_engine(endpoint, params,
- Path(context.nominatim.website_dir.name),
- context.nominatim.test_env,
- getattr(context, 'http_headers', {})))
-
-
-@given('the HTTP header')
-def add_http_header(context):
- if not hasattr(context, 'http_headers'):
- context.http_headers = {}
-
- for h in context.table.headings:
- context.http_headers[h] = context.table[0][h]
-
-
-@when(r'sending (?P<fmt>\S+ )?search query "(?P<query>.*)"(?P<addr> with address)?')
-def website_search_request(context, fmt, query, addr):
- params = {}
- if query:
- params['q'] = query
- if addr is not None:
- params['addressdetails'] = '1'
-
- outp, status = send_api_query('search', params, fmt, context)
-
- context.response = SearchResponse(outp, fmt or 'json', status)
-
-
-@when(r'sending v1/reverse at (?P<lat>[\d.-]*),(?P<lon>[\d.-]*)(?: with format (?P<fmt>.+))?')
-def api_endpoint_v1_reverse(context, lat, lon, fmt):
- params = {}
- if lat is not None:
- params['lat'] = lat
- if lon is not None:
- params['lon'] = lon
- if fmt is None:
- fmt = 'jsonv2'
- elif fmt == "''":
- fmt = None
-
- outp, status = send_api_query('reverse', params, fmt, context)
- context.response = ReverseResponse(outp, fmt or 'xml', status)
-
-
-@when(r'sending v1/reverse N(?P<nodeid>\d+)(?: with format (?P<fmt>.+))?')
-def api_endpoint_v1_reverse_from_node(context, nodeid, fmt):
- params = {}
- params['lon'], params['lat'] = (f'{c:f}' for c in context.osm.grid_node(int(nodeid)))
-
- outp, status = send_api_query('reverse', params, fmt, context)
- context.response = ReverseResponse(outp, fmt or 'xml', status)
-
-
-@when(r'sending (?P<fmt>\S+ )?details query for (?P<query>.*)')
-def website_details_request(context, fmt, query):
- params = {}
- if query[0] in 'NWR':
- nid = NominatimID(query)
- params['osmtype'] = nid.typ
- params['osmid'] = nid.oid
- if nid.cls:
- params['class'] = nid.cls
- else:
- params['place_id'] = query
- outp, status = send_api_query('details', params, fmt, context)
-
- context.response = GenericResponse(outp, fmt or 'json', status)
-
-
-@when(r'sending (?P<fmt>\S+ )?lookup query for (?P<query>.*)')
-def website_lookup_request(context, fmt, query):
- params = {'osm_ids': query}
- outp, status = send_api_query('lookup', params, fmt, context)
-
- context.response = SearchResponse(outp, fmt or 'xml', status)
-
-
-@when(r'sending (?P<fmt>\S+ )?status query')
-def website_status_request(context, fmt):
- params = {}
- outp, status = send_api_query('status', params, fmt, context)
-
- context.response = StatusResponse(outp, fmt or 'text', status)
-
-
-@step(r'(?P<operator>less than|more than|exactly|at least|at most) '
- r'(?P<number>\d+) results? (?:is|are) returned')
-def validate_result_number(context, operator, number):
- context.execute_steps("Then a HTTP 200 is returned")
- numres = len(context.response.result)
- assert compare(operator, numres, int(number)), \
- f"Bad number of results: expected {operator} {number}, got {numres}."
-
-
-@then(r'a HTTP (?P<status>\d+) is returned')
-def check_http_return_status(context, status):
- assert context.response.errorcode == int(status), \
- f"Return HTTP status is {context.response.errorcode}."\
- f" Full response:\n{context.response.page}"
-
-
-@then(r'the page contents equals "(?P<text>.+)"')
-def check_page_content_equals(context, text):
- assert context.response.page == text
-
-
-@then(r'the result is valid (?P<fmt>\w+)')
-def step_impl(context, fmt):
- context.execute_steps("Then a HTTP 200 is returned")
- if fmt.strip() == 'html':
- try:
- tree = ET.fromstring(context.response.page)
- except Exception as ex:
- assert False, f"Could not parse page: {ex}\n{context.response.page}"
-
- assert tree.tag == 'html'
- body = tree.find('./body')
- assert body is not None
- assert body.find('.//script') is None
- else:
- assert context.response.format == fmt
-
-
-@then(r'a (?P<fmt>\w+) user error is returned')
-def check_page_error(context, fmt):
- context.execute_steps("Then a HTTP 400 is returned")
- assert context.response.format == fmt
-
- if fmt == 'xml':
- assert re.search(r'<error>.+</error>', context.response.page, re.DOTALL) is not None
- else:
- assert re.search(r'({"error":)', context.response.page, re.DOTALL) is not None
-
-
-@then('result header contains')
-def check_header_attr(context):
- context.execute_steps("Then a HTTP 200 is returned")
- for line in context.table:
- assert line['attr'] in context.response.header, \
- f"Field '{line['attr']}' missing in header. " \
- f"Full header:\n{context.response.header}"
- value = context.response.header[line['attr']]
- assert re.fullmatch(line['value'], value) is not None, \
- f"Attribute '{line['attr']}': expected: '{line['value']}', got '{value}'"
-
-
-@then('result header has (?P<neg>not )?attributes (?P<attrs>.*)')
-def check_header_no_attr(context, neg, attrs):
- check_for_attributes(context.response.header, attrs,
- 'absent' if neg else 'present')
-
-
-@then(r'results contain(?: in field (?P<field>.*))?')
-def results_contain_in_field(context, field):
- context.execute_steps("then at least 1 result is returned")
-
- for line in context.table:
- context.response.match_row(line, context=context, field=field)
-
-
-@then(r'result (?P<lid>\d+ )?has (?P<neg>not )?attributes (?P<attrs>.*)')
-def validate_attributes(context, lid, neg, attrs):
- for i in make_todo_list(context, lid):
- check_for_attributes(context.response.result[i], attrs,
- 'absent' if neg else 'present')
-
-
-@then(u'result addresses contain')
-def result_addresses_contain(context):
- context.execute_steps("then at least 1 result is returned")
-
- for line in context.table:
- idx = int(line['ID']) if 'ID' in line.headings else None
-
- for name, value in zip(line.headings, line.cells):
- if name != 'ID':
- context.response.assert_address_field(idx, name, value)
-
-
-@then(r'address of result (?P<lid>\d+) has(?P<neg> no)? types (?P<attrs>.*)')
-def check_address_has_types(context, lid, neg, attrs):
- context.execute_steps(f"then more than {lid} results are returned")
-
- addr_parts = context.response.result[int(lid)]['address']
-
- for attr in attrs.split(','):
- if neg:
- assert attr not in addr_parts
- else:
- assert attr in addr_parts
-
-
-@then(r'address of result (?P<lid>\d+) (?P<complete>is|contains)')
-def check_address(context, lid, complete):
- context.execute_steps(f"then more than {lid} results are returned")
-
- lid = int(lid)
- addr_parts = dict(context.response.result[lid]['address'])
-
- for line in context.table:
- context.response.assert_address_field(lid, line['type'], line['value'])
- del addr_parts[line['type']]
-
- if complete == 'is':
- assert len(addr_parts) == 0, f"Additional address parts found: {addr_parts!s}"
-
-
-@then(r'result (?P<lid>\d+ )?has bounding box in (?P<coords>[\d,.-]+)')
-def check_bounding_box_in_area(context, lid, coords):
- expected = Bbox(coords)
-
- for idx in make_todo_list(context, lid):
- res = context.response.result[idx]
- check_for_attributes(res, 'boundingbox')
- context.response.check_row(idx, res['boundingbox'] in expected,
- f"Bbox is not contained in {expected}")
-
-
-@then(r'result (?P<lid>\d+ )?has centroid in (?P<coords>[\d,.-]+)')
-def check_centroid_in_area(context, lid, coords):
- expected = Bbox(coords)
-
- for idx in make_todo_list(context, lid):
- res = context.response.result[idx]
- check_for_attributes(res, 'lat,lon')
- context.response.check_row(idx, (res['lon'], res['lat']) in expected,
- f"Centroid is not inside {expected}")
-
-
-@then('there are(?P<neg> no)? duplicates')
-def check_for_duplicates(context, neg):
- context.execute_steps("then at least 1 result is returned")
-
- resarr = set()
- has_dupe = False
-
- for res in context.response.result:
- dup = (res['osm_type'], res['class'], res['type'], res['display_name'])
- if dup in resarr:
- has_dupe = True
- break
- resarr.add(dup)
-
- if neg:
- assert not has_dupe, f"Found duplicate for {dup}"
- else:
- assert has_dupe, "No duplicates found"
+++ /dev/null
-# SPDX-License-Identifier: GPL-3.0-or-later
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-from itertools import chain
-
-import psycopg
-from psycopg import sql as pysql
-
-from place_inserter import PlaceColumn
-from table_compare import NominatimID, DBRow
-
-from nominatim_db.tokenizer import factory as tokenizer_factory
-
-
-def check_database_integrity(context):
- """ Check some generic constraints on the tables.
- """
- with context.db.cursor(row_factory=psycopg.rows.tuple_row) as cur:
- # place_addressline should not have duplicate (place_id, address_place_id)
- cur.execute("""SELECT count(*) FROM
- (SELECT place_id, address_place_id, count(*) as c
- FROM place_addressline GROUP BY place_id, address_place_id) x
- WHERE c > 1""")
- assert cur.fetchone()[0] == 0, "Duplicates found in place_addressline"
-
- # word table must not have empty word_tokens
- cur.execute("SELECT count(*) FROM word WHERE word_token = ''")
- assert cur.fetchone()[0] == 0, "Empty word tokens found in word table"
-
-# GIVEN ##################################
-
-
-@given("the (?P<named>named )?places")
-def add_data_to_place_table(context, named):
- """ Add entries into the place table. 'named places' makes sure that
- the entries get a random name when none is explicitly given.
- """
- with context.db.cursor() as cur:
- cur.execute('ALTER TABLE place DISABLE TRIGGER place_before_insert')
- for row in context.table:
- PlaceColumn(context).add_row(row, named is not None).db_insert(cur)
- cur.execute('ALTER TABLE place ENABLE TRIGGER place_before_insert')
-
-
-@given("the relations")
-def add_data_to_planet_relations(context):
- """ Add entries into the osm2pgsql relation middle table. This is needed
- for tests on data that looks up members.
- """
- with context.db.cursor() as cur:
- cur.execute("SELECT value FROM osm2pgsql_properties WHERE property = 'db_format'")
- row = cur.fetchone()
- if row is None or row['value'] == '1':
- for r in context.table:
- last_node = 0
- last_way = 0
- parts = []
- if r['members']:
- members = []
- for m in r['members'].split(','):
- mid = NominatimID(m)
- if mid.typ == 'N':
- parts.insert(last_node, int(mid.oid))
- last_node += 1
- last_way += 1
- elif mid.typ == 'W':
- parts.insert(last_way, int(mid.oid))
- last_way += 1
- else:
- parts.append(int(mid.oid))
-
- members.extend((mid.typ.lower() + mid.oid, mid.cls or ''))
- else:
- members = None
-
- tags = chain.from_iterable([(h[5:], r[h]) for h in r.headings
- if h.startswith("tags+")])
-
- cur.execute("""INSERT INTO planet_osm_rels (id, way_off, rel_off,
- parts, members, tags)
- VALUES (%s, %s, %s, %s, %s, %s)""",
- (r['id'], last_node, last_way, parts, members, list(tags)))
- else:
- for r in context.table:
- if r['members']:
- members = []
- for m in r['members'].split(','):
- mid = NominatimID(m)
- members.append({'ref': mid.oid, 'role': mid.cls or '', 'type': mid.typ})
- else:
- members = []
-
- tags = {h[5:]: r[h] for h in r.headings if h.startswith("tags+")}
-
- cur.execute("""INSERT INTO planet_osm_rels (id, tags, members)
- VALUES (%s, %s, %s)""",
- (r['id'], psycopg.types.json.Json(tags),
- psycopg.types.json.Json(members)))
-
-
-@given("the ways")
-def add_data_to_planet_ways(context):
- """ Add entries into the osm2pgsql way middle table. This is necessary for
- tests on that that looks up node ids in this table.
- """
- with context.db.cursor() as cur:
- cur.execute("SELECT value FROM osm2pgsql_properties WHERE property = 'db_format'")
- row = cur.fetchone()
- json_tags = row is not None and row['value'] != '1'
- for r in context.table:
- if json_tags:
- tags = psycopg.types.json.Json({h[5:]: r[h] for h in r.headings
- if h.startswith("tags+")})
- else:
- tags = list(chain.from_iterable([(h[5:], r[h])
- for h in r.headings if h.startswith("tags+")]))
- nodes = [int(x.strip()) for x in r['nodes'].split(',')]
-
- cur.execute("INSERT INTO planet_osm_ways (id, nodes, tags) VALUES (%s, %s, %s)",
- (r['id'], nodes, tags))
-
-# WHEN ##################################
-
-
-@when("importing")
-def import_and_index_data_from_place_table(context):
- """ Import data previously set up in the place table.
- """
- context.nominatim.run_nominatim('import', '--continue', 'load-data',
- '--index-noanalyse', '-q',
- '--offline')
-
- check_database_integrity(context)
-
- # Remove the output of the input, when all was right. Otherwise it will be
- # output when there are errors that had nothing to do with the import
- # itself.
- context.log_capture.buffer.clear()
-
-
-@when("updating places")
-def update_place_table(context):
- """ Update the place table with the given data. Also runs all triggers
- related to updates and reindexes the new data.
- """
- context.nominatim.run_nominatim('refresh', '--functions')
- with context.db.cursor() as cur:
- for row in context.table:
- col = PlaceColumn(context).add_row(row, False)
- col.db_delete(cur)
- col.db_insert(cur)
- cur.execute('SELECT flush_deleted_places()')
-
- context.nominatim.reindex_placex(context.db)
- check_database_integrity(context)
-
- # Remove the output of the input, when all was right. Otherwise it will be
- # output when there are errors that had nothing to do with the import
- # itself.
- context.log_capture.buffer.clear()
-
-
-@when("updating postcodes")
-def update_postcodes(context):
- """ Rerun the calculation of postcodes.
- """
- context.nominatim.run_nominatim('refresh', '--postcodes')
-
-
-@when("marking for delete (?P<oids>.*)")
-def delete_places(context, oids):
- """ Remove entries from the place table. Multiple ids may be given
- separated by commas. Also runs all triggers
- related to updates and reindexes the new data.
- """
- context.nominatim.run_nominatim('refresh', '--functions')
- with context.db.cursor() as cur:
- cur.execute('TRUNCATE place_to_be_deleted')
- for oid in oids.split(','):
- NominatimID(oid).query_osm_id(cur, 'DELETE FROM place WHERE {}')
- cur.execute('SELECT flush_deleted_places()')
-
- context.nominatim.reindex_placex(context.db)
-
- # Remove the output of the input, when all was right. Otherwise it will be
- # output when there are errors that had nothing to do with the import
- # itself.
- context.log_capture.buffer.clear()
-
-# THEN ##################################
-
-
-@then("(?P<table>placex|place) contains(?P<exact> exactly)?")
-def check_place_contents(context, table, exact):
- """ Check contents of place/placex tables. Each row represents a table row
- and all data must match. Data not present in the expected table, may
- be arbitrary. The rows are identified via the 'object' column which must
- have an identifier of the form '<NRW><osm id>[:<class>]'. When multiple
- rows match (for example because 'class' was left out and there are
- multiple entries for the given OSM object) then all must match. All
- expected rows are expected to be present with at least one database row.
- When 'exactly' is given, there must not be additional rows in the database.
- """
- with context.db.cursor() as cur:
- expected_content = set()
- for row in context.table:
- nid = NominatimID(row['object'])
- query = """SELECT *, ST_AsText(geometry) as geomtxt,
- ST_GeometryType(geometry) as geometrytype """
- if table == 'placex':
- query += ' ,ST_X(centroid) as cx, ST_Y(centroid) as cy'
- query += " FROM %s WHERE {}" % (table, )
- nid.query_osm_id(cur, query)
- assert cur.rowcount > 0, "No rows found for " + row['object']
-
- for res in cur:
- if exact:
- expected_content.add((res['osm_type'], res['osm_id'], res['class']))
-
- DBRow(nid, res, context).assert_row(row, ['object'])
-
- if exact:
- cur.execute(pysql.SQL('SELECT osm_type, osm_id, class from')
- + pysql.Identifier(table))
- actual = set([(r['osm_type'], r['osm_id'], r['class']) for r in cur])
- assert expected_content == actual, \
- f"Missing entries: {expected_content - actual}\n" \
- f"Not expected in table: {actual - expected_content}"
-
-
-@then("(?P<table>placex|place) has no entry for (?P<oid>.*)")
-def check_place_has_entry(context, table, oid):
- """ Ensure that no database row for the given object exists. The ID
- must be of the form '<NRW><osm id>[:<class>]'.
- """
- with context.db.cursor() as cur:
- NominatimID(oid).query_osm_id(cur, "SELECT * FROM %s where {}" % table)
- assert cur.rowcount == 0, \
- "Found {} entries for ID {}".format(cur.rowcount, oid)
-
-
-@then("search_name contains(?P<exclude> not)?")
-def check_search_name_contents(context, exclude):
- """ Check contents of place/placex tables. Each row represents a table row
- and all data must match. Data not present in the expected table, may
- be arbitrary. The rows are identified via the 'object' column which must
- have an identifier of the form '<NRW><osm id>[:<class>]'. All
- expected rows are expected to be present with at least one database row.
- """
- tokenizer = tokenizer_factory.get_tokenizer_for_db(context.nominatim.get_test_config())
-
- with tokenizer.name_analyzer() as analyzer:
- with context.db.cursor() as cur:
- for row in context.table:
- nid = NominatimID(row['object'])
- nid.row_by_place_id(cur, 'search_name',
- ['ST_X(centroid) as cx', 'ST_Y(centroid) as cy'])
- assert cur.rowcount > 0, "No rows found for " + row['object']
-
- for res in cur:
- db_row = DBRow(nid, res, context)
- for name, value in zip(row.headings, row.cells):
- if name in ('name_vector', 'nameaddress_vector'):
- items = [x.strip() for x in value.split(',')]
- tokens = analyzer.get_word_token_info(items)
-
- if not exclude:
- assert len(tokens) >= len(items), \
- f"No word entry found for {value}. Entries found: {len(tokens)}"
- for word, token, wid in tokens:
- if exclude:
- assert wid not in res[name], \
- "Found term for {}/{}: {}".format(nid, name, wid)
- else:
- assert wid in res[name], \
- "Missing term for {}/{}: {}".format(nid, name, wid)
- elif name != 'object':
- assert db_row.contains(name, value), db_row.assert_msg(name, value)
-
-
-@then("search_name has no entry for (?P<oid>.*)")
-def check_search_name_has_entry(context, oid):
- """ Check that there is noentry in the search_name table for the given
- objects. IDs are in format '<NRW><osm id>[:<class>]'.
- """
- with context.db.cursor() as cur:
- NominatimID(oid).row_by_place_id(cur, 'search_name')
-
- assert cur.rowcount == 0, \
- "Found {} entries for ID {}".format(cur.rowcount, oid)
-
-
-@then("location_postcode contains exactly")
-def check_location_postcode(context):
- """ Check full contents for location_postcode table. Each row represents a table row
- and all data must match. Data not present in the expected table, may
- be arbitrary. The rows are identified via 'country' and 'postcode' columns.
- All rows must be present as excepted and there must not be additional
- rows.
- """
- with context.db.cursor() as cur:
- cur.execute("SELECT *, ST_AsText(geometry) as geomtxt FROM location_postcode")
- assert cur.rowcount == len(list(context.table)), \
- "Postcode table has {cur.rowcount} rows, expected {len(list(context.table))}."
-
- results = {}
- for row in cur:
- key = (row['country_code'], row['postcode'])
- assert key not in results, "Postcode table has duplicate entry: {}".format(row)
- results[key] = DBRow((row['country_code'], row['postcode']), row, context)
-
- for row in context.table:
- db_row = results.get((row['country'], row['postcode']))
- assert db_row is not None, \
- f"Missing row for country '{row['country']}' postcode '{row['postcode']}'."
-
- db_row.assert_row(row, ('country', 'postcode'))
-
-
-@then("there are(?P<exclude> no)? word tokens for postcodes (?P<postcodes>.*)")
-def check_word_table_for_postcodes(context, exclude, postcodes):
- """ Check that the tokenizer produces postcode tokens for the given
- postcodes. The postcodes are a comma-separated list of postcodes.
- Whitespace matters.
- """
- nctx = context.nominatim
- tokenizer = tokenizer_factory.get_tokenizer_for_db(nctx.get_test_config())
- with tokenizer.name_analyzer() as ana:
- plist = [ana.normalize_postcode(p) for p in postcodes.split(',')]
-
- plist.sort()
-
- with context.db.cursor() as cur:
- cur.execute("SELECT word FROM word WHERE type = 'P' and word = any(%s)",
- (plist,))
-
- found = [row['word'] for row in cur]
- assert len(found) == len(set(found)), f"Duplicate rows for postcodes: {found}"
-
- if exclude:
- assert len(found) == 0, f"Unexpected postcodes: {found}"
- else:
- assert set(found) == set(plist), \
- f"Missing postcodes {set(plist) - set(found)}. Found: {found}"
-
-
-@then("place_addressline contains")
-def check_place_addressline(context):
- """ Check the contents of the place_addressline table. Each row represents
- a table row and all data must match. Data not present in the expected
- table, may be arbitrary. The rows are identified via the 'object' column,
- representing the addressee and the 'address' column, representing the
- address item.
- """
- with context.db.cursor() as cur:
- for row in context.table:
- nid = NominatimID(row['object'])
- pid = nid.get_place_id(cur)
- apid = NominatimID(row['address']).get_place_id(cur)
- cur.execute(""" SELECT * FROM place_addressline
- WHERE place_id = %s AND address_place_id = %s""",
- (pid, apid))
- assert cur.rowcount > 0, \
- f"No rows found for place {row['object']} and address {row['address']}."
-
- for res in cur:
- DBRow(nid, res, context).assert_row(row, ('address', 'object'))
-
-
-@then("place_addressline doesn't contain")
-def check_place_addressline_exclude(context):
- """ Check that the place_addressline doesn't contain any entries for the
- given addressee/address item pairs.
- """
- with context.db.cursor() as cur:
- for row in context.table:
- pid = NominatimID(row['object']).get_place_id(cur)
- apid = NominatimID(row['address']).get_place_id(cur, allow_empty=True)
- if apid is not None:
- cur.execute(""" SELECT * FROM place_addressline
- WHERE place_id = %s AND address_place_id = %s""",
- (pid, apid))
- assert cur.rowcount == 0, \
- f"Row found for place {row['object']} and address {row['address']}."
-
-
-@then(r"W(?P<oid>\d+) expands to(?P<neg> no)? interpolation")
-def check_location_property_osmline(context, oid, neg):
- """ Check that the given way is present in the interpolation table.
- """
- with context.db.cursor() as cur:
- cur.execute("""SELECT *, ST_AsText(linegeo) as geomtxt
- FROM location_property_osmline
- WHERE osm_id = %s AND startnumber IS NOT NULL""",
- (oid, ))
-
- if neg:
- assert cur.rowcount == 0, "Interpolation found for way {}.".format(oid)
- return
-
- todo = list(range(len(list(context.table))))
- for res in cur:
- for i in todo:
- row = context.table[i]
- if (int(row['start']) == res['startnumber']
- and int(row['end']) == res['endnumber']):
- todo.remove(i)
- break
- else:
- assert False, "Unexpected row " + str(res)
-
- DBRow(oid, res, context).assert_row(row, ('start', 'end'))
-
- assert not todo, f"Unmatched lines in table: {list(context.table[i] for i in todo)}"
-
-
-@then("location_property_osmline contains(?P<exact> exactly)?")
-def check_osmline_contents(context, exact):
- """ Check contents of the interpolation table. Each row represents a table row
- and all data must match. Data not present in the expected table, may
- be arbitrary. The rows are identified via the 'object' column which must
- have an identifier of the form '<osm id>[:<startnumber>]'. When multiple
- rows match (for example because 'startnumber' was left out and there are
- multiple entries for the given OSM object) then all must match. All
- expected rows are expected to be present with at least one database row.
- When 'exactly' is given, there must not be additional rows in the database.
- """
- with context.db.cursor() as cur:
- expected_content = set()
- for row in context.table:
- if ':' in row['object']:
- nid, start = row['object'].split(':', 2)
- start = int(start)
- else:
- nid, start = row['object'], None
-
- query = """SELECT *, ST_AsText(linegeo) as geomtxt,
- ST_GeometryType(linegeo) as geometrytype
- FROM location_property_osmline WHERE osm_id=%s"""
-
- if ':' in row['object']:
- query += ' and startnumber = %s'
- params = [int(val) for val in row['object'].split(':', 2)]
- else:
- params = (int(row['object']), )
-
- cur.execute(query, params)
- assert cur.rowcount > 0, "No rows found for " + row['object']
-
- for res in cur:
- if exact:
- expected_content.add((res['osm_id'], res['startnumber']))
-
- DBRow(nid, res, context).assert_row(row, ['object'])
-
- if exact:
- cur.execute('SELECT osm_id, startnumber from location_property_osmline')
- actual = set([(r['osm_id'], r['startnumber']) for r in cur])
- assert expected_content == actual, \
- f"Missing entries: {expected_content - actual}\n" \
- f"Not expected in table: {actual - expected_content}"
+++ /dev/null
-# SPDX-License-Identifier: GPL-3.0-or-later
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2024 by the Nominatim developer community.
-# For a full list of authors see the git log.
-import tempfile
-import random
-import os
-from pathlib import Path
-
-from nominatim_db.tools.exec_utils import run_osm2pgsql
-from nominatim_db.tools.replication import run_osm2pgsql_updates
-
-from geometry_alias import ALIASES
-
-
-def get_osm2pgsql_options(nominatim_env, fname, append):
- return dict(import_file=fname,
- osm2pgsql='osm2pgsql',
- osm2pgsql_cache=50,
- osm2pgsql_style=str(nominatim_env.get_test_config().get_import_style_file()),
- osm2pgsql_style_path=nominatim_env.get_test_config().lib_dir.lua,
- threads=1,
- dsn=nominatim_env.get_libpq_dsn(),
- flatnode_file='',
- tablespaces=dict(slim_data='', slim_index='',
- main_data='', main_index=''),
- append=append)
-
-
-def write_opl_file(opl, grid):
- """ Create a temporary OSM file from OPL and return the file name. It is
- the responsibility of the caller to delete the file again.
-
- Node with missing coordinates, can retrieve their coordinates from
- a supplied grid. Failing that a random coordinate is assigned.
- """
- with tempfile.NamedTemporaryFile(suffix='.opl', delete=False) as fd:
- for line in opl.splitlines():
- if line.startswith('n') and line.find(' x') < 0:
- coord = grid.grid_node(int(line[1:].split(' ')[0]))
- if coord is None:
- coord = (random.uniform(-180, 180), random.uniform(-90, 90))
- line += " x%f y%f" % coord
- fd.write(line.encode('utf-8'))
- fd.write(b'\n')
-
- return fd.name
-
-
-@given('the lua style file')
-def lua_style_file(context):
- """ Define a custom style file to use for the import.
- """
- style = Path(context.nominatim.website_dir.name) / 'custom.lua'
- style.write_text(context.text)
- context.nominatim.test_env['NOMINATIM_IMPORT_STYLE'] = str(style)
-
-
-@given(u'the ([0-9.]+ )?grid(?: with origin (?P<origin>.*))?')
-def define_node_grid(context, grid_step, origin):
- """
- Define a grid of node positions.
- Use a table to define the grid. The nodes must be integer ids. Optionally
- you can give the grid distance. The default is 0.00001 degrees.
- """
- if grid_step is not None:
- grid_step = float(grid_step.strip())
- else:
- grid_step = 0.00001
-
- if origin:
- if ',' in origin:
- # TODO coordinate
- coords = origin.split(',')
- if len(coords) != 2:
- raise RuntimeError('Grid origin expects origin with x,y coordinates.')
- origin = (float(coords[0]), float(coords[1]))
- elif origin in ALIASES:
- origin = ALIASES[origin]
- else:
- raise RuntimeError('Grid origin must be either coordinate or alias.')
- else:
- origin = (0.0, 0.0)
-
- context.osm.set_grid([context.table.headings] + [list(h) for h in context.table],
- grid_step, origin)
-
-
-@when(u'loading osm data')
-def load_osm_file(context):
- """
- Load the given data into a freshly created test database using osm2pgsql.
- No further indexing is done.
-
- The data is expected as attached text in OPL format.
- """
- # create an OSM file and import it
- fname = write_opl_file(context.text, context.osm)
- try:
- run_osm2pgsql(get_osm2pgsql_options(context.nominatim, fname, append=False))
- finally:
- os.remove(fname)
-
- # reintroduce the triggers/indexes we've lost by having osm2pgsql set up place again
- cur = context.db.cursor()
- cur.execute("""CREATE TRIGGER place_before_delete BEFORE DELETE ON place
- FOR EACH ROW EXECUTE PROCEDURE place_delete()""")
- cur.execute("""CREATE TRIGGER place_before_insert BEFORE INSERT ON place
- FOR EACH ROW EXECUTE PROCEDURE place_insert()""")
- cur.execute("""CREATE UNIQUE INDEX idx_place_osm_unique ON place
- USING btree(osm_id,osm_type,class,type)""")
- context.db.commit()
-
-
-@when(u'updating osm data')
-def update_from_osm_file(context):
- """
- Update a database previously populated with 'loading osm data'.
- Needs to run indexing on the existing data first to yield the correct result.
-
- The data is expected as attached text in OPL format.
- """
- context.nominatim.copy_from_place(context.db)
- context.nominatim.run_nominatim('index')
- context.nominatim.run_nominatim('refresh', '--functions')
-
- # create an OSM file and import it
- fname = write_opl_file(context.text, context.osm)
- try:
- run_osm2pgsql_updates(context.db,
- get_osm2pgsql_options(context.nominatim, fname, append=True))
- finally:
- os.remove(fname)
-
-
-@when('indexing')
-def index_database(context):
- """
- Run the Nominatim indexing step. This will process data previously
- loaded with 'updating osm data'
- """
- context.nominatim.run_nominatim('index')
+++ /dev/null
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# This file is part of Nominatim. (https://nominatim.org)
-#
-# Copyright (C) 2025 by the Nominatim developer community.
-# For a full list of authors see the git log.
-"""
-Functions to facilitate accessing and comparing the content of DB tables.
-"""
-import math
-import re
-import json
-
-import psycopg
-from psycopg import sql as pysql
-
-ID_REGEX = re.compile(r"(?P<typ>[NRW])(?P<oid>\d+)(:(?P<cls>\w+))?")
-
-
-class NominatimID:
- """ Splits a unique identifier for places into its components.
- As place_ids cannot be used for testing, we use a unique
- identifier instead that is of the form <osmtype><osmid>[:<class>].
- """
-
- def __init__(self, oid):
- self.typ = self.oid = self.cls = None
-
- if oid is not None:
- m = ID_REGEX.fullmatch(oid)
- assert m is not None, \
- "ID '{}' not of form <osmtype><osmid>[:<class>]".format(oid)
-
- self.typ = m.group('typ')
- self.oid = m.group('oid')
- self.cls = m.group('cls')
-
- def __str__(self):
- if self.cls is None:
- return self.typ + self.oid
-
- return '{self.typ}{self.oid}:{self.cls}'.format(self=self)
-
- def query_osm_id(self, cur, query):
- """ Run a query on cursor `cur` using osm ID, type and class. The
- `query` string must contain exactly one placeholder '{}' where
- the 'where' query should go.
- """
- where = 'osm_type = %s and osm_id = %s'
- params = [self.typ, self. oid]
-
- if self.cls is not None:
- where += ' and class = %s'
- params.append(self.cls)
-
- cur.execute(query.format(where), params)
-
- def row_by_place_id(self, cur, table, extra_columns=None):
- """ Get a row by place_id from the given table using cursor `cur`.
- extra_columns may contain a list additional elements for the select
- part of the query.
- """
- pid = self.get_place_id(cur)
- query = "SELECT {} FROM {} WHERE place_id = %s".format(
- ','.join(['*'] + (extra_columns or [])), table)
- cur.execute(query, (pid, ))
-
- def get_place_id(self, cur, allow_empty=False):
- """ Look up the place id for the ID. Throws an assertion if the ID
- is not unique.
- """
- self.query_osm_id(cur, "SELECT place_id FROM placex WHERE {}")
- if cur.rowcount == 0 and allow_empty:
- return None
-
- assert cur.rowcount == 1, \
- "Place ID {!s} not unique. Found {} entries.".format(self, cur.rowcount)
-
- return cur.fetchone()['place_id']
-
-
-class DBRow:
- """ Represents a row from a database and offers comparison functions.
- """
- def __init__(self, nid, db_row, context):
- self.nid = nid
- self.db_row = db_row
- self.context = context
-
- def assert_row(self, row, exclude_columns):
- """ Check that all columns of the given behave row are contained
- in the database row. Exclude behave rows with the names given
- in the `exclude_columns` list.
- """
- for name, value in zip(row.headings, row.cells):
- if name not in exclude_columns:
- assert self.contains(name, value), self.assert_msg(name, value)
-
- def contains(self, name, expected):
- """ Check that the DB row contains a column `name` with the given value.
- """
- if '+' in name:
- column, field = name.split('+', 1)
- return self._contains_hstore_value(column, field, expected)
-
- if name == 'geometry':
- return self._has_geometry(expected)
-
- if name not in self.db_row:
- return False
-
- actual = self.db_row[name]
-
- if expected == '-':
- return actual is None
-
- if name == 'name' and ':' not in expected:
- return self._compare_column(actual[name], expected)
-
- if 'place_id' in name:
- return self._compare_place_id(actual, expected)
-
- if name == 'centroid':
- return self._has_centroid(expected)
-
- return self._compare_column(actual, expected)
-
- def _contains_hstore_value(self, column, field, expected):
- if column == 'addr':
- column = 'address'
-
- if column not in self.db_row:
- return False
-
- if expected == '-':
- return self.db_row[column] is None or field not in self.db_row[column]
-
- if self.db_row[column] is None:
- return False
-
- return self._compare_column(self.db_row[column].get(field), expected)
-
- def _compare_column(self, actual, expected):
- if isinstance(actual, dict):
- return actual == eval('{' + expected + '}')
-
- return str(actual) == expected
-
- def _compare_place_id(self, actual, expected):
- if expected == '0':
- return actual == 0
-
- with self.context.db.cursor() as cur:
- return NominatimID(expected).get_place_id(cur) == actual
-
- def _has_centroid(self, expected):
- if expected == 'in geometry':
- with self.context.db.cursor(row_factory=psycopg.rows.tuple_row) as cur:
- cur.execute("""SELECT ST_Within(ST_SetSRID(ST_Point(%(cx)s, %(cy)s), 4326),
- ST_SetSRID(%(geomtxt)s::geometry, 4326))""",
- (self.db_row))
- return cur.fetchone()[0]
-
- if ' ' in expected:
- x, y = expected.split(' ')
- else:
- x, y = self.context.osm.grid_node(int(expected))
-
- return math.isclose(float(x), self.db_row['cx']) \
- and math.isclose(float(y), self.db_row['cy'])
-
- def _has_geometry(self, expected):
- geom = self.context.osm.parse_geometry(expected)
- with self.context.db.cursor(row_factory=psycopg.rows.tuple_row) as cur:
- cur.execute(pysql.SQL("""
- SELECT ST_Equals(ST_SnapToGrid({}, 0.00001, 0.00001),
- ST_SnapToGrid(ST_SetSRID({}::geometry, 4326), 0.00001, 0.00001))""")
- .format(pysql.SQL(geom),
- pysql.Literal(self.db_row['geomtxt'])))
- return cur.fetchone()[0]
-
- def assert_msg(self, name, value):
- """ Return a string with an informative message for a failed compare.
- """
- msg = "\nBad column '{}' in row '{!s}'.".format(name, self.nid)
- actual = self._get_actual(name)
- if actual is not None:
- msg += " Expected: {}, got: {}.".format(value, actual)
- else:
- msg += " No such column."
-
- return msg + "\nFull DB row: {}".format(json.dumps(dict(self.db_row),
- indent=4, default=str))
-
- def _get_actual(self, name):
- if '+' in name:
- column, field = name.split('+', 1)
- if column == 'addr':
- column = 'address'
- return (self.db_row.get(column) or {}).get(field)
-
- if name == 'geometry':
- return self.db_row['geomtxt']
-
- if name not in self.db_row:
- return None
-
- if name == 'centroid':
- return "POINT({cx} {cy})".format(**self.db_row)
-
- actual = self.db_row[name]
-
- if 'place_id' in name:
- if actual is None:
- return '<null>'
-
- if actual == 0:
- return "place ID 0"
-
- with self.context.db.cursor(row_factory=psycopg.rows.tuple_row) as cur:
- cur.execute("""SELECT osm_type, osm_id, class
- FROM placex WHERE place_id = %s""",
- (actual, ))
-
- if cur.rowcount == 1:
- return "{0[0]}{0[1]}:{0[2]}".format(cur.fetchone())
-
- return "[place ID {} not found]".format(actual)
-
- return actual
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Collector for all BDD API tests.
+
+These tests work on a static test database that is the same for all tests.
+The source data for the database can be found in the test/testdb directory.
+"""
+from pathlib import Path
+import xml.etree.ElementTree as ET
+
+import pytest
+from pytest_bdd.parsers import re as step_parse
+from pytest_bdd import scenarios, when, given, then
+
+from nominatim_db import cli
+from nominatim_db.config import Configuration
+
+from utils.db import DBManager
+from utils.api_runner import APIRunner
+from utils.api_result import APIResult
+
+
+TESTDB_PATH = (Path(__file__) / '..' / '..' / 'testdb').resolve()
+
+CONTENT_TYPES = {
+ 'json': 'application/json; charset=utf-8',
+ 'xml': 'text/xml; charset=utf-8',
+ 'geojson': 'application/json; charset=utf-8',
+ 'geocodejson': 'application/json; charset=utf-8',
+ 'html': 'text/html; charset=utf-8'
+}
+
+
+@pytest.fixture(autouse=True, scope='session')
+def session_api_test_db(pytestconfig):
+ """ Create a Nominatim database from the official API test data.
+ Will only recreate an existing database if --nominatim-purge
+ was set.
+ """
+ dbname = pytestconfig.getini('nominatim_api_test_db')
+
+ config = Configuration(None).get_os_env()
+ config['NOMINATIM_DATABASE_DSN'] = f"pgsql:dbname={dbname}"
+ config['NOMINATIM_LANGUAGES'] = 'en,de,fr,ja'
+ config['NOMINATIM_USE_US_TIGER_DATA'] = 'yes'
+ if pytestconfig.option.NOMINATIM_TOKENIZER is not None:
+ config['NOMINATIM_TOKENIZER'] = pytestconfig.option.NOMINATIM_TOKENIZER
+
+ dbm = DBManager(purge=pytestconfig.option.NOMINATIM_PURGE)
+
+ if not dbm.check_for_db(dbname):
+ try:
+ cli.nominatim(cli_args=['import', '--project-dir', str(TESTDB_PATH),
+ '--osm-file', str(TESTDB_PATH / 'apidb-test-data.pbf')],
+ environ=config)
+ cli.nominatim(cli_args=['add-data', '--project-dir', str(TESTDB_PATH),
+ '--tiger-data', str(TESTDB_PATH / 'tiger')],
+ environ=config)
+ cli.nominatim(cli_args=['freeze', '--project-dir', str(TESTDB_PATH)],
+ environ=config)
+ cli.nominatim(cli_args=['special-phrases', '--project-dir', str(TESTDB_PATH),
+ '--import-from-csv',
+ str(TESTDB_PATH / 'full_en_phrases_test.csv')],
+ environ=config)
+ except: # noqa: E722
+ dbm.drop_db(dbname)
+ raise
+
+
+@pytest.fixture
+def test_config_env(pytestconfig):
+ dbname = pytestconfig.getini('nominatim_api_test_db')
+
+ config = Configuration(None).get_os_env()
+ config['NOMINATIM_DATABASE_DSN'] = f"pgsql:dbname={dbname}"
+ config['NOMINATIM_LANGUAGES'] = 'en,de,fr,ja'
+ config['NOMINATIM_USE_US_TIGER_DATA'] = 'yes'
+ if pytestconfig.option.NOMINATIM_TOKENIZER is not None:
+ config['NOMINATIM_TOKENIZER'] = pytestconfig.option.NOMINATIM_TOKENIZER
+
+ return config
+
+
+@pytest.fixture
+def api_http_request_headers():
+ return {}
+
+
+@given('the HTTP header', target_fixture='api_http_request_headers')
+def set_additional_http_headers(api_http_request_headers, datatable):
+ api_http_request_headers.update(zip(datatable[0], datatable[1]))
+ return api_http_request_headers
+
+
+@given('an unknown database', target_fixture='test_config_env')
+def setup_connection_unknown_database(test_config_env):
+ test_config_env['NOMINATIM_DATABASE_DSN'] = "pgsql:dbname=gerlkghngergn6732nf"
+ return test_config_env
+
+
+@when(step_parse(r'sending v1/(?P<endpoint>\S+)(?: with format (?P<fmt>\S+))?'),
+ target_fixture='api_response')
+def send_api_status(test_config_env, api_http_request_headers, pytestconfig,
+ datatable, endpoint, fmt):
+ runner = APIRunner(test_config_env, pytestconfig.option.NOMINATIM_API_ENGINE)
+ return runner.run_step(endpoint, {}, datatable, fmt, api_http_request_headers)
+
+
+@then(step_parse(r'a HTTP (?P<status>\d+) is returned'), converters={'status': int})
+def check_http_result(api_response, status):
+ assert api_response.status == status
+
+
+@then(step_parse('the page content equals "(?P<content>.*)"'))
+def check_page_content_exact(api_response, content):
+ assert api_response.body == content
+
+
+@then('the result is valid html')
+def check_for_html_correctness(api_response):
+ assert api_response.headers['content-type'] == CONTENT_TYPES['html']
+
+ try:
+ tree = ET.fromstring(api_response.body)
+ except Exception as ex:
+ assert False, f"Could not parse page: {ex}\n{api_response.body}"
+
+ assert tree.tag == 'html'
+
+ body = tree.find('./body')
+ assert body is not None
+ assert body.find('.//script') is None
+
+
+@then(step_parse(r'the result is valid (?P<fmt>\S+)(?: with (?P<num>\d+) results?)?'),
+ target_fixture='nominatim_result')
+def parse_api_json_response(api_response, fmt, num):
+ assert api_response.headers['content-type'] == CONTENT_TYPES[fmt]
+
+ result = APIResult(fmt, api_response.endpoint, api_response.body)
+
+ if num:
+ assert len(result) == int(num)
+
+ return result
+
+
+scenarios('features/api')
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Collector for BDD import acceptance tests.
+
+These tests check the Nominatim import chain after the osm2pgsql import.
+"""
+import asyncio
+import re
+
+import psycopg
+
+import pytest
+from pytest_bdd import scenarios, when, then, given
+from pytest_bdd.parsers import re as step_parse
+
+from utils.place_inserter import PlaceColumn
+from utils.checks import check_table_content
+
+from nominatim_db.config import Configuration
+from nominatim_db import cli
+from nominatim_db.tools.database_import import load_data, create_table_triggers
+from nominatim_db.tools.postcodes import update_postcodes
+from nominatim_db.tokenizer import factory as tokenizer_factory
+
+
+def _rewrite_placeid_field(field, new_field, datatable, place_ids):
+ try:
+ oidx = datatable[0].index(field)
+ datatable[0][oidx] = new_field
+ for line in datatable[1:]:
+ line[oidx] = None if line[oidx] == '-' else place_ids[line[oidx]]
+ except ValueError:
+ pass
+
+
+def _collect_place_ids(conn):
+ pids = {}
+ with conn.cursor() as cur:
+ for row in cur.execute('SELECT place_id, osm_type, osm_id, class FROM placex'):
+ pids[f"{row[1]}{row[2]}"] = row[0]
+ pids[f"{row[1]}{row[2]}:{row[3]}"] = row[0]
+
+ return pids
+
+
+@pytest.fixture
+def test_config_env(pytestconfig):
+ dbname = pytestconfig.getini('nominatim_test_db')
+
+ config = Configuration(None).get_os_env()
+ config['NOMINATIM_DATABASE_DSN'] = f"pgsql:dbname={dbname}"
+ config['NOMINATIM_LANGUAGES'] = 'en,de,fr,ja'
+ config['NOMINATIM_USE_US_TIGER_DATA'] = 'yes'
+ if pytestconfig.option.NOMINATIM_TOKENIZER is not None:
+ config['NOMINATIM_TOKENIZER'] = pytestconfig.option.NOMINATIM_TOKENIZER
+
+ return config
+
+
+@pytest.fixture
+def update_config(def_config):
+ """ Prepare the database for being updatable and return the config.
+ """
+ cli.nominatim(['refresh', '--functions'], def_config.environ)
+
+ return def_config
+
+
+@given(step_parse('the (?P<named>named )?places'), target_fixture=None)
+def import_places(db_conn, named, datatable, node_grid):
+ """ Insert todo rows into the place table.
+ When 'named' is given, then a random name will be generated for all
+ objects.
+ """
+ with db_conn.cursor() as cur:
+ for row in datatable[1:]:
+ PlaceColumn(node_grid).add_row(datatable[0], row, named is not None).db_insert(cur)
+
+
+@given('the ways', target_fixture=None)
+def import_ways(db_conn, datatable):
+ """ Import raw ways into the osm2pgsql way middle table.
+ """
+ with db_conn.cursor() as cur:
+ id_idx = datatable[0].index('id')
+ node_idx = datatable[0].index('nodes')
+ for line in datatable[1:]:
+ tags = psycopg.types.json.Json(
+ {k[5:]: v for k, v in zip(datatable[0], line)
+ if k.startswith("tags+")})
+ nodes = [int(x) for x in line[node_idx].split(',')]
+
+ cur.execute("INSERT INTO planet_osm_ways (id, nodes, tags) VALUES (%s, %s, %s)",
+ (line[id_idx], nodes, tags))
+
+
+@given('the relations', target_fixture=None)
+def import_rels(db_conn, datatable):
+ """ Import raw relations into the osm2pgsql relation middle table.
+ """
+ with db_conn.cursor() as cur:
+ id_idx = datatable[0].index('id')
+ memb_idx = datatable[0].index('members')
+ for line in datatable[1:]:
+ tags = psycopg.types.json.Json(
+ {k[5:]: v for k, v in zip(datatable[0], line)
+ if k.startswith("tags+")})
+ members = []
+ if line[memb_idx]:
+ for member in line[memb_idx].split(','):
+ m = re.fullmatch(r'\s*([RWN])(\d+)(?::(\S+))?\s*', member)
+ if not m:
+ raise ValueError(f'Illegal member {member}.')
+ members.append({'ref': int(m[2]), 'role': m[3] or '', 'type': m[1]})
+
+ cur.execute('INSERT INTO planet_osm_rels (id, tags, members) VALUES (%s, %s, %s)',
+ (int(line[id_idx]), tags, psycopg.types.json.Json(members)))
+
+
+@when('importing', target_fixture='place_ids')
+def do_import(db_conn, def_config):
+ """ Run a reduced version of the Nominatim import.
+ """
+ create_table_triggers(db_conn, def_config)
+ asyncio.run(load_data(def_config.get_libpq_dsn(), 1))
+ tokenizer = tokenizer_factory.get_tokenizer_for_db(def_config)
+ update_postcodes(def_config.get_libpq_dsn(), None, tokenizer)
+ cli.nominatim(['index', '-q'], def_config.environ)
+
+ return _collect_place_ids(db_conn)
+
+
+@when('updating places', target_fixture='place_ids')
+def do_update(db_conn, update_config, node_grid, datatable):
+ """ Update the place table with the given data. Also runs all triggers
+ related to updates and reindexes the new data.
+ """
+ with db_conn.cursor() as cur:
+ for row in datatable[1:]:
+ PlaceColumn(node_grid).add_row(datatable[0], row, False).db_insert(cur)
+ cur.execute('SELECT flush_deleted_places()')
+ db_conn.commit()
+
+ cli.nominatim(['index', '-q'], update_config.environ)
+
+ return _collect_place_ids(db_conn)
+
+
+@when('updating postcodes')
+def do_postcode_update(update_config):
+ """ Recompute the postcode centroids.
+ """
+ cli.nominatim(['refresh', '--postcodes'], update_config.environ)
+
+
+@when(step_parse(r'marking for delete (?P<otype>[NRW])(?P<oid>\d+)'),
+ converters={'oid': int})
+def do_delete_place(db_conn, update_config, node_grid, otype, oid):
+ """ Remove the given place from the database.
+ """
+ with db_conn.cursor() as cur:
+ cur.execute('TRUNCATE place_to_be_deleted')
+ cur.execute('DELETE FROM place WHERE osm_type = %s and osm_id = %s',
+ (otype, oid))
+ cur.execute('SELECT flush_deleted_places()')
+ db_conn.commit()
+
+ cli.nominatim(['index', '-q'], update_config.environ)
+
+
+@then(step_parse(r'(?P<table>\w+) contains(?P<exact> exactly)?'))
+def then_check_table_content(db_conn, place_ids, datatable, node_grid, table, exact):
+ _rewrite_placeid_field('object', 'place_id', datatable, place_ids)
+ _rewrite_placeid_field('parent_place_id', 'parent_place_id', datatable, place_ids)
+ _rewrite_placeid_field('linked_place_id', 'linked_place_id', datatable, place_ids)
+ if table == 'place_addressline':
+ _rewrite_placeid_field('address', 'address_place_id', datatable, place_ids)
+
+ for i, title in enumerate(datatable[0]):
+ if title.startswith('addr+'):
+ datatable[0][i] = f"address+{title[5:]}"
+
+ check_table_content(db_conn, table, datatable, grid=node_grid, exact=bool(exact))
+
+
+@then(step_parse(r'(DISABLED?P<table>placex?) has no entry for (?P<oid>[NRW]\d+(?::\S+)?)'))
+def then_check_place_missing_lines(db_conn, place_ids, table, oid):
+ assert oid in place_ids
+
+ sql = pysql.SQL("""SELECT count(*) FROM {}
+ WHERE place_id = %s""").format(pysql.Identifier(tablename))
+
+ with conn.cursor(row_factory=tuple_row) as cur:
+ assert cur.execute(sql, [place_ids[oid]]).fetchone()[0] == 0
+
+
+@then(step_parse(r'W(?P<oid>\d+) expands to interpolation'),
+ converters={'oid': int})
+def then_check_interpolation_table(db_conn, node_grid, place_ids, oid, datatable):
+ with db_conn.cursor() as cur:
+ cur.execute('SELECT count(*) FROM location_property_osmline WHERE osm_id = %s',
+ [oid])
+ assert cur.fetchone()[0] == len(datatable) - 1
+
+ converted = [['osm_id', 'startnumber', 'endnumber', 'linegeo!wkt']]
+ start_idx = datatable[0].index('start') if 'start' in datatable[0] else None
+ end_idx = datatable[0].index('end') if 'end' in datatable[0] else None
+ geom_idx = datatable[0].index('geometry') if 'geometry' in datatable[0] else None
+ converted = [['osm_id']]
+ for val, col in zip((start_idx, end_idx, geom_idx),
+ ('startnumber', 'endnumber', 'linegeo!wkt')):
+ if val is not None:
+ converted[0].append(col)
+
+ for line in datatable[1:]:
+ convline = [oid]
+ for val in (start_idx, end_idx):
+ if val is not None:
+ convline.append(line[val])
+ if geom_idx is not None:
+ convline.append(line[geom_idx])
+ converted.append(convline)
+
+ _rewrite_placeid_field('parent_place_id', 'parent_place_id', converted, place_ids)
+
+ check_table_content(db_conn, 'location_property_osmline', converted, grid=node_grid)
+
+
+@then(step_parse(r'W(?P<oid>\d+) expands to no interpolation'),
+ converters={'oid': int})
+def then_check_interpolation_table_negative(db_conn, oid):
+ with db_conn.cursor() as cur:
+ cur.execute("""SELECT count(*) FROM location_property_osmline
+ WHERE osm_id = %s and startnumber is not null""",
+ [oid])
+ assert cur.fetchone()[0] == 0
+
+
+scenarios('features/db')
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Collector for BDD osm2pgsql import style tests.
+"""
+import asyncio
+import random
+
+import pytest
+from pytest_bdd import scenarios, when, then, given
+from pytest_bdd.parsers import re as step_parse
+
+from nominatim_db import cli
+from nominatim_db.tools.exec_utils import run_osm2pgsql
+from nominatim_db.tools.database_import import load_data, create_table_triggers
+from nominatim_db.tools.replication import run_osm2pgsql_updates
+
+from utils.checks import check_table_content
+
+
+@pytest.fixture
+def osm2pgsql_options(def_config):
+ return dict(osm2pgsql='osm2pgsql',
+ osm2pgsql_cache=50,
+ osm2pgsql_style=str(def_config.get_import_style_file()),
+ osm2pgsql_style_path=def_config.lib_dir.lua,
+ threads=1,
+ dsn=def_config.get_libpq_dsn(),
+ flatnode_file='',
+ tablespaces=dict(slim_data='', slim_index='',
+ main_data='', main_index=''),
+ append=False)
+
+
+@pytest.fixture
+def opl_writer(tmp_path, node_grid):
+ nr = [0]
+
+ def _write(data):
+ fname = tmp_path / f"test_osm_{nr[0]}.opl"
+ nr[0] += 1
+ with fname.open('wt') as fd:
+ for line in data.split('\n'):
+ if line.startswith('n') and ' x' not in line:
+ coord = node_grid.get(line[1:].split(' ')[0]) \
+ or (random.uniform(-180, 180), random.uniform(-90, 90))
+ line = f"{line} x{coord[0]:.7f} y{coord[1]:.7f}"
+ fd.write(line)
+ fd.write('\n')
+ return fname
+
+ return _write
+
+
+@given('the lua style file', target_fixture='osm2pgsql_options')
+def set_lua_style_file(osm2pgsql_options, docstring, tmp_path):
+ style = tmp_path / 'custom.lua'
+ style.write_text(docstring)
+ osm2pgsql_options['osm2pgsql_style'] = str(style)
+
+ return osm2pgsql_options
+
+
+@when('loading osm data')
+def load_from_osm_file(db, osm2pgsql_options, opl_writer, docstring):
+ """ Load the given data into a freshly created test database using osm2pgsql.
+ No further indexing is done.
+
+ The data is expected as attached text in OPL format.
+ """
+ osm2pgsql_options['import_file'] = opl_writer(docstring.replace(r'//', r'/'))
+ osm2pgsql_options['append'] = False
+ run_osm2pgsql(osm2pgsql_options)
+
+
+@when('updating osm data')
+def update_from_osm_file(db_conn, def_config, osm2pgsql_options, opl_writer, docstring):
+ """ Update a database previously populated with 'loading osm data'.
+ Needs to run indexing on the existing data first to yield the correct
+ result.
+
+ The data is expected as attached text in OPL format.
+ """
+ create_table_triggers(db_conn, def_config)
+ asyncio.run(load_data(def_config.get_libpq_dsn(), 1))
+ cli.nominatim(['index'], def_config.environ)
+ cli.nominatim(['refresh', '--functions'], def_config.environ)
+
+ osm2pgsql_options['import_file'] = opl_writer(docstring.replace(r'//', r'/'))
+ run_osm2pgsql_updates(db_conn, osm2pgsql_options)
+
+
+@when('indexing')
+def do_index(def_config):
+ """ Run Nominatim's indexing step.
+ """
+ cli.nominatim(['index'], def_config.environ)
+
+
+@then(step_parse(r'(?P<table>\w+) contains(?P<exact> exactly)?'))
+def check_place_content(db_conn, datatable, node_grid, table, exact):
+ check_table_content(db_conn, table, datatable, grid=node_grid, exact=bool(exact))
+
+
+scenarios('features/osm2pgsql')
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Wrapper for results from the API
+"""
+import json
+import xml.etree.ElementTree as ET
+
+
+class APIResult:
+
+ def __init__(self, fmt, endpoint, body):
+ getattr(self, '_parse_' + fmt)(endpoint, body)
+
+ def is_simple(self):
+ return not isinstance(self.result, list)
+
+ def __len__(self):
+ return 1 if self.is_simple() else len(self.result)
+
+ def __str__(self):
+ return json.dumps({'meta': self.meta, 'result': self.result}, indent=2)
+
+ def _parse_json(self, _, body):
+ self.meta = {}
+ self.result = json.loads(body)
+
+ def _parse_xml(self, endpoint, body):
+ xml_tree = ET.fromstring(body)
+
+ self.meta = dict(xml_tree.attrib)
+
+ if xml_tree.tag == 'reversegeocode':
+ self._parse_xml_simple(xml_tree)
+ elif xml_tree.tag == 'searchresults':
+ self._parse_xml_multi(xml_tree)
+ elif xml_tree.tag == 'error':
+ self.result = {'error': {sub.tag: sub.text for sub in xml_tree}}
+
+ def _parse_xml_simple(self, xml):
+ self.result = {}
+
+ for child in xml:
+ if child.tag == 'result':
+ assert not self.result, "More than one result in reverse result"
+ self.result.update(child.attrib)
+ assert 'display_name' not in self.result
+ self.result['display_name'] = child.text
+ elif child.tag == 'addressparts':
+ assert 'address' not in self.result
+ self.result['address'] = {sub.tag: sub.text for sub in child}
+ elif child.tag == 'extratags':
+ assert 'extratags' not in self.result
+ self.result['extratags'] = {tag.attrib['key']: tag.attrib['value'] for tag in child}
+ elif child.tag == 'namedetails':
+ assert 'namedetails' not in self.result
+ self.result['namedetails'] = {tag.attrib['desc']: tag.text for tag in child}
+ elif child.tag == 'geokml':
+ assert 'geokml' not in self.result
+ self.result['geokml'] = ET.tostring(child, encoding='unicode')
+ elif child.tag == 'error':
+ assert not self.result
+ self.result['error'] = child.text
+ else:
+ assert False, f"Unknown XML tag {child.tag} on page: {self.page}"
+
+ def _parse_xml_multi(self, xml):
+ self.result = []
+
+ for child in xml:
+ assert child.tag == "place"
+ res = dict(child.attrib)
+
+ address = {}
+ for sub in child:
+ if sub.tag == 'extratags':
+ assert 'extratags' not in res
+ res['extratags'] = {tag.attrib['key']: tag.attrib['value'] for tag in sub}
+ elif sub.tag == 'namedetails':
+ assert 'namedetails' not in res
+ res['namedetails'] = {tag.attrib['desc']: tag.text for tag in sub}
+ elif sub.tag == 'geokml':
+ res['geokml'] = ET.tostring(sub, encoding='utf-8')
+ else:
+ address[sub.tag] = sub.text
+
+ if address:
+ res['address'] = address
+
+ self.result.append(res)
+
+ def _parse_geojson(self, _, body):
+ geojson = json.loads(body)
+
+ assert geojson.get('type') == 'FeatureCollection'
+ assert isinstance(geojson.get('features'), list)
+
+ self.meta = {k: v for k, v in geojson.items() if k not in ('type', 'features')}
+ self.result = []
+
+ for obj in geojson['features']:
+ assert isinstance(obj, dict)
+ assert obj.get('type') == 'Feature'
+
+ assert isinstance(obj.get('properties'), dict)
+ result = obj['properties']
+ assert 'geojson' not in result
+ result['geojson'] = obj['geometry']
+ if 'bbox' in obj:
+ assert 'boundingbox' not in result
+ # bbox is minlon, minlat, maxlon, maxlat
+ # boundingbox is minlat, maxlat, minlon, maxlon
+ result['boundingbox'] = [obj['bbox'][1], obj['bbox'][3],
+ obj['bbox'][0], obj['bbox'][2]]
+ self.result.append(result)
+
+ def _parse_geocodejson(self, endpoint, body):
+ self._parse_geojson(endpoint, body)
+
+ assert set(self.meta.keys()) == {'geocoding'}
+ assert isinstance(self.meta['geocoding'], dict)
+ self.meta = self.meta['geocoding']
+
+ for r in self.result:
+ assert set(r.keys()) == {'geocoding', 'geojson'}
+ inner = r.pop('geocoding')
+ assert isinstance(inner, dict)
+ assert 'geojson' not in inner
+ r.update(inner)
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Various helper classes for running Nominatim commands.
+"""
+import asyncio
+from collections import namedtuple
+
+APIResponse = namedtuple('APIResponse', ['endpoint', 'status', 'body', 'headers'])
+
+
+class APIRunner:
+ """ Execute a call to an API endpoint.
+ """
+ def __init__(self, environ, api_engine):
+ create_func = getattr(self, f"create_engine_{api_engine}")
+ self.exec_engine = create_func(environ)
+
+ def run(self, endpoint, params, http_headers):
+ return asyncio.run(self.exec_engine(endpoint, params, http_headers))
+
+ def run_step(self, endpoint, base_params, datatable, fmt, http_headers):
+ if fmt:
+ base_params['format'] = fmt.strip()
+
+ if datatable:
+ if datatable[0] == ['param', 'value']:
+ base_params.update(datatable[1:])
+ else:
+ base_params.update(zip(datatable[0], datatable[1]))
+
+ return self.run(endpoint, base_params, http_headers)
+
+ def create_engine_falcon(self, environ):
+ import nominatim_api.server.falcon.server
+ import falcon.testing
+
+ async def exec_engine_falcon(endpoint, params, http_headers):
+ app = nominatim_api.server.falcon.server.get_application(None, environ)
+
+ async with falcon.testing.ASGIConductor(app) as conductor:
+ response = await conductor.get("/" + endpoint, params=params,
+ headers=http_headers)
+
+ return APIResponse(endpoint, response.status_code,
+ response.text, response.headers)
+
+ return exec_engine_falcon
+
+ def create_engine_starlette(self, environ):
+ import nominatim_api.server.starlette.server
+ from asgi_lifespan import LifespanManager
+ import httpx
+
+ async def _request(endpoint, params, http_headers):
+ app = nominatim_api.server.starlette.server.get_application(None, environ)
+
+ async with LifespanManager(app):
+ async with httpx.AsyncClient(app=app, base_url="http://nominatim.test") as client:
+ response = await client.get("/" + endpoint, params=params,
+ headers=http_headers)
+
+ return APIResponse(endpoint, response.status_code,
+ response.text, response.headers)
+
+ return _request
--- /dev/null
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Helper functions to compare expected values.
+"""
+import json
+import re
+import math
+
+from psycopg import sql as pysql
+from psycopg.rows import dict_row
+from .geometry_alias import ALIASES
+
+
+COMPARATOR_TERMS = {
+ 'exactly': lambda exp, act: exp == act,
+ 'more than': lambda exp, act: act > exp,
+ 'less than': lambda exp, act: act < exp,
+}
+
+
+def _pretty(obj):
+ return json.dumps(obj, sort_keys=True, indent=2)
+
+
+def _pt_close(p1, p2):
+ return math.isclose(p1[0], p2[0], abs_tol=1e-07) \
+ and math.isclose(p1[1], p2[1], abs_tol=1e-07)
+
+
+def within_box(value, expect):
+ coord = [float(x) for x in expect.split(',')]
+
+ if isinstance(value, str):
+ if value.startswith('POINT'):
+ value = value[6:-1].split(' ')
+ else:
+ value = value.split(',')
+ value = list(map(float, value))
+
+ if len(value) == 2:
+ return coord[0] <= value[0] <= coord[2] \
+ and coord[1] <= value[1] <= coord[3]
+
+ if len(value) == 4:
+ return value[0] >= coord[0] and value[1] <= coord[1] \
+ and value[2] >= coord[2] and value[3] <= coord[3]
+
+ raise ValueError("Not a coordinate or bbox.")
+
+
+COMPARISON_FUNCS = {
+ None: lambda val, exp: str(val) == exp,
+ 'i': lambda val, exp: str(val).lower() == exp.lower(),
+ 'fm': lambda val, exp: re.fullmatch(exp, val) is not None,
+ 'dict': lambda val, exp: val is None if exp == '-' else (val == eval('{' + exp + '}')),
+ 'in_box': within_box
+}
+
+OSM_TYPE = {'node': 'n', 'way': 'w', 'relation': 'r',
+ 'N': 'n', 'W': 'w', 'R': 'r'}
+
+
+class ResultAttr:
+ """ Returns the given attribute as a string.
+
+ The key parameter determines how the value is formatted before
+ returning. To refer to sub attributes, use '+' to add more keys
+ (e.g. 'name+ref' will access obj['name']['ref']). A '!' introduces
+ a formatting suffix. If no suffix is given, the value will be
+ converted using the str() function.
+
+ Available formatters:
+
+ !:... - use a formatting expression according to Python Mini Format Spec
+ !i - make case-insensitive comparison
+ !fm - consider comparison string a regular expression and match full value
+ !wkt - convert the expected value to a WKT string before comparing
+ !in_box - the expected value is a comma-separated bbox description
+ """
+
+ def __init__(self, obj, key, grid=None):
+ self.grid = grid
+ self.obj = obj
+ if '!' in key:
+ self.key, self.fmt = key.rsplit('!', 1)
+ else:
+ self.key = key
+ self.fmt = None
+
+ if self.key == 'object':
+ assert 'osm_id' in obj
+ assert 'osm_type' in obj
+ self.subobj = OSM_TYPE[obj['osm_type']] + str(obj['osm_id'])
+ self.fmt = 'i'
+ else:
+ done = ''
+ self.subobj = self.obj
+ for sub in self.key.split('+'):
+ done += f"[{sub}]"
+ assert sub in self.subobj, \
+ f"Missing attribute {done}. Full object:\n{_pretty(self.obj)}"
+ self.subobj = self.subobj[sub]
+
+ def __eq__(self, other):
+ # work around bad quoting by pytest-bdd
+ if not isinstance(other, str):
+ return self.subobj == other
+
+ other = other.replace(r'\\', '\\')
+
+ if self.fmt in COMPARISON_FUNCS:
+ return COMPARISON_FUNCS[self.fmt](self.subobj, other)
+
+ if self.fmt.startswith(':'):
+ return other == f"{{{self.fmt}}}".format(self.subobj)
+
+ if self.fmt == 'wkt':
+ return self.compare_wkt(self.subobj, other)
+
+ raise RuntimeError(f"Unknown format string '{self.fmt}'.")
+
+ def __repr__(self):
+ k = self.key.replace('+', '][')
+ if self.fmt:
+ k += '!' + self.fmt
+ return f"result[{k}]({self.subobj})"
+
+ def compare_wkt(self, value, expected):
+ """ Compare a WKT value against a compact geometry format.
+ The function understands the following formats:
+
+ country:<country code>
+ Point geometry guaranteed to be in the given country
+ <P>
+ Point geometry
+ <P>,...,<P>
+ Line geometry
+ (<P>,...,<P>)
+ Polygon geometry
+
+ <P> may either be a coordinate of the form '<x> <y>' or a single
+ number. In the latter case it must refer to a point in
+ a previously defined grid.
+ """
+ m = re.fullmatch(r'(POINT)\(([0-9. -]*)\)', value) \
+ or re.fullmatch(r'(LINESTRING)\(([0-9,. -]*)\)', value) \
+ or re.fullmatch(r'(POLYGON)\(\(([0-9,. -]*)\)\)', value)
+ if not m:
+ return False
+
+ converted = [list(map(float, pt.split(' ', 1)))
+ for pt in map(str.strip, m[2].split(','))]
+
+ if expected.startswith('country:'):
+ ccode = expected[8:].upper()
+ assert ccode in ALIASES, f"Geometry error: unknown country {ccode}"
+ return m[1] == 'POINT' and _pt_close(converted[0], ALIASES[ccode])
+
+ if ',' not in expected:
+ return m[1] == 'POINT' and _pt_close(converted[0], self.get_point(expected))
+
+ if '(' not in expected:
+ return m[1] == 'LINESTRING' and \
+ all(_pt_close(p1, p2) for p1, p2 in
+ zip(converted, (self.get_point(p) for p in expected.split(','))))
+
+ if m[1] != 'POLYGON':
+ return False
+
+ # Polygon comparison is tricky because the polygons don't necessarily
+ # end at the same point or have the same winding order.
+ # Brute force all possible variants of the expected polygon
+ exp_coords = [self.get_point(p) for p in expected[1:-1].split(',')]
+ if exp_coords[0] != exp_coords[-1]:
+ raise RuntimeError(f"Invalid polygon {expected}. "
+ "First and last point need to be the same")
+ for line in (exp_coords[:-1], exp_coords[-1:0:-1]):
+ for i in range(len(line)):
+ if all(_pt_close(p1, p2) for p1, p2 in
+ zip(converted, line[i:] + line[:i])):
+ return True
+
+ return False
+
+ def get_point(self, pt):
+ pt = pt.strip()
+ if ' ' in pt:
+ return list(map(float, pt.split(' ', 1)))
+
+ assert self.grid
+
+ return self.grid.get(pt)
+
+
+def check_table_content(conn, tablename, data, grid=None, exact=False):
+ lines = set(range(1, len(data)))
+
+ cols = []
+ for col in data[0]:
+ if col == 'object':
+ cols.extend(('osm_id', 'osm_type'))
+ elif '!' in col:
+ name, fmt = col.rsplit('!', 1)
+ if fmt in ('wkt', 'in_box'):
+ cols.append(f"ST_AsText({name}) as {name}")
+ else:
+ cols.append(name.split('+')[0])
+ else:
+ cols.append(col.split('+')[0])
+
+ with conn.cursor(row_factory=dict_row) as cur:
+ cur.execute(pysql.SQL(f"SELECT {','.join(cols)} FROM")
+ + pysql.Identifier(tablename))
+
+ table_content = ''
+ for row in cur:
+ table_content += '\n' + str(row)
+ for i in lines:
+ for col, value in zip(data[0], data[i]):
+ if ResultAttr(row, col, grid=grid) != (None if value == '-' else value):
+ break
+ else:
+ lines.remove(i)
+ break
+ else:
+ assert not exact, f"Unexpected row in table {tablename}: {row}"
+
+ assert not lines, \
+ "Rows not found:\n" \
+ + '\n'.join(str(data[i]) for i in lines) \
+ + "\nTable content:\n" \
+ + table_content
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+Helper functions for managing test databases.
+"""
+import asyncio
+import psycopg
+from psycopg import sql as pysql
+
+from nominatim_db.tools.database_import import setup_database_skeleton, create_tables, \
+ create_partition_tables, create_search_indices
+from nominatim_db.data.country_info import setup_country_tables, create_country_names
+from nominatim_db.tools.refresh import create_functions, load_address_levels_from_config
+from nominatim_db.tools.exec_utils import run_osm2pgsql
+from nominatim_db.tokenizer import factory as tokenizer_factory
+
+
+class DBManager:
+
+ def __init__(self, purge=False):
+ self.purge = purge
+
+ def check_for_db(self, dbname):
+ """ Check if the given DB already exists.
+ When the purge option is set, then an existing database will
+ be deleted and the function returns that it does not exist.
+ """
+ if self.purge:
+ self.drop_db(dbname)
+ return False
+
+ return self.exists_db(dbname)
+
+ def drop_db(self, dbname):
+ """ Drop the given database if it exists.
+ """
+ with psycopg.connect(dbname='postgres') as conn:
+ conn.autocommit = True
+ conn.execute(pysql.SQL('DROP DATABASE IF EXISTS')
+ + pysql.Identifier(dbname))
+
+ def exists_db(self, dbname):
+ """ Check if a database with the given name exists already.
+ """
+ with psycopg.connect(dbname='postgres') as conn:
+ cur = conn.execute('select count(*) from pg_database where datname = %s',
+ (dbname,))
+ return cur.fetchone()[0] == 1
+
+ def create_db_from_template(self, dbname, template):
+ """ Create a new database from the given template database.
+ Any existing database with the same name will be dropped.
+ """
+ with psycopg.connect(dbname='postgres') as conn:
+ conn.autocommit = True
+ conn.execute(pysql.SQL('DROP DATABASE IF EXISTS')
+ + pysql.Identifier(dbname))
+ conn.execute(pysql.SQL('CREATE DATABASE {} WITH TEMPLATE {}')
+ .format(pysql.Identifier(dbname),
+ pysql.Identifier(template)))
+
+ def setup_template_db(self, config):
+ """ Create a template DB which contains the necessary extensions
+ and basic static tables.
+
+ The template will only be created if the database does not yet
+ exist or 'purge' is set.
+ """
+ dsn = config.get_libpq_dsn()
+
+ if self.check_for_db(config.get_database_params()['dbname']):
+ return
+
+ setup_database_skeleton(dsn)
+
+ run_osm2pgsql(dict(osm2pgsql='osm2pgsql',
+ osm2pgsql_cache=1,
+ osm2pgsql_style=str(config.get_import_style_file()),
+ osm2pgsql_style_path=config.lib_dir.lua,
+ threads=1,
+ dsn=dsn,
+ flatnode_file='',
+ tablespaces=dict(slim_data='', slim_index='',
+ main_data='', main_index=''),
+ append=False,
+ import_data=b'<osm version="0.6"></osm>'))
+
+ setup_country_tables(dsn, config.lib_dir.data)
+
+ with psycopg.connect(dsn) as conn:
+ create_tables(conn, config)
+ load_address_levels_from_config(conn, config)
+ create_partition_tables(conn, config)
+ create_functions(conn, config, enable_diff_updates=False)
+ asyncio.run(create_search_indices(conn, config))
+
+ tokenizer = tokenizer_factory.create_tokenizer(config)
+ create_country_names(conn, tokenizer)
--- /dev/null
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+# This file is part of Nominatim. (https://nominatim.org)
+#
+# Copyright (C) 2025 by the Nominatim developer community.
+# For a full list of authors see the git log.
+"""
+A grid describing node placement in an area.
+Useful for visually describing geometries.
+"""
+
+
+class Grid:
+
+ def __init__(self, table, step, origin):
+ if step is None:
+ step = 0.00001
+ if origin is None:
+ origin = (0.0, 0.0)
+ self.grid = {}
+
+ y = origin[1]
+ for line in table:
+ x = origin[0]
+ for pt_id in line:
+ if pt_id:
+ self.grid[pt_id] = (x, y)
+ x += step
+ y += step
+
+ def get(self, nodeid):
+ """ Get the coordinates for the given grid node.
+ """
+ return self.grid.get(nodeid)
+
+ def parse_point(self, value):
+ """ Get the coordinates for either a grid node or a full coordinate.
+ """
+ value = value.strip()
+ if ' ' in value:
+ return [float(v) for v in value.split(' ', 1)]
+
+ return self.grid.get(value)
+
+ def parse_line(self, value):
+ return [self.parse_point(p) for p in value.split(',')]
import random
import string
+from .geometry_alias import ALIASES
+
class PlaceColumn:
- """ Helper class to collect contents from a behave table row and
+ """ Helper class to collect contents from a BDD table row and
insert it into the place table.
"""
- def __init__(self, context):
+ def __init__(self, grid=None):
self.columns = {'admin_level': 15}
- self.context = context
+ self.grid = grid
self.geometry = None
- def add_row(self, row, force_name):
+ def add_row(self, headings, row, force_name):
""" Parse the content from the given behave row as place column data.
"""
- for name, value in zip(row.headings, row.cells):
+ for name, value in zip(headings, row):
self._add(name, value)
assert 'osm_type' in self.columns, "osm column missing"
self._add_hstore('address', 'country', value)
def _set_key_geometry(self, value):
- self.geometry = self.context.osm.parse_geometry(value)
- assert self.geometry is not None, "Bad geometry: {}".format(value)
+ if value.startswith('country:'):
+ ccode = value[8:].upper()
+ self.geometry = "ST_SetSRID(ST_Point({}, {}), 4326)".format(*ALIASES[ccode])
+ elif ',' not in value:
+ if self.grid:
+ pt = self.grid.parse_point(value)
+ else:
+ pt = value.split(' ')
+ self.geometry = f"ST_SetSRID(ST_Point({pt[0]}, {pt[1]}), 4326)"
+ elif '(' not in value:
+ if self.grid:
+ coords = ','.join(' '.join(f"{p:.7f}" for p in pt)
+ for pt in self.grid.parse_line(value))
+ else:
+ coords = value
+ self.geometry = f"'srid=4326;LINESTRING({coords})'::geometry"
+ else:
+ if self.grid:
+ coords = ','.join(' '.join(f"{p:.7f}" for p in pt)
+ for pt in self.grid.parse_line(value[1:-1]))
+ else:
+ coords = value[1:-1]
+ self.geometry = f"'srid=4326;POLYGON(({coords}))'::geometry"
def _add_hstore(self, column, key, value):
if column in self.columns:
""" Insert the collected data into the database.
"""
if self.columns['osm_type'] == 'N' and self.geometry is None:
- pt = self.context.osm.grid_node(self.columns['osm_id'])
+ pt = self.grid.get(str(self.columns['osm_id'])) if self.grid else None
if pt is None:
pt = (random.uniform(-180, 180), random.uniform(-90, 90))
- self.geometry = "ST_SetSRID(ST_Point(%f, %f), 4326)" % pt
+ self.geometry = "ST_SetSRID(ST_Point({}, {}), 4326)".format(*pt)
else:
assert self.geometry is not None, "Geometry missing"
def test_query_node_empty(qnode):
- assert not qnode.has_tokens(3, query.TOKEN_PARTIAL)
assert qnode.get_tokens(3, query.TOKEN_WORD) is None
assert qnode.has_tokens(2, query.TOKEN_PARTIAL)
assert qnode.has_tokens(2, query.TOKEN_WORD)
- assert qnode.get_tokens(3, query.TOKEN_PARTIAL) is None
assert qnode.get_tokens(2, query.TOKEN_COUNTRY) is None
assert len(qnode.get_tokens(2, query.TOKEN_PARTIAL)) == 2
assert len(qnode.get_tokens(2, query.TOKEN_WORD)) == 1
assert q.get_tokens(query.TokenRange(0, 2), query.TOKEN_WORD) == []
assert len(q.get_tokens(query.TokenRange(1, 2), query.TOKEN_WORD)) == 2
- partials = q.get_partials_list(query.TokenRange(0, 2))
+ partials = list(q.iter_partials(query.TokenRange(0, 2)))
assert len(partials) == 2
assert [t.token for t in partials] == [1, 2]
q.add_token(query.TokenRange(0, 1), query.TOKEN_PARTIAL, mktoken(1))
q.add_token(query.TokenRange(1, 2), query.TOKEN_COUNTRY, mktoken(100))
- assert q.get_tokens(query.TokenRange(0, 1), query.TOKEN_PARTIAL) == []
assert len(q.get_tokens(query.TokenRange(1, 2), query.TOKEN_COUNTRY)) == 1
q.add_token(query.TokenRange(0, 1), query.TOKEN_NEAR_ITEM, mktoken(2))
q.add_token(query.TokenRange(0, 1), query.TOKEN_QUALIFIER, mktoken(3))
- assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_PARTIAL)) == 1
+ assert q.nodes[0].partial.token == 1
assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_NEAR_ITEM)) == 1
assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_QUALIFIER)) == 0
q.add_token(query.TokenRange(*trange), query.TOKEN_NEAR_ITEM, mktoken(2))
q.add_token(query.TokenRange(*trange), query.TOKEN_QUALIFIER, mktoken(3))
- assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_PARTIAL)) == 1
+ assert q.nodes[0].partial.token == 1
assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_NEAR_ITEM)) == 0
assert len(q.get_tokens(query.TokenRange(0, 1), query.TOKEN_QUALIFIER)) == 1
- assert len(q.get_tokens(query.TokenRange(1, 2), query.TOKEN_PARTIAL)) == 1
+ assert q.nodes[1].partial.token == 1
assert len(q.get_tokens(query.TokenRange(1, 2), query.TOKEN_NEAR_ITEM)) == 0
assert len(q.get_tokens(query.TokenRange(1, 2), query.TOKEN_QUALIFIER)) == 1
assert query.source[0].text == 'foo bar'
assert query.num_token_slots() == 2
- assert len(query.nodes[0].starting) == 1
- assert not query.nodes[1].starting
+ assert query.nodes[0].partial.token == 1
+ assert query.nodes[1].partial is None
@pytest.mark.asyncio
@pytest.mark.asyncio
-@pytest.mark.parametrize('term,order', [('23456', ['P', 'H', 'W', 'w']),
- ('3', ['H', 'W', 'w'])])
+@pytest.mark.parametrize('term,order', [('23456', ['P', 'H', 'W']),
+ ('3', ['H', 'W'])])
async def test_penalty_postcodes_and_housenumbers(conn, term, order):
ana = await tok.create_query_analyzer(conn)
property_table.set('tokenizer', 'dummy')
def _create_tokenizer():
- return dummy_tokenizer.DummyTokenizer(None, None)
+ return dummy_tokenizer.DummyTokenizer(None)
return _create_tokenizer
from nominatim_db.config import Configuration
-def create(dsn, data_dir):
+def create(dsn):
""" Create a new instance of the tokenizer provided by this module.
"""
- return DummyTokenizer(dsn, data_dir)
+ return DummyTokenizer(dsn)
class DummyTokenizer:
- def __init__(self, dsn, data_dir):
+ def __init__(self, dsn):
self.dsn = dsn
- self.data_dir = data_dir
self.init_state = None
self.analyser_cache = {}
assert isinstance(tokenizer, DummyTokenizer)
assert tokenizer.init_state == "new"
- assert (self.config.project_dir / 'tokenizer').is_dir()
assert properties.get_property(temp_db_conn, 'tokenizer') == 'dummy'
- def test_setup_tokenizer_dir_exists(self):
- (self.config.project_dir / 'tokenizer').mkdir()
-
- tokenizer = factory.create_tokenizer(self.config)
-
- assert isinstance(tokenizer, DummyTokenizer)
- assert tokenizer.init_state == "new"
-
- def test_setup_tokenizer_dir_failure(self):
- (self.config.project_dir / 'tokenizer').write_text("foo")
-
- with pytest.raises(UsageError):
- factory.create_tokenizer(self.config)
-
def test_load_tokenizer(self):
factory.create_tokenizer(self.config)
self.config.project_dir = self.config.project_dir
factory.get_tokenizer_for_db(self.config)
- assert (self.config.project_dir / 'tokenizer').exists()
def test_load_missing_property(self, temp_db_cursor):
factory.create_tokenizer(self.config)
@pytest.fixture
-def tokenizer_factory(dsn, tmp_path, property_table,
- sql_preprocessor, place_table, word_table):
- (tmp_path / 'tokenizer').mkdir()
-
+def tokenizer_factory(dsn, property_table, sql_preprocessor, place_table, word_table):
def _maker():
- return icu_tokenizer.create(dsn, tmp_path / 'tokenizer')
+ return icu_tokenizer.create(dsn)
return _maker
@pytest.fixture
def tokenizer():
- return dummy_tokenizer.DummyTokenizer(None, None)
+ return dummy_tokenizer.DummyTokenizer(None)
@pytest.fixture
return _insert_implicit_postcode
-def test_postcodes_empty(dsn, postcode_table, place_table,
- tmp_path, tokenizer):
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+def test_postcodes_empty(dsn, postcode_table, place_table, tokenizer):
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert not postcode_table.row_set
-def test_postcodes_add_new(dsn, postcode_table, tmp_path,
- insert_implicit_postcode, tokenizer):
+def test_postcodes_add_new(dsn, postcode_table, insert_implicit_postcode, tokenizer):
insert_implicit_postcode(1, 'xx', 'POINT(10 12)', dict(postcode='9486'))
postcode_table.add('yy', '9486', 99, 34)
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert postcode_table.row_set == {('xx', '9486', 10, 12), }
assert postcode_table.row_set == {('xx', 'AB 4511', 10, 12)}
-def test_postcodes_replace_coordinates_close(dsn, postcode_table, tmp_path,
+def test_postcodes_replace_coordinates_close(dsn, postcode_table,
insert_implicit_postcode, tokenizer):
insert_implicit_postcode(1, 'xx', 'POINT(10 12)', dict(postcode='AB 4511'))
postcode_table.add('xx', 'AB 4511', 10, 11.99999)
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert postcode_table.row_set == {('xx', 'AB 4511', 10, 11.99999)}
-def test_postcodes_remove(dsn, postcode_table, tmp_path,
+def test_postcodes_remove(dsn, postcode_table,
insert_implicit_postcode, tokenizer):
insert_implicit_postcode(1, 'xx', 'POINT(10 12)', dict(postcode='AB 4511'))
postcode_table.add('xx', 'badname', 10, 12)
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert postcode_table.row_set == {('xx', 'AB 4511', 10, 12)}
-def test_postcodes_ignore_empty_country(dsn, postcode_table, tmp_path,
+def test_postcodes_ignore_empty_country(dsn, postcode_table,
insert_implicit_postcode, tokenizer):
insert_implicit_postcode(1, None, 'POINT(10 12)', dict(postcode='AB 4511'))
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert not postcode_table.row_set
-def test_postcodes_remove_all(dsn, postcode_table, place_table,
- tmp_path, tokenizer):
+def test_postcodes_remove_all(dsn, postcode_table, place_table, tokenizer):
postcode_table.add('ch', '5613', 10, 12)
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert not postcode_table.row_set
-def test_postcodes_multi_country(dsn, postcode_table, tmp_path,
+def test_postcodes_multi_country(dsn, postcode_table,
insert_implicit_postcode, tokenizer):
insert_implicit_postcode(1, 'de', 'POINT(10 12)', dict(postcode='54451'))
insert_implicit_postcode(2, 'cc', 'POINT(100 56)', dict(postcode='DD23 T'))
insert_implicit_postcode(3, 'de', 'POINT(10.3 11.0)', dict(postcode='54452'))
insert_implicit_postcode(4, 'cc', 'POINT(10.3 11.0)', dict(postcode='54452'))
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert postcode_table.row_set == {('de', '54451', 10, 12),
('de', '54452', 10.3, 11.0),
assert postcodes.can_compute(dsn)
-def test_no_placex_entry(dsn, tmp_path, temp_db_cursor, place_row, postcode_table, tokenizer):
+def test_no_placex_entry(dsn, temp_db_cursor, place_row, postcode_table, tokenizer):
# Rewrite the get_country_code function to verify its execution.
temp_db_cursor.execute("""
CREATE OR REPLACE FUNCTION get_country_code(place geometry)
END; $$ LANGUAGE plpgsql;
""")
place_row(geom='SRID=4326;POINT(10 12)', address=dict(postcode='AB 4511'))
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert postcode_table.row_set == {('yy', 'AB 4511', 10, 12)}
-def test_discard_badly_formatted_postcodes(dsn, tmp_path, temp_db_cursor, place_row,
+def test_discard_badly_formatted_postcodes(dsn, temp_db_cursor, place_row,
postcode_table, tokenizer):
# Rewrite the get_country_code function to verify its execution.
temp_db_cursor.execute("""
END; $$ LANGUAGE plpgsql;
""")
place_row(geom='SRID=4326;POINT(10 12)', address=dict(postcode='AB 4511'))
- postcodes.update_postcodes(dsn, tmp_path, tokenizer)
+ postcodes.update_postcodes(dsn, None, tokenizer)
assert not postcode_table.row_set
projects / nominatim.git / commitdiff