]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
7 years agocoding style and some documentation
Sarah Hoffmann [Mon, 9 Oct 2017 21:12:13 +0000 (23:12 +0200)]
coding style and some documentation

7 years agomove complete search query code into SearchDescription
Sarah Hoffmann [Mon, 9 Oct 2017 20:55:50 +0000 (22:55 +0200)]
move complete search query code into SearchDescription

7 years agoadapt phpunit tests to new SearchContext class
Sarah Hoffmann [Mon, 9 Oct 2017 20:11:46 +0000 (22:11 +0200)]
adapt phpunit tests to new SearchContext class

7 years agomove country list to SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 21:33:54 +0000 (23:33 +0200)]
move country list to SearchContext

7 years agomove excluded place list to SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 21:15:06 +0000 (23:15 +0200)]
move excluded place list to SearchContext

7 years agomove viewbox sql to new SearchContext
Sarah Hoffmann [Sun, 8 Oct 2017 20:44:01 +0000 (22:44 +0200)]
move viewbox sql to new SearchContext

7 years agoreplace NearPoint with a more generic context object
Sarah Hoffmann [Sun, 8 Oct 2017 19:23:31 +0000 (21:23 +0200)]
replace NearPoint with a more generic context object

The NearPoint is actually common to all SearchDescriptions
and there is other context data as well. like viewbox, that
needs to be available to the search object but is common.

7 years agodon't trust words from word table to be sanatized
Sarah Hoffmann [Sun, 8 Oct 2017 15:36:38 +0000 (17:36 +0200)]
don't trust words from word table to be sanatized

7 years agoadd missing include
Sarah Hoffmann [Sun, 8 Oct 2017 15:13:41 +0000 (17:13 +0200)]
add missing include

7 years agofix CodeSniffer violations
Sarah Hoffmann [Sun, 8 Oct 2017 15:00:59 +0000 (17:00 +0200)]
fix CodeSniffer violations

7 years agofix more syntax issues
Sarah Hoffmann [Sun, 8 Oct 2017 14:42:04 +0000 (16:42 +0200)]
fix more syntax issues

7 years agomove Search dump function into SearchDescription class
Sarah Hoffmann [Sun, 8 Oct 2017 14:03:30 +0000 (16:03 +0200)]
move Search dump function into SearchDescription class

7 years agofix syntax errors from introduction of SearchDescription
Sarah Hoffmann [Sun, 8 Oct 2017 13:26:14 +0000 (15:26 +0200)]
fix syntax errors from introduction of  SearchDescription

7 years agoconvert getGroupedSearches to SearchDescription class
Sarah Hoffmann [Sun, 8 Oct 2017 10:57:22 +0000 (12:57 +0200)]
convert getGroupedSearches to SearchDescription class

7 years agoadd function to convert array to SQL
Sarah Hoffmann [Sun, 8 Oct 2017 08:06:17 +0000 (10:06 +0200)]
add function to convert array to SQL

7 years agouse SearchDescription class in query loop
Sarah Hoffmann [Sat, 7 Oct 2017 10:01:56 +0000 (12:01 +0200)]
use SearchDescription class in query loop

7 years agomove initial search setup to new class type
Sarah Hoffmann [Thu, 5 Oct 2017 22:14:48 +0000 (00:14 +0200)]
move initial search setup to new class type

7 years agoadd new class for searches
Sarah Hoffmann [Thu, 5 Oct 2017 21:03:03 +0000 (23:03 +0200)]
add new class for searches

7 years agodrop searches with excluded country codes earlier
Sarah Hoffmann [Sat, 7 Oct 2017 10:23:46 +0000 (12:23 +0200)]
drop searches with excluded country codes earlier

7 years agoremove code for dropping address terms
Sarah Hoffmann [Sat, 7 Oct 2017 09:53:33 +0000 (11:53 +0200)]
remove code for dropping address terms

This code has been inactive in quite a while and is a suboptimal
solution. We need to be much more selective in what gets dropped.

7 years agofix variable names
Sarah Hoffmann [Fri, 6 Oct 2017 20:01:52 +0000 (22:01 +0200)]
fix variable names

7 years agofurther restrict use of partial terms in names
Sarah Hoffmann [Fri, 6 Oct 2017 19:36:28 +0000 (21:36 +0200)]
further restrict use of partial terms in names

7 years agohousenumbers may only appear before or after the name
Sarah Hoffmann [Fri, 6 Oct 2017 19:12:25 +0000 (21:12 +0200)]
housenumbers may only appear before or after the name

7 years agopenalize search order where a country comes first
Sarah Hoffmann [Fri, 6 Oct 2017 19:07:33 +0000 (21:07 +0200)]
penalize search order where a country comes first

7 years agoallow postcodes and housenumbers together
Sarah Hoffmann [Fri, 6 Oct 2017 18:48:35 +0000 (20:48 +0200)]
allow postcodes and housenumbers together

Fixes #805.

7 years agosanitize special search term before normalizing
Sarah Hoffmann [Thu, 5 Oct 2017 22:22:27 +0000 (00:22 +0200)]
sanitize special search term before normalizing

7 years agofix postcode search
Sarah Hoffmann [Wed, 4 Oct 2017 21:22:04 +0000 (23:22 +0200)]
fix postcode search

Name token must be fully replaced with the postcode and
postcode search must be done only once.

7 years agoonly allow either postcode or special search
Sarah Hoffmann [Wed, 4 Oct 2017 18:15:06 +0000 (20:15 +0200)]
only allow either postcode or special search

Fixes #804.

7 years agouse correct source for radius column in debug view
Sarah Hoffmann [Wed, 4 Oct 2017 18:14:35 +0000 (20:14 +0200)]
use correct source for radius column in debug view

7 years agotests: more coverage for all API endpoints
Sarah Hoffmann [Tue, 3 Oct 2017 22:05:34 +0000 (00:05 +0200)]
tests: more coverage for all API endpoints

7 years agoMerge pull request #803 from lonvia/update-postcodes
Sarah Hoffmann [Tue, 3 Oct 2017 14:28:22 +0000 (16:28 +0200)]
Merge pull request #803 from lonvia/update-postcodes

Add script to update table with artifical postcode centroids

7 years agoadd script for updating postcodes
Sarah Hoffmann [Tue, 3 Oct 2017 10:07:26 +0000 (12:07 +0200)]
add script for updating postcodes

7 years agomove psqlRunScript implementation into cmd lib
Sarah Hoffmann [Tue, 3 Oct 2017 08:16:17 +0000 (10:16 +0200)]
move psqlRunScript implementation into cmd lib

Function needed for update.php as well.

7 years agotest: remove road-fallback test from db tests
Sarah Hoffmann [Tue, 3 Oct 2017 12:26:08 +0000 (14:26 +0200)]
test: remove road-fallback test from db tests

This should be tested in the api section.

7 years agofix search for postcode via structured query
Sarah Hoffmann [Tue, 3 Oct 2017 10:10:27 +0000 (12:10 +0200)]
fix search for postcode via structured query

Results from the artifical postcode table were dropped
when reevaluating rank of results.

7 years agomore coverage tests for Geocode.php
Sarah Hoffmann [Mon, 2 Oct 2017 21:09:45 +0000 (23:09 +0200)]
more coverage tests for Geocode.php

7 years agoremove unnecessary size check
Sarah Hoffmann [Mon, 2 Oct 2017 20:31:52 +0000 (22:31 +0200)]
remove unnecessary size check

7 years agobe more strict with searches involving house numbers
Sarah Hoffmann [Mon, 2 Oct 2017 19:57:44 +0000 (21:57 +0200)]
be more strict with searches involving house numbers

Housenumber searches without a name cannot exist per
definition. Searches with only a name but no address
should not fall back on a search without house number.
This should improve postcode only search.

7 years agoavoid unnecessary SQL when rechecking rank restrictions
Sarah Hoffmann [Mon, 2 Oct 2017 18:42:37 +0000 (20:42 +0200)]
avoid unnecessary SQL when rechecking rank restrictions

7 years agofix viewbox related test
Sarah Hoffmann [Mon, 2 Oct 2017 18:39:33 +0000 (20:39 +0200)]
fix viewbox related test

Coordinates are no longer specially ordered.

7 years agodocs: clarify how to run pip install
Sarah Hoffmann [Sun, 1 Oct 2017 20:48:16 +0000 (22:48 +0200)]
docs: clarify how to run pip install

Fixes #792.

7 years agoorder of viewbox coordinates does not matter
Sarah Hoffmann [Sat, 30 Sep 2017 12:16:07 +0000 (14:16 +0200)]
order of viewbox coordinates does not matter

7 years agoMerge pull request #802 from mtmail/coordinate-extract-missing-first-minus-sign
Sarah Hoffmann [Sun, 1 Oct 2017 20:42:24 +0000 (22:42 +0200)]
Merge pull request #802 from mtmail/coordinate-extract-missing-first-minus-sign

NearPoint::extractFromQuery - greedy-match optional quote sign

7 years agoskip output of lat/lon in debug when no near point given
Sarah Hoffmann [Sat, 30 Sep 2017 10:24:37 +0000 (12:24 +0200)]
skip output of lat/lon in debug when no near point given

7 years agofix index when rechecking postcode name
Sarah Hoffmann [Sat, 30 Sep 2017 10:19:16 +0000 (12:19 +0200)]
fix index when rechecking postcode name

7 years agoreturn unchanged term if normalizer was not found
Sarah Hoffmann [Sat, 30 Sep 2017 07:39:47 +0000 (09:39 +0200)]
return unchanged term if normalizer was not found

7 years agoNearPoint::extractFromQuery - greedy-match optional quote sign
marc tobias [Thu, 21 Sep 2017 17:13:50 +0000 (19:13 +0200)]
NearPoint::extractFromQuery - greedy-match optional quote sign

7 years agomore API tests (mostly for user errors)
Sarah Hoffmann [Tue, 19 Sep 2017 21:06:31 +0000 (23:06 +0200)]
more API tests (mostly for user errors)

7 years agoenable coverage also for tests with HTTP errors
Sarah Hoffmann [Tue, 19 Sep 2017 20:42:09 +0000 (22:42 +0200)]
enable coverage also for tests with HTTP errors

7 years agoMerge pull request #798 from mtmail/coordinate-extract-missing-first-minus-sign
Sarah Hoffmann [Tue, 19 Sep 2017 19:23:49 +0000 (21:23 +0200)]
Merge pull request #798 from mtmail/coordinate-extract-missing-first-minus-sign

fix to NearPoint::extractFromQuery handling first minus sign

7 years agofix to NearPoint::extractFromQuery handling first minus sign
marc tobias [Tue, 19 Sep 2017 11:40:10 +0000 (12:40 +0100)]
fix to NearPoint::extractFromQuery handling first minus sign

7 years agofix handling of near queries with special search
Sarah Hoffmann [Mon, 18 Sep 2017 22:07:11 +0000 (00:07 +0200)]
fix handling of near queries with special search

Make sure to use the classtype tables with near search and
allow to search for arbitrary key/values (forbidding it
for viewbox searches).

Add tests for near queries.

7 years agofix display of nearpoint in debug view
Sarah Hoffmann [Mon, 18 Sep 2017 21:06:30 +0000 (23:06 +0200)]
fix display of nearpoint in debug view

7 years agoreinstate key-value amenity search
Sarah Hoffmann [Mon, 18 Sep 2017 20:07:08 +0000 (22:07 +0200)]
reinstate key-value amenity search

Reenable search by the secret special term [key=value]
matching against the given main tag. Note that for most
cases that works only for tags that also have a special
search table.

7 years agomore API tests for code coverage
Sarah Hoffmann [Sun, 17 Sep 2017 21:30:08 +0000 (23:30 +0200)]
more API tests for code coverage

Also fixes two minor issues related to structured queries.

7 years agoimprove code coverage documentation
Sarah Hoffmann [Sun, 17 Sep 2017 18:23:40 +0000 (20:23 +0200)]
improve code coverage documentation

7 years agoreduce message frequency during indexing
Sarah Hoffmann [Sun, 17 Sep 2017 18:13:05 +0000 (20:13 +0200)]
reduce message frequency during indexing

7 years agosetup: bail out earl when something is wrong with nominatim.so
Sarah Hoffmann [Sun, 17 Sep 2017 18:07:03 +0000 (20:07 +0200)]
setup: bail out earl when something is wrong with nominatim.so

7 years agosetup: error out when web site user does not exist
Sarah Hoffmann [Sun, 17 Sep 2017 17:51:00 +0000 (19:51 +0200)]
setup: error out when web site user does not exist

User is needed to be able to grant rights.

7 years agorun psql in quiet mode unless 'verbose' is enabled
Sarah Hoffmann [Sun, 17 Sep 2017 09:34:35 +0000 (11:34 +0200)]
run psql in quiet mode unless 'verbose' is enabled

7 years agotimestamp info message and repeat warnings at end
Sarah Hoffmann [Sun, 17 Sep 2017 09:06:52 +0000 (11:06 +0200)]
timestamp info message and repeat warnings at end

7 years agodocs: add more requirements for running tests
Sarah Hoffmann [Sat, 16 Sep 2017 20:11:39 +0000 (22:11 +0200)]
docs: add more requirements for running tests

7 years agoMerge pull request #782 from lonvia/rework-postcodes
Sarah Hoffmann [Sat, 16 Sep 2017 13:54:55 +0000 (15:54 +0200)]
Merge pull request #782 from lonvia/rework-postcodes

Rework handling of artificial postcode centroids

7 years agoREADME: point to release instalation instructions
Sarah Hoffmann [Wed, 6 Sep 2017 18:36:59 +0000 (20:36 +0200)]
README: point to release instalation instructions

7 years agoincrease search rank of leisure=park
Sarah Hoffmann [Thu, 31 Aug 2017 19:10:48 +0000 (21:10 +0200)]
increase search rank of leisure=park

Fixes #786.

7 years agocheck that replication URL points to a repo of OSM diffs
Sarah Hoffmann [Tue, 29 Aug 2017 19:04:28 +0000 (21:04 +0200)]
check that replication URL points to a repo of OSM diffs

Also check that pyosmium does not return None to work around
a bad return code in the current release of pyosmium-get-changes.

Fixes #784.

7 years agofurther restrict results for <postcode>, <term>
Sarah Hoffmann [Mon, 21 Aug 2017 20:29:51 +0000 (22:29 +0200)]
further restrict results for <postcode>, <term>

Disallow postcode operator together with housenumbers
and force results around a postcode when no address is
given.

7 years agotests: add new admin scene
Sarah Hoffmann [Sun, 20 Aug 2017 07:29:56 +0000 (09:29 +0200)]
tests: add new admin scene

7 years agofixup tests
Sarah Hoffmann [Sat, 19 Aug 2017 17:36:34 +0000 (19:36 +0200)]
fixup tests

7 years agoenable details view for artificial postcodes
Sarah Hoffmann [Sat, 19 Aug 2017 07:46:56 +0000 (09:46 +0200)]
enable details view for artificial postcodes

7 years agofix subqueries when getting details for postcodes
Sarah Hoffmann [Fri, 18 Aug 2017 21:07:53 +0000 (23:07 +0200)]
fix subqueries when getting details for postcodes

7 years agothrow away searches with two postcodes
Sarah Hoffmann [Fri, 18 Aug 2017 19:34:52 +0000 (21:34 +0200)]
throw away searches with two postcodes

7 years agoadd simple tests for postcode import
Sarah Hoffmann [Sun, 6 Aug 2017 16:42:04 +0000 (18:42 +0200)]
add simple tests for postcode import

7 years agoadapt scene generation tool to newest libosmium
Sarah Hoffmann [Sun, 6 Aug 2017 16:41:30 +0000 (18:41 +0200)]
adapt scene generation tool to newest libosmium

7 years agomove adding postcodes to word table to calculation step
Sarah Hoffmann [Sun, 16 Jul 2017 18:32:21 +0000 (20:32 +0200)]
move adding postcodes to word table to calculation step

7 years agoadd migration path for postcodes
Sarah Hoffmann [Sun, 9 Jul 2017 19:33:40 +0000 (21:33 +0200)]
add migration path for postcodes

7 years agonormalize all postcodes before use
Sarah Hoffmann [Sun, 16 Jul 2017 17:55:55 +0000 (19:55 +0200)]
normalize all postcodes before use

7 years agosimplify search for artificial postcodes
Sarah Hoffmann [Sun, 16 Jul 2017 17:49:47 +0000 (19:49 +0200)]
simplify search for artificial postcodes

7 years agospecial handling for estimated postcode in areas
Sarah Hoffmann [Sun, 9 Jul 2017 15:29:48 +0000 (17:29 +0200)]
special handling for estimated postcode in areas

Don't add a postcode at all if multiple estimated
postcodes fall into the area.

7 years agofix more tests
Sarah Hoffmann [Sun, 9 Jul 2017 08:09:37 +0000 (10:09 +0200)]
fix more tests

7 years agofix API tests wrt postcodes
Sarah Hoffmann [Sun, 9 Jul 2017 07:37:10 +0000 (09:37 +0200)]
fix API tests wrt postcodes

7 years agofix postcode-related tests
Sarah Hoffmann [Thu, 6 Jul 2017 21:54:07 +0000 (23:54 +0200)]
fix postcode-related tests

7 years agoremove lat/lon check for search terms
Sarah Hoffmann [Thu, 6 Jul 2017 21:11:17 +0000 (23:11 +0200)]
remove lat/lon check for search terms

Was only used with GB postcodes which were removed.

7 years agorequire postcodes to match exactly in normalised form
Sarah Hoffmann [Thu, 6 Jul 2017 21:06:13 +0000 (23:06 +0200)]
require postcodes to match exactly in normalised form

7 years agoinclude GB CodePoint data into location_postcode table
Sarah Hoffmann [Thu, 6 Jul 2017 20:48:09 +0000 (22:48 +0200)]
include GB CodePoint data into location_postcode table

7 years agoimprove calculation of postcode for interpolations
Sarah Hoffmann [Thu, 6 Jul 2017 18:42:03 +0000 (20:42 +0200)]
improve calculation of postcode for interpolations

7 years agomove postcode indexing to end of setup
Sarah Hoffmann [Thu, 6 Jul 2017 17:51:18 +0000 (19:51 +0200)]
move postcode indexing to end of setup

The search_name tables are needed for finding the parent,
so the rest of the database must be indexed.

7 years agotake postcode into account for other searches
Sarah Hoffmann [Wed, 5 Jul 2017 21:35:22 +0000 (23:35 +0200)]
take postcode into account for other searches

Existence of postcode is still optional but if a matching
result is found, then non-matching ones will be discarded.

7 years agoimmediately drop searches where requested country code does not match
Sarah Hoffmann [Wed, 5 Jul 2017 19:34:00 +0000 (21:34 +0200)]
immediately drop searches where requested country code does not match

7 years agotake address part into account in postcode search
Sarah Hoffmann [Wed, 5 Jul 2017 19:15:50 +0000 (21:15 +0200)]
take address part into account in postcode search

7 years agomerging back postcodes is no longer necessary
Sarah Hoffmann [Tue, 4 Jul 2017 21:42:33 +0000 (23:42 +0200)]
merging back postcodes is no longer necessary

7 years agoadd search for postcode
Sarah Hoffmann [Tue, 4 Jul 2017 21:25:48 +0000 (23:25 +0200)]
add search for postcode

Implements the 'postcode' operator.

7 years agomove postcodes into special operation for Searches
Sarah Hoffmann [Mon, 3 Jul 2017 22:02:11 +0000 (00:02 +0200)]
move postcodes into special operation for Searches

Introduces postcode field in searches and sorts out any marked
postcodes.

7 years agofix typo
Sarah Hoffmann [Mon, 3 Jul 2017 21:03:19 +0000 (23:03 +0200)]
fix typo

7 years agoadd postcodes as special items in word table
Sarah Hoffmann [Mon, 3 Jul 2017 20:13:01 +0000 (22:13 +0200)]
add postcodes as special items in word table

7 years agomake sure postcode gets recomputed on update
Sarah Hoffmann [Sun, 2 Jul 2017 14:28:02 +0000 (16:28 +0200)]
make sure postcode gets recomputed on update

7 years agouse only computed postcode when getting address
Sarah Hoffmann [Sun, 2 Jul 2017 12:16:48 +0000 (14:16 +0200)]
use only computed postcode when getting address

Postcodes from address parts are now ignored as they have
been already taken into account when computing the postcode.

7 years agoremove unused get_address_postcode function
Sarah Hoffmann [Sun, 2 Jul 2017 09:37:37 +0000 (11:37 +0200)]
remove unused get_address_postcode function

7 years agonormalize postcodes before adding to location tables
Sarah Hoffmann [Sun, 2 Jul 2017 09:32:32 +0000 (11:32 +0200)]
normalize postcodes before adding to location tables

7 years agoshow address tags and postcode in details
Sarah Hoffmann [Sat, 1 Jul 2017 21:16:01 +0000 (23:16 +0200)]
show address tags and postcode in details