]> git.openstreetmap.org Git - rails.git/blob - .rubocop_todo.yml
Fix new rubocop warnings
[rails.git] / .rubocop_todo.yml
1 # This configuration was generated by
2 # `rubocop --auto-gen-config`
3 # on 2022-02-23 19:11:04 UTC using RuboCop version 1.25.1.
4 # The point is for the user to remove these configuration records
5 # one by one as the offenses are removed from the code base.
6 # Note that changes in the inspected code, or installation of new
7 # versions of RuboCop, may require this file to be generated again.
8
9 # Work around erblint issues.
10 # https://github.com/openstreetmap/openstreetmap-website/issues/2472
11 require:
12   - rubocop-minitest
13   - rubocop-performance
14   - rubocop-rails
15   - rubocop-rake
16
17 # Offense count: 550
18 # Cop supports --auto-correct.
19 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
20 # URISchemes: http, https
21 Layout/LineLength:
22   Max: 270
23
24 # Offense count: 62
25 # Cop supports --auto-correct.
26 Lint/AmbiguousOperatorPrecedence:
27   Exclude:
28     - 'app/controllers/geocoder_controller.rb'
29     - 'app/models/user.rb'
30     - 'lib/bounding_box.rb'
31     - 'lib/osm.rb'
32     - 'lib/rich_text.rb'
33     - 'lib/short_link.rb'
34     - 'test/controllers/api/old_nodes_controller_test.rb'
35     - 'test/lib/short_link_test.rb'
36
37 # Offense count: 34
38 # Configuration parameters: AllowSafeAssignment.
39 Lint/AssignmentInCondition:
40   Exclude:
41     - 'app/controllers/accounts_controller.rb'
42     - 'app/controllers/api/traces_controller.rb'
43     - 'app/controllers/api/user_preferences_controller.rb'
44     - 'app/controllers/application_controller.rb'
45     - 'app/controllers/geocoder_controller.rb'
46     - 'app/controllers/notes_controller.rb'
47     - 'app/controllers/traces_controller.rb'
48     - 'app/controllers/users_controller.rb'
49     - 'app/helpers/application_helper.rb'
50     - 'app/helpers/browse_tags_helper.rb'
51     - 'app/mailers/user_mailer.rb'
52     - 'app/models/client_application.rb'
53     - 'lib/nominatim.rb'
54     - 'lib/osm.rb'
55     - 'script/deliver-message'
56
57 # Offense count: 665
58 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
59 Metrics/AbcSize:
60   Max: 189
61
62 # Offense count: 73
63 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
64 # IgnoredMethods: refine
65 Metrics/BlockLength:
66   Max: 71
67
68 # Offense count: 15
69 # Configuration parameters: CountBlocks.
70 Metrics/BlockNesting:
71   Max: 5
72
73 # Offense count: 25
74 # Configuration parameters: CountComments, CountAsOne.
75 Metrics/ClassLength:
76   Max: 313
77
78 # Offense count: 58
79 # Configuration parameters: IgnoredMethods.
80 Metrics/CyclomaticComplexity:
81   Max: 25
82
83 # Offense count: 742
84 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
85 Metrics/MethodLength:
86   Max: 179
87
88 # Offense count: 1
89 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
90 Metrics/ParameterLists:
91   Max: 6
92
93 # Offense count: 59
94 # Configuration parameters: IgnoredMethods.
95 Metrics/PerceivedComplexity:
96   Max: 26
97
98 # Offense count: 550
99 Minitest/MultipleAssertions:
100   Max: 52
101
102 # Offense count: 1
103 Naming/AccessorMethodName:
104   Exclude:
105     - 'app/helpers/title_helper.rb'
106
107 # Offense count: 8
108 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
109 # NamePrefix: is_, has_, have_
110 # ForbiddenPrefixes: is_, has_, have_
111 # AllowedMethods: is_a?
112 # MethodDefinitionMacros: define_method, define_singleton_method
113 Naming/PredicateName:
114   Exclude:
115     - 'app/models/user.rb'
116
117 # Offense count: 5
118 # Configuration parameters: Database, Include.
119 # SupportedDatabases: mysql, postgresql
120 # Include: db/migrate/*.rb
121 Rails/BulkChangeTable:
122   Exclude:
123     - 'db/migrate/20111116184519_update_oauth.rb'
124     - 'db/migrate/20120208194454_add_domain_to_acl.rb'
125     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
126
127 # Offense count: 2
128 # Configuration parameters: Include.
129 # Include: app/models/**/*.rb
130 Rails/HasAndBelongsToMany:
131   Exclude:
132     - 'app/models/changeset.rb'
133     - 'app/models/user.rb'
134
135 # Offense count: 3
136 # Configuration parameters: Include.
137 # Include: app/helpers/**/*.rb
138 Rails/HelperInstanceVariable:
139   Exclude:
140     - 'app/helpers/title_helper.rb'
141
142 # Offense count: 16
143 # Configuration parameters: IgnoreScopes, Include.
144 # Include: app/models/**/*.rb
145 Rails/InverseOf:
146   Exclude:
147     - 'app/models/changeset.rb'
148     - 'app/models/diary_entry.rb'
149     - 'app/models/friendship.rb'
150     - 'app/models/issue.rb'
151     - 'app/models/message.rb'
152     - 'app/models/note.rb'
153     - 'app/models/user.rb'
154
155 # Offense count: 2
156 # Configuration parameters: Include.
157 # Include: app/controllers/**/*.rb
158 Rails/LexicallyScopedActionFilter:
159   Exclude:
160     - 'app/controllers/oauth2_applications_controller.rb'
161     - 'app/controllers/oauth2_authorizations_controller.rb'
162
163 # Offense count: 5
164 # Configuration parameters: Include.
165 # Include: db/migrate/*.rb
166 Rails/NotNullColumn:
167   Exclude:
168     - 'db/migrate/002_cleanup_osm_db.rb'
169     - 'db/migrate/020_populate_node_tags_and_remove.rb'
170     - 'db/migrate/021_move_to_innodb.rb'
171     - 'db/migrate/025_add_end_time_to_changesets.rb'
172     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
173
174 # Offense count: 9
175 Rails/OutputSafety:
176   Exclude:
177     - 'app/controllers/sessions_controller.rb'
178     - 'app/controllers/users_controller.rb'
179     - 'app/helpers/application_helper.rb'
180     - 'lib/rich_text.rb'
181     - 'test/helpers/application_helper_test.rb'
182
183 # Offense count: 6
184 # Cop supports --auto-correct.
185 Rake/Desc:
186   Exclude:
187     - 'lib/tasks/auto_annotate_models.rake'
188     - 'lib/tasks/eslint.rake'
189     - 'lib/tasks/subscribe_diary_authors.rake'
190     - 'lib/tasks/subscribe_old_changesets.rake'
191
192 # Offense count: 617
193 # Cop supports --auto-correct.
194 # Configuration parameters: EnforcedStyle.
195 # SupportedStyles: always, always_true, never
196 Style/FrozenStringLiteralComment:
197   Enabled: false
198
199 # Offense count: 72
200 # Cop supports --auto-correct.
201 # Configuration parameters: Strict, AllowedNumbers.
202 Style/NumericLiterals:
203   MinDigits: 15