.rubocop_todo.yml

   1 # This configuration was generated by
   2 # `rubocop --auto-gen-config`
   3 # on 2020-08-06 20:53:30 UTC using RuboCop version 0.89.0.
   4 # The point is for the user to remove these configuration records
   5 # one by one as the offenses are removed from the code base.
   6 # Note that changes in the inspected code, or installation of new
   7 # versions of RuboCop, may require this file to be generated again.
   8 # versions of RuboCop, may require this file to be generated again.
   9
  10 # Work around erblint issues.
  11 # https://github.com/openstreetmap/openstreetmap-website/issues/2472
  12 require:
  13   - rubocop-minitest
  14   - rubocop-performance
  15   - rubocop-rails
  16
  17 # Offense count: 568
  18 # Cop supports --auto-correct.
  19 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
  20 # URISchemes: http, https
  21 Layout/LineLength:
  22   Max: 370
  23
  24 # Offense count: 36
  25 # Configuration parameters: AllowSafeAssignment.
  26 Lint/AssignmentInCondition:
  27   Exclude:
  28     - 'app/controllers/api/traces_controller.rb'
  29     - 'app/controllers/api/user_preferences_controller.rb'
  30     - 'app/controllers/application_controller.rb'
  31     - 'app/controllers/geocoder_controller.rb'
  32     - 'app/controllers/notes_controller.rb'
  33     - 'app/controllers/traces_controller.rb'
  34     - 'app/controllers/users_controller.rb'
  35     - 'app/helpers/application_helper.rb'
  36     - 'app/helpers/browse_tags_helper.rb'
  37     - 'app/mailers/notifier.rb'
  38     - 'app/models/client_application.rb'
  39     - 'lib/nominatim.rb'
  40     - 'lib/osm.rb'
  41     - 'script/deliver-message'
  42
  43 # Offense count: 682
  44 # Configuration parameters: IgnoredMethods.
  45 Metrics/AbcSize:
  46   Max: 194
  47
  48 # Offense count: 72
  49 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
  50 # ExcludedMethods: refine
  51 Metrics/BlockLength:
  52   Max: 71
  53
  54 # Offense count: 15
  55 # Configuration parameters: CountBlocks.
  56 Metrics/BlockNesting:
  57   Max: 5
  58
  59 # Offense count: 25
  60 # Configuration parameters: CountComments, CountAsOne.
  61 Metrics/ClassLength:
  62   Max: 645
  63
  64 # Offense count: 68
  65 # Configuration parameters: IgnoredMethods.
  66 Metrics/CyclomaticComplexity:
  67   Max: 26
  68
  69 # Offense count: 735
  70 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
  71 Metrics/MethodLength:
  72   Max: 179
  73
  74 # Offense count: 4
  75 # Configuration parameters: CountKeywordArgs.
  76 Metrics/ParameterLists:
  77   Max: 9
  78
  79 # Offense count: 69
  80 # Configuration parameters: IgnoredMethods.
  81 Metrics/PerceivedComplexity:
  82   Max: 26
  83
  84 # Offense count: 540
  85 Minitest/MultipleAssertions:
  86   Max: 81
  87
  88 # Offense count: 26
  89 # Cop supports --auto-correct.
  90 Minitest/TestMethodName:
  91   Exclude:
  92     - 'test/abilities/api_capability_test.rb'
  93     - 'test/controllers/api/nodes_controller_test.rb'
  94     - 'test/controllers/api/old_nodes_controller_test.rb'
  95     - 'test/controllers/api/relations_controller_test.rb'
  96     - 'test/controllers/api/ways_controller_test.rb'
  97     - 'test/helpers/browse_helper_test.rb'
  98     - 'test/integration/client_applications_test.rb'
  99     - 'test/integration/short_links_test.rb'
 100     - 'test/integration/user_blocks_test.rb'
 101     - 'test/integration/user_creation_test.rb'
 102
 103 # Offense count: 6
 104 Naming/AccessorMethodName:
 105   Exclude:
 106     - 'app/controllers/application_controller.rb'
 107     - 'app/helpers/title_helper.rb'
 108     - 'app/models/old_way.rb'
 109     - 'lib/osm.rb'
 110     - 'lib/potlatch.rb'
 111
 112 # Offense count: 8
 113 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 114 # NamePrefix: is_, has_, have_
 115 # ForbiddenPrefixes: is_, has_, have_
 116 # AllowedMethods: is_a?
 117 # MethodDefinitionMacros: define_method, define_singleton_method
 118 Naming/PredicateName:
 119   Exclude:
 120     - 'spec/**/*'
 121     - 'app/models/changeset.rb'
 122     - 'app/models/old_node.rb'
 123     - 'app/models/old_relation.rb'
 124     - 'app/models/old_way.rb'
 125     - 'app/models/user.rb'
 126     - 'lib/classic_pagination/pagination.rb'
 127
 128 # Offense count: 5
 129 # Configuration parameters: Database, Include.
 130 # SupportedDatabases: mysql, postgresql
 131 # Include: db/migrate/*.rb
 132 Rails/BulkChangeTable:
 133   Exclude:
 134     - 'db/migrate/20111116184519_update_oauth.rb'
 135     - 'db/migrate/20120208194454_add_domain_to_acl.rb'
 136     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 137
 138 # Offense count: 2
 139 # Configuration parameters: Include.
 140 # Include: app/models/**/*.rb
 141 Rails/HasAndBelongsToMany:
 142   Exclude:
 143     - 'app/models/changeset.rb'
 144     - 'app/models/user.rb'
 145
 146 # Offense count: 4
 147 # Configuration parameters: Include.
 148 # Include: app/helpers/**/*.rb
 149 Rails/HelperInstanceVariable:
 150   Exclude:
 151     - 'app/helpers/title_helper.rb'
 152
 153 # Offense count: 1
 154 # Cop supports --auto-correct.
 155 # Configuration parameters: Include.
 156 # Include: app/mailers/**/*.rb
 157 Rails/MailerName:
 158   Exclude:
 159     - 'app/mailers/notifier.rb'
 160
 161 # Offense count: 5
 162 # Configuration parameters: Include.
 163 # Include: db/migrate/*.rb
 164 Rails/NotNullColumn:
 165   Exclude:
 166     - 'db/migrate/002_cleanup_osm_db.rb'
 167     - 'db/migrate/020_populate_node_tags_and_remove.rb'
 168     - 'db/migrate/021_move_to_innodb.rb'
 169     - 'db/migrate/025_add_end_time_to_changesets.rb'
 170     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 171
 172 # Offense count: 19
 173 Rails/OutputSafety:
 174   Exclude:
 175     - 'app/controllers/users_controller.rb'
 176     - 'app/helpers/application_helper.rb'
 177     - 'app/helpers/changesets_helper.rb'
 178     - 'app/helpers/geocoder_helper.rb'
 179     - 'app/helpers/note_helper.rb'
 180     - 'app/helpers/open_graph_helper.rb'
 181     - 'app/helpers/user_blocks_helper.rb'
 182     - 'lib/rich_text.rb'
 183     - 'test/helpers/application_helper_test.rb'
 184
 185 # Offense count: 95
 186 # Cop supports --auto-correct.
 187 # Configuration parameters: EnforcedStyle.
 188 # SupportedStyles: strict, flexible
 189 Rails/TimeZone:
 190   Enabled: false
 191
 192 # Offense count: 6
 193 # Cop supports --auto-correct.
 194 Style/ExplicitBlockArgument:
 195   Exclude:
 196     - 'app/controllers/api/amf_controller.rb'
 197     - 'app/controllers/application_controller.rb'
 198     - 'app/mailers/notifier.rb'
 199     - 'test/integration/client_applications_test.rb'
 200
 201 # Offense count: 572
 202 # Cop supports --auto-correct.
 203 # Configuration parameters: EnforcedStyle.
 204 # SupportedStyles: always, always_true, never
 205 Style/FrozenStringLiteralComment:
 206   Enabled: false
 207
 208 # Offense count: 78
 209 # Cop supports --auto-correct.
 210 # Configuration parameters: Strict.
 211 Style/NumericLiterals:
 212   MinDigits: 11
 213
 214 # Offense count: 20
 215 Style/OptionalBooleanParameter:
 216   Exclude:
 217     - 'app/controllers/api/notes_controller.rb'
 218     - 'app/controllers/application_controller.rb'
 219     - 'app/helpers/browse_helper.rb'
 220     - 'app/models/changeset.rb'
 221     - 'app/models/node.rb'
 222     - 'app/models/relation.rb'
 223     - 'app/models/trace.rb'
 224     - 'app/models/tracepoint.rb'
 225     - 'app/models/way.rb'
 226     - 'test/models/diary_entry_test.rb'
 227     - 'test/models/trace_test.rb'
 228     - 'test/models/tracetag_test.rb'
 229
 230 # Offense count: 44
 231 # Cop supports --auto-correct.
 232 Style/StringConcatenation:
 233   Enabled: false