1 # The ChangesetController is the RESTful interface to Changeset objects
3 class ChangesetController < ApplicationController
7 skip_before_action :verify_authenticity_token, :except => [:list]
8 before_action :authorize_web, :only => [:list, :feed, :comments_feed]
9 before_action :set_locale, :only => [:list, :feed, :comments_feed]
10 before_action :authorize, :only => [:create, :update, :delete, :upload, :include, :close, :comment, :subscribe, :unsubscribe, :hide_comment, :unhide_comment]
11 before_action :require_moderator, :only => [:hide_comment, :unhide_comment]
12 before_action :require_allow_write_api, :only => [:create, :update, :delete, :upload, :include, :close, :comment, :subscribe, :unsubscribe, :hide_comment, :unhide_comment]
13 before_action :require_public_data, :only => [:create, :update, :delete, :upload, :include, :close, :comment, :subscribe, :unsubscribe]
14 before_action :check_api_writable, :only => [:create, :update, :delete, :upload, :include, :comment, :subscribe, :unsubscribe, :hide_comment, :unhide_comment]
15 before_action :check_api_readable, :except => [:create, :update, :delete, :upload, :download, :query, :list, :feed, :comment, :subscribe, :unsubscribe, :comments_feed]
16 before_action(:only => [:list, :feed, :comments_feed]) { |c| c.check_database_readable(true) }
17 around_action :api_call_handle_error, :except => [:list, :feed, :comments_feed]
18 around_action :api_call_timeout, :except => [:list, :feed, :comments_feed, :upload]
19 around_action :web_timeout, :only => [:list, :feed, :comments_feed]
21 # Helper methods for checking consistency
22 include ConsistencyValidations
24 # Create a changeset from XML.
28 cs = Changeset.from_xml(request.raw_post, true)
30 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
31 cs.user = current_user
34 # Subscribe user to changeset comments
35 cs.subscribers << current_user
37 render :plain => cs.id.to_s
41 # Return XML giving the basic info about the changeset. Does not
42 # return anything about the nodes, ways and relations in the changeset.
44 changeset = Changeset.find(params[:id])
46 render :xml => changeset.to_xml(params[:include_discussion].presence).to_s
50 # marks a changeset as closed. this may be called multiple times
51 # on the same changeset, so is idempotent.
55 changeset = Changeset.find(params[:id])
56 check_changeset_consistency(changeset, current_user)
58 # to close the changeset, we'll just set its closed_at time to
59 # now. this might not be enough if there are concurrency issues,
60 # but we'll have to wait and see.
61 changeset.set_closed_time_now
68 # insert a (set of) points into a changeset bounding box. this can only
69 # increase the size of the bounding box. this is a hint that clients can
70 # set either before uploading a large number of changes, or changes that
71 # the client (but not the server) knows will affect areas further away.
73 # only allow POST requests, because although this method is
74 # idempotent, there is no "document" to PUT really...
77 cs = Changeset.find(params[:id])
78 check_changeset_consistency(cs, current_user)
80 # keep an array of lons and lats
84 # the request is in pseudo-osm format... this is kind-of an
85 # abuse, maybe should change to some other format?
86 doc = XML::Parser.string(request.raw_post, :options => XML::Parser::Options::NOERROR).parse
87 doc.find("//osm/node").each do |n|
88 lon << n["lon"].to_f * GeoRecord::SCALE
89 lat << n["lat"].to_f * GeoRecord::SCALE
92 # add the existing bounding box to the lon-lat array
93 lon << cs.min_lon unless cs.min_lon.nil?
94 lat << cs.min_lat unless cs.min_lat.nil?
95 lon << cs.max_lon unless cs.max_lon.nil?
96 lat << cs.max_lat unless cs.max_lat.nil?
98 # collapse the arrays to minimum and maximum
104 # save the larger bounding box and return the changeset, which
105 # will include the bigger bounding box.
107 render :xml => cs.to_xml.to_s
111 # Upload a diff in a single transaction.
113 # This means that each change within the diff must succeed, i.e: that
114 # each version number mentioned is still current. Otherwise the entire
115 # transaction *must* be rolled back.
117 # Furthermore, each element in the diff can only reference the current
120 # Returns: a diffResult document, as described in
121 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
123 # only allow POST requests, as the upload method is most definitely
124 # not idempotent, as several uploads with placeholder IDs will have
125 # different side-effects.
126 # see http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2
129 changeset = Changeset.find(params[:id])
130 check_changeset_consistency(changeset, current_user)
132 diff_reader = DiffReader.new(request.raw_post, changeset)
133 Changeset.transaction do
134 result = diff_reader.commit
135 render :xml => result.to_s
140 # download the changeset as an osmChange document.
142 # to make it easier to revert diffs it would be better if the osmChange
143 # format were reversible, i.e: contained both old and new versions of
144 # modified elements. but it doesn't at the moment...
146 # this method cannot order the database changes fully (i.e: timestamp and
147 # version number may be too coarse) so the resulting diff may not apply
148 # to a different database. however since changesets are not atomic this
149 # behaviour cannot be guaranteed anyway and is the result of a design
152 changeset = Changeset.find(params[:id])
154 # get all the elements in the changeset which haven't been redacted
155 # and stick them in a big array.
156 elements = [changeset.old_nodes.unredacted,
157 changeset.old_ways.unredacted,
158 changeset.old_relations.unredacted].flatten
160 # sort the elements by timestamp and version number, as this is the
161 # almost sensible ordering available. this would be much nicer if
162 # global (SVN-style) versioning were used - then that would be
164 elements.sort! do |a, b|
165 if a.timestamp == b.timestamp
166 a.version <=> b.version
168 a.timestamp <=> b.timestamp
172 # create changeset and user caches
174 user_display_name_cache = {}
176 # create an osmChange document for the output
177 result = OSM::API.new.get_xml_doc
178 result.root.name = "osmChange"
180 # generate an output element for each operation. note: we avoid looking
181 # at the history because it is simpler - but it would be more correct to
182 # check these assertions.
183 elements.each do |elt|
186 # first version, so it must be newly-created.
187 created = XML::Node.new "create"
188 created << elt.to_xml_node(changeset_cache, user_display_name_cache)
191 modified = XML::Node.new "modify"
192 modified << elt.to_xml_node(changeset_cache, user_display_name_cache)
194 # if the element isn't visible then it must have been deleted
195 deleted = XML::Node.new "delete"
196 deleted << elt.to_xml_node(changeset_cache, user_display_name_cache)
200 render :xml => result.to_s
204 # query changesets by bounding box, time, user or open/closed status.
206 # find any bounding box
207 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
209 # create the conditions that the user asked for. some or all of
211 changesets = Changeset.all
212 changesets = conditions_bbox(changesets, bbox)
213 changesets = conditions_user(changesets, params["user"], params["display_name"])
214 changesets = conditions_time(changesets, params["time"])
215 changesets = conditions_open(changesets, params["open"])
216 changesets = conditions_closed(changesets, params["closed"])
217 changesets = conditions_ids(changesets, params["changesets"])
219 # create the results document
220 results = OSM::API.new.get_xml_doc
222 # add all matching changesets to the XML results document
223 changesets.order("created_at DESC").limit(100).each do |cs|
224 results.root << cs.to_xml_node
227 render :xml => results.to_s
231 # updates a changeset's tags. none of the changeset's attributes are
232 # user-modifiable, so they will be ignored.
234 # changesets are not (yet?) versioned, so we don't have to deal with
235 # history tables here. changesets are locked to a single user, however.
237 # after succesful update, returns the XML of the changeset.
239 # request *must* be a PUT.
242 changeset = Changeset.find(params[:id])
243 new_changeset = Changeset.from_xml(request.raw_post)
245 check_changeset_consistency(changeset, current_user)
246 changeset.update_from(new_changeset, current_user)
247 render :xml => changeset.to_xml.to_s
251 # list non-empty changesets in reverse chronological order
253 @params = params.permit(:display_name, :bbox, :friends, :nearby, :max_id, :list)
255 if request.format == :atom && @params[:max_id]
256 redirect_to url_for(@params.merge(:max_id => nil)), :status => :moved_permanently
260 if @params[:display_name]
261 user = User.find_by(:display_name => @params[:display_name])
262 if !user || !user.active?
263 render_unknown_user @params[:display_name]
268 if (@params[:friends] || @params[:nearby]) && !current_user
273 if request.format == :html && !@params[:list]
275 render :action => :history, :layout => map_layout
277 changesets = conditions_nonempty(Changeset.all)
279 if @params[:display_name]
280 changesets = if user.data_public? || user == current_user
281 changesets.where(:user_id => user.id)
283 changesets.where("false")
286 changesets = conditions_bbox(changesets, BoundingBox.from_bbox_params(params))
287 elsif @params[:friends] && current_user
288 changesets = changesets.where(:user_id => current_user.friend_users.identifiable)
289 elsif @params[:nearby] && current_user
290 changesets = changesets.where(:user_id => current_user.nearby)
294 changesets = changesets.where("changesets.id <= ?", @params[:max_id])
297 @edits = changesets.order("changesets.id DESC").limit(20).preload(:user, :changeset_tags, :comments)
299 render :action => :list, :layout => false
304 # list edits as an atom feed
310 # Add a comment to a changeset
312 # Check the arguments are sane
313 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
314 raise OSM::APIBadUserInput, "No text was given" if params[:text].blank?
316 # Extract the arguments
317 id = params[:id].to_i
320 # Find the changeset and check it is valid
321 changeset = Changeset.find(id)
322 raise OSM::APIChangesetNotYetClosedError, changeset if changeset.is_open?
324 # Add a comment to the changeset
325 comment = changeset.comments.create(:changeset => changeset,
327 :author => current_user)
329 # Notify current subscribers of the new comment
330 changeset.subscribers.visible.each do |user|
331 if current_user != user
332 Notifier.changeset_comment_notification(comment, user).deliver_now
336 # Add the commenter to the subscribers if necessary
337 changeset.subscribers << current_user unless changeset.subscribers.exists?(current_user.id)
339 # Return a copy of the updated changeset
340 render :xml => changeset.to_xml.to_s
344 # Adds a subscriber to the changeset
346 # Check the arguments are sane
347 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
349 # Extract the arguments
350 id = params[:id].to_i
352 # Find the changeset and check it is valid
353 changeset = Changeset.find(id)
354 raise OSM::APIChangesetNotYetClosedError, changeset if changeset.is_open?
355 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribers.exists?(current_user.id)
358 changeset.subscribers << current_user
360 # Return a copy of the updated changeset
361 render :xml => changeset.to_xml.to_s
365 # Removes a subscriber from the changeset
367 # Check the arguments are sane
368 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
370 # Extract the arguments
371 id = params[:id].to_i
373 # Find the changeset and check it is valid
374 changeset = Changeset.find(id)
375 raise OSM::APIChangesetNotYetClosedError, changeset if changeset.is_open?
376 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribers.exists?(current_user.id)
378 # Remove the subscriber
379 changeset.subscribers.delete(current_user)
381 # Return a copy of the updated changeset
382 render :xml => changeset.to_xml.to_s
386 # Sets visible flag on comment to false
388 # Check the arguments are sane
389 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
391 # Extract the arguments
392 id = params[:id].to_i
395 comment = ChangesetComment.find(id)
398 comment.update(:visible => false)
400 # Return a copy of the updated changeset
401 render :xml => comment.changeset.to_xml.to_s
405 # Sets visible flag on comment to true
407 # Check the arguments are sane
408 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
410 # Extract the arguments
411 id = params[:id].to_i
414 comment = ChangesetComment.find(id)
417 comment.update(:visible => true)
419 # Return a copy of the updated changeset
420 render :xml => comment.changeset.to_xml.to_s
424 # Get a feed of recent changeset comments
427 # Extract the arguments
428 id = params[:id].to_i
431 changeset = Changeset.find(id)
433 # Return comments for this changeset only
434 @comments = changeset.comments.includes(:author, :changeset).limit(comments_limit)
437 @comments = ChangesetComment.includes(:author, :changeset).where(:visible => true).order("created_at DESC").limit(comments_limit).preload(:changeset)
441 respond_to do |format|
444 rescue OSM::APIBadUserInput
450 #------------------------------------------------------------
451 # utility functions below.
452 #------------------------------------------------------------
455 # if a bounding box was specified do some sanity checks.
456 # restrict changesets to those enclosed by a bounding box
457 # we need to return both the changesets and the bounding box
458 def conditions_bbox(changesets, bbox)
460 bbox.check_boundaries
461 bbox = bbox.to_scaled
463 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
464 bbox.max_lon.to_i, bbox.min_lon.to_i,
465 bbox.max_lat.to_i, bbox.min_lat.to_i)
472 # restrict changesets to those by a particular user
473 def conditions_user(changesets, user, name)
474 if user.nil? && name.nil?
477 # shouldn't provide both name and UID
478 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
480 # use either the name or the UID to find the user which we're selecting on.
482 # user input checking, we don't have any UIDs < 1
483 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
484 u = User.find(user.to_i)
486 u = User.find_by(:display_name => name)
489 # make sure we found a user
490 raise OSM::APINotFoundError if u.nil?
492 # should be able to get changesets of public users only, or
493 # our own changesets regardless of public-ness.
494 unless u.data_public?
495 # get optional user auth stuff so that users can see their own
496 # changesets if they're non-public
499 raise OSM::APINotFoundError if current_user.nil? || current_user != u
502 changesets.where(:user_id => u.id)
507 # restrict changes to those closed during a particular time period
508 def conditions_time(changesets, time)
511 elsif time.count(",") == 1
512 # if there is a range, i.e: comma separated, then the first is
513 # low, second is high - same as with bounding boxes.
515 # check that we actually have 2 elements in the array
516 times = time.split(/,/)
517 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
519 from, to = times.collect { |t| Time.parse(t) }
520 return changesets.where("closed_at >= ? and created_at <= ?", from, to)
522 # if there is no comma, assume its a lower limit on time
523 return changesets.where("closed_at >= ?", Time.parse(time))
525 # stupid Time seems to throw both of these for bad parsing, so
526 # we have to catch both and ensure the correct code path is taken.
527 rescue ArgumentError => ex
528 raise OSM::APIBadUserInput, ex.message.to_s
529 rescue RuntimeError => ex
530 raise OSM::APIBadUserInput, ex.message.to_s
534 # return changesets which are open (haven't been closed yet)
535 # we do this by seeing if the 'closed at' time is in the future. Also if we've
536 # hit the maximum number of changes then it counts as no longer open.
537 # if parameter 'open' is nill then open and closed changesets are returned
538 def conditions_open(changesets, open)
542 changesets.where("closed_at >= ? and num_changes <= ?",
543 Time.now.getutc, Changeset::MAX_ELEMENTS)
548 # query changesets which are closed
549 # ('closed at' time has passed or changes limit is hit)
550 def conditions_closed(changesets, closed)
554 changesets.where("closed_at < ? or num_changes > ?",
555 Time.now.getutc, Changeset::MAX_ELEMENTS)
560 # query changesets by a list of ids
561 # (either specified as array or comma-separated string)
562 def conditions_ids(changesets, ids)
566 raise OSM::APIBadUserInput, "No changesets were given to search for"
568 ids = ids.split(",").collect(&:to_i)
569 changesets.where(:id => ids)
574 # eliminate empty changesets (where the bbox has not been set)
575 # this should be applied to all changeset list displays
576 def conditions_nonempty(changesets)
577 changesets.where("num_changes > 0")
581 # Get the maximum number of comments to return
584 if params[:limit].to_i > 0 && params[:limit].to_i <= 10000
587 raise OSM::APIBadUserInput, "Comments limit must be between 1 and 10000"