1 # == Schema Information
3 # Table name: current_relations
5 # id :bigint(8) not null, primary key
6 # changeset_id :bigint(8) not null
7 # timestamp :datetime not null
8 # visible :boolean not null
9 # version :bigint(8) not null
13 # current_relations_timestamp_idx (timestamp)
17 # current_relations_changeset_id_fkey (changeset_id => changesets.id)
20 class Relation < ApplicationRecord
23 include ConsistencyValidations
26 self.table_name = "current_relations"
30 has_many :old_relations, -> { order(:version) }
32 has_many :relation_members, -> { order(:sequence_id) }
33 has_many :relation_tags
35 has_many :containing_relation_members, :class_name => "RelationMember", :as => :member
36 has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation
38 validates :id, :uniqueness => true, :presence => { :on => :update },
39 :numericality => { :on => :update, :only_integer => true }
40 validates :version, :presence => true,
41 :numericality => { :only_integer => true }
42 validates :changeset_id, :presence => true,
43 :numericality => { :only_integer => true }
44 validates :timestamp, :presence => true
45 validates :changeset, :associated => true
46 validates :visible, :inclusion => [true, false]
48 scope :visible, -> { where(:visible => true) }
49 scope :invisible, -> { where(:visible => false) }
50 scope :nodes, ->(*ids) { joins(:relation_members).where(:current_relation_members => { :member_type => "Node", :member_id => ids.flatten }) }
51 scope :ways, ->(*ids) { joins(:relation_members).where(:current_relation_members => { :member_type => "Way", :member_id => ids.flatten }) }
52 scope :relations, ->(*ids) { joins(:relation_members).where(:current_relation_members => { :member_type => "Relation", :member_id => ids.flatten }) }
54 TYPES = %w[node way relation].freeze
56 def self.from_xml(xml, create: false)
57 p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
59 pt = doc.find_first("//osm/relation")
62 Relation.from_xml_node(pt, :create => create)
64 raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/relation element.")
66 rescue LibXML::XML::Error, ArgumentError => e
67 raise OSM::APIBadXMLError.new("relation", xml, e.message)
70 def self.from_xml_node(pt, create: false)
71 relation = Relation.new
73 raise OSM::APIBadXMLError.new("relation", pt, "Version is required when updating") unless create || !pt["version"].nil?
75 relation.version = pt["version"]
76 raise OSM::APIBadXMLError.new("relation", pt, "Changeset id is missing") if pt["changeset"].nil?
78 relation.changeset_id = pt["changeset"]
81 raise OSM::APIBadXMLError.new("relation", pt, "ID is required when updating") if pt["id"].nil?
83 relation.id = pt["id"].to_i
84 # .to_i will return 0 if there is no number that can be parsed.
85 # We want to make sure that there is no id with zero anyway
86 raise OSM::APIBadUserInput, "ID of relation cannot be zero when updating." if relation.id.zero?
89 # We don't care about the timestamp nor the visibility as these are either
90 # set explicitly or implicit in the action. The visibility is set to true,
91 # and manually set to false before the actual delete.
92 relation.visible = true
97 # Add in any tags from the XML
98 pt.find("tag").each do |tag|
99 raise OSM::APIBadXMLError.new("relation", pt, "tag is missing key") if tag["k"].nil?
100 raise OSM::APIBadXMLError.new("relation", pt, "tag is missing value") if tag["v"].nil?
102 relation.add_tag_keyval(tag["k"], tag["v"])
105 # need to initialise the relation members array explicitly, as if this
106 # isn't done for a new relation then @members attribute will be nil,
107 # and the members will be loaded from the database instead of being
108 # empty, as intended.
109 relation.members = []
111 pt.find("member").each do |member|
113 raise OSM::APIBadXMLError.new("relation", pt, "The #{member['type']} is not allowed only, #{TYPES.inspect} allowed") unless TYPES.include? member["type"]
115 # member_ref = member['ref']
117 member["role"] ||= "" # Allow the upload to not include this, in which case we default to an empty string.
118 relation.add_member(member["type"].classify, member["ref"], member["role"])
120 raise OSM::APIBadUserInput, "Some bad xml in relation" if relation.nil?
125 # FIXME: is this really needed?
127 @members ||= relation_members.map do |member|
128 [member.member_type, member.member_id, member.member_role]
133 @tags ||= relation_tags.to_h { |t| [t.k, t.v] }
136 attr_writer :members, :tags
138 def add_member(type, id, role)
140 @members << [type, id.to_i, role]
143 def add_tag_keyval(k, v)
146 # duplicate tags are now forbidden, so we can't allow values
147 # in the hash to be overwritten.
148 raise OSM::APIDuplicateTagsError.new("relation", id, k) if @tags.include? k
154 # updates the changeset bounding box to contain the bounding box of
155 # the element with given +type+ and +id+. this only works with nodes
156 # and ways at the moment, as they're the only elements to respond to
158 def update_changeset_element(type, id)
159 element = Kernel.const_get(type.capitalize).find(id)
160 changeset.update_bbox! element.bbox
163 def delete_with_history!(new_relation, user)
164 raise OSM::APIAlreadyDeletedError.new("relation", new_relation.id) unless visible
166 # need to start the transaction here, so that the database can
167 # provide repeatable reads for the used-by checks. this means it
168 # shouldn't be possible to get race conditions.
169 Relation.transaction do
171 check_consistency(self, new_relation, user)
172 # This will check to see if this relation is used by another relation
173 rel = RelationMember.joins(:relation).find_by("visible = ? AND member_type = 'Relation' and member_id = ? ", true, id)
174 raise OSM::APIPreconditionFailedError, "The relation #{new_relation.id} is used in relation #{rel.relation.id}." unless rel.nil?
176 self.changeset_id = new_relation.changeset_id
184 def update_from(new_relation, user)
185 Relation.transaction do
187 check_consistency(self, new_relation, user)
188 raise OSM::APIPreconditionFailedError, "Cannot update relation #{id}: data or member data is invalid." unless new_relation.preconditions_ok?(members)
190 self.changeset_id = new_relation.changeset_id
191 self.changeset = new_relation.changeset
192 self.tags = new_relation.tags
193 self.members = new_relation.members
199 def create_with_history(user)
200 check_create_consistency(self, user)
201 raise OSM::APIPreconditionFailedError, "Cannot create relation: data or member data is invalid." unless preconditions_ok?
208 def preconditions_ok?(good_members = [])
209 # These are hastables that store an id in the index of all
210 # the nodes/way/relations that have already been added.
211 # If the member is valid and visible then we add it to the
212 # relevant hash table, with the value true as a cache.
213 # Thus if you have nodes with the ids of 50 and 1 already in the
214 # relation, then the hash table nodes would contain:
215 # => {50=>true, 1=>true}
216 elements = { :node => {}, :way => {}, :relation => {} }
218 # pre-set all existing members to good
219 good_members.each { |m| elements[m[0].downcase.to_sym][m[1]] = true }
222 # find the hash for the element type or die
223 hash = elements[m[0].downcase.to_sym]
224 return false unless hash
226 # unless its in the cache already
227 next if hash.key? m[1]
229 # use reflection to look up the appropriate class
230 model = Kernel.const_get(m[0].capitalize)
231 # get the element with that ID. and, if found, lock the element to
232 # ensure it can't be deleted until after the current transaction
234 element = model.lock("for share").find_by(:id => m[1])
236 # and check that it is OK to use.
237 raise OSM::APIPreconditionFailedError, "Relation with id #{id} cannot be saved due to #{m[0]} with id #{m[1]}" unless element&.visible? && element&.preconditions_ok?
246 # if any members are referenced by placeholder IDs (i.e: negative) then
247 # this calling this method will fix them using the map from placeholders
249 def fix_placeholders!(id_map, placeholder_id = nil)
250 members.map! do |type, id, role|
253 new_id = id_map[type.downcase.to_sym][old_id]
254 raise OSM::APIBadUserInput, "Placeholder #{type} not found for reference #{old_id} in relation #{self.id.nil? ? placeholder_id : self.id}." if new_id.nil?
265 def save_with_history!
271 Relation.transaction do
272 # have to be a little bit clever here - to detect if any tags
273 # changed then we have to monitor their before and after state.
276 # clone the object before saving it so that the original is
277 # still marked as dirty if we retry the transaction
280 tags = self.tags.clone
281 relation_tags.each do |old_tag|
283 # if we can match the tags we currently have to the list
284 # of old tags, then we never set the tags_changed flag. but
285 # if any are different then set the flag and do the DB
288 tags_changed |= (old_tag.v != tags[key])
290 # remove from the map, so that we can expect an empty map
291 # at the end if there are no new tags
295 # this means a tag was deleted
299 # if there are left-over tags then they are new and will have to
301 tags_changed |= !tags.empty?
302 RelationTag.where(:relation_id => id).delete_all
303 self.tags.each do |k, v|
304 tag = RelationTag.new
311 # same pattern as before, but this time we're collecting the
312 # changed members in an array, as the bounding box updates for
313 # elements are per-element, not blanked on/off like for tags.
315 members = self.members.clone
316 relation_members.each do |old_member|
317 key = [old_member.member_type, old_member.member_id, old_member.member_role]
318 i = members.index key
320 changed_members << key
325 # any remaining members must be new additions
326 changed_members += members
328 # update the members. first delete all the old members, as the new
329 # members may be in a different order and i don't feel like implementing
330 # a longest common subsequence algorithm to optimise this.
331 members = self.members
332 RelationMember.where(:relation_id => id).delete_all
333 members.each_with_index do |m, i|
334 mem = RelationMember.new
337 mem.member_type = m[0]
339 mem.member_role = m[2]
343 old_relation = OldRelation.from_relation(self)
344 old_relation.timestamp = t
345 old_relation.save_with_dependencies!
347 # update the bbox of the changeset and save it too.
348 # discussion on the mailing list gave the following definition for
349 # the bounding box update procedure of a relation:
351 # adding or removing nodes or ways from a relation causes them to be
352 # added to the changeset bounding box. adding a relation member or
353 # changing tag values causes all node and way members to be added to the
354 # bounding box. this is similar to how the map call does things and is
355 # reasonable on the assumption that adding or removing members doesn't
356 # materially change the rest of the relation.
358 changed_members.collect { |type, _id, _role| type == "Relation" }
359 .inject(false) { |acc, elem| acc || elem }
361 # if the relation is being deleted tags_changed will be true and members empty
362 # so we need to use changed_members to create a correct bounding box
363 update_members = if visible && (tags_changed || any_relations)
364 # add all non-relation bounding boxes to the changeset
365 # FIXME: check for tag changes along with element deletions and
366 # make sure that the deleted element's bounding box is hit.
371 update_members.each do |type, id, _role|
372 update_changeset_element(type, id) if type != "Relation"
375 # tell the changeset we updated one element only
376 changeset.add_changes! 1
378 # save the (maybe updated) changeset bounding box