.rubocop_todo.yml

   1 # This configuration was generated by
   2 # `rubocop --auto-gen-config`
   3 # on 2020-08-06 20:53:30 UTC using RuboCop version 0.89.0.
   4 # The point is for the user to remove these configuration records
   5 # one by one as the offenses are removed from the code base.
   6 # Note that changes in the inspected code, or installation of new
   7 # versions of RuboCop, may require this file to be generated again.
   8 # versions of RuboCop, may require this file to be generated again.
   9
  10 # Work around erblint issues.
  11 # https://github.com/openstreetmap/openstreetmap-website/issues/2472
  12 require:
  13   - rubocop-minitest
  14   - rubocop-performance
  15   - rubocop-rails
  16
  17 # Offense count: 568
  18 # Cop supports --auto-correct.
  19 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
  20 # URISchemes: http, https
  21 Layout/LineLength:
  22   Max: 370
  23
  24 # Offense count: 36
  25 # Configuration parameters: AllowSafeAssignment.
  26 Lint/AssignmentInCondition:
  27   Exclude:
  28     - 'app/controllers/api/traces_controller.rb'
  29     - 'app/controllers/api/user_preferences_controller.rb'
  30     - 'app/controllers/application_controller.rb'
  31     - 'app/controllers/geocoder_controller.rb'
  32     - 'app/controllers/notes_controller.rb'
  33     - 'app/controllers/traces_controller.rb'
  34     - 'app/controllers/users_controller.rb'
  35     - 'app/helpers/application_helper.rb'
  36     - 'app/helpers/browse_tags_helper.rb'
  37     - 'app/mailers/notifier.rb'
  38     - 'app/models/client_application.rb'
  39     - 'lib/nominatim.rb'
  40     - 'lib/osm.rb'
  41     - 'script/deliver-message'
  42
  43 # Offense count: 20
  44 Lint/MissingSuper:
  45   Exclude:
  46     - 'config/initializers/oauth.rb'
  47     - 'lib/osm.rb'
  48     - 'lib/session_persistence.rb'
  49
  50 # Offense count: 682
  51 # Configuration parameters: IgnoredMethods.
  52 Metrics/AbcSize:
  53   Max: 194
  54
  55 # Offense count: 72
  56 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
  57 # ExcludedMethods: refine
  58 Metrics/BlockLength:
  59   Max: 71
  60
  61 # Offense count: 15
  62 # Configuration parameters: CountBlocks.
  63 Metrics/BlockNesting:
  64   Max: 5
  65
  66 # Offense count: 25
  67 # Configuration parameters: CountComments, CountAsOne.
  68 Metrics/ClassLength:
  69   Max: 645
  70
  71 # Offense count: 68
  72 # Configuration parameters: IgnoredMethods.
  73 Metrics/CyclomaticComplexity:
  74   Max: 26
  75
  76 # Offense count: 735
  77 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
  78 Metrics/MethodLength:
  79   Max: 179
  80
  81 # Offense count: 4
  82 # Configuration parameters: CountKeywordArgs.
  83 Metrics/ParameterLists:
  84   Max: 9
  85
  86 # Offense count: 69
  87 # Configuration parameters: IgnoredMethods.
  88 Metrics/PerceivedComplexity:
  89   Max: 26
  90
  91 # Offense count: 540
  92 Minitest/MultipleAssertions:
  93   Max: 81
  94
  95 # Offense count: 26
  96 # Cop supports --auto-correct.
  97 Minitest/TestMethodName:
  98   Exclude:
  99     - 'test/abilities/api_capability_test.rb'
 100     - 'test/controllers/api/nodes_controller_test.rb'
 101     - 'test/controllers/api/old_nodes_controller_test.rb'
 102     - 'test/controllers/api/relations_controller_test.rb'
 103     - 'test/controllers/api/ways_controller_test.rb'
 104     - 'test/helpers/browse_helper_test.rb'
 105     - 'test/integration/client_applications_test.rb'
 106     - 'test/integration/short_links_test.rb'
 107     - 'test/integration/user_blocks_test.rb'
 108     - 'test/integration/user_creation_test.rb'
 109
 110 # Offense count: 6
 111 Naming/AccessorMethodName:
 112   Exclude:
 113     - 'app/controllers/application_controller.rb'
 114     - 'app/helpers/title_helper.rb'
 115     - 'app/models/old_way.rb'
 116     - 'lib/osm.rb'
 117     - 'lib/potlatch.rb'
 118
 119 # Offense count: 8
 120 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 121 # NamePrefix: is_, has_, have_
 122 # ForbiddenPrefixes: is_, has_, have_
 123 # AllowedMethods: is_a?
 124 # MethodDefinitionMacros: define_method, define_singleton_method
 125 Naming/PredicateName:
 126   Exclude:
 127     - 'spec/**/*'
 128     - 'app/models/changeset.rb'
 129     - 'app/models/old_node.rb'
 130     - 'app/models/old_relation.rb'
 131     - 'app/models/old_way.rb'
 132     - 'app/models/user.rb'
 133     - 'lib/classic_pagination/pagination.rb'
 134
 135 # Offense count: 5
 136 # Configuration parameters: Database, Include.
 137 # SupportedDatabases: mysql, postgresql
 138 # Include: db/migrate/*.rb
 139 Rails/BulkChangeTable:
 140   Exclude:
 141     - 'db/migrate/20111116184519_update_oauth.rb'
 142     - 'db/migrate/20120208194454_add_domain_to_acl.rb'
 143     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 144
 145 # Offense count: 2
 146 # Configuration parameters: Include.
 147 # Include: app/models/**/*.rb
 148 Rails/HasAndBelongsToMany:
 149   Exclude:
 150     - 'app/models/changeset.rb'
 151     - 'app/models/user.rb'
 152
 153 # Offense count: 4
 154 # Configuration parameters: Include.
 155 # Include: app/helpers/**/*.rb
 156 Rails/HelperInstanceVariable:
 157   Exclude:
 158     - 'app/helpers/title_helper.rb'
 159
 160 # Offense count: 1
 161 # Cop supports --auto-correct.
 162 # Configuration parameters: Include.
 163 # Include: app/mailers/**/*.rb
 164 Rails/MailerName:
 165   Exclude:
 166     - 'app/mailers/notifier.rb'
 167
 168 # Offense count: 5
 169 # Configuration parameters: Include.
 170 # Include: db/migrate/*.rb
 171 Rails/NotNullColumn:
 172   Exclude:
 173     - 'db/migrate/002_cleanup_osm_db.rb'
 174     - 'db/migrate/020_populate_node_tags_and_remove.rb'
 175     - 'db/migrate/021_move_to_innodb.rb'
 176     - 'db/migrate/025_add_end_time_to_changesets.rb'
 177     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 178
 179 # Offense count: 19
 180 Rails/OutputSafety:
 181   Exclude:
 182     - 'app/controllers/users_controller.rb'
 183     - 'app/helpers/application_helper.rb'
 184     - 'app/helpers/changesets_helper.rb'
 185     - 'app/helpers/geocoder_helper.rb'
 186     - 'app/helpers/note_helper.rb'
 187     - 'app/helpers/open_graph_helper.rb'
 188     - 'app/helpers/user_blocks_helper.rb'
 189     - 'lib/rich_text.rb'
 190     - 'test/helpers/application_helper_test.rb'
 191
 192 # Offense count: 95
 193 # Cop supports --auto-correct.
 194 # Configuration parameters: EnforcedStyle.
 195 # SupportedStyles: strict, flexible
 196 Rails/TimeZone:
 197   Enabled: false
 198
 199 # Offense count: 6
 200 # Cop supports --auto-correct.
 201 Style/ExplicitBlockArgument:
 202   Exclude:
 203     - 'app/controllers/api/amf_controller.rb'
 204     - 'app/controllers/application_controller.rb'
 205     - 'app/mailers/notifier.rb'
 206     - 'test/integration/client_applications_test.rb'
 207
 208 # Offense count: 572
 209 # Cop supports --auto-correct.
 210 # Configuration parameters: EnforcedStyle.
 211 # SupportedStyles: always, always_true, never
 212 Style/FrozenStringLiteralComment:
 213   Enabled: false
 214
 215 # Offense count: 78
 216 # Cop supports --auto-correct.
 217 # Configuration parameters: Strict.
 218 Style/NumericLiterals:
 219   MinDigits: 11
 220
 221 # Offense count: 20
 222 Style/OptionalBooleanParameter:
 223   Exclude:
 224     - 'app/controllers/api/notes_controller.rb'
 225     - 'app/controllers/application_controller.rb'
 226     - 'app/helpers/browse_helper.rb'
 227     - 'app/models/changeset.rb'
 228     - 'app/models/node.rb'
 229     - 'app/models/relation.rb'
 230     - 'app/models/trace.rb'
 231     - 'app/models/tracepoint.rb'
 232     - 'app/models/way.rb'
 233     - 'test/models/diary_entry_test.rb'
 234     - 'test/models/trace_test.rb'
 235     - 'test/models/tracetag_test.rb'
 236
 237 # Offense count: 44
 238 # Cop supports --auto-correct.
 239 Style/StringConcatenation:
 240   Enabled: false