1 class Way < ActiveRecord::Base
4 include ConsistencyValidations
8 self.table_name = "current_ways"
12 has_many :old_ways, -> { order(:version) }
14 has_many :way_nodes, -> { order(:sequence_id) }
15 has_many :nodes, :through => :way_nodes
19 has_many :containing_relation_members, :class_name => "RelationMember", :as => :member
20 has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation
22 validates :id, :uniqueness => true, :presence => { :on => :update },
23 :numericality => { :on => :update, :integer_only => true }
24 validates :version, :presence => true,
25 :numericality => { :integer_only => true }
26 validates :changeset_id, :presence => true,
27 :numericality => { :integer_only => true }
28 validates :timestamp, :presence => true
29 validates :changeset, :associated => true
30 validates :visible, :inclusion => [true, false]
32 scope :visible, -> { where(:visible => true) }
33 scope :invisible, -> { where(:visible => false) }
35 # Read in xml as text and return it's Way object representation
36 def self.from_xml(xml, create = false)
37 p = XML::Parser.string(xml)
40 doc.find("//osm/way").each do |pt|
41 return Way.from_xml_node(pt, create)
43 fail OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/way element.")
44 rescue LibXML::XML::Error, ArgumentError => ex
45 raise OSM::APIBadXMLError.new("way", xml, ex.message)
48 def self.from_xml_node(pt, create = false)
51 fail OSM::APIBadXMLError.new("way", pt, "Version is required when updating") unless create || !pt["version"].nil?
52 way.version = pt["version"]
53 fail OSM::APIBadXMLError.new("way", pt, "Changeset id is missing") if pt["changeset"].nil?
54 way.changeset_id = pt["changeset"]
57 fail OSM::APIBadXMLError.new("way", pt, "ID is required when updating") if pt["id"].nil?
58 way.id = pt["id"].to_i
59 # .to_i will return 0 if there is no number that can be parsed.
60 # We want to make sure that there is no id with zero anyway
61 fail OSM::APIBadUserInput.new("ID of way cannot be zero when updating.") if way.id == 0
64 # We don't care about the timestamp nor the visibility as these are either
65 # set explicitly or implicit in the action. The visibility is set to true,
66 # and manually set to false before the actual delete.
72 # Add in any tags from the XML
73 pt.find("tag").each do |tag|
74 fail OSM::APIBadXMLError.new("way", pt, "tag is missing key") if tag["k"].nil?
75 fail OSM::APIBadXMLError.new("way", pt, "tag is missing value") if tag["v"].nil?
76 way.add_tag_keyval(tag["k"], tag["v"])
79 pt.find("nd").each do |nd|
80 way.add_nd_num(nd["ref"])
86 # Find a way given it's ID, and in a single SQL call also grab its nodes and tags
88 doc = OSM::API.new.get_xml_doc
89 doc.root << to_xml_node
93 def to_xml_node(visible_nodes = nil, changeset_cache = {}, user_display_name_cache = {})
94 el = XML::Node.new "way"
97 add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
99 # make sure nodes are output in sequence_id order
101 way_nodes.each do |nd|
103 # if there is a list of visible nodes then use that to weed out deleted nodes
104 if visible_nodes[nd.node_id]
105 ordered_nodes[nd.sequence_id] = nd.node_id.to_s
108 # otherwise, manually go to the db to check things
109 if nd.node && nd.node.visible?
110 ordered_nodes[nd.sequence_id] = nd.node_id.to_s
115 ordered_nodes.each do |nd_id|
116 next unless nd_id && nd_id != "0"
118 node_el = XML::Node.new "nd"
119 node_el["ref"] = nd_id
123 add_tags_to_xml_node(el, way_tags)
129 @nds ||= way_nodes.collect(&:node_id)
133 @tags ||= Hash[way_tags.collect { |t| [t.k, t.v] }]
141 @nds = [] unless @nds
145 def add_tag_keyval(k, v)
146 @tags = {} unless @tags
148 # duplicate tags are now forbidden, so we can't allow values
149 # in the hash to be overwritten.
150 fail OSM::APIDuplicateTagsError.new("way", id, k) if @tags.include? k
156 # the integer coords (i.e: unscaled) bounding box of the way, assuming
157 # straight line segments.
159 lons = nodes.collect(&:longitude)
160 lats = nodes.collect(&:latitude)
161 BoundingBox.new(lons.min, lats.min, lons.max, lats.max)
164 def update_from(new_way, user)
167 check_consistency(self, new_way, user)
168 unless new_way.preconditions_ok?(nds)
169 fail OSM::APIPreconditionFailedError.new("Cannot update way #{id}: data is invalid.")
172 self.changeset_id = new_way.changeset_id
173 self.changeset = new_way.changeset
174 self.tags = new_way.tags
175 self.nds = new_way.nds
181 def create_with_history(user)
182 check_create_consistency(self, user)
183 unless self.preconditions_ok?
184 fail OSM::APIPreconditionFailedError.new("Cannot create way: data is invalid.")
191 def preconditions_ok?(old_nodes = [])
192 return false if nds.empty?
193 if nds.length > MAX_NUMBER_OF_WAY_NODES
194 fail OSM::APITooManyWayNodesError.new(id, nds.length, MAX_NUMBER_OF_WAY_NODES)
197 # check only the new nodes, for efficiency - old nodes having been checked last time and can't
198 # be deleted when they're in-use.
199 new_nds = (nds - old_nodes).sort.uniq
201 unless new_nds.empty?
202 db_nds = Node.where(:id => new_nds, :visible => true)
204 if db_nds.length < new_nds.length
205 missing = new_nds - db_nds.collect(&:id)
206 fail OSM::APIPreconditionFailedError.new("Way #{id} requires the nodes with id in (#{missing.join(',')}), which either do not exist, or are not visible.")
213 def delete_with_history!(new_way, user)
214 fail OSM::APIAlreadyDeletedError.new("way", new_way.id) unless visible
216 # need to start the transaction here, so that the database can
217 # provide repeatable reads for the used-by checks. this means it
218 # shouldn't be possible to get race conditions.
221 check_consistency(self, new_way, user)
222 rels = Relation.joins(:relation_members).where(:visible => true, :current_relation_members => { :member_type => "Way", :member_id => id }).order(:id)
223 fail OSM::APIPreconditionFailedError.new("Way #{id} is still used by relations #{rels.collect(&:id).join(",")}.") unless rels.empty?
225 self.changeset_id = new_way.changeset_id
226 self.changeset = new_way.changeset
236 # if any referenced nodes are placeholder IDs (i.e: are negative) then
237 # this calling this method will fix them using the map from placeholders
239 def fix_placeholders!(id_map, placeholder_id = nil)
240 nds.map! do |node_id|
242 new_id = id_map[:node][node_id]
243 fail OSM::APIBadUserInput.new("Placeholder node not found for reference #{node_id} in way #{id.nil? ? placeholder_id : id}") if new_id.nil?
253 def save_with_history!
256 # update the bounding box, note that this has to be done both before
257 # and after the save, so that nodes from both versions are included in the
258 # bbox. we use a copy of the changeset so that it isn't reloaded
261 cs.update_bbox!(bbox) unless nodes.empty?
269 WayTag.delete_all(:way_id => id)
279 WayNode.delete_all(:way_id => id)
283 nd.id = [id, sequence]
289 old_way = OldWay.from_way(self)
290 old_way.timestamp = t
291 old_way.save_with_dependencies!
293 # reload the way so that the nodes array points to the correct
297 # update and commit the bounding box, now that way nodes
298 # have been updated and we're in a transaction.
299 cs.update_bbox!(bbox) unless nodes.empty?
301 # tell the changeset we updated one element only