1 class Changeset < ActiveRecord::Base
6 has_many :changeset_tags, :foreign_key => 'id'
13 has_many :old_relations
15 validates_presence_of :user_id, :created_at, :closed_at
17 # over-expansion factor to use when updating the bounding box
20 # maximum number of elements allowed in a changeset
23 # maximum time a changeset is allowed to be open for (note that this
24 # is in days - so one hour is Rational(1,24)).
27 # idle timeout increment, one hour as a rational number of days.
28 IDLE_TIMEOUT = Rational(1,24)
30 # Use a method like this, so that we can easily change how we
31 # determine whether a changeset is open, without breaking code in at
34 # a changeset is open (that is, it will accept further changes) when
35 # it has not yet run out of time and its capacity is small enough.
36 # note that this may not be a hard limit - due to timing changes and
37 # concurrency it is possible that some changesets may be slightly
38 # longer than strictly allowed or have slightly more changes in them.
39 return ((closed_at > DateTime.now) and (num_changes <= MAX_ELEMENTS))
42 def self.from_xml(xml, create=false)
50 doc.find('//osm/changeset').each do |pt|
52 cs.created_at = Time.now
53 # initial close time is 1h ahead, but will be increased on each
55 cs.closed_at = Time.now + IDLE_TIMEOUT
56 # initially we have no changes in a changeset
60 pt.find('tag').each do |tag|
61 cs.add_tag_keyval(tag['k'], tag['v'])
64 rescue Exception => ex
72 # returns the bounding box of the changeset. it is possible that some
73 # or all of the values will be nil, indicating that they are undefined.
75 @bbox ||= [ min_lon, min_lat, max_lon, max_lat ]
79 # expand the bounding box to include the given bounding box. also,
80 # expand a little bit more in the direction of the expansion, so that
81 # further expansions may be unnecessary. this is an optimisation
82 # suggested on the wiki page by kleptog.
83 def update_bbox!(array)
84 # ensure that bbox is cached and has no nils in it. if there are any
85 # nils, just use the bounding box update to write over them.
86 @bbox = bbox.zip(array).collect { |a, b| a.nil? ? b : a }
88 # FIXME - this looks nasty and violates DRY... is there any prettier
90 @bbox[0] = array[0] + EXPAND * (@bbox[0] - @bbox[2]) if array[0] < @bbox[0]
91 @bbox[1] = array[1] + EXPAND * (@bbox[1] - @bbox[3]) if array[1] < @bbox[1]
92 @bbox[2] = array[2] + EXPAND * (@bbox[2] - @bbox[0]) if array[2] > @bbox[2]
93 @bbox[3] = array[3] + EXPAND * (@bbox[3] - @bbox[1]) if array[3] > @bbox[3]
95 # update active record. rails 2.1's dirty handling should take care of
96 # whether this object needs saving or not.
97 self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox
101 # the number of elements is also passed in so that we can ensure that
102 # a single changeset doesn't contain too many elements. this, of course,
103 # destroys the optimisation described in the bbox method above.
104 def add_changes!(elements)
105 self.num_changes += elements
115 self.changeset_tags.each do |tag|
126 def add_tag_keyval(k, v)
127 @tags = Hash.new unless @tags
134 # do the changeset update and the changeset tags update in the
135 # same transaction to ensure consistency.
136 Changeset.transaction do
137 # set the auto-close time to be one hour in the future unless
138 # that would make it more than 24h long, in which case clip to
139 # 24h, as this has been decided is a reasonable time limit.
140 if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
141 self.closed_at = created_at + MAX_TIME_OPEN
143 self.closed_at = DateTime.now + IDLE_TIMEOUT
148 ChangesetTag.delete_all(['id = ?', self.id])
151 tag = ChangesetTag.new
161 doc = OSM::API.new.get_xml_doc
162 doc.root << to_xml_node()
166 def to_xml_node(user_display_name_cache = nil)
167 el1 = XML::Node.new 'changeset'
168 el1['id'] = self.id.to_s
170 user_display_name_cache = {} if user_display_name_cache.nil?
172 if user_display_name_cache and user_display_name_cache.key?(self.user_id)
173 # use the cache if available
174 elsif self.user.data_public?
175 user_display_name_cache[self.user_id] = self.user.display_name
177 user_display_name_cache[self.user_id] = nil
180 el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?
181 el1['uid'] = self.user_id.to_s if self.user.data_public?
183 self.tags.each do |k,v|
184 el2 = XML::Node.new('tag')
190 el1['created_at'] = self.created_at.xmlschema
191 el1['closed_at'] = self.closed_at.xmlschema unless is_open?
192 el1['open'] = is_open?.to_s
194 el1['min_lon'] = (bbox[0].to_f / GeoRecord::SCALE).to_s unless bbox[0].nil?
195 el1['min_lat'] = (bbox[1].to_f / GeoRecord::SCALE).to_s unless bbox[1].nil?
196 el1['max_lon'] = (bbox[2].to_f / GeoRecord::SCALE).to_s unless bbox[2].nil?
197 el1['max_lat'] = (bbox[3].to_f / GeoRecord::SCALE).to_s unless bbox[3].nil?
199 # NOTE: changesets don't include the XML of the changes within them,
200 # they are just structures for tagging. to get the osmChange of a
201 # changeset, see the download method of the controller.
207 # update this instance from another instance given and the user who is
208 # doing the updating. note that this method is not for updating the
209 # bounding box, only the tags of the changeset.
210 def update_from(other, user)
211 # ensure that only the user who opened the changeset may modify it.
212 unless user.id == self.user_id
213 raise OSM::APIUserChangesetMismatchError
216 # can't change a closed changeset
218 raise OSM::APIChangesetAlreadyClosedError
221 # copy the other's tags
222 self.tags = other.tags