1 class Changeset < ActiveRecord::Base
6 has_many :changeset_tags, :foreign_key => 'id'
13 has_many :old_relations
15 validates_presence_of :id, :on => :update
16 validates_presence_of :user_id, :created_at, :closed_at, :num_changes
17 validates_uniqueness_of :id
18 validates_numericality_of :id, :on => :update, :integer_only => true
19 validates_numericality_of :min_lat, :max_lat, :min_lon, :max_lat, :allow_nil => true, :integer_only => true
20 validates_numericality_of :user_id, :integer_only => true
21 validates_numericality_of :num_changes, :integer_only => true, :greater_than_or_equal_to => 0
22 validates_associated :user
24 # over-expansion factor to use when updating the bounding box
27 # maximum number of elements allowed in a changeset
30 # maximum time a changeset is allowed to be open for.
33 # idle timeout increment, one hour seems reasonable.
36 # Use a method like this, so that we can easily change how we
37 # determine whether a changeset is open, without breaking code in at
40 # a changeset is open (that is, it will accept further changes) when
41 # it has not yet run out of time and its capacity is small enough.
42 # note that this may not be a hard limit - due to timing changes and
43 # concurrency it is possible that some changesets may be slightly
44 # longer than strictly allowed or have slightly more changes in them.
45 return ((closed_at > Time.now) and (num_changes <= MAX_ELEMENTS))
48 def set_closed_time_now
50 self.closed_at = Time.now
54 def self.from_xml(xml, create=false)
56 p = XML::Parser.string(xml)
61 doc.find('//osm/changeset').each do |pt|
63 cs.created_at = Time.now
64 # initial close time is 1h ahead, but will be increased on each
66 cs.closed_at = Time.now + IDLE_TIMEOUT
67 # initially we have no changes in a changeset
71 pt.find('tag').each do |tag|
72 cs.add_tag_keyval(tag['k'], tag['v'])
75 rescue Exception => ex
83 # returns the bounding box of the changeset. it is possible that some
84 # or all of the values will be nil, indicating that they are undefined.
86 @bbox ||= [ min_lon, min_lat, max_lon, max_lat ]
90 # expand the bounding box to include the given bounding box. also,
91 # expand a little bit more in the direction of the expansion, so that
92 # further expansions may be unnecessary. this is an optimisation
93 # suggested on the wiki page by kleptog.
94 def update_bbox!(array)
95 # ensure that bbox is cached and has no nils in it. if there are any
96 # nils, just use the bounding box update to write over them.
97 @bbox = bbox.zip(array).collect { |a, b| a.nil? ? b : a }
99 # FIXME - this looks nasty and violates DRY... is there any prettier
101 @bbox[0] = array[0] + EXPAND * (@bbox[0] - @bbox[2]) if array[0] < @bbox[0]
102 @bbox[1] = array[1] + EXPAND * (@bbox[1] - @bbox[3]) if array[1] < @bbox[1]
103 @bbox[2] = array[2] + EXPAND * (@bbox[2] - @bbox[0]) if array[2] > @bbox[2]
104 @bbox[3] = array[3] + EXPAND * (@bbox[3] - @bbox[1]) if array[3] > @bbox[3]
106 # update active record. rails 2.1's dirty handling should take care of
107 # whether this object needs saving or not.
108 self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox
112 # the number of elements is also passed in so that we can ensure that
113 # a single changeset doesn't contain too many elements. this, of course,
114 # destroys the optimisation described in the bbox method above.
115 def add_changes!(elements)
116 self.num_changes += elements
126 self.changeset_tags.each do |tag|
137 def add_tag_keyval(k, v)
138 @tags = Hash.new unless @tags
145 # do the changeset update and the changeset tags update in the
146 # same transaction to ensure consistency.
147 Changeset.transaction do
148 # set the auto-close time to be one hour in the future unless
149 # that would make it more than 24h long, in which case clip to
150 # 24h, as this has been decided is a reasonable time limit.
151 if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
152 self.closed_at = created_at + MAX_TIME_OPEN
154 self.closed_at = Time.now + IDLE_TIMEOUT
159 ChangesetTag.delete_all(['id = ?', self.id])
162 tag = ChangesetTag.new
172 doc = OSM::API.new.get_xml_doc
173 doc.root << to_xml_node()
177 def to_xml_node(user_display_name_cache = nil)
178 el1 = XML::Node.new 'changeset'
179 el1['id'] = self.id.to_s
181 user_display_name_cache = {} if user_display_name_cache.nil?
183 if user_display_name_cache and user_display_name_cache.key?(self.user_id)
184 # use the cache if available
185 elsif self.user.data_public?
186 user_display_name_cache[self.user_id] = self.user.display_name
188 user_display_name_cache[self.user_id] = nil
191 el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?
192 el1['uid'] = self.user_id.to_s if self.user.data_public?
194 self.tags.each do |k,v|
195 el2 = XML::Node.new('tag')
201 el1['created_at'] = self.created_at.xmlschema
202 el1['closed_at'] = self.closed_at.xmlschema unless is_open?
203 el1['open'] = is_open?.to_s
205 el1['min_lon'] = (bbox[0].to_f / GeoRecord::SCALE).to_s unless bbox[0].nil?
206 el1['min_lat'] = (bbox[1].to_f / GeoRecord::SCALE).to_s unless bbox[1].nil?
207 el1['max_lon'] = (bbox[2].to_f / GeoRecord::SCALE).to_s unless bbox[2].nil?
208 el1['max_lat'] = (bbox[3].to_f / GeoRecord::SCALE).to_s unless bbox[3].nil?
210 # NOTE: changesets don't include the XML of the changes within them,
211 # they are just structures for tagging. to get the osmChange of a
212 # changeset, see the download method of the controller.
218 # update this instance from another instance given and the user who is
219 # doing the updating. note that this method is not for updating the
220 # bounding box, only the tags of the changeset.
221 def update_from(other, user)
222 # ensure that only the user who opened the changeset may modify it.
223 unless user.id == self.user_id
224 raise OSM::APIUserChangesetMismatchError
227 # can't change a closed changeset
229 raise OSM::APIChangesetAlreadyClosedError.new(self)
232 # copy the other's tags
233 self.tags = other.tags