1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
5 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
6 before_action :check_api_readable, :except => [:index, :create, :update, :upload, :download, :subscribe, :unsubscribe]
7 before_action :setup_user_auth, :only => [:show]
8 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
12 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
13 before_action :set_request_formats, :except => [:create, :close, :upload]
15 around_action :api_call_handle_error
16 around_action :api_call_timeout, :except => [:upload]
18 # Helper methods for checking consistency
19 include ConsistencyValidations
22 # query changesets by bounding box, time, user or open/closed status.
24 raise OSM::APIBadUserInput, "cannot use order=oldest with time" if params[:time] && params[:order] == "oldest"
26 # find any bounding box
27 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
29 # create the conditions that the user asked for. some or all of
31 changesets = Changeset.all
32 changesets = conditions_bbox(changesets, bbox)
33 changesets = conditions_user(changesets, params["user"], params["display_name"])
34 changesets = conditions_time(changesets, params["time"])
35 changesets = conditions_from_to(changesets, params["from"], params["to"])
36 changesets = conditions_open(changesets, params["open"])
37 changesets = conditions_closed(changesets, params["closed"])
38 changesets = conditions_ids(changesets, params["changesets"])
41 changesets = if params[:order] == "oldest"
42 changesets.order(:created_at => :asc)
44 changesets.order(:created_at => :desc)
48 changesets = changesets.limit(result_limit)
50 # preload users, tags and comments, and render result
51 @changesets = changesets.preload(:user, :changeset_tags, :comments)
53 respond_to do |format|
60 # Return XML giving the basic info about the changeset. Does not
61 # return anything about the nodes, ways and relations in the changeset.
63 @changeset = Changeset.find(params[:id])
64 if params[:include_discussion].presence
65 @comments = @changeset.comments
66 @comments = @comments.unscope(:where => :visible) if params[:show_hidden_comments].presence && can?(:restore, ChangesetComment)
67 @comments = @comments.includes(:author)
70 respond_to do |format|
76 # Create a changeset from XML.
78 cs = Changeset.from_xml(request.raw_post, :create => true)
80 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
81 cs.user = current_user
84 # Subscribe user to changeset comments
85 cs.subscribe(current_user)
87 render :plain => cs.id.to_s
91 # marks a changeset as closed. this may be called multiple times
92 # on the same changeset, so is idempotent.
94 changeset = Changeset.find(params[:id])
95 check_changeset_consistency(changeset, current_user)
97 # to close the changeset, we'll just set its closed_at time to
98 # now. this might not be enough if there are concurrency issues,
99 # but we'll have to wait and see.
100 changeset.set_closed_time_now
107 # Upload a diff in a single transaction.
109 # This means that each change within the diff must succeed, i.e: that
110 # each version number mentioned is still current. Otherwise the entire
111 # transaction *must* be rolled back.
113 # Furthermore, each element in the diff can only reference the current
116 # Returns: a diffResult document, as described in
117 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
119 changeset = Changeset.find(params[:id])
120 check_changeset_consistency(changeset, current_user)
122 diff_reader = DiffReader.new(request.raw_post, changeset)
123 Changeset.transaction do
124 result = diff_reader.commit
125 # the number of changes in this changeset has already been
126 # updated and is visible in this transaction so we don't need
127 # to allow for any more when checking the limit
129 render :xml => result.to_s
134 # download the changeset as an osmChange document.
136 # to make it easier to revert diffs it would be better if the osmChange
137 # format were reversible, i.e: contained both old and new versions of
138 # modified elements. but it doesn't at the moment...
140 # this method cannot order the database changes fully (i.e: timestamp and
141 # version number may be too coarse) so the resulting diff may not apply
142 # to a different database. however since changesets are not atomic this
143 # behaviour cannot be guaranteed anyway and is the result of a design
146 changeset = Changeset.find(params[:id])
148 # get all the elements in the changeset which haven't been redacted
149 # and stick them in a big array.
150 elements = [changeset.old_nodes.unredacted,
151 changeset.old_ways.unredacted,
152 changeset.old_relations.unredacted].flatten
154 # sort the elements by timestamp and version number, as this is the
155 # almost sensible ordering available. this would be much nicer if
156 # global (SVN-style) versioning were used - then that would be
158 elements.sort_by! { |e| [e.timestamp, e.version] }
160 # generate an output element for each operation. note: we avoid looking
161 # at the history because it is simpler - but it would be more correct to
162 # check these assertions.
167 elements.each do |elt|
169 # first version, so it must be newly-created.
175 # if the element isn't visible then it must have been deleted
180 respond_to do |format|
186 # updates a changeset's tags. none of the changeset's attributes are
187 # user-modifiable, so they will be ignored.
189 # changesets are not (yet?) versioned, so we don't have to deal with
190 # history tables here. changesets are locked to a single user, however.
192 # after succesful update, returns the XML of the changeset.
194 @changeset = Changeset.find(params[:id])
195 new_changeset = Changeset.from_xml(request.raw_post)
197 check_changeset_consistency(@changeset, current_user)
198 @changeset.update_from(new_changeset, current_user)
201 respond_to do |format|
208 # Adds a subscriber to the changeset
210 # Check the arguments are sane
211 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
213 # Extract the arguments
214 id = params[:id].to_i
216 # Find the changeset and check it is valid
217 changeset = Changeset.find(id)
218 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribed?(current_user)
221 changeset.subscribe(current_user)
223 # Return a copy of the updated changeset
224 @changeset = changeset
227 respond_to do |format|
234 # Removes a subscriber from the changeset
236 # Check the arguments are sane
237 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
239 # Extract the arguments
240 id = params[:id].to_i
242 # Find the changeset and check it is valid
243 changeset = Changeset.find(id)
244 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribed?(current_user)
246 # Remove the subscriber
247 changeset.unsubscribe(current_user)
249 # Return a copy of the updated changeset
250 @changeset = changeset
253 respond_to do |format|
261 #------------------------------------------------------------
262 # utility functions below.
263 #------------------------------------------------------------
266 # if a bounding box was specified do some sanity checks.
267 # restrict changesets to those enclosed by a bounding box
268 def conditions_bbox(changesets, bbox)
270 bbox.check_boundaries
271 bbox = bbox.to_scaled
273 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
274 bbox.max_lon.to_i, bbox.min_lon.to_i,
275 bbox.max_lat.to_i, bbox.min_lat.to_i)
282 # restrict changesets to those by a particular user
283 def conditions_user(changesets, user, name)
284 if user.nil? && name.nil?
287 # shouldn't provide both name and UID
288 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
290 # use either the name or the UID to find the user which we're selecting on.
292 # user input checking, we don't have any UIDs < 1
293 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
295 u = User.find_by(:id => user.to_i)
297 u = User.find_by(:display_name => name)
300 # make sure we found a user
301 raise OSM::APINotFoundError if u.nil?
303 # should be able to get changesets of public users only, or
304 # our own changesets regardless of public-ness.
305 unless u.data_public?
306 # get optional user auth stuff so that users can see their own
307 # changesets if they're non-public
310 raise OSM::APINotFoundError if current_user.nil? || current_user != u
313 changesets.where(:user => u)
318 # restrict changesets to those during a particular time period
319 def conditions_time(changesets, time)
322 elsif time.count(",") == 1
323 # if there is a range, i.e: comma separated, then the first is
324 # low, second is high - same as with bounding boxes.
326 # check that we actually have 2 elements in the array
327 times = time.split(",")
328 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
330 from, to = times.collect { |t| Time.parse(t).utc }
331 changesets.where("closed_at >= ? and created_at <= ?", from, to)
333 # if there is no comma, assume its a lower limit on time
334 changesets.where("closed_at >= ?", Time.parse(time).utc)
336 # stupid Time seems to throw both of these for bad parsing, so
337 # we have to catch both and ensure the correct code path is taken.
338 rescue ArgumentError, RuntimeError => e
339 raise OSM::APIBadUserInput, e.message.to_s
343 # restrict changesets to those opened during a particular time period
344 # works similar to from..to of notes controller, including the requirement of 'from' when specifying 'to'
345 def conditions_from_to(changesets, from, to)
348 from = Time.parse(from).utc
350 raise OSM::APIBadUserInput, "Date #{from} is in a wrong format"
360 raise OSM::APIBadUserInput, "Date #{to} is in a wrong format"
363 changesets.where(:created_at => from..to)
370 # return changesets which are open (haven't been closed yet)
371 # we do this by seeing if the 'closed at' time is in the future. Also if we've
372 # hit the maximum number of changes then it counts as no longer open.
373 # if parameter 'open' is nill then open and closed changesets are returned
374 def conditions_open(changesets, open)
378 changesets.where("closed_at >= ? and num_changes <= ?",
379 Time.now.utc, Changeset::MAX_ELEMENTS)
384 # query changesets which are closed
385 # ('closed at' time has passed or changes limit is hit)
386 def conditions_closed(changesets, closed)
390 changesets.where("closed_at < ? or num_changes > ?",
391 Time.now.utc, Changeset::MAX_ELEMENTS)
396 # query changesets by a list of ids
397 # (either specified as array or comma-separated string)
398 def conditions_ids(changesets, ids)
402 raise OSM::APIBadUserInput, "No changesets were given to search for"
404 ids = ids.split(",").collect(&:to_i)
405 changesets.where(:id => ids)
410 # Get the maximum number of results to return
413 if params[:limit].to_i.positive? && params[:limit].to_i <= Settings.max_changeset_query_limit
416 raise OSM::APIBadUserInput, "Changeset limit must be between 1 and #{Settings.max_changeset_query_limit}"
419 Settings.default_changeset_query_limit