1 # The ChangesetController is the RESTful interface to Changeset objects
4 class ChangesetsController < ApiController
5 before_action :check_api_writable, :only => [:create, :update, :upload, :subscribe, :unsubscribe]
6 before_action :setup_user_auth, :only => [:show]
7 before_action :authorize, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
11 before_action :require_public_data, :only => [:create, :update, :upload, :close, :subscribe, :unsubscribe]
12 before_action :set_request_formats, :except => [:create, :close, :upload]
14 around_action :api_call_handle_error
15 around_action :api_call_timeout, :except => [:upload]
17 # Helper methods for checking consistency
18 include ConsistencyValidations
21 # query changesets by bounding box, time, user or open/closed status.
23 raise OSM::APIBadUserInput, "cannot use order=oldest with time" if params[:time] && params[:order] == "oldest"
25 # find any bounding box
26 bbox = BoundingBox.from_bbox_params(params) if params["bbox"]
28 # create the conditions that the user asked for. some or all of
30 changesets = Changeset.all
31 changesets = conditions_bbox(changesets, bbox)
32 changesets = conditions_user(changesets, params["user"], params["display_name"])
33 changesets = conditions_time(changesets, params["time"])
34 changesets = conditions_from_to(changesets, params["from"], params["to"])
35 changesets = conditions_open(changesets, params["open"])
36 changesets = conditions_closed(changesets, params["closed"])
37 changesets = conditions_ids(changesets, params["changesets"])
40 changesets = if params[:order] == "oldest"
41 changesets.order(:created_at => :asc)
43 changesets.order(:created_at => :desc)
47 changesets = changesets.limit(result_limit)
49 # preload users, tags and comments, and render result
50 @changesets = changesets.preload(:user, :changeset_tags, :comments)
52 respond_to do |format|
59 # Return XML giving the basic info about the changeset. Does not
60 # return anything about the nodes, ways and relations in the changeset.
62 @changeset = Changeset.find(params[:id])
63 if params[:include_discussion].presence
64 @comments = @changeset.comments
65 @comments = @comments.unscope(:where => :visible) if params[:show_hidden_comments].presence && can?(:restore, ChangesetComment)
66 @comments = @comments.includes(:author)
69 respond_to do |format|
75 # Create a changeset from XML.
77 cs = Changeset.from_xml(request.raw_post, :create => true)
79 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
80 cs.user = current_user
83 # Subscribe user to changeset comments
84 cs.subscribe(current_user)
86 render :plain => cs.id.to_s
90 # marks a changeset as closed. this may be called multiple times
91 # on the same changeset, so is idempotent.
93 changeset = Changeset.find(params[:id])
94 check_changeset_consistency(changeset, current_user)
96 # to close the changeset, we'll just set its closed_at time to
97 # now. this might not be enough if there are concurrency issues,
98 # but we'll have to wait and see.
99 changeset.set_closed_time_now
106 # Upload a diff in a single transaction.
108 # This means that each change within the diff must succeed, i.e: that
109 # each version number mentioned is still current. Otherwise the entire
110 # transaction *must* be rolled back.
112 # Furthermore, each element in the diff can only reference the current
115 # Returns: a diffResult document, as described in
116 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
118 changeset = Changeset.find(params[:id])
119 check_changeset_consistency(changeset, current_user)
121 diff_reader = DiffReader.new(request.raw_post, changeset)
122 Changeset.transaction do
123 result = diff_reader.commit
124 # the number of changes in this changeset has already been
125 # updated and is visible in this transaction so we don't need
126 # to allow for any more when checking the limit
128 render :xml => result.to_s
133 # download the changeset as an osmChange document.
135 # to make it easier to revert diffs it would be better if the osmChange
136 # format were reversible, i.e: contained both old and new versions of
137 # modified elements. but it doesn't at the moment...
139 # this method cannot order the database changes fully (i.e: timestamp and
140 # version number may be too coarse) so the resulting diff may not apply
141 # to a different database. however since changesets are not atomic this
142 # behaviour cannot be guaranteed anyway and is the result of a design
145 changeset = Changeset.find(params[:id])
147 # get all the elements in the changeset which haven't been redacted
148 # and stick them in a big array.
149 elements = [changeset.old_nodes.unredacted,
150 changeset.old_ways.unredacted,
151 changeset.old_relations.unredacted].flatten
153 # sort the elements by timestamp and version number, as this is the
154 # almost sensible ordering available. this would be much nicer if
155 # global (SVN-style) versioning were used - then that would be
157 elements.sort_by! { |e| [e.timestamp, e.version] }
159 # generate an output element for each operation. note: we avoid looking
160 # at the history because it is simpler - but it would be more correct to
161 # check these assertions.
166 elements.each do |elt|
168 # first version, so it must be newly-created.
174 # if the element isn't visible then it must have been deleted
179 respond_to do |format|
185 # updates a changeset's tags. none of the changeset's attributes are
186 # user-modifiable, so they will be ignored.
188 # changesets are not (yet?) versioned, so we don't have to deal with
189 # history tables here. changesets are locked to a single user, however.
191 # after succesful update, returns the XML of the changeset.
193 @changeset = Changeset.find(params[:id])
194 new_changeset = Changeset.from_xml(request.raw_post)
196 check_changeset_consistency(@changeset, current_user)
197 @changeset.update_from(new_changeset, current_user)
200 respond_to do |format|
207 # Adds a subscriber to the changeset
209 # Check the arguments are sane
210 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
212 # Extract the arguments
213 id = params[:id].to_i
215 # Find the changeset and check it is valid
216 changeset = Changeset.find(id)
217 raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribed?(current_user)
220 changeset.subscribe(current_user)
222 # Return a copy of the updated changeset
223 @changeset = changeset
226 respond_to do |format|
233 # Removes a subscriber from the changeset
235 # Check the arguments are sane
236 raise OSM::APIBadUserInput, "No id was given" unless params[:id]
238 # Extract the arguments
239 id = params[:id].to_i
241 # Find the changeset and check it is valid
242 changeset = Changeset.find(id)
243 raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribed?(current_user)
245 # Remove the subscriber
246 changeset.unsubscribe(current_user)
248 # Return a copy of the updated changeset
249 @changeset = changeset
252 respond_to do |format|
260 #------------------------------------------------------------
261 # utility functions below.
262 #------------------------------------------------------------
265 # if a bounding box was specified do some sanity checks.
266 # restrict changesets to those enclosed by a bounding box
267 def conditions_bbox(changesets, bbox)
269 bbox.check_boundaries
270 bbox = bbox.to_scaled
272 changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
273 bbox.max_lon.to_i, bbox.min_lon.to_i,
274 bbox.max_lat.to_i, bbox.min_lat.to_i)
281 # restrict changesets to those by a particular user
282 def conditions_user(changesets, user, name)
283 if user.nil? && name.nil?
286 # shouldn't provide both name and UID
287 raise OSM::APIBadUserInput, "provide either the user ID or display name, but not both" if user && name
289 # use either the name or the UID to find the user which we're selecting on.
291 # user input checking, we don't have any UIDs < 1
292 raise OSM::APIBadUserInput, "invalid user ID" if user.to_i < 1
294 u = User.find_by(:id => user.to_i)
296 u = User.find_by(:display_name => name)
299 # make sure we found a user
300 raise OSM::APINotFoundError if u.nil?
302 # should be able to get changesets of public users only, or
303 # our own changesets regardless of public-ness.
304 unless u.data_public?
305 # get optional user auth stuff so that users can see their own
306 # changesets if they're non-public
309 raise OSM::APINotFoundError if current_user.nil? || current_user != u
312 changesets.where(:user => u)
317 # restrict changesets to those during a particular time period
318 def conditions_time(changesets, time)
321 elsif time.count(",") == 1
322 # if there is a range, i.e: comma separated, then the first is
323 # low, second is high - same as with bounding boxes.
325 # check that we actually have 2 elements in the array
326 times = time.split(",")
327 raise OSM::APIBadUserInput, "bad time range" if times.size != 2
329 from, to = times.collect { |t| Time.parse(t).utc }
330 changesets.where("closed_at >= ? and created_at <= ?", from, to)
332 # if there is no comma, assume its a lower limit on time
333 changesets.where(:closed_at => Time.parse(time).utc..)
335 # stupid Time seems to throw both of these for bad parsing, so
336 # we have to catch both and ensure the correct code path is taken.
337 rescue ArgumentError, RuntimeError => e
338 raise OSM::APIBadUserInput, e.message.to_s
342 # restrict changesets to those opened during a particular time period
343 # works similar to from..to of notes controller, including the requirement of 'from' when specifying 'to'
344 def conditions_from_to(changesets, from, to)
347 from = Time.parse(from).utc
349 raise OSM::APIBadUserInput, "Date #{from} is in a wrong format"
359 raise OSM::APIBadUserInput, "Date #{to} is in a wrong format"
362 changesets.where(:created_at => from..to)
369 # return changesets which are open (haven't been closed yet)
370 # we do this by seeing if the 'closed at' time is in the future. Also if we've
371 # hit the maximum number of changes then it counts as no longer open.
372 # if parameter 'open' is nill then open and closed changesets are returned
373 def conditions_open(changesets, open)
377 changesets.where("closed_at >= ? and num_changes <= ?",
378 Time.now.utc, Changeset::MAX_ELEMENTS)
383 # query changesets which are closed
384 # ('closed at' time has passed or changes limit is hit)
385 def conditions_closed(changesets, closed)
389 changesets.where("closed_at < ? or num_changes > ?",
390 Time.now.utc, Changeset::MAX_ELEMENTS)
395 # query changesets by a list of ids
396 # (either specified as array or comma-separated string)
397 def conditions_ids(changesets, ids)
401 raise OSM::APIBadUserInput, "No changesets were given to search for"
403 ids = ids.split(",").collect(&:to_i)
404 changesets.where(:id => ids)
409 # Get the maximum number of results to return
412 if params[:limit].to_i.positive? && params[:limit].to_i <= Settings.max_changeset_query_limit
415 raise OSM::APIBadUserInput, "Changeset limit must be between 1 and #{Settings.max_changeset_query_limit}"
418 Settings.default_changeset_query_limit