1 # The ChangesetController is the RESTful interface to Changeset objects
3 class ChangesetController < ApplicationController
7 skip_before_filter :verify_authenticity_token, :except => [:list]
8 before_filter :authorize_web, :only => [:list, :feed]
9 before_filter :set_locale, :only => [:list, :feed]
10 before_filter :authorize, :only => [:create, :update, :delete, :upload, :include, :close]
11 before_filter :require_allow_write_api, :only => [:create, :update, :delete, :upload, :include, :close]
12 before_filter :require_public_data, :only => [:create, :update, :delete, :upload, :include, :close]
13 before_filter :check_api_writable, :only => [:create, :update, :delete, :upload, :include]
14 before_filter :check_api_readable, :except => [:create, :update, :delete, :upload, :download, :query, :list, :feed]
15 before_filter(:only => [:list, :feed]) { |c| c.check_database_readable(true) }
16 after_filter :compress_output
17 around_filter :api_call_handle_error, :except => [:list, :feed]
18 around_filter :web_timeout, :only => [:list, :feed]
20 # Helper methods for checking consistency
21 include ConsistencyValidations
23 # Create a changeset from XML.
27 cs = Changeset.from_xml(request.raw_post, true)
29 # Assume that Changeset.from_xml has thrown an exception if there is an error parsing the xml
32 render :text => cs.id.to_s, :content_type => "text/plain"
36 # Return XML giving the basic info about the changeset. Does not
37 # return anything about the nodes, ways and relations in the changeset.
39 changeset = Changeset.find(params[:id])
40 render :text => changeset.to_xml.to_s, :content_type => "text/xml"
44 # marks a changeset as closed. this may be called multiple times
45 # on the same changeset, so is idempotent.
49 changeset = Changeset.find(params[:id])
50 check_changeset_consistency(changeset, @user)
52 # to close the changeset, we'll just set its closed_at time to
53 # now. this might not be enough if there are concurrency issues,
54 # but we'll have to wait and see.
55 changeset.set_closed_time_now
62 # insert a (set of) points into a changeset bounding box. this can only
63 # increase the size of the bounding box. this is a hint that clients can
64 # set either before uploading a large number of changes, or changes that
65 # the client (but not the server) knows will affect areas further away.
67 # only allow POST requests, because although this method is
68 # idempotent, there is no "document" to PUT really...
71 cs = Changeset.find(params[:id])
72 check_changeset_consistency(cs, @user)
74 # keep an array of lons and lats
78 # the request is in pseudo-osm format... this is kind-of an
79 # abuse, maybe should change to some other format?
80 doc = XML::Parser.string(request.raw_post).parse
81 doc.find("//osm/node").each do |n|
82 lon << n['lon'].to_f * GeoRecord::SCALE
83 lat << n['lat'].to_f * GeoRecord::SCALE
86 # add the existing bounding box to the lon-lat array
87 lon << cs.min_lon unless cs.min_lon.nil?
88 lat << cs.min_lat unless cs.min_lat.nil?
89 lon << cs.max_lon unless cs.max_lon.nil?
90 lat << cs.max_lat unless cs.max_lat.nil?
92 # collapse the arrays to minimum and maximum
93 cs.min_lon, cs.min_lat, cs.max_lon, cs.max_lat =
94 lon.min, lat.min, lon.max, lat.max
96 # save the larger bounding box and return the changeset, which
97 # will include the bigger bounding box.
99 render :text => cs.to_xml.to_s, :content_type => "text/xml"
103 # Upload a diff in a single transaction.
105 # This means that each change within the diff must succeed, i.e: that
106 # each version number mentioned is still current. Otherwise the entire
107 # transaction *must* be rolled back.
109 # Furthermore, each element in the diff can only reference the current
112 # Returns: a diffResult document, as described in
113 # http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
115 # only allow POST requests, as the upload method is most definitely
116 # not idempotent, as several uploads with placeholder IDs will have
117 # different side-effects.
118 # see http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.2
121 changeset = Changeset.find(params[:id])
122 check_changeset_consistency(changeset, @user)
124 diff_reader = DiffReader.new(request.raw_post, changeset)
125 Changeset.transaction do
126 result = diff_reader.commit
127 render :text => result.to_s, :content_type => "text/xml"
132 # download the changeset as an osmChange document.
134 # to make it easier to revert diffs it would be better if the osmChange
135 # format were reversible, i.e: contained both old and new versions of
136 # modified elements. but it doesn't at the moment...
138 # this method cannot order the database changes fully (i.e: timestamp and
139 # version number may be too coarse) so the resulting diff may not apply
140 # to a different database. however since changesets are not atomic this
141 # behaviour cannot be guaranteed anyway and is the result of a design
144 changeset = Changeset.find(params[:id])
146 # get all the elements in the changeset which haven't been redacted
147 # and stick them in a big array.
148 elements = [changeset.old_nodes.unredacted,
149 changeset.old_ways.unredacted,
150 changeset.old_relations.unredacted].flatten
152 # sort the elements by timestamp and version number, as this is the
153 # almost sensible ordering available. this would be much nicer if
154 # global (SVN-style) versioning were used - then that would be
156 elements.sort! do |a, b|
157 if (a.timestamp == b.timestamp)
158 a.version <=> b.version
160 a.timestamp <=> b.timestamp
164 # create changeset and user caches
166 user_display_name_cache = {}
168 # create an osmChange document for the output
169 result = OSM::API.new.get_xml_doc
170 result.root.name = "osmChange"
172 # generate an output element for each operation. note: we avoid looking
173 # at the history because it is simpler - but it would be more correct to
174 # check these assertions.
175 elements.each do |elt|
177 if (elt.version == 1)
178 # first version, so it must be newly-created.
179 created = XML::Node.new "create"
180 created << elt.to_xml_node(changeset_cache, user_display_name_cache)
183 # if the element isn't visible then it must have been deleted
184 deleted = XML::Node.new "delete"
185 deleted << elt.to_xml_node(changeset_cache, user_display_name_cache)
188 modified = XML::Node.new "modify"
189 modified << elt.to_xml_node(changeset_cache, user_display_name_cache)
194 render :text => result.to_s, :content_type => "text/xml"
198 # query changesets by bounding box, time, user or open/closed status.
200 # find any bounding box
202 bbox = BoundingBox.from_bbox_params(params)
205 # create the conditions that the user asked for. some or all of
207 changesets = Changeset.all
208 changesets = conditions_bbox(changesets, bbox)
209 changesets = conditions_user(changesets, params['user'], params['display_name'])
210 changesets = conditions_time(changesets, params['time'])
211 changesets = conditions_open(changesets, params['open'])
212 changesets = conditions_closed(changesets, params['closed'])
214 # create the results document
215 results = OSM::API.new.get_xml_doc
217 # add all matching changesets to the XML results document
218 changesets.order("created_at DESC").limit(100).each do |cs|
219 results.root << cs.to_xml_node
222 render :text => results.to_s, :content_type => "text/xml"
226 # updates a changeset's tags. none of the changeset's attributes are
227 # user-modifiable, so they will be ignored.
229 # changesets are not (yet?) versioned, so we don't have to deal with
230 # history tables here. changesets are locked to a single user, however.
232 # after succesful update, returns the XML of the changeset.
234 # request *must* be a PUT.
237 changeset = Changeset.find(params[:id])
238 new_changeset = Changeset.from_xml(request.raw_post)
240 unless new_changeset.nil?
241 check_changeset_consistency(changeset, @user)
242 changeset.update_from(new_changeset, @user)
243 render :text => changeset.to_xml, :mime_type => "text/xml"
246 render :text => "", :status => :bad_request
251 # list edits (open changesets) in reverse chronological order
253 if request.format == :atom and params[:max_id]
254 redirect_to params.merge({ :max_id => nil }), :status => :moved_permanently
258 if params[:display_name]
259 user = User.find_by_display_name(params[:display_name])
260 if !user || !user.active?
261 render_unknown_user params[:display_name]
266 if (params[:friends] || params[:nearby]) && !@user && request.format == :html
271 if request.format == :html and !params[:list]
273 render :action => :history, :layout => map_layout
275 changesets = conditions_nonempty(Changeset.all)
277 if params[:display_name]
278 if user.data_public? or user == @user
279 changesets = changesets.where(:user_id => user.id)
281 changesets = changesets.where("false")
284 changesets = conditions_bbox(changesets, BoundingBox.from_bbox_params(params))
285 elsif params[:friends] && @user
286 changesets = changesets.where(:user_id => @user.friend_users.public)
287 elsif params[:nearby] && @user
288 changesets = changesets.where(:user_id => @user.nearby)
292 changesets = changesets.where("changesets.id <= ?", params[:max_id])
295 @edits = changesets.order("changesets.id DESC").limit(20).preload(:user, :changeset_tags)
297 render :action => :list, :layout => false
302 # list edits as an atom feed
308 #------------------------------------------------------------
309 # utility functions below.
310 #------------------------------------------------------------
313 # if a bounding box was specified do some sanity checks.
314 # restrict changesets to those enclosed by a bounding box
315 # we need to return both the changesets and the bounding box
316 def conditions_bbox(changesets, bbox)
318 bbox.check_boundaries
319 bbox = bbox.to_scaled
320 return changesets.where("min_lon < ? and max_lon > ? and min_lat < ? and max_lat > ?",
321 bbox.max_lon.to_i, bbox.min_lon.to_i,
322 bbox.max_lat.to_i, bbox.min_lat.to_i)
329 # restrict changesets to those by a particular user
330 def conditions_user(changesets, user, name)
331 unless user.nil? and name.nil?
332 # shouldn't provide both name and UID
333 raise OSM::APIBadUserInput.new("provide either the user ID or display name, but not both") if user and name
335 # use either the name or the UID to find the user which we're selecting on.
337 # user input checking, we don't have any UIDs < 1
338 raise OSM::APIBadUserInput.new("invalid user ID") if user.to_i < 1
339 u = User.find(user.to_i)
341 u = User.find_by_display_name(name)
344 # make sure we found a user
345 raise OSM::APINotFoundError.new if u.nil?
347 # should be able to get changesets of public users only, or
348 # our own changesets regardless of public-ness.
349 unless u.data_public?
350 # get optional user auth stuff so that users can see their own
351 # changesets if they're non-public
354 raise OSM::APINotFoundError if @user.nil? or @user.id != u.id
356 return changesets.where(:user_id => u.id)
363 # restrict changes to those closed during a particular time period
364 def conditions_time(changesets, time)
366 # if there is a range, i.e: comma separated, then the first is
367 # low, second is high - same as with bounding boxes.
368 if time.count(',') == 1
369 # check that we actually have 2 elements in the array
370 times = time.split(/,/)
371 raise OSM::APIBadUserInput.new("bad time range") if times.size != 2
373 from, to = times.collect { |t| DateTime.parse(t) }
374 return changesets.where("closed_at >= ? and created_at <= ?", from, to)
376 # if there is no comma, assume its a lower limit on time
377 return changesets.where("closed_at >= ?", DateTime.parse(time))
382 # stupid DateTime seems to throw both of these for bad parsing, so
383 # we have to catch both and ensure the correct code path is taken.
384 rescue ArgumentError => ex
385 raise OSM::APIBadUserInput.new(ex.message.to_s)
386 rescue RuntimeError => ex
387 raise OSM::APIBadUserInput.new(ex.message.to_s)
391 # return changesets which are open (haven't been closed yet)
392 # we do this by seeing if the 'closed at' time is in the future. Also if we've
393 # hit the maximum number of changes then it counts as no longer open.
394 # if parameter 'open' is nill then open and closed changesets are returned
395 def conditions_open(changesets, open)
399 return changesets.where("closed_at >= ? and num_changes <= ?",
400 Time.now.getutc, Changeset::MAX_ELEMENTS)
405 # query changesets which are closed
406 # ('closed at' time has passed or changes limit is hit)
407 def conditions_closed(changesets, closed)
411 return changesets.where("closed_at < ? or num_changes > ?",
412 Time.now.getutc, Changeset::MAX_ELEMENTS)
417 # eliminate empty changesets (where the bbox has not been set)
418 # this should be applied to all changeset list displays
419 def conditions_nonempty(changesets)
420 return changesets.where("num_changes > 0")