1 class Changeset < ActiveRecord::Base
6 has_many :changeset_tags, :foreign_key => 'id'
13 has_many :old_relations
15 validates_presence_of :user_id, :created_at, :closed_at
17 # over-expansion factor to use when updating the bounding box
20 # maximum number of elements allowed in a changeset
23 # maximum time a changeset is allowed to be open for (note that this
24 # is in days - so one hour is Rational(1,24)).
27 # idle timeout increment, one hour as a rational number of days.
28 # NOTE: DO NOT CHANGE THIS TO 1.hour! when this was done the idle
29 # timeout changed to 1 second, which meant all changesets closed
31 IDLE_TIMEOUT = Rational(1,24)
33 # Use a method like this, so that we can easily change how we
34 # determine whether a changeset is open, without breaking code in at
37 # a changeset is open (that is, it will accept further changes) when
38 # it has not yet run out of time and its capacity is small enough.
39 # note that this may not be a hard limit - due to timing changes and
40 # concurrency it is possible that some changesets may be slightly
41 # longer than strictly allowed or have slightly more changes in them.
42 return ((closed_at > DateTime.now) and (num_changes <= MAX_ELEMENTS))
45 def set_closed_time_now
46 closed_at = DateTime.now
49 def self.from_xml(xml, create=false)
57 doc.find('//osm/changeset').each do |pt|
59 cs.created_at = Time.now
60 # initial close time is 1h ahead, but will be increased on each
62 cs.closed_at = Time.now + IDLE_TIMEOUT
63 # initially we have no changes in a changeset
67 pt.find('tag').each do |tag|
68 cs.add_tag_keyval(tag['k'], tag['v'])
71 rescue Exception => ex
79 # returns the bounding box of the changeset. it is possible that some
80 # or all of the values will be nil, indicating that they are undefined.
82 @bbox ||= [ min_lon, min_lat, max_lon, max_lat ]
86 # expand the bounding box to include the given bounding box. also,
87 # expand a little bit more in the direction of the expansion, so that
88 # further expansions may be unnecessary. this is an optimisation
89 # suggested on the wiki page by kleptog.
90 def update_bbox!(array)
91 # ensure that bbox is cached and has no nils in it. if there are any
92 # nils, just use the bounding box update to write over them.
93 @bbox = bbox.zip(array).collect { |a, b| a.nil? ? b : a }
95 # FIXME - this looks nasty and violates DRY... is there any prettier
97 @bbox[0] = array[0] + EXPAND * (@bbox[0] - @bbox[2]) if array[0] < @bbox[0]
98 @bbox[1] = array[1] + EXPAND * (@bbox[1] - @bbox[3]) if array[1] < @bbox[1]
99 @bbox[2] = array[2] + EXPAND * (@bbox[2] - @bbox[0]) if array[2] > @bbox[2]
100 @bbox[3] = array[3] + EXPAND * (@bbox[3] - @bbox[1]) if array[3] > @bbox[3]
102 # update active record. rails 2.1's dirty handling should take care of
103 # whether this object needs saving or not.
104 self.min_lon, self.min_lat, self.max_lon, self.max_lat = @bbox
108 # the number of elements is also passed in so that we can ensure that
109 # a single changeset doesn't contain too many elements. this, of course,
110 # destroys the optimisation described in the bbox method above.
111 def add_changes!(elements)
112 self.num_changes += elements
122 self.changeset_tags.each do |tag|
133 def add_tag_keyval(k, v)
134 @tags = Hash.new unless @tags
141 # do the changeset update and the changeset tags update in the
142 # same transaction to ensure consistency.
143 Changeset.transaction do
144 # set the auto-close time to be one hour in the future unless
145 # that would make it more than 24h long, in which case clip to
146 # 24h, as this has been decided is a reasonable time limit.
147 if (closed_at - created_at) > (MAX_TIME_OPEN - IDLE_TIMEOUT)
148 self.closed_at = created_at + MAX_TIME_OPEN
150 self.closed_at = DateTime.now + IDLE_TIMEOUT
155 ChangesetTag.delete_all(['id = ?', self.id])
158 tag = ChangesetTag.new
168 doc = OSM::API.new.get_xml_doc
169 doc.root << to_xml_node()
173 def to_xml_node(user_display_name_cache = nil)
174 el1 = XML::Node.new 'changeset'
175 el1['id'] = self.id.to_s
177 user_display_name_cache = {} if user_display_name_cache.nil?
179 if user_display_name_cache and user_display_name_cache.key?(self.user_id)
180 # use the cache if available
181 elsif self.user.data_public?
182 user_display_name_cache[self.user_id] = self.user.display_name
184 user_display_name_cache[self.user_id] = nil
187 el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil?
188 el1['uid'] = self.user_id.to_s if self.user.data_public?
190 self.tags.each do |k,v|
191 el2 = XML::Node.new('tag')
197 el1['created_at'] = self.created_at.xmlschema
198 el1['closed_at'] = self.closed_at.xmlschema unless is_open?
199 el1['open'] = is_open?.to_s
201 el1['min_lon'] = (bbox[0].to_f / GeoRecord::SCALE).to_s unless bbox[0].nil?
202 el1['min_lat'] = (bbox[1].to_f / GeoRecord::SCALE).to_s unless bbox[1].nil?
203 el1['max_lon'] = (bbox[2].to_f / GeoRecord::SCALE).to_s unless bbox[2].nil?
204 el1['max_lat'] = (bbox[3].to_f / GeoRecord::SCALE).to_s unless bbox[3].nil?
206 # NOTE: changesets don't include the XML of the changes within them,
207 # they are just structures for tagging. to get the osmChange of a
208 # changeset, see the download method of the controller.
214 # update this instance from another instance given and the user who is
215 # doing the updating. note that this method is not for updating the
216 # bounding box, only the tags of the changeset.
217 def update_from(other, user)
218 # ensure that only the user who opened the changeset may modify it.
219 unless user.id == self.user_id
220 raise OSM::APIUserChangesetMismatchError
223 # can't change a closed changeset
225 raise OSM::APIChangesetAlreadyClosedError.new(self)
228 # copy the other's tags
229 self.tags = other.tags